* [PATCH] usbip: vhci-hcd: make vhci_hc_driver const
@ 2017-08-30 12:52 Bhumika Goyal
2017-08-30 17:27 ` Shuah Khan
0 siblings, 1 reply; 2+ messages in thread
From: Bhumika Goyal @ 2017-08-30 12:52 UTC (permalink / raw)
To: julia.lawall, valentina.manea.m, shuah, gregkh, linux-usb, linux-kernel
Cc: Bhumika Goyal
Make this const as it is not modified anywhere.
Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
---
drivers/usb/usbip/vhci_hcd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/usbip/vhci_hcd.c b/drivers/usb/usbip/vhci_hcd.c
index c747623..11b9a22 100644
--- a/drivers/usb/usbip/vhci_hcd.c
+++ b/drivers/usb/usbip/vhci_hcd.c
@@ -1274,7 +1274,7 @@ static int vhci_free_streams(struct usb_hcd *hcd, struct usb_device *udev,
return 0;
}
-static struct hc_driver vhci_hc_driver = {
+static const struct hc_driver vhci_hc_driver = {
.description = driver_name,
.product_desc = driver_desc,
.hcd_priv_size = sizeof(struct vhci_hcd),
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] usbip: vhci-hcd: make vhci_hc_driver const
2017-08-30 12:52 [PATCH] usbip: vhci-hcd: make vhci_hc_driver const Bhumika Goyal
@ 2017-08-30 17:27 ` Shuah Khan
0 siblings, 0 replies; 2+ messages in thread
From: Shuah Khan @ 2017-08-30 17:27 UTC (permalink / raw)
To: Bhumika Goyal, julia.lawall, valentina.manea.m, gregkh,
linux-usb, linux-kernel
Cc: Shuah Khan, Shuah Khan
On 08/30/2017 06:52 AM, Bhumika Goyal wrote:
> Make this const as it is not modified anywhere.
>
> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
> ---
> drivers/usb/usbip/vhci_hcd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/usbip/vhci_hcd.c b/drivers/usb/usbip/vhci_hcd.c
> index c747623..11b9a22 100644
> --- a/drivers/usb/usbip/vhci_hcd.c
> +++ b/drivers/usb/usbip/vhci_hcd.c
> @@ -1274,7 +1274,7 @@ static int vhci_free_streams(struct usb_hcd *hcd, struct usb_device *udev,
> return 0;
> }
>
> -static struct hc_driver vhci_hc_driver = {
> +static const struct hc_driver vhci_hc_driver = {
> .description = driver_name,
> .product_desc = driver_desc,
> .hcd_priv_size = sizeof(struct vhci_hcd),
>
Looks good to me.
Acked-by: Shuah Khan <shuahkh@osg.samsung.com>
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-08-30 17:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-30 12:52 [PATCH] usbip: vhci-hcd: make vhci_hc_driver const Bhumika Goyal
2017-08-30 17:27 ` Shuah Khan
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.