All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v1] arm64: defconfig: Enable Virtio RNG driver as built in
@ 2023-02-13 10:16 Ryan Roberts
  2023-03-23 12:51 ` Ryan Roberts
  0 siblings, 1 reply; 5+ messages in thread
From: Ryan Roberts @ 2023-02-13 10:16 UTC (permalink / raw)
  To: Catalin Marinas, Will Deacon
  Cc: Ryan Roberts, Bjorn Andersson, Arnd Bergmann, linux-arm-kernel

Modern versions of FVP_Base_RevC-2xAEMvA contain a Virtio RNG device,
use of which can dramatically speed up the time taken for Linux to
initialize its CRNG, from 10s of seconds in some cases, to instant. This
improves the debug cycle significantly.

However, there are 2 barriers to getting people to use it. The first is
that the defconfig doesn't have the required driver. The second is that
the device is disabled in the device tree (for back-compat since older
versions of the FVP don't have the device). Here we solve the first
issue.

Signed-off-by: Ryan Roberts <ryan.roberts@arm.com>
---
 arch/arm64/configs/defconfig | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index 851e8f9be06d..e2dad45e87a7 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -464,6 +464,8 @@ CONFIG_VIRTIO_CONSOLE=y
 CONFIG_IPMI_HANDLER=m
 CONFIG_IPMI_DEVICE_INTERFACE=m
 CONFIG_IPMI_SI=m
+CONFIG_HW_RANDOM=y
+CONFIG_HW_RANDOM_VIRTIO=y
 CONFIG_TCG_TPM=y
 CONFIG_TCG_TIS=m
 CONFIG_TCG_TIS_SPI=m
--
2.25.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH v1] arm64: defconfig: Enable Virtio RNG driver as built in
  2023-02-13 10:16 [PATCH v1] arm64: defconfig: Enable Virtio RNG driver as built in Ryan Roberts
@ 2023-03-23 12:51 ` Ryan Roberts
  2023-03-23 17:37   ` Catalin Marinas
  0 siblings, 1 reply; 5+ messages in thread
From: Ryan Roberts @ 2023-03-23 12:51 UTC (permalink / raw)
  To: Catalin Marinas, Will Deacon
  Cc: Bjorn Andersson, Arnd Bergmann, linux-arm-kernel

Hi Catalin, Will, all,

Just a polite nudge: Is there any reason it would be problematic to merge this?

Thanks,
Ryan


On 13/02/2023 10:16, Ryan Roberts wrote:
> Modern versions of FVP_Base_RevC-2xAEMvA contain a Virtio RNG device,
> use of which can dramatically speed up the time taken for Linux to
> initialize its CRNG, from 10s of seconds in some cases, to instant. This
> improves the debug cycle significantly.
> 
> However, there are 2 barriers to getting people to use it. The first is
> that the defconfig doesn't have the required driver. The second is that
> the device is disabled in the device tree (for back-compat since older
> versions of the FVP don't have the device). Here we solve the first
> issue.
> 
> Signed-off-by: Ryan Roberts <ryan.roberts@arm.com>
> ---
>  arch/arm64/configs/defconfig | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> index 851e8f9be06d..e2dad45e87a7 100644
> --- a/arch/arm64/configs/defconfig
> +++ b/arch/arm64/configs/defconfig
> @@ -464,6 +464,8 @@ CONFIG_VIRTIO_CONSOLE=y
>  CONFIG_IPMI_HANDLER=m
>  CONFIG_IPMI_DEVICE_INTERFACE=m
>  CONFIG_IPMI_SI=m
> +CONFIG_HW_RANDOM=y
> +CONFIG_HW_RANDOM_VIRTIO=y
>  CONFIG_TCG_TPM=y
>  CONFIG_TCG_TIS=m
>  CONFIG_TCG_TIS_SPI=m
> --
> 2.25.1
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
> 


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v1] arm64: defconfig: Enable Virtio RNG driver as built in
  2023-03-23 12:51 ` Ryan Roberts
@ 2023-03-23 17:37   ` Catalin Marinas
  2023-03-24 17:49     ` Arnd Bergmann
  0 siblings, 1 reply; 5+ messages in thread
From: Catalin Marinas @ 2023-03-23 17:37 UTC (permalink / raw)
  To: Ryan Roberts
  Cc: Will Deacon, Bjorn Andersson, Arnd Bergmann, linux-arm-kernel

On Thu, Mar 23, 2023 at 12:51:17PM +0000, Ryan Roberts wrote:
> Just a polite nudge: Is there any reason it would be problematic to merge this?

No problems with the patch. It probably fell through the cracks. Will
and I normally leave the defconfig patches to Arnd but I guess it was
also posted fairly close to the merging window when most of maintainer
trees had already been frozen.

-- 
Catalin

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v1] arm64: defconfig: Enable Virtio RNG driver as built in
  2023-03-23 17:37   ` Catalin Marinas
@ 2023-03-24 17:49     ` Arnd Bergmann
  2023-03-24 19:08       ` Ryan Roberts
  0 siblings, 1 reply; 5+ messages in thread
From: Arnd Bergmann @ 2023-03-24 17:49 UTC (permalink / raw)
  To: Catalin Marinas, Ryan Roberts
  Cc: Will Deacon, Bjorn Andersson, linux-arm-kernel

On Thu, Mar 23, 2023, at 18:37, Catalin Marinas wrote:
> On Thu, Mar 23, 2023 at 12:51:17PM +0000, Ryan Roberts wrote:
>> Just a polite nudge: Is there any reason it would be problematic to merge this?
>
> No problems with the patch. It probably fell through the cracks. Will
> and I normally leave the defconfig patches to Arnd but I guess it was
> also posted fairly close to the merging window when most of maintainer
> trees had already been frozen.

I've applied it to the soc/defconfig branch for 6.4 now, sorry
for missing it before.

      Arnd

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v1] arm64: defconfig: Enable Virtio RNG driver as built in
  2023-03-24 17:49     ` Arnd Bergmann
@ 2023-03-24 19:08       ` Ryan Roberts
  0 siblings, 0 replies; 5+ messages in thread
From: Ryan Roberts @ 2023-03-24 19:08 UTC (permalink / raw)
  To: Arnd Bergmann, Catalin Marinas
  Cc: Will Deacon, Bjorn Andersson, linux-arm-kernel

On 24/03/2023 17:49, Arnd Bergmann wrote:
> On Thu, Mar 23, 2023, at 18:37, Catalin Marinas wrote:
>> On Thu, Mar 23, 2023 at 12:51:17PM +0000, Ryan Roberts wrote:
>>> Just a polite nudge: Is there any reason it would be problematic to merge this?
>>
>> No problems with the patch. It probably fell through the cracks. Will
>> and I normally leave the defconfig patches to Arnd but I guess it was
>> also posted fairly close to the merging window when most of maintainer
>> trees had already been frozen.
> 
> I've applied it to the soc/defconfig branch for 6.4 now, sorry
> for missing it before.

No problem - thanks!

> 
>       Arnd


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2023-03-24 19:10 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-13 10:16 [PATCH v1] arm64: defconfig: Enable Virtio RNG driver as built in Ryan Roberts
2023-03-23 12:51 ` Ryan Roberts
2023-03-23 17:37   ` Catalin Marinas
2023-03-24 17:49     ` Arnd Bergmann
2023-03-24 19:08       ` Ryan Roberts

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.