All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] stm32mp: remove redundant SYS_TEXT_BASE prompt
@ 2019-12-21  2:03 Thomas Hebb
  2020-01-06 18:11 ` Patrick DELAUNAY
  2020-01-17 12:38 ` [Uboot-stm32] " Patrick DELAUNAY
  0 siblings, 2 replies; 3+ messages in thread
From: Thomas Hebb @ 2019-12-21  2:03 UTC (permalink / raw)
  To: u-boot

The main prompt for this (defined in /Kconfig) is visible at all times,
which means there's no reason to have an additional, machine-specific
prompt to set the same option.

Signed-off-by: Thomas Hebb <tommyhebb@gmail.com>
---

 arch/arm/mach-stm32mp/Kconfig | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/arch/arm/mach-stm32mp/Kconfig b/arch/arm/mach-stm32mp/Kconfig
index ae28f6e206..bf8a18a0c3 100644
--- a/arch/arm/mach-stm32mp/Kconfig
+++ b/arch/arm/mach-stm32mp/Kconfig
@@ -80,12 +80,7 @@ config STM32MP1_OPTEE
 		OP-TEE monitor provides ST SMC to access to secure resources
 
 config SYS_TEXT_BASE
-	prompt "U-Boot base address"
 	default 0xC0100000
-	help
-		configure the U-Boot base address
-		when DDR driver is used:
-		  DDR + 1MB (0xC0100000)
 
 config NR_DRAM_BANKS
 	default 1
-- 
2.24.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH] stm32mp: remove redundant SYS_TEXT_BASE prompt
  2019-12-21  2:03 [PATCH] stm32mp: remove redundant SYS_TEXT_BASE prompt Thomas Hebb
@ 2020-01-06 18:11 ` Patrick DELAUNAY
  2020-01-17 12:38 ` [Uboot-stm32] " Patrick DELAUNAY
  1 sibling, 0 replies; 3+ messages in thread
From: Patrick DELAUNAY @ 2020-01-06 18:11 UTC (permalink / raw)
  To: u-boot

Hi Thomas,

> From: Thomas Hebb <tommyhebb@gmail.com>
> Sent: samedi 21 décembre 2019 03:04
> 
> The main prompt for this (defined in /Kconfig) is visible at all times, which means
> there's no reason to have an additional, machine-specific prompt to set the same
> option.
> 
> Signed-off-by: Thomas Hebb <tommyhebb@gmail.com>

Yes, thanks for notice it.

It wasn't the case before the commit 278b90ce786f ('configs: Migrate CONFIG_SYS_TEXT_BASE')
merged before my first comit 2514c2d0e6abe (' arm: stm32: add new architecture for STM32MP family').

And I miss it when I rebase my initial serie.

Acked-by: Patrick Delaunay <patrick.delaunay@st.com>

> ---
> 
>  arch/arm/mach-stm32mp/Kconfig | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/arch/arm/mach-stm32mp/Kconfig b/arch/arm/mach-stm32mp/Kconfig
> index ae28f6e206..bf8a18a0c3 100644
> --- a/arch/arm/mach-stm32mp/Kconfig
> +++ b/arch/arm/mach-stm32mp/Kconfig
> @@ -80,12 +80,7 @@ config STM32MP1_OPTEE
>  		OP-TEE monitor provides ST SMC to access to secure resources
> 
>  config SYS_TEXT_BASE
> -	prompt "U-Boot base address"
>  	default 0xC0100000
> -	help
> -		configure the U-Boot base address
> -		when DDR driver is used:
> -		  DDR + 1MB (0xC0100000)
> 
>  config NR_DRAM_BANKS
>  	default 1
> --
> 2.24.1

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [Uboot-stm32] [PATCH] stm32mp: remove redundant SYS_TEXT_BASE prompt
  2019-12-21  2:03 [PATCH] stm32mp: remove redundant SYS_TEXT_BASE prompt Thomas Hebb
  2020-01-06 18:11 ` Patrick DELAUNAY
@ 2020-01-17 12:38 ` Patrick DELAUNAY
  1 sibling, 0 replies; 3+ messages in thread
From: Patrick DELAUNAY @ 2020-01-17 12:38 UTC (permalink / raw)
  To: u-boot

Hi Thomas,

> From: Uboot-stm32 <uboot-stm32-bounces@st-md-mailman.stormreply.com> On
> Behalf Of Thomas Hebb
> 
> The main prompt for this (defined in /Kconfig) is visible at all times, which means
> there's no reason to have an additional, machine-specific prompt to set the same
> option.
> 
> Signed-off-by: Thomas Hebb <tommyhebb@gmail.com>
> ---

Acked-by: Patrick Delaunay <patrick.delaunay@st.com>

Applied to u-boot-stm32/master, thanks!

Regards
Patrick 

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-01-17 12:38 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-21  2:03 [PATCH] stm32mp: remove redundant SYS_TEXT_BASE prompt Thomas Hebb
2020-01-06 18:11 ` Patrick DELAUNAY
2020-01-17 12:38 ` [Uboot-stm32] " Patrick DELAUNAY

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.