Re: [Buildroot] [PATCH v3 1/3] board/andes: rearrange nds32 folder structure

From: Giulio Benetti <giulio.benetti@benettiengineering.com>
To: Yu Chien Peter Lin <peterlin@andestech.com>, buildroot@buildroot.org
Cc: alankao@andestech.com
Subject: Re: [Buildroot] [PATCH v3 1/3] board/andes: rearrange nds32 folder structure
Date: Thu, 17 Feb 2022 16:55:49 +0100	[thread overview]
Message-ID: <b7e77527-b4a2-e0ea-90d9-eebc08a9ac62@benettiengineering.com> (raw)
In-Reply-To: <20220215053327.4046-1-peterlin@andestech.com>

Hi Peter,

On 15/02/22 06:33, Yu Chien Peter Lin wrote:
> Rearrange nds32 folder structure to add AE350 platform.
> 
> Signed-off-by: Yu Chien Peter Lin <peterlin@andestech.com>
> Signed-off-by: Alan Kao <alankao@andestech.com>
> ---
>   .../patches/linux/0001-nds32-Fix-boot-messages-garbled.patch    | 0
>   ...2-scripts-dtc-Remove-redundant-YYLOC-global-declaratio.patch | 0
>   board/andes/{ => ae3xx}/readme.txt                              | 0
>   configs/andes_ae3xx_defconfig                                   | 2 +-
>   4 files changed, 1 insertion(+), 1 deletion(-)
>   rename board/andes/{ => ae3xx}/patches/linux/0001-nds32-Fix-boot-messages-garbled.patch (100%)
>   rename board/andes/{ => ae3xx}/patches/linux/0002-scripts-dtc-Remove-redundant-YYLOC-global-declaratio.patch (100%)
>   rename board/andes/{ => ae3xx}/readme.txt (100%)

Here we have both:
board/andes/ae3xx
and
board/andes/ae350

ae3xx should be use for every ae3xx family(ae350 included), but for 
ae350 you use a specific folder.
What I see digging into ae3xx is that it is for FPGA demonstration, so I 
would move ae3xx directory to be name as ae3xx-fpga. Otherwise I would 
expect ae350(and newer parts) to be part of ae3xx.

Same goes for the defconfig, I would name it like:
andes_ae3xx_fpga_defconfig

This way we can divide the 2 typologies:
- fpga demonostration for ae3xx
- ae3xx SoC family

Otherwise you should provide a single family folder(ae3xx) compatible 
for both fpgas and SoCs.

Thank you

Best regards
-- 
Giulio Benetti
Benetti Engineering sas

> diff --git a/board/andes/patches/linux/0001-nds32-Fix-boot-messages-garbled.patch b/board/andes/ae3xx/patches/linux/0001-nds32-Fix-boot-messages-garbled.patch
> similarity index 100%
> rename from board/andes/patches/linux/0001-nds32-Fix-boot-messages-garbled.patch
> rename to board/andes/ae3xx/patches/linux/0001-nds32-Fix-boot-messages-garbled.patch
> diff --git a/board/andes/patches/linux/0002-scripts-dtc-Remove-redundant-YYLOC-global-declaratio.patch b/board/andes/ae3xx/patches/linux/0002-scripts-dtc-Remove-redundant-YYLOC-global-declaratio.patch
> similarity index 100%
> rename from board/andes/patches/linux/0002-scripts-dtc-Remove-redundant-YYLOC-global-declaratio.patch
> rename to board/andes/ae3xx/patches/linux/0002-scripts-dtc-Remove-redundant-YYLOC-global-declaratio.patch
> diff --git a/board/andes/readme.txt b/board/andes/ae3xx/readme.txt
> similarity index 100%
> rename from board/andes/readme.txt
> rename to board/andes/ae3xx/readme.txt
> diff --git a/configs/andes_ae3xx_defconfig b/configs/andes_ae3xx_defconfig
> index 52634caa50..18051115c3 100644
> --- a/configs/andes_ae3xx_defconfig
> +++ b/configs/andes_ae3xx_defconfig
> @@ -1,5 +1,5 @@
>   BR2_nds32=y
> -BR2_GLOBAL_PATCH_DIR="board/andes/patches/"
> +BR2_GLOBAL_PATCH_DIR="board/andes/ae3xx/patches"
>   BR2_TOOLCHAIN_EXTERNAL=y
>   BR2_TOOLCHAIN_EXTERNAL_ANDES_NDS32=y
>   BR2_LINUX_KERNEL=y

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot