Re: [Buildroot] [PATCH v3 1/3] board/andes: rearrange nds32 folder structure

[Giulio Benetti <giulio.benetti@benettiengineering.com>]

Ah, forgotten to mention,

On 21/02/22 10:07, Giulio Benetti wrote:
> Hi Peter, Alan,
> 
> On 21/02/22 04:37, Yu Chien Peter Lin wrote:
>> Hi Giulio,
>>
>> On Thu, Feb 17, 2022 at 04:55:49PM +0100, Giulio Benetti wrote:
>>> Hi Peter,
>>>
>>> On 15/02/22 06:33, Yu Chien Peter Lin wrote:
>>>> Rearrange nds32 folder structure to add AE350 platform.

Please explain here that AE300 and AE350 are 2 different platform by 
also pointing the URL I've pointed you below.

Thank you
-- 
Giulio Benetti
Benetti Engineering sas

>>>> Signed-off-by: Yu Chien Peter Lin <peterlin@andestech.com>
>>>> Signed-off-by: Alan Kao <alankao@andestech.com>
>>>> ---
>>>>     .../patches/linux/0001-nds32-Fix-boot-messages-garbled.patch    | 0
>>>>     ...2-scripts-dtc-Remove-redundant-YYLOC-global-declaratio.patch | 0
>>>>     board/andes/{ => ae3xx}/readme.txt                              | 0
>>>>     configs/andes_ae3xx_defconfig                                   | 2 +-
>>>>     4 files changed, 1 insertion(+), 1 deletion(-)
>>>>     rename board/andes/{ => ae3xx}/patches/linux/0001-nds32-Fix-boot-messages-garbled.patch (100%)
>>>>     rename board/andes/{ => ae3xx}/patches/linux/0002-scripts-dtc-Remove-redundant-YYLOC-global-declaratio.patch (100%)
>>>>     rename board/andes/{ => ae3xx}/readme.txt (100%)
>>>
>>> Here we have both:
>>> board/andes/ae3xx
>>> and
>>> board/andes/ae350
>>>
>>> ae3xx should be use for every ae3xx family(ae350 included), but for ae350
>>> you use a specific folder.
>>> What I see digging into ae3xx is that it is for FPGA demonstration, so I
>>> would move ae3xx directory to be name as ae3xx-fpga. Otherwise I would
>>> expect ae350(and newer parts) to be part of ae3xx.
>>>
>>> Same goes for the defconfig, I would name it like:
>>> andes_ae3xx_fpga_defconfig
>>>
>>> This way we can divide the 2 typologies:
>>> - fpga demonostration for ae3xx
>>> - ae3xx SoC family
>>>
>>> Otherwise you should provide a single family folder(ae3xx) compatible for
>>> both fpgas and SoCs.
>>>
>>> Thank you
>>>
>>> Best regards
>>> -- 
>>> Giulio Benetti
>>> Benetti Engineering sas
>>
>> For this naming issue, we decide to make ae3xx
>> explicit to have these two platform residing
>> in its own folder. So it would be:
>>
>> board/andes/
>>    |- {ae3xx => ae300}/
>>    `- ae350/
>>
>> If this make sense to you, I will submit PATCH v4.
> 
> It works for me.
> I've checked your website and I see:
> http://www.andestech.com/en/products-solutions/andeshape-platforms/
> 
> where you have:
> AE300:
> http://www.andestech.com/en/products-solutions/andeshape-platforms/ae300/
> 
> and AE350:
> http://www.andestech.com/en/products-solutions/andeshape-platforms/ae350-axi-based-platform-pre-integrated-with-n25f-nx25f-a25-ax25/
> 
> so your solution fits perfectly since they are two very distinct platforms.
> 
> So yes please send V4 with that change.
> 
> Thank you!
> 
> Best regards

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot