All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH -next] net/wireless/rtl8225: Remove unused variable rtl8225z2_tx_power_ofdm
@ 2020-05-12 11:14 ChenTao
  2020-05-12 15:24 ` Larry Finger
  0 siblings, 1 reply; 3+ messages in thread
From: ChenTao @ 2020-05-12 11:14 UTC (permalink / raw)
  To: herton, htl10, Larry.Finger, kvalo
  Cc: davem, linux-wireless, netdev, linux-kernel, chentao107

Fix the following warning:

drivers/net/wireless/realtek/rtl818x/rtl8187/rtl8225.c:609:17: warning:
‘rtl8225z2_tx_power_ofdm’ defined but not used
 static const u8 rtl8225z2_tx_power_ofdm[] = {

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: ChenTao <chentao107@huawei.com>
---
 drivers/net/wireless/realtek/rtl818x/rtl8187/rtl8225.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/net/wireless/realtek/rtl818x/rtl8187/rtl8225.c b/drivers/net/wireless/realtek/rtl818x/rtl8187/rtl8225.c
index b2616d61b66d..585784258c66 100644
--- a/drivers/net/wireless/realtek/rtl818x/rtl8187/rtl8225.c
+++ b/drivers/net/wireless/realtek/rtl818x/rtl8187/rtl8225.c
@@ -606,10 +606,6 @@ static const u8 rtl8225z2_tx_power_cck[] = {
 	0x26, 0x25, 0x21, 0x1b, 0x14, 0x0d, 0x06, 0x03
 };
 
-static const u8 rtl8225z2_tx_power_ofdm[] = {
-	0x42, 0x00, 0x40, 0x00, 0x40
-};
-
 static const u8 rtl8225z2_tx_gain_cck_ofdm[] = {
 	0x00, 0x01, 0x02, 0x03, 0x04, 0x05,
 	0x06, 0x07, 0x08, 0x09, 0x0a, 0x0b,
-- 
2.22.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH -next] net/wireless/rtl8225: Remove unused variable rtl8225z2_tx_power_ofdm
  2020-05-12 11:14 [PATCH -next] net/wireless/rtl8225: Remove unused variable rtl8225z2_tx_power_ofdm ChenTao
@ 2020-05-12 15:24 ` Larry Finger
  2020-05-13  1:00   ` chentao (AS)
  0 siblings, 1 reply; 3+ messages in thread
From: Larry Finger @ 2020-05-12 15:24 UTC (permalink / raw)
  To: ChenTao, herton, htl10, kvalo; +Cc: davem, linux-wireless, netdev, linux-kernel

On 5/12/20 6:14 AM, ChenTao wrote:
> Fix the following warning:
> 
> drivers/net/wireless/realtek/rtl818x/rtl8187/rtl8225.c:609:17: warning:
> ‘rtl8225z2_tx_power_ofdm’ defined but not used
>   static const u8 rtl8225z2_tx_power_ofdm[] = {
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: ChenTao <chentao107@huawei.com>

The patch is OK, but the subject is wrong. It should be "[PATCH-next] rtl8187: 
Remove ...."

With that change, ACKed-by: Larry Finger <Larry.Finger@lwfinger.net>

Larry

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH -next] net/wireless/rtl8225: Remove unused variable rtl8225z2_tx_power_ofdm
  2020-05-12 15:24 ` Larry Finger
@ 2020-05-13  1:00   ` chentao (AS)
  0 siblings, 0 replies; 3+ messages in thread
From: chentao (AS) @ 2020-05-13  1:00 UTC (permalink / raw)
  To: Larry Finger, herton, htl10, kvalo
  Cc: davem, linux-wireless, netdev, linux-kernel

Thanks, i will change it in v2.

On 2020/5/12 23:24, Larry Finger wrote:
> On 5/12/20 6:14 AM, ChenTao wrote:
>> Fix the following warning:
>>
>> drivers/net/wireless/realtek/rtl818x/rtl8187/rtl8225.c:609:17: warning:
>> ‘rtl8225z2_tx_power_ofdm’ defined but not used
>>   static const u8 rtl8225z2_tx_power_ofdm[] = {
>>
>> Reported-by: Hulk Robot <hulkci@huawei.com>
>> Signed-off-by: ChenTao <chentao107@huawei.com>
>
> The patch is OK, but the subject is wrong. It should be "[PATCH-next] 
> rtl8187: Remove ...."
>
> With that change, ACKed-by: Larry Finger <Larry.Finger@lwfinger.net>
>
> Larry

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-05-13  1:01 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-12 11:14 [PATCH -next] net/wireless/rtl8225: Remove unused variable rtl8225z2_tx_power_ofdm ChenTao
2020-05-12 15:24 ` Larry Finger
2020-05-13  1:00   ` chentao (AS)

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.