All of lore.kernel.org
 help / color / mirror / Atom feed
From: pillair@codeaurora.org
To: Kalle Valo <kvalo@codeaurora.org>
Cc: ath10k@lists.infradead.org, linux-wireless@vger.kernel.org
Subject: Re: ath10k: Enable hw checksum for wcn3990
Date: Tue, 17 Apr 2018 14:57:36 +0530	[thread overview]
Message-ID: <b82378df7d86887170e650305c6f224b@codeaurora.org> (raw)
In-Reply-To: <20180416131652.E274C606AC@smtp.codeaurora.org>

Hi Kalle,

The ath10k-check warning has been corrected and I have sent the v2 for 
the same.

Thanks,
Rakesh Pillai.

On 2018-04-16 18:46, Kalle Valo wrote:
> Rakesh Pillai <pillair@codeaurora.org> wrote:
> 
>> By default ath10k driver enables the support for HW_CHECKSUM
>> (NETIF_F_HW_CSUM). Since the TCP/UDP checksum calculation is not 
>> enabled
>> in the wcn3990 firmware the checksum is incorrect in the TCP/UDP 
>> packets
>> and all patckets are dropped. But due note that wcn3990 support in
>> ath10k is still incomplete so this isn't a critical fix (yet).
>> 
>> Enable hw checksum calculations in wcn3990 hardware by
>> setting the proper flags in msdu descriptor tso flags.
>> 
>> Signed-off-by: Rakesh Pillai <pillair@codeaurora.org>
>> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
> 
> Introduces a new sparse warning:
> 
> potku:~/ath10k/src/ath$ ath10k-check
> drivers/net/wireless/ath/ath10k/htt_tx.c:1480:47: warning: invalid
> assignment: |=
> drivers/net/wireless/ath/ath10k/htt_tx.c:1480:47:    left side has
> type restricted __le32
> drivers/net/wireless/ath/ath10k/htt_tx.c:1480:47:    right side has
> type unsigned long
> 
> Patch set to Changes Requested.

WARNING: multiple messages have this Message-ID (diff)
From: pillair@codeaurora.org
To: Kalle Valo <kvalo@codeaurora.org>
Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org
Subject: Re: ath10k: Enable hw checksum for wcn3990
Date: Tue, 17 Apr 2018 14:57:36 +0530	[thread overview]
Message-ID: <b82378df7d86887170e650305c6f224b@codeaurora.org> (raw)
In-Reply-To: <20180416131652.E274C606AC@smtp.codeaurora.org>

Hi Kalle,

The ath10k-check warning has been corrected and I have sent the v2 for 
the same.

Thanks,
Rakesh Pillai.

On 2018-04-16 18:46, Kalle Valo wrote:
> Rakesh Pillai <pillair@codeaurora.org> wrote:
> 
>> By default ath10k driver enables the support for HW_CHECKSUM
>> (NETIF_F_HW_CSUM). Since the TCP/UDP checksum calculation is not 
>> enabled
>> in the wcn3990 firmware the checksum is incorrect in the TCP/UDP 
>> packets
>> and all patckets are dropped. But due note that wcn3990 support in
>> ath10k is still incomplete so this isn't a critical fix (yet).
>> 
>> Enable hw checksum calculations in wcn3990 hardware by
>> setting the proper flags in msdu descriptor tso flags.
>> 
>> Signed-off-by: Rakesh Pillai <pillair@codeaurora.org>
>> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
> 
> Introduces a new sparse warning:
> 
> potku:~/ath10k/src/ath$ ath10k-check
> drivers/net/wireless/ath/ath10k/htt_tx.c:1480:47: warning: invalid
> assignment: |=
> drivers/net/wireless/ath/ath10k/htt_tx.c:1480:47:    left side has
> type restricted __le32
> drivers/net/wireless/ath/ath10k/htt_tx.c:1480:47:    right side has
> type unsigned long
> 
> Patch set to Changes Requested.

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

  parent reply	other threads:[~2018-04-17  9:27 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-06  5:45 [PATCH] ath10k: Enable hw checksum for wcn3990 pillair
2018-04-06  5:45 ` pillair
2018-04-16 13:16 ` Kalle Valo
2018-04-16 13:16 ` Kalle Valo
     [not found] ` <20180416131652.E274C606AC@smtp.codeaurora.org>
2018-04-17  9:27   ` pillair [this message]
2018-04-17  9:27     ` pillair

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b82378df7d86887170e650305c6f224b@codeaurora.org \
    --to=pillair@codeaurora.org \
    --cc=ath10k@lists.infradead.org \
    --cc=kvalo@codeaurora.org \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.