All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tomi Sarvela <tomi.p.sarvela@intel.com>
To: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
	Tvrtko Ursulin <tursulin@ursulin.net>,
	igt-dev@lists.freedesktop.org, Intel-gfx@lists.freedesktop.org,
	Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Subject: Re: [igt-dev] [PATCH i-g-t] tests/perf_pmu: Handle CPU hotplug failures better
Date: Mon, 26 Feb 2018 12:14:08 +0200	[thread overview]
Message-ID: <b8382b39-1c55-065e-a212-7512c98159be@intel.com> (raw)
In-Reply-To: <20180226100337.wmmy5x24eyca7ovx@platvala-desk.ger.corp.intel.com>

On 02/26/2018 12:03 PM, Petri Latvala wrote:
> On Fri, Feb 23, 2018 at 02:20:59PM +0000, Tvrtko Ursulin wrote:
>>
>> On 23/02/2018 11:58, Petri Latvala wrote:
>>> We have IGT_HANG and IGT_HANG_WITHOUT_RESET so the users can opt
>>> in/out of some fatal behaviour already. I'm fine with auto-rebooting,
>>> even as the default, if users can opt out of it with
>>> IGT_NO_REBOOT_PRETTY_PLEASE or so.
>>
>> I am fine with something like that. Just lets define how to call the env
>> variable and what the default should be?
> 
> 
> IGT_REBOOT_ON_FATAL_ERROR=1, default behaviour is not to reboot?

Default behaviour is not to reboot on panic either, but we want to have 
that.

So something that adds forced panic / reboot when test spectacularly 
fails is probably the sanest default: only if we have asked for that 
behaviour.

Turning that on with ENV or piglit.conf entry are both ok, either way 
it's something that user needs to know and explicitly turn on.

Tomi

> 
> Tomi, preference?
> 
> 
> 
>> Do we have a return code from a test which stops the test runner?
>>
>> I am thinking that the best approach would be not to reboot but to halt
>> testing, unless this environment option is set.
> 
> 
> Yeah, that would be the best out of all the options. Unfortunately
> that's not going to materialize in the near future. I have an
> implementation of aborting support hacked up on my test machines, but
> it's quite ugly and requires hacking deeply into the bowels of piglit.
> 
> Piglit is a hammer and we have screws...
> 
> 
> 


Tomi
-- 
Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

WARNING: multiple messages have this Message-ID (diff)
From: Tomi Sarvela <tomi.p.sarvela@intel.com>
To: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
	Tvrtko Ursulin <tursulin@ursulin.net>,
	igt-dev@lists.freedesktop.org, Intel-gfx@lists.freedesktop.org,
	Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Subject: Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] tests/perf_pmu: Handle CPU hotplug failures better
Date: Mon, 26 Feb 2018 12:14:08 +0200	[thread overview]
Message-ID: <b8382b39-1c55-065e-a212-7512c98159be@intel.com> (raw)
In-Reply-To: <20180226100337.wmmy5x24eyca7ovx@platvala-desk.ger.corp.intel.com>

On 02/26/2018 12:03 PM, Petri Latvala wrote:
> On Fri, Feb 23, 2018 at 02:20:59PM +0000, Tvrtko Ursulin wrote:
>>
>> On 23/02/2018 11:58, Petri Latvala wrote:
>>> We have IGT_HANG and IGT_HANG_WITHOUT_RESET so the users can opt
>>> in/out of some fatal behaviour already. I'm fine with auto-rebooting,
>>> even as the default, if users can opt out of it with
>>> IGT_NO_REBOOT_PRETTY_PLEASE or so.
>>
>> I am fine with something like that. Just lets define how to call the env
>> variable and what the default should be?
> 
> 
> IGT_REBOOT_ON_FATAL_ERROR=1, default behaviour is not to reboot?

Default behaviour is not to reboot on panic either, but we want to have 
that.

So something that adds forced panic / reboot when test spectacularly 
fails is probably the sanest default: only if we have asked for that 
behaviour.

Turning that on with ENV or piglit.conf entry are both ok, either way 
it's something that user needs to know and explicitly turn on.

Tomi

> 
> Tomi, preference?
> 
> 
> 
>> Do we have a return code from a test which stops the test runner?
>>
>> I am thinking that the best approach would be not to reboot but to halt
>> testing, unless this environment option is set.
> 
> 
> Yeah, that would be the best out of all the options. Unfortunately
> that's not going to materialize in the near future. I have an
> implementation of aborting support hacked up on my test machines, but
> it's quite ugly and requires hacking deeply into the bowels of piglit.
> 
> Piglit is a hammer and we have screws...
> 
> 
> 


Tomi
-- 
Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2018-02-26 10:14 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-23 11:34 [PATCH i-g-t] tests/perf_pmu: Handle CPU hotplug failures better Tvrtko Ursulin
2018-02-23 11:34 ` [Intel-gfx] " Tvrtko Ursulin
2018-02-23 11:58 ` [igt-dev] " Petri Latvala
2018-02-23 11:58   ` Petri Latvala
2018-02-23 14:20   ` Tvrtko Ursulin
2018-02-23 14:20     ` [igt-dev] [Intel-gfx] " Tvrtko Ursulin
2018-02-26 10:03     ` [igt-dev] " Petri Latvala
2018-02-26 10:03       ` [igt-dev] [Intel-gfx] " Petri Latvala
2018-02-26 10:14       ` Tomi Sarvela [this message]
2018-02-26 10:14         ` [Intel-gfx] [igt-dev] " Tomi Sarvela
2018-02-28 10:05         ` [PATCH i-g-t v2] " Tvrtko Ursulin
2018-02-28 10:05           ` [igt-dev] " Tvrtko Ursulin
2018-03-02 11:12           ` Petri Latvala
2018-03-02 11:12             ` [Intel-gfx] " Petri Latvala
2018-03-02 11:28             ` [PATCH i-g-t v3] " Tvrtko Ursulin
2018-03-02 11:28               ` [igt-dev] " Tvrtko Ursulin
2018-03-02 11:39               ` [PATCH i-g-t v4] " Tvrtko Ursulin
2018-03-02 11:39                 ` [igt-dev] " Tvrtko Ursulin
2018-03-02 11:42                 ` Chris Wilson
2018-03-02 11:42                   ` [igt-dev] " Chris Wilson
2018-03-02 11:55                   ` [PATCH i-g-t v5] " Tvrtko Ursulin
2018-03-02 11:55                     ` [igt-dev] " Tvrtko Ursulin
2018-03-02 11:32             ` [PATCH i-g-t v2] " Chris Wilson
2018-03-02 11:32               ` [igt-dev] " Chris Wilson
2018-03-02 20:16             ` [igt-dev] ✓ Fi.CI.BAT: success for tests/perf_pmu: Handle CPU hotplug failures better (rev5) Patchwork
2018-03-02 23:33             ` [igt-dev] ✗ Fi.CI.IGT: warning " Patchwork
2018-02-23 12:37 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/perf_pmu: Handle CPU hotplug failures better Patchwork
2018-02-23 15:34 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2018-02-28 11:54 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/perf_pmu: Handle CPU hotplug failures better (rev2) Patchwork
2018-02-28 14:50 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b8382b39-1c55-065e-a212-7512c98159be@intel.com \
    --to=tomi.p.sarvela@intel.com \
    --cc=Intel-gfx@lists.freedesktop.org \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=tursulin@ursulin.net \
    --cc=tvrtko.ursulin@intel.com \
    --cc=tvrtko.ursulin@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.