From: Paolo Bonzini <pbonzini@redhat.com> To: guangrong.xiao@gmail.com, mst@redhat.com, mtosatti@redhat.com Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org, yunfangtai@tencent.com, Xiao Guangrong <xiaoguangrong@tencent.com> Subject: Re: [PATCH 3/5] mc146818rtc: properly count the time for the next interrupt Date: Wed, 3 May 2017 17:32:27 +0200 [thread overview] Message-ID: <b855686b-20cd-9403-c765-c8b3a3268302@redhat.com> (raw) In-Reply-To: <20170412095111.11728-4-xiaoguangrong@tencent.com> On 12/04/2017 11:51, guangrong.xiao@gmail.com wrote: > +#ifdef TARGET_I386 > + /* > + * if more than period clocks were passed, i.e, the timer interrupt > + * has been lost, we should catch up the time. > + */ > + if (s->lost_tick_policy == LOST_TICK_POLICY_SLEW && > + (lost_clock / period)) { > + int lost_interrupt = lost_clock / period; > + > + s->irq_coalesced += lost_interrupt; > + lost_clock -= lost_interrupt * period; > + if (lost_interrupt) { > + DPRINTF_C("cmos: compensate %d interrupts, coalesced irqs " > + "increased to %d\n", lost_interrupt, > + s->irq_coalesced); > + rtc_coalesced_timer_update(s); > + } I think you should merge these two patches, since both of them essentially update the number of coalesced ticks and then split it between s->irq_coalesced and lost_clock. Paolo > + } else > +#endif > + /* > + * no way to compensate the interrupt if LOST_TICK_POLICY_SLEW > + * is not used, we should make the time progress anyway. > + */ > + lost_clock = MIN(lost_clock, period); > + assert(lost_clock >= 0); > + } > +
WARNING: multiple messages have this Message-ID (diff)
From: Paolo Bonzini <pbonzini@redhat.com> To: guangrong.xiao@gmail.com, mst@redhat.com, mtosatti@redhat.com Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org, yunfangtai@tencent.com, Xiao Guangrong <xiaoguangrong@tencent.com> Subject: Re: [Qemu-devel] [PATCH 3/5] mc146818rtc: properly count the time for the next interrupt Date: Wed, 3 May 2017 17:32:27 +0200 [thread overview] Message-ID: <b855686b-20cd-9403-c765-c8b3a3268302@redhat.com> (raw) In-Reply-To: <20170412095111.11728-4-xiaoguangrong@tencent.com> On 12/04/2017 11:51, guangrong.xiao@gmail.com wrote: > +#ifdef TARGET_I386 > + /* > + * if more than period clocks were passed, i.e, the timer interrupt > + * has been lost, we should catch up the time. > + */ > + if (s->lost_tick_policy == LOST_TICK_POLICY_SLEW && > + (lost_clock / period)) { > + int lost_interrupt = lost_clock / period; > + > + s->irq_coalesced += lost_interrupt; > + lost_clock -= lost_interrupt * period; > + if (lost_interrupt) { > + DPRINTF_C("cmos: compensate %d interrupts, coalesced irqs " > + "increased to %d\n", lost_interrupt, > + s->irq_coalesced); > + rtc_coalesced_timer_update(s); > + } I think you should merge these two patches, since both of them essentially update the number of coalesced ticks and then split it between s->irq_coalesced and lost_clock. Paolo > + } else > +#endif > + /* > + * no way to compensate the interrupt if LOST_TICK_POLICY_SLEW > + * is not used, we should make the time progress anyway. > + */ > + lost_clock = MIN(lost_clock, period); > + assert(lost_clock >= 0); > + } > +
next prev parent reply other threads:[~2017-05-03 15:32 UTC|newest] Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-04-12 9:51 [PATCH 0/5] mc146818rtc: fix Windows VM clock faster guangrong.xiao 2017-04-12 9:51 ` [Qemu-devel] " guangrong.xiao 2017-04-12 9:51 ` [PATCH 1/5] mc146818rtc: update periodic timer only if it is needed guangrong.xiao 2017-04-12 9:51 ` [Qemu-devel] " guangrong.xiao 2017-05-03 15:42 ` Paolo Bonzini 2017-05-03 15:42 ` [Qemu-devel] " Paolo Bonzini 2017-05-04 3:27 ` Xiao Guangrong 2017-05-04 3:27 ` [Qemu-devel] " Xiao Guangrong 2017-04-12 9:51 ` [PATCH 2/5] mc146818rtc: fix clock lost after scaling coalesced irq guangrong.xiao 2017-04-12 9:51 ` [Qemu-devel] " guangrong.xiao 2017-05-03 15:15 ` Paolo Bonzini 2017-05-03 15:15 ` [Qemu-devel] " Paolo Bonzini 2017-05-04 2:51 ` Xiao Guangrong 2017-05-04 2:51 ` [Qemu-devel] " Xiao Guangrong 2017-04-12 9:51 ` [PATCH 3/5] mc146818rtc: properly count the time for the next interrupt guangrong.xiao 2017-04-12 9:51 ` [Qemu-devel] " guangrong.xiao 2017-05-03 15:32 ` Paolo Bonzini [this message] 2017-05-03 15:32 ` Paolo Bonzini 2017-05-04 2:54 ` Xiao Guangrong 2017-05-04 2:54 ` [Qemu-devel] " Xiao Guangrong 2017-05-04 12:02 ` Paolo Bonzini 2017-05-04 12:02 ` [Qemu-devel] " Paolo Bonzini 2017-04-12 9:51 ` [PATCH 4/5] mc146818rtc: move x86 specific code out of periodic_timer_update guangrong.xiao 2017-04-12 9:51 ` [Qemu-devel] " guangrong.xiao 2017-05-03 15:39 ` Paolo Bonzini 2017-05-03 15:39 ` [Qemu-devel] " Paolo Bonzini 2017-05-04 3:25 ` Xiao Guangrong 2017-05-04 3:25 ` [Qemu-devel] " Xiao Guangrong 2017-05-04 7:08 ` Paolo Bonzini 2017-05-04 7:08 ` [Qemu-devel] " Paolo Bonzini 2017-04-12 9:51 ` [PATCH 5/5] mc146818rtc: embrace all x86 specific code guangrong.xiao 2017-04-12 9:51 ` [Qemu-devel] " guangrong.xiao 2017-04-13 6:37 ` [PATCH 0/5] mc146818rtc: fix Windows VM clock faster Paolo Bonzini 2017-04-13 6:37 ` [Qemu-devel] " Paolo Bonzini 2017-04-13 8:39 ` Xiao Guangrong 2017-04-13 8:39 ` [Qemu-devel] " Xiao Guangrong 2017-04-13 8:52 ` Xiao Guangrong 2017-04-13 8:52 ` [Qemu-devel] " Xiao Guangrong 2017-04-13 9:05 ` 答复: " Zhanghailiang 2017-04-13 9:05 ` [Qemu-devel] " Zhanghailiang 2017-04-13 9:18 ` Xiao Guangrong 2017-04-13 9:18 ` [Qemu-devel] " Xiao Guangrong 2017-04-13 9:29 ` Hailiang Zhang 2017-04-13 9:29 ` [Qemu-devel] " Hailiang Zhang 2017-04-13 9:35 ` Xiao Guangrong 2017-04-13 9:35 ` [Qemu-devel] " Xiao Guangrong 2017-04-13 9:38 ` Hailiang Zhang 2017-04-13 9:38 ` [Qemu-devel] " Hailiang Zhang 2017-04-19 2:02 ` Xiao Guangrong 2017-04-19 2:02 ` [Qemu-devel] " Xiao Guangrong 2017-04-19 10:41 ` Hailiang Zhang 2017-04-19 10:41 ` [Qemu-devel] " Hailiang Zhang 2017-04-19 11:13 ` Xiao Guangrong 2017-04-19 11:13 ` [Qemu-devel] " Xiao Guangrong 2017-04-19 16:44 ` Paolo Bonzini 2017-04-19 16:44 ` [Qemu-devel] " Paolo Bonzini 2017-04-14 5:09 ` Paolo Bonzini 2017-04-14 5:09 ` [Qemu-devel] " Paolo Bonzini 2017-04-14 6:07 ` Xiao Guangrong
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=b855686b-20cd-9403-c765-c8b3a3268302@redhat.com \ --to=pbonzini@redhat.com \ --cc=guangrong.xiao@gmail.com \ --cc=kvm@vger.kernel.org \ --cc=mst@redhat.com \ --cc=mtosatti@redhat.com \ --cc=qemu-devel@nongnu.org \ --cc=xiaoguangrong@tencent.com \ --cc=yunfangtai@tencent.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.