All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] sunxi: Revert "sunxi: make SoC variant choice mandatory"
Date: Sun, 12 Jun 2016 19:50:20 +0200	[thread overview]
Message-ID: <b85742aa-c18d-f871-07e3-e6e0e20b4a04@redhat.com> (raw)
In-Reply-To: <1465734303.22752.21.camel@hellion.org.uk>

Hi,

On 12-06-16 14:25, Ian Campbell wrote:
> On Sun, 2016-06-12 at 13:03 +0200, Hans de Goede wrote:
>> This reverts commit 1a5f0de08e86("sunxi: make SoC variant choice
>> mandatory").
>>
>> With the optional marking in the Kconfig "make savedefconfig"
>> will drop CONFIG_MACH_SUN4I=y from all the A10 boards, making it
>> hard to see at a glance which family of sunxi chips the defconfig
>> is for.
>>
>> This commit therefore restores the optional, and restores
>> CONFIG_MACH_SUN4I=y to all defconfig's which had it dropped
>> because of this.
>
> Is this because the first config in a choice is considered the default
> and hence is omitted by savedefconfig

Yes, exactly.

> or is something else going on?
>
> In any case:
>
>> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
>
> Acked-by: Ian Campbell <ijc@hellion.org.uk>

Thanks for all the reviews!

Regards,

Hans


p.s.

I've just send out another patch for a new board

  reply	other threads:[~2016-06-12 17:50 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-12 11:03 [U-Boot] [PATCH] sunxi: Revert "sunxi: make SoC variant choice mandatory" Hans de Goede
2016-06-12 12:25 ` Ian Campbell
2016-06-12 17:50   ` Hans de Goede [this message]
  -- strict thread matches above, loose matches on Subject: below --
2016-06-12 11:00 Hans de Goede

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b85742aa-c18d-f871-07e3-e6e0e20b4a04@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.