All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guoqing Jiang <guoqing.jiang@cloud.ionos.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: axboe@kernel.dk, linux-block@vger.kernel.org,
	target-devel@vger.kernel.org, linux-scsi@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	linux-ide@vger.kernel.org, linux-mmc@vger.kernel.org,
	linux-nvme@lists.infradead.org, linux-nfs@vger.kernel.org
Subject: Re: [PATCH 1/2] block: remove unnecessary argument from blk_execute_rq_nowait
Date: Fri, 22 Jan 2021 08:36:45 +0100	[thread overview]
Message-ID: <b87591b9-e598-6436-d41f-80cc56640549@cloud.ionos.com> (raw)
In-Reply-To: <20210121170257.GA4120717@infradead.org>



On 1/21/21 18:02, Christoph Hellwig wrote:
> On Thu, Jan 21, 2021 at 03:29:04PM +0100, Guoqing Jiang wrote:
>> The 'q' is not used since commit a1ce35fa4985 ("block: remove dead
>> elevator code"), also update the comment of the function.
> 
> And more importantly it never really was needed to start with given
> that we can triviall derive it from struct request.

Thanks Christoph, will add the above to header and send new version.

Guoqing

WARNING: multiple messages have this Message-ID (diff)
From: Guoqing Jiang <guoqing.jiang@cloud.ionos.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: axboe@kernel.dk, linux-nfs@vger.kernel.org,
	linux-scsi@vger.kernel.org, linux-mmc@vger.kernel.org,
	linux-nvme@lists.infradead.org,
	virtualization@lists.linux-foundation.org,
	linux-block@vger.kernel.org, linux-ide@vger.kernel.org,
	target-devel@vger.kernel.org
Subject: Re: [PATCH 1/2] block: remove unnecessary argument from blk_execute_rq_nowait
Date: Fri, 22 Jan 2021 08:36:45 +0100	[thread overview]
Message-ID: <b87591b9-e598-6436-d41f-80cc56640549@cloud.ionos.com> (raw)
In-Reply-To: <20210121170257.GA4120717@infradead.org>



On 1/21/21 18:02, Christoph Hellwig wrote:
> On Thu, Jan 21, 2021 at 03:29:04PM +0100, Guoqing Jiang wrote:
>> The 'q' is not used since commit a1ce35fa4985 ("block: remove dead
>> elevator code"), also update the comment of the function.
> 
> And more importantly it never really was needed to start with given
> that we can triviall derive it from struct request.

Thanks Christoph, will add the above to header and send new version.

Guoqing

_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme

WARNING: multiple messages have this Message-ID (diff)
From: Guoqing Jiang <guoqing.jiang@cloud.ionos.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: axboe@kernel.dk, linux-nfs@vger.kernel.org,
	linux-scsi@vger.kernel.org, linux-mmc@vger.kernel.org,
	linux-nvme@lists.infradead.org,
	virtualization@lists.linux-foundation.org,
	linux-block@vger.kernel.org, linux-ide@vger.kernel.org,
	target-devel@vger.kernel.org
Subject: Re: [PATCH 1/2] block: remove unnecessary argument from blk_execute_rq_nowait
Date: Fri, 22 Jan 2021 08:36:45 +0100	[thread overview]
Message-ID: <b87591b9-e598-6436-d41f-80cc56640549@cloud.ionos.com> (raw)
In-Reply-To: <20210121170257.GA4120717@infradead.org>



On 1/21/21 18:02, Christoph Hellwig wrote:
> On Thu, Jan 21, 2021 at 03:29:04PM +0100, Guoqing Jiang wrote:
>> The 'q' is not used since commit a1ce35fa4985 ("block: remove dead
>> elevator code"), also update the comment of the function.
> 
> And more importantly it never really was needed to start with given
> that we can triviall derive it from struct request.

Thanks Christoph, will add the above to header and send new version.

Guoqing
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

  reply	other threads:[~2021-01-22  7:37 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-21 14:29 [PATCH 0/2] remove unused argument from blk_execute_rq_nowait and blk_execute_rq Guoqing Jiang
2021-01-21 14:29 ` Guoqing Jiang
2021-01-21 14:29 ` Guoqing Jiang
2021-01-21 14:29 ` [PATCH 1/2] block: remove unnecessary argument from blk_execute_rq_nowait Guoqing Jiang
2021-01-21 14:29   ` Guoqing Jiang
2021-01-21 14:29   ` Guoqing Jiang
2021-01-21 17:02   ` Christoph Hellwig
2021-01-21 17:02     ` Christoph Hellwig
2021-01-21 17:02     ` Christoph Hellwig
2021-01-22  7:36     ` Guoqing Jiang [this message]
2021-01-22  7:36       ` Guoqing Jiang
2021-01-22  7:36       ` Guoqing Jiang
2021-01-21 14:29 ` [PATCH 2/2] block: remove unnecessary argument from blk_execute_rq Guoqing Jiang
2021-01-21 14:29   ` Guoqing Jiang
2021-01-21 14:29   ` Guoqing Jiang
2021-01-21 17:04   ` Christoph Hellwig
2021-01-21 17:04     ` Christoph Hellwig
2021-01-21 17:04     ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b87591b9-e598-6436-d41f-80cc56640549@cloud.ionos.com \
    --to=guoqing.jiang@cloud.ionos.com \
    --cc=axboe@kernel.dk \
    --cc=hch@infradead.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=target-devel@vger.kernel.org \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.