* [PATCH 1/1] ARM: imx7ulp: add cpuidle support
@ 2017-08-27 13:43 ` Dong Aisheng
0 siblings, 0 replies; 6+ messages in thread
From: Dong Aisheng @ 2017-08-27 13:43 UTC (permalink / raw)
To: linux-pm
Cc: linux-arm-kernel, daniel.lezcano, rjw, shawnguo, Anson.Huang,
Dong Aisheng
i.MX7ULP support 3 levels idle as below:
1. patial stop mode 3;
2. patial stop mode 2;
3. patial stop mode 1.
PSTOP1 - Partial Stop with system and bus clock disabled
PSTOP2 - Partial Stop with system clock disabled and bus clock enabled
PSTOP3 - Partial Stop with system clock enabled and bus clock enabled
For PSTOP 1/2 mode, as the system and bus clock will be disabled, the
devices working inprogress may not be able to work anymore, driver needs
to use pm_qos API to prevent system enter those modes.
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: Shawn Guo <shawnguo@kernel.org>
Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
---
arch/arm/mach-imx/Makefile | 1 +
arch/arm/mach-imx/common.h | 12 +++++++
arch/arm/mach-imx/cpuidle-imx7ulp.c | 69 +++++++++++++++++++++++++++++++++++++
arch/arm/mach-imx/cpuidle.h | 5 +++
arch/arm/mach-imx/mach-imx7ulp.c | 7 ++++
arch/arm/mach-imx/pm-imx7ulp.c | 65 +++++++++++++++++++++++++++++++---
6 files changed, 155 insertions(+), 4 deletions(-)
create mode 100644 arch/arm/mach-imx/cpuidle-imx7ulp.c
diff --git a/arch/arm/mach-imx/Makefile b/arch/arm/mach-imx/Makefile
index c5948b7..a3f55a9 100644
--- a/arch/arm/mach-imx/Makefile
+++ b/arch/arm/mach-imx/Makefile
@@ -28,6 +28,7 @@ obj-$(CONFIG_SOC_IMX6Q) += cpuidle-imx6q.o
obj-$(CONFIG_SOC_IMX6SL) += cpuidle-imx6sl.o
obj-$(CONFIG_SOC_IMX6SX) += cpuidle-imx6sx.o
obj-$(CONFIG_SOC_IMX6UL) += cpuidle-imx6sx.o
+obj-$(CONFIG_SOC_IMX7ULP) += cpuidle-imx7ulp.o
endif
ifdef CONFIG_SND_IMX_SOC
diff --git a/arch/arm/mach-imx/common.h b/arch/arm/mach-imx/common.h
index b0e85df..9b78902 100644
--- a/arch/arm/mach-imx/common.h
+++ b/arch/arm/mach-imx/common.h
@@ -78,6 +78,17 @@ enum mx3_cpu_pwr_mode {
MX3_SLEEP,
};
+enum imx7ulp_cpu_pwr_mode {
+ HSRUN,
+ RUN,
+ VLPR,
+ WAIT,
+ VLPW,
+ STOP,
+ VLPS,
+ VLLS,
+};
+
void mx3_cpu_lp_set(enum mx3_cpu_pwr_mode mode);
void imx_enable_cpu(int cpu, bool enable);
@@ -106,6 +117,7 @@ int imx6_set_lpm(enum mxc_cpu_pwr_mode mode);
void imx6_set_int_mem_clk_lpm(bool enable);
void imx6sl_set_wait_clk(bool enter);
int imx_mmdc_get_ddr_type(void);
+int imx7ulp_set_lpm(enum imx7ulp_cpu_pwr_mode mode);
void imx_cpu_die(unsigned int cpu);
int imx_cpu_kill(unsigned int cpu);
diff --git a/arch/arm/mach-imx/cpuidle-imx7ulp.c b/arch/arm/mach-imx/cpuidle-imx7ulp.c
new file mode 100644
index 0000000..f165d85
--- /dev/null
+++ b/arch/arm/mach-imx/cpuidle-imx7ulp.c
@@ -0,0 +1,69 @@
+/*
+ * Copyright (C) 2016 Freescale Semiconductor, Inc.
+ * Copyright (C) 2017 NXP.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ */
+
+#include <linux/cpuidle.h>
+#include <linux/module.h>
+#include <asm/cpuidle.h>
+
+#include "common.h"
+#include "cpuidle.h"
+#include "hardware.h"
+
+static int imx7ulp_enter_idle(struct cpuidle_device *dev,
+ struct cpuidle_driver *drv, int index)
+{
+ switch (index) {
+ case 1:
+ imx7ulp_set_lpm(WAIT);
+ break;
+ case 2:
+ imx7ulp_set_lpm(STOP);
+ break;
+ default:
+ break;
+ }
+
+ cpu_do_idle();
+
+ imx7ulp_set_lpm(RUN);
+
+ return index;
+}
+
+static struct cpuidle_driver imx7ulp_cpuidle_driver = {
+ .name = "imx7ulp_cpuidle",
+ .owner = THIS_MODULE,
+ .states = {
+ /* WFI */
+ ARM_CPUIDLE_WFI_STATE,
+ /* WAIT */
+ {
+ .exit_latency = 50,
+ .target_residency = 75,
+ .enter = imx7ulp_enter_idle,
+ .name = "WAIT",
+ .desc = "PSTOP2",
+ },
+ /* STOP */
+ {
+ .exit_latency = 100,
+ .target_residency = 150,
+ .enter = imx7ulp_enter_idle,
+ .name = "STOP",
+ .desc = "PSTOP1",
+ },
+ },
+ .state_count = 3,
+ .safe_state_index = 0,
+};
+
+int __init imx7ulp_cpuidle_init(void)
+{
+ return cpuidle_register(&imx7ulp_cpuidle_driver, NULL);
+}
diff --git a/arch/arm/mach-imx/cpuidle.h b/arch/arm/mach-imx/cpuidle.h
index f914012..7694c8f 100644
--- a/arch/arm/mach-imx/cpuidle.h
+++ b/arch/arm/mach-imx/cpuidle.h
@@ -15,6 +15,7 @@ extern int imx5_cpuidle_init(void);
extern int imx6q_cpuidle_init(void);
extern int imx6sl_cpuidle_init(void);
extern int imx6sx_cpuidle_init(void);
+extern int imx7ulp_cpuidle_init(void);
#else
static inline int imx5_cpuidle_init(void)
{
@@ -32,4 +33,8 @@ static inline int imx6sx_cpuidle_init(void)
{
return 0;
}
+static inline int imx7ulp_cpuidle_init(void)
+{
+ return 0;
+}
#endif
diff --git a/arch/arm/mach-imx/mach-imx7ulp.c b/arch/arm/mach-imx/mach-imx7ulp.c
index 9f7a25c..1d8fe71 100644
--- a/arch/arm/mach-imx/mach-imx7ulp.c
+++ b/arch/arm/mach-imx/mach-imx7ulp.c
@@ -15,8 +15,14 @@
#include <asm/mach/arch.h>
#include "common.h"
+#include "cpuidle.h"
#include "hardware.h"
+static void __init imx7ulp_init_late(void)
+{
+ imx7ulp_cpuidle_init();
+}
+
static void __init imx7ulp_init_machine(void)
{
imx7ulp_pm_init();
@@ -33,5 +39,6 @@ static const char *const imx7ulp_dt_compat[] __initconst = {
DT_MACHINE_START(IMX7ulp, "Freescale i.MX7ULP (Device Tree)")
.init_machine = imx7ulp_init_machine,
+ .init_late = imx7ulp_init_late,
.dt_compat = imx7ulp_dt_compat,
MACHINE_END
diff --git a/arch/arm/mach-imx/pm-imx7ulp.c b/arch/arm/mach-imx/pm-imx7ulp.c
index df5d6b6..5f85040 100644
--- a/arch/arm/mach-imx/pm-imx7ulp.c
+++ b/arch/arm/mach-imx/pm-imx7ulp.c
@@ -14,20 +14,77 @@
#include <linux/of.h>
#include <linux/of_address.h>
+#include "common.h"
+
+/* SMC registers */
+#define SMC_PMPROT 0x8
#define SMC_PMCTRL 0x10
+#define SMC_PMSTAT 0x18
+#define SMC_SRS 0x20
+#define SMC_RPC 0x24
+#define SMC_SSRS 0x28
+#define SMC_SRIE 0x2c
+#define SMC_SRIF 0x30
+#define SMC_CSRE 0x34
+#define SMC_MR 0x40
+#define SMC_FM 0x40
+
+/* PMPROT */
+#define BM_PMPROT_AHSRUN BIT(7)
+#define BM_PMPROT_AVLP BIT(5)
+#define BM_PMPROT_ALLS BIT(3)
+#define BM_PMPROT_AVLLS BIT(1)
+
+/* PMCTRL */
+#define BM_PMCTRL_STOPA (0x1 << 24)
#define BP_PMCTRL_PSTOPO 16
+#define BM_PMCTRL_PSTOPO (0x3 << BP_PMCTRL_PSTOPO)
+#define BP_PMCTRL_RUNM 8
+#define BM_PMCTRL_RUNM (0x3 << BP_PMCTRL_RUNM)
+#define BP_PMCTRL_STOPM 0
+#define BM_PMCTRL_STOPM (0x7 << BP_PMCTRL_STOPM)
+
#define PSTOPO_PSTOP3 0x3
+#define PSTOPO_PSTOP2 0x2
+#define PSTOPO_PSTOP1 0x1
+
+static void __iomem *smc1_base;
+
+int imx7ulp_set_lpm(enum imx7ulp_cpu_pwr_mode mode)
+{
+ u32 smc_ctrl = readl_relaxed(smc1_base + SMC_PMCTRL);
+
+ smc_ctrl &= ~(BM_PMCTRL_RUNM | BM_PMCTRL_STOPM | BM_PMCTRL_PSTOPO);
+
+ switch (mode) {
+ case RUN:
+ /* system/bus clock enabled */
+ smc_ctrl |= PSTOPO_PSTOP3 << BP_PMCTRL_PSTOPO;
+ break;
+ case WAIT:
+ /* system clock disabled, bus clock enabled */
+ smc_ctrl |= PSTOPO_PSTOP2 << BP_PMCTRL_PSTOPO;
+ break;
+ case STOP:
+ /* system/bus clock disabled */
+ smc_ctrl |= PSTOPO_PSTOP1 << BP_PMCTRL_PSTOPO;
+ break;
+ default:
+ return -EINVAL;
+ }
+
+ writel_relaxed(smc_ctrl, smc1_base + SMC_PMCTRL);
+
+ return 0;
+}
void __init imx7ulp_pm_init(void)
{
struct device_node *np;
- void __iomem *smc1_base;
np = of_find_compatible_node(NULL, NULL, "fsl,imx7ulp-smc1");
smc1_base = of_iomap(np, 0);
WARN_ON(!smc1_base);
- /* Partial Stop mode 3 with system/bus clock enabled */
- writel_relaxed(PSTOPO_PSTOP3 << BP_PMCTRL_PSTOPO,
- smc1_base + SMC_PMCTRL);
+ imx7ulp_set_lpm(RUN);
}
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 1/1] ARM: imx7ulp: add cpuidle support
@ 2017-08-27 13:43 ` Dong Aisheng
0 siblings, 0 replies; 6+ messages in thread
From: Dong Aisheng @ 2017-08-27 13:43 UTC (permalink / raw)
To: linux-arm-kernel
i.MX7ULP support 3 levels idle as below:
1. patial stop mode 3;
2. patial stop mode 2;
3. patial stop mode 1.
PSTOP1 - Partial Stop with system and bus clock disabled
PSTOP2 - Partial Stop with system clock disabled and bus clock enabled
PSTOP3 - Partial Stop with system clock enabled and bus clock enabled
For PSTOP 1/2 mode, as the system and bus clock will be disabled, the
devices working inprogress may not be able to work anymore, driver needs
to use pm_qos API to prevent system enter those modes.
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: Shawn Guo <shawnguo@kernel.org>
Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
---
arch/arm/mach-imx/Makefile | 1 +
arch/arm/mach-imx/common.h | 12 +++++++
arch/arm/mach-imx/cpuidle-imx7ulp.c | 69 +++++++++++++++++++++++++++++++++++++
arch/arm/mach-imx/cpuidle.h | 5 +++
arch/arm/mach-imx/mach-imx7ulp.c | 7 ++++
arch/arm/mach-imx/pm-imx7ulp.c | 65 +++++++++++++++++++++++++++++++---
6 files changed, 155 insertions(+), 4 deletions(-)
create mode 100644 arch/arm/mach-imx/cpuidle-imx7ulp.c
diff --git a/arch/arm/mach-imx/Makefile b/arch/arm/mach-imx/Makefile
index c5948b7..a3f55a9 100644
--- a/arch/arm/mach-imx/Makefile
+++ b/arch/arm/mach-imx/Makefile
@@ -28,6 +28,7 @@ obj-$(CONFIG_SOC_IMX6Q) += cpuidle-imx6q.o
obj-$(CONFIG_SOC_IMX6SL) += cpuidle-imx6sl.o
obj-$(CONFIG_SOC_IMX6SX) += cpuidle-imx6sx.o
obj-$(CONFIG_SOC_IMX6UL) += cpuidle-imx6sx.o
+obj-$(CONFIG_SOC_IMX7ULP) += cpuidle-imx7ulp.o
endif
ifdef CONFIG_SND_IMX_SOC
diff --git a/arch/arm/mach-imx/common.h b/arch/arm/mach-imx/common.h
index b0e85df..9b78902 100644
--- a/arch/arm/mach-imx/common.h
+++ b/arch/arm/mach-imx/common.h
@@ -78,6 +78,17 @@ enum mx3_cpu_pwr_mode {
MX3_SLEEP,
};
+enum imx7ulp_cpu_pwr_mode {
+ HSRUN,
+ RUN,
+ VLPR,
+ WAIT,
+ VLPW,
+ STOP,
+ VLPS,
+ VLLS,
+};
+
void mx3_cpu_lp_set(enum mx3_cpu_pwr_mode mode);
void imx_enable_cpu(int cpu, bool enable);
@@ -106,6 +117,7 @@ int imx6_set_lpm(enum mxc_cpu_pwr_mode mode);
void imx6_set_int_mem_clk_lpm(bool enable);
void imx6sl_set_wait_clk(bool enter);
int imx_mmdc_get_ddr_type(void);
+int imx7ulp_set_lpm(enum imx7ulp_cpu_pwr_mode mode);
void imx_cpu_die(unsigned int cpu);
int imx_cpu_kill(unsigned int cpu);
diff --git a/arch/arm/mach-imx/cpuidle-imx7ulp.c b/arch/arm/mach-imx/cpuidle-imx7ulp.c
new file mode 100644
index 0000000..f165d85
--- /dev/null
+++ b/arch/arm/mach-imx/cpuidle-imx7ulp.c
@@ -0,0 +1,69 @@
+/*
+ * Copyright (C) 2016 Freescale Semiconductor, Inc.
+ * Copyright (C) 2017 NXP.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ */
+
+#include <linux/cpuidle.h>
+#include <linux/module.h>
+#include <asm/cpuidle.h>
+
+#include "common.h"
+#include "cpuidle.h"
+#include "hardware.h"
+
+static int imx7ulp_enter_idle(struct cpuidle_device *dev,
+ struct cpuidle_driver *drv, int index)
+{
+ switch (index) {
+ case 1:
+ imx7ulp_set_lpm(WAIT);
+ break;
+ case 2:
+ imx7ulp_set_lpm(STOP);
+ break;
+ default:
+ break;
+ }
+
+ cpu_do_idle();
+
+ imx7ulp_set_lpm(RUN);
+
+ return index;
+}
+
+static struct cpuidle_driver imx7ulp_cpuidle_driver = {
+ .name = "imx7ulp_cpuidle",
+ .owner = THIS_MODULE,
+ .states = {
+ /* WFI */
+ ARM_CPUIDLE_WFI_STATE,
+ /* WAIT */
+ {
+ .exit_latency = 50,
+ .target_residency = 75,
+ .enter = imx7ulp_enter_idle,
+ .name = "WAIT",
+ .desc = "PSTOP2",
+ },
+ /* STOP */
+ {
+ .exit_latency = 100,
+ .target_residency = 150,
+ .enter = imx7ulp_enter_idle,
+ .name = "STOP",
+ .desc = "PSTOP1",
+ },
+ },
+ .state_count = 3,
+ .safe_state_index = 0,
+};
+
+int __init imx7ulp_cpuidle_init(void)
+{
+ return cpuidle_register(&imx7ulp_cpuidle_driver, NULL);
+}
diff --git a/arch/arm/mach-imx/cpuidle.h b/arch/arm/mach-imx/cpuidle.h
index f914012..7694c8f 100644
--- a/arch/arm/mach-imx/cpuidle.h
+++ b/arch/arm/mach-imx/cpuidle.h
@@ -15,6 +15,7 @@ extern int imx5_cpuidle_init(void);
extern int imx6q_cpuidle_init(void);
extern int imx6sl_cpuidle_init(void);
extern int imx6sx_cpuidle_init(void);
+extern int imx7ulp_cpuidle_init(void);
#else
static inline int imx5_cpuidle_init(void)
{
@@ -32,4 +33,8 @@ static inline int imx6sx_cpuidle_init(void)
{
return 0;
}
+static inline int imx7ulp_cpuidle_init(void)
+{
+ return 0;
+}
#endif
diff --git a/arch/arm/mach-imx/mach-imx7ulp.c b/arch/arm/mach-imx/mach-imx7ulp.c
index 9f7a25c..1d8fe71 100644
--- a/arch/arm/mach-imx/mach-imx7ulp.c
+++ b/arch/arm/mach-imx/mach-imx7ulp.c
@@ -15,8 +15,14 @@
#include <asm/mach/arch.h>
#include "common.h"
+#include "cpuidle.h"
#include "hardware.h"
+static void __init imx7ulp_init_late(void)
+{
+ imx7ulp_cpuidle_init();
+}
+
static void __init imx7ulp_init_machine(void)
{
imx7ulp_pm_init();
@@ -33,5 +39,6 @@ static const char *const imx7ulp_dt_compat[] __initconst = {
DT_MACHINE_START(IMX7ulp, "Freescale i.MX7ULP (Device Tree)")
.init_machine = imx7ulp_init_machine,
+ .init_late = imx7ulp_init_late,
.dt_compat = imx7ulp_dt_compat,
MACHINE_END
diff --git a/arch/arm/mach-imx/pm-imx7ulp.c b/arch/arm/mach-imx/pm-imx7ulp.c
index df5d6b6..5f85040 100644
--- a/arch/arm/mach-imx/pm-imx7ulp.c
+++ b/arch/arm/mach-imx/pm-imx7ulp.c
@@ -14,20 +14,77 @@
#include <linux/of.h>
#include <linux/of_address.h>
+#include "common.h"
+
+/* SMC registers */
+#define SMC_PMPROT 0x8
#define SMC_PMCTRL 0x10
+#define SMC_PMSTAT 0x18
+#define SMC_SRS 0x20
+#define SMC_RPC 0x24
+#define SMC_SSRS 0x28
+#define SMC_SRIE 0x2c
+#define SMC_SRIF 0x30
+#define SMC_CSRE 0x34
+#define SMC_MR 0x40
+#define SMC_FM 0x40
+
+/* PMPROT */
+#define BM_PMPROT_AHSRUN BIT(7)
+#define BM_PMPROT_AVLP BIT(5)
+#define BM_PMPROT_ALLS BIT(3)
+#define BM_PMPROT_AVLLS BIT(1)
+
+/* PMCTRL */
+#define BM_PMCTRL_STOPA (0x1 << 24)
#define BP_PMCTRL_PSTOPO 16
+#define BM_PMCTRL_PSTOPO (0x3 << BP_PMCTRL_PSTOPO)
+#define BP_PMCTRL_RUNM 8
+#define BM_PMCTRL_RUNM (0x3 << BP_PMCTRL_RUNM)
+#define BP_PMCTRL_STOPM 0
+#define BM_PMCTRL_STOPM (0x7 << BP_PMCTRL_STOPM)
+
#define PSTOPO_PSTOP3 0x3
+#define PSTOPO_PSTOP2 0x2
+#define PSTOPO_PSTOP1 0x1
+
+static void __iomem *smc1_base;
+
+int imx7ulp_set_lpm(enum imx7ulp_cpu_pwr_mode mode)
+{
+ u32 smc_ctrl = readl_relaxed(smc1_base + SMC_PMCTRL);
+
+ smc_ctrl &= ~(BM_PMCTRL_RUNM | BM_PMCTRL_STOPM | BM_PMCTRL_PSTOPO);
+
+ switch (mode) {
+ case RUN:
+ /* system/bus clock enabled */
+ smc_ctrl |= PSTOPO_PSTOP3 << BP_PMCTRL_PSTOPO;
+ break;
+ case WAIT:
+ /* system clock disabled, bus clock enabled */
+ smc_ctrl |= PSTOPO_PSTOP2 << BP_PMCTRL_PSTOPO;
+ break;
+ case STOP:
+ /* system/bus clock disabled */
+ smc_ctrl |= PSTOPO_PSTOP1 << BP_PMCTRL_PSTOPO;
+ break;
+ default:
+ return -EINVAL;
+ }
+
+ writel_relaxed(smc_ctrl, smc1_base + SMC_PMCTRL);
+
+ return 0;
+}
void __init imx7ulp_pm_init(void)
{
struct device_node *np;
- void __iomem *smc1_base;
np = of_find_compatible_node(NULL, NULL, "fsl,imx7ulp-smc1");
smc1_base = of_iomap(np, 0);
WARN_ON(!smc1_base);
- /* Partial Stop mode 3 with system/bus clock enabled */
- writel_relaxed(PSTOPO_PSTOP3 << BP_PMCTRL_PSTOPO,
- smc1_base + SMC_PMCTRL);
+ imx7ulp_set_lpm(RUN);
}
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 1/1] ARM: imx7ulp: add cpuidle support
2017-08-27 13:43 ` Dong Aisheng
@ 2017-08-29 8:30 ` Daniel Lezcano
-1 siblings, 0 replies; 6+ messages in thread
From: Daniel Lezcano @ 2017-08-29 8:30 UTC (permalink / raw)
To: Dong Aisheng, linux-pm; +Cc: linux-arm-kernel, rjw, shawnguo, Anson.Huang
On 27/08/2017 15:43, Dong Aisheng wrote:
> i.MX7ULP support 3 levels idle as below:
> 1. patial stop mode 3;
> 2. patial stop mode 2;
> 3. patial stop mode 1.
>
> PSTOP1 - Partial Stop with system and bus clock disabled
> PSTOP2 - Partial Stop with system clock disabled and bus clock enabled
> PSTOP3 - Partial Stop with system clock enabled and bus clock enabled
>
> For PSTOP 1/2 mode, as the system and bus clock will be disabled, the
> devices working inprogress may not be able to work anymore, driver needs
> to use pm_qos API to prevent system enter those modes.
>
> Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
> Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
> Cc: Shawn Guo <shawnguo@kernel.org>
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
> ---
Acked-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Will you consider in the future to move the driver to a DT based
description and to the cpuidle-arm driver ?
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 1/1] ARM: imx7ulp: add cpuidle support
@ 2017-08-29 8:30 ` Daniel Lezcano
0 siblings, 0 replies; 6+ messages in thread
From: Daniel Lezcano @ 2017-08-29 8:30 UTC (permalink / raw)
To: linux-arm-kernel
On 27/08/2017 15:43, Dong Aisheng wrote:
> i.MX7ULP support 3 levels idle as below:
> 1. patial stop mode 3;
> 2. patial stop mode 2;
> 3. patial stop mode 1.
>
> PSTOP1 - Partial Stop with system and bus clock disabled
> PSTOP2 - Partial Stop with system clock disabled and bus clock enabled
> PSTOP3 - Partial Stop with system clock enabled and bus clock enabled
>
> For PSTOP 1/2 mode, as the system and bus clock will be disabled, the
> devices working inprogress may not be able to work anymore, driver needs
> to use pm_qos API to prevent system enter those modes.
>
> Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
> Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
> Cc: Shawn Guo <shawnguo@kernel.org>
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
> ---
Acked-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Will you consider in the future to move the driver to a DT based
description and to the cpuidle-arm driver ?
--
<http://www.linaro.org/> Linaro.org ? Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH 1/1] ARM: imx7ulp: add cpuidle support
2017-08-29 8:30 ` Daniel Lezcano
@ 2017-08-29 9:32 ` A.s. Dong
-1 siblings, 0 replies; 6+ messages in thread
From: A.s. Dong @ 2017-08-29 9:32 UTC (permalink / raw)
To: Daniel Lezcano, linux-pm; +Cc: linux-arm-kernel, rjw, shawnguo, Anson Huang
> -----Original Message-----
> From: Daniel Lezcano [mailto:daniel.lezcano@linaro.org]
> Sent: Tuesday, August 29, 2017 4:30 PM
> To: A.s. Dong; linux-pm@vger.kernel.org
> Cc: linux-arm-kernel@lists.infradead.org; rjw@rjwysocki.net;
> shawnguo@kernel.org; Anson Huang
> Subject: Re: [PATCH 1/1] ARM: imx7ulp: add cpuidle support
>
> On 27/08/2017 15:43, Dong Aisheng wrote:
> > i.MX7ULP support 3 levels idle as below:
> > 1. patial stop mode 3;
> > 2. patial stop mode 2;
> > 3. patial stop mode 1.
> >
> > PSTOP1 - Partial Stop with system and bus clock disabled
> > PSTOP2 - Partial Stop with system clock disabled and bus clock enabled
> > PSTOP3 - Partial Stop with system clock enabled and bus clock enabled
> >
> > For PSTOP 1/2 mode, as the system and bus clock will be disabled, the
> > devices working inprogress may not be able to work anymore, driver
> > needs to use pm_qos API to prevent system enter those modes.
> >
> > Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
> > Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
> > Cc: Shawn Guo <shawnguo@kernel.org>
> > Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> > Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
> > ---
>
> Acked-by: Daniel Lezcano <daniel.lezcano@linaro.org>
>
> Will you consider in the future to move the driver to a DT based
> description and to the cpuidle-arm driver ?
>
Thanks for the suggestion.
I will investigate it later when I'm free.
Shawn,
This is based on the former imx7ulp arch patch series.
Will notify you once they're merged.
Regards
Dong Aisheng
> --
> <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
>
> Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
> <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-
> blog/> Blog
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 1/1] ARM: imx7ulp: add cpuidle support
@ 2017-08-29 9:32 ` A.s. Dong
0 siblings, 0 replies; 6+ messages in thread
From: A.s. Dong @ 2017-08-29 9:32 UTC (permalink / raw)
To: linux-arm-kernel
> -----Original Message-----
> From: Daniel Lezcano [mailto:daniel.lezcano at linaro.org]
> Sent: Tuesday, August 29, 2017 4:30 PM
> To: A.s. Dong; linux-pm at vger.kernel.org
> Cc: linux-arm-kernel at lists.infradead.org; rjw at rjwysocki.net;
> shawnguo at kernel.org; Anson Huang
> Subject: Re: [PATCH 1/1] ARM: imx7ulp: add cpuidle support
>
> On 27/08/2017 15:43, Dong Aisheng wrote:
> > i.MX7ULP support 3 levels idle as below:
> > 1. patial stop mode 3;
> > 2. patial stop mode 2;
> > 3. patial stop mode 1.
> >
> > PSTOP1 - Partial Stop with system and bus clock disabled
> > PSTOP2 - Partial Stop with system clock disabled and bus clock enabled
> > PSTOP3 - Partial Stop with system clock enabled and bus clock enabled
> >
> > For PSTOP 1/2 mode, as the system and bus clock will be disabled, the
> > devices working inprogress may not be able to work anymore, driver
> > needs to use pm_qos API to prevent system enter those modes.
> >
> > Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
> > Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
> > Cc: Shawn Guo <shawnguo@kernel.org>
> > Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> > Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
> > ---
>
> Acked-by: Daniel Lezcano <daniel.lezcano@linaro.org>
>
> Will you consider in the future to move the driver to a DT based
> description and to the cpuidle-arm driver ?
>
Thanks for the suggestion.
I will investigate it later when I'm free.
Shawn,
This is based on the former imx7ulp arch patch series.
Will notify you once they're merged.
Regards
Dong Aisheng
> --
> <http://www.linaro.org/> Linaro.org ? Open source software for ARM SoCs
>
> Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
> <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-
> blog/> Blog
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-08-29 9:32 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-27 13:43 [PATCH 1/1] ARM: imx7ulp: add cpuidle support Dong Aisheng
2017-08-27 13:43 ` Dong Aisheng
2017-08-29 8:30 ` Daniel Lezcano
2017-08-29 8:30 ` Daniel Lezcano
2017-08-29 9:32 ` A.s. Dong
2017-08-29 9:32 ` A.s. Dong
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.