All of lore.kernel.org
 help / color / mirror / Atom feed
* Re: [PATCH] auto-t: fix testNetconfig
  2020-09-17 21:32 [PATCH] auto-t: fix testNetconfig James Prestwood
@ 2020-09-17 21:20 ` Denis Kenzior
  0 siblings, 0 replies; 2+ messages in thread
From: Denis Kenzior @ 2020-09-17 21:20 UTC (permalink / raw)
  To: iwd

[-- Attachment #1: Type: text/plain, Size: 385 bytes --]

Hi James,

On 9/17/20 4:32 PM, James Prestwood wrote:
> The interface was hard coded to wln0 which works when running single
> tests but not when running multiple. Instead use the actual ifname
> that hostapd is using.
> ---
>   autotests/testNetconfig/connection_test.py | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
> 

Applied, thanks.

Regards,
-Denis

^ permalink raw reply	[flat|nested] 2+ messages in thread

* [PATCH] auto-t: fix testNetconfig
@ 2020-09-17 21:32 James Prestwood
  2020-09-17 21:20 ` Denis Kenzior
  0 siblings, 1 reply; 2+ messages in thread
From: James Prestwood @ 2020-09-17 21:32 UTC (permalink / raw)
  To: iwd

[-- Attachment #1: Type: text/plain, Size: 1451 bytes --]

The interface was hard coded to wln0 which works when running single
tests but not when running multiple. Instead use the actual ifname
that hostapd is using.
---
 autotests/testNetconfig/connection_test.py | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/autotests/testNetconfig/connection_test.py b/autotests/testNetconfig/connection_test.py
index 3a590aeb..6818ceff 100644
--- a/autotests/testNetconfig/connection_test.py
+++ b/autotests/testNetconfig/connection_test.py
@@ -8,6 +8,7 @@ import iwd
 from iwd import IWD
 from iwd import PSKAgent
 from iwd import NetworkType
+from hostapd import HostapdCLI
 import testutil
 from config import ctx
 
@@ -54,10 +55,11 @@ class Test(unittest.TestCase):
 
     @classmethod
     def setUpClass(cls):
+        hapd = HostapdCLI()
         # TODO: This could be moved into test-runner itself if other tests ever
         #       require this functionality (p2p, FILS, etc.). Since its simple
         #       enough it can stay here for now.
-        ctx.start_process(['ifconfig', 'wln0', '192.168.1.1', 'netmask', '255.255.255.0'],
+        ctx.start_process(['ifconfig', hapd.ifname, '192.168.1.1', 'netmask', '255.255.255.0'],
                                 wait=True)
         ctx.start_process(['touch', '/tmp/dhcpd.leases'], wait=True)
         ctx.start_process(['dhcpd', '-cf', '/tmp/dhcpd.conf', '-lf', '/tmp/dhcpd.leases'])
-- 
2.26.2

^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-09-17 21:32 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-17 21:32 [PATCH] auto-t: fix testNetconfig James Prestwood
2020-09-17 21:20 ` Denis Kenzior

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.