[MPTCP] Re: [MPTCP][PATCH v4 mptcp-next 0/2] mptcp: add the address ID assignment bitmap and testcases

[MPTCP] Re: [MPTCP][PATCH v4 mptcp-next 0/2] mptcp: add the address ID assignment bitmap and testcases

[Mat Martineau]

[-- Attachment #1: Type: text/plain, Size: 914 bytes --]


On Wed, 9 Dec 2020, Geliang Tang wrote:

> v4:
> - update the find_next code

v4 looks good for the export branch based on code review and running 
tests. Thanks Geliang!

Mat


>
> v3:
> - call find_next_zero_bit() again for the invalid id.
> - use "for (i = id; ..." in mptcp_nl_cmd_dump_addrs.
> - add a wrap around testcase.
>
> v2:
> - use BITS_PER_LONG macro.
> - add back the callback argument in cmd_dump_addrs.
> - add a testcase.
>
> Closes: https://github.com/multipath-tcp/mptcp_net-next/issues/117
>
> Geliang Tang (2):
>  mptcp: add the address ID assignment bitmap
>  selftests: mptcp: add testcases for setting the address ID
>
> net/mptcp/pm_netlink.c                        | 71 ++++++++++++++-----
> .../testing/selftests/net/mptcp/pm_netlink.sh | 41 ++++++++++-
> 2 files changed, 92 insertions(+), 20 deletions(-)
>
> -- 
> 2.26.2

--
Mat Martineau
Intel

[MPTCP] Re: [MPTCP][PATCH v4 mptcp-next 0/2] mptcp: add the address ID assignment bitmap and testcases

[Matthieu Baerts]

[-- Attachment #1: Type: text/plain, Size: 933 bytes --]

Hi Geliang, Mat,

On 09/12/2020 09:04, Geliang Tang wrote:
> v4:
>   - update the find_next code
> 
> v3:
>   - call find_next_zero_bit() again for the invalid id.
>   - use "for (i = id; ..." in mptcp_nl_cmd_dump_addrs.
>   - add a wrap around testcase.
> 
> v2:
>   - use BITS_PER_LONG macro.
>   - add back the callback argument in cmd_dump_addrs.
>   - add a testcase.

Thank you for the patches and the reviews!

Just added in our tree, with Mat's Reviewed-by tags!

- f4b03aa16214: mptcp: add the address ID assignment bitmap
- 6636ac3e5e80: selftests: mptcp: add testcases for setting the address ID
- edac8433efa9: "squashed" in "mptcp: add the address ID assignment bitmap"

Tests + export are going to be started soon

> Closes: https://github.com/multipath-tcp/mptcp_net-next/issues/117

Thanks for the link!

Cheers,
Matt
-- 
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net