All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: Christoph Hellwig <hch@lst.de>
Cc: Ming Lei <ming.lei@redhat.com>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	linux-block@vger.kernel.org, xen-devel@lists.xen.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: clean up physical merging helpers
Date: Sat, 15 Sep 2018 08:47:13 -0600	[thread overview]
Message-ID: <b8f3621a-f789-d737-649f-7b3645912888@kernel.dk> (raw)
In-Reply-To: <20180915070300.GA10555@lst.de>

On 9/15/18 1:03 AM, Christoph Hellwig wrote:
> Jens, any comments?
> 
> On Tue, Sep 04, 2018 at 12:14:18PM -0700, Christoph Hellwig wrote:
>> Hi Jens,
>>
>> this series moves various helpers related to merging based on physical
>> addresses from the public headers into block/, moves the Xen special
>> case from arch hooks into common code, cleans up the code a bit, and
>> removes not nessecary includes from the block headers.
> ---end quoted text---
> 

It's a good cleanup, I like it. Would prefer if the arm/xen folks could
ack the first bits, and 13/13 should probably just to in differently.

-- 
Jens Axboe

WARNING: multiple messages have this Message-ID (diff)
From: axboe@kernel.dk (Jens Axboe)
To: linux-arm-kernel@lists.infradead.org
Subject: clean up physical merging helpers
Date: Sat, 15 Sep 2018 08:47:13 -0600	[thread overview]
Message-ID: <b8f3621a-f789-d737-649f-7b3645912888@kernel.dk> (raw)
In-Reply-To: <20180915070300.GA10555@lst.de>

On 9/15/18 1:03 AM, Christoph Hellwig wrote:
> Jens, any comments?
> 
> On Tue, Sep 04, 2018 at 12:14:18PM -0700, Christoph Hellwig wrote:
>> Hi Jens,
>>
>> this series moves various helpers related to merging based on physical
>> addresses from the public headers into block/, moves the Xen special
>> case from arch hooks into common code, cleans up the code a bit, and
>> removes not nessecary includes from the block headers.
> ---end quoted text---
> 

It's a good cleanup, I like it. Would prefer if the arm/xen folks could
ack the first bits, and 13/13 should probably just to in differently.

-- 
Jens Axboe

  reply	other threads:[~2018-09-15 14:47 UTC|newest]

Thread overview: 72+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-04 19:14 clean up physical merging helpers Christoph Hellwig
2018-09-04 19:14 ` Christoph Hellwig
2018-09-04 19:14 ` [PATCH 01/13] arm: remove the unused BIOVEC_MERGEABLE define Christoph Hellwig
2018-09-04 19:14   ` Christoph Hellwig
2018-09-04 19:14   ` Christoph Hellwig
2018-09-04 19:14 ` [PATCH 02/13] xen: remove the xen_biovec_phys_mergeable export Christoph Hellwig
2018-09-04 19:14   ` Christoph Hellwig
2018-09-04 19:14 ` Christoph Hellwig
2018-09-04 19:14 ` [PATCH 03/13] xen: provide a prototype for xen_biovec_phys_mergeable in xen.h Christoph Hellwig
2018-09-04 19:14   ` Christoph Hellwig
2018-09-04 19:14   ` Christoph Hellwig
2018-09-04 19:14 ` [PATCH 04/13] block: move integrity_req_gap_{back,front}_merge to blk.h Christoph Hellwig
2018-09-04 19:14   ` [PATCH 04/13] block: move integrity_req_gap_{back, front}_merge " Christoph Hellwig
2018-09-04 19:14   ` Christoph Hellwig
2018-09-04 19:14 ` [PATCH 05/13] block: move req_gap_{back,front}_merge to blk-merge.c Christoph Hellwig
2018-09-04 19:14   ` [PATCH 05/13] block: move req_gap_{back, front}_merge " Christoph Hellwig
2018-09-04 19:14   ` [PATCH 05/13] block: move req_gap_{back,front}_merge " Christoph Hellwig
2018-09-04 19:14 ` [PATCH 06/13] block: move req_gap_back_merge to blk.h Christoph Hellwig
2018-09-04 19:14   ` Christoph Hellwig
2018-09-04 19:14   ` Christoph Hellwig
2018-09-04 19:14 ` [PATCH 07/13] block: simplify BIOVEC_PHYS_MERGEABLE Christoph Hellwig
2018-09-04 19:14   ` Christoph Hellwig
2018-09-04 19:14   ` Christoph Hellwig
2018-09-04 19:14 ` [PATCH 08/13] block: add a missing BIOVEC_SEG_BOUNDARY check in bio_add_pc_page Christoph Hellwig
2018-09-04 19:14   ` Christoph Hellwig
2018-09-04 19:14   ` Christoph Hellwig
2018-09-04 19:14 ` [PATCH 09/13] block: merge BIOVEC_SEG_BOUNDARY into biovec_phys_mergeable Christoph Hellwig
2018-09-04 19:14   ` Christoph Hellwig
2018-09-04 19:14   ` Christoph Hellwig
2018-09-04 19:14 ` [PATCH 10/13] block: remove bvec_to_phys Christoph Hellwig
2018-09-04 19:14   ` Christoph Hellwig
2018-09-04 19:14   ` Christoph Hellwig
2018-09-04 19:36   ` Geert Uytterhoeven
2018-09-04 19:36     ` Geert Uytterhoeven
2018-09-04 19:36     ` Geert Uytterhoeven
2018-09-04 19:14 ` [PATCH 11/13] block: don't include io.h from bio.h Christoph Hellwig
2018-09-04 19:14   ` Christoph Hellwig
2018-09-04 19:14   ` Christoph Hellwig
2018-09-04 19:14 ` [PATCH 12/13] block: don't include bug.h " Christoph Hellwig
2018-09-04 19:14   ` Christoph Hellwig
2018-09-04 19:14   ` Christoph Hellwig
2018-09-04 19:14 ` [PATCH 13/13] xen: don't include <xen/xen.h> from <asm/io.h> and <asm/dma-mapping.h> Christoph Hellwig
2018-09-04 19:14   ` Christoph Hellwig
2018-09-04 19:14   ` Christoph Hellwig
2018-09-15  7:03 ` clean up physical merging helpers Christoph Hellwig
2018-09-15  7:03   ` Christoph Hellwig
2018-09-15 14:47   ` Jens Axboe [this message]
2018-09-15 14:47     ` Jens Axboe
2018-09-20  6:29     ` Christoph Hellwig
2018-09-20  6:29       ` Christoph Hellwig
2018-09-20  7:52       ` Christoph Hellwig
2018-09-20  7:52       ` Christoph Hellwig
2018-09-20  7:52         ` Christoph Hellwig
2018-09-20 14:39       ` Jens Axboe
2018-09-20 14:39       ` Jens Axboe
2018-09-20 14:39         ` Jens Axboe
2018-09-24 14:25         ` Boris Ostrovsky
2018-09-24 14:25         ` [Xen-devel] " Boris Ostrovsky
2018-09-24 14:25           ` Boris Ostrovsky
2018-09-25 20:29           ` Christoph Hellwig
2018-09-25 20:29             ` Christoph Hellwig
2018-09-25 20:29             ` [Xen-devel] " Christoph Hellwig
2018-09-20  6:29     ` Christoph Hellwig
2018-09-15 14:47   ` Jens Axboe
2018-09-15  7:03 ` Christoph Hellwig
2018-09-04 19:14 Christoph Hellwig
2018-09-25 20:30 Christoph Hellwig
2018-09-25 20:30 ` Christoph Hellwig
2018-09-25 20:30 ` Christoph Hellwig
2018-09-26 14:45 ` Jens Axboe
2018-09-26 14:45   ` Jens Axboe
2018-09-26 14:45   ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b8f3621a-f789-d737-649f-7b3645912888@kernel.dk \
    --to=axboe@kernel.dk \
    --cc=hch@lst.de \
    --cc=konrad.wilk@oracle.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-block@vger.kernel.org \
    --cc=ming.lei@redhat.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.