From: Jamal Hadi Salim <jhs@mojatatu.com>
To: Cong Wang <xiyou.wangcong@gmail.com>, Chris Mi <chrism@mellanox.com>
Cc: Linux Kernel Network Developers <netdev@vger.kernel.org>,
Lucas Bates <lucasb@mojatatu.com>, Jiri Pirko <jiri@resnulli.us>,
David Miller <davem@davemloft.net>
Subject: Re: [patch net v2 1/4] net/sched: Change tc_action refcnt and bindcnt to atomic
Date: Thu, 19 Oct 2017 10:21:18 -0400 [thread overview]
Message-ID: <b9444485-8e34-48ac-2b4f-abbd9c6d455f@mojatatu.com> (raw)
In-Reply-To: <CAM_iQpVA2SQ4eFWEQxjQwmoxwQnQiLgREETKdQLoADWt_xD4Bg@mail.gmail.com>
On 17-10-18 12:43 PM, Cong Wang wrote:
> On Tue, Oct 17, 2017 at 6:03 PM, Chris Mi <chrism@mellanox.com> wrote:
>>> -----Original Message-----
>
> You listed 3 problems, and you think they are 3 different ones, here
> I argue problem 3 (using RCU callbacks) is the cause of problem 1
> (refcnt not atomic). This is why I mentioned I have been thinking about
> removing RCU callbacks, because it probably could fix all of them.
>
Cong,
Given this is a known bug (the test case Chris presented crashes the
kernel) - would it make sense to have a patch that goes to -net
to fix this while your approach and discussion outcome goes into
net-next?
cheers,
jamal
next prev parent reply other threads:[~2017-10-19 14:21 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-16 11:18 [patch net v2 0/4] net/sched: Fix a system panic when deleting filters Chris Mi
2017-10-16 11:18 ` [patch net v2 1/4] net/sched: Change tc_action refcnt and bindcnt to atomic Chris Mi
2017-10-16 17:06 ` Cong Wang
2017-10-17 1:14 ` Chris Mi
2017-10-17 15:52 ` Cong Wang
2017-10-18 1:03 ` Chris Mi
2017-10-18 16:43 ` Cong Wang
2017-10-19 14:21 ` Jamal Hadi Salim [this message]
2017-10-20 3:00 ` Cong Wang
2017-10-23 2:47 ` Chris Mi
2017-10-23 15:39 ` Cong Wang
2017-10-24 6:17 ` Chris Mi
2017-10-16 11:18 ` [patch net v2 2/4] net/sched: Use action array instead of action list as parameter Chris Mi
2017-10-16 11:18 ` [patch net v2 3/4] selftests: Introduce a new script to generate tc batch file Chris Mi
2017-10-16 16:24 ` Lucas Bates
2017-10-16 11:18 ` [patch net v2 4/4] selftests: Introduce a new test case to tc testsuite Chris Mi
2017-10-16 16:25 ` Lucas Bates
2017-10-17 1:03 ` Chris Mi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b9444485-8e34-48ac-2b4f-abbd9c6d455f@mojatatu.com \
--to=jhs@mojatatu.com \
--cc=chrism@mellanox.com \
--cc=davem@davemloft.net \
--cc=jiri@resnulli.us \
--cc=lucasb@mojatatu.com \
--cc=netdev@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.