From: Matthias Brugger <matthias.bgg@gmail.com>
To: EastL <EastL.Lee@mediatek.com>, Sean Wang <sean.wang@mediatek.com>
Cc: vkoul@kernel.org, robh+dt@kernel.org, mark.rutland@arm.com,
dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org,
wsd_upstream@mediatek.com
Subject: Re: [PATCH v4 3/4] dmaengine: mediatek-cqdma: fix compatible
Date: Thu, 28 May 2020 15:39:54 +0200 [thread overview]
Message-ID: <b96e9b4d-880d-885e-fc2e-56e5618eb014@gmail.com> (raw)
In-Reply-To: <1590659832-31476-4-git-send-email-EastL.Lee@mediatek.com>
On 28/05/2020 11:57, EastL wrote:
> This patch fixes mediatek-cqdma compatible to common.
>
> Signed-off-by: EastL <EastL.Lee@mediatek.com>
> ---
> drivers/dma/mediatek/mtk-cqdma.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dma/mediatek/mtk-cqdma.c b/drivers/dma/mediatek/mtk-cqdma.c
> index 905bbcb..bca7118 100644
> --- a/drivers/dma/mediatek/mtk-cqdma.c
> +++ b/drivers/dma/mediatek/mtk-cqdma.c
> @@ -544,7 +544,7 @@ static void mtk_cqdma_hw_deinit(struct mtk_cqdma_device *cqdma)
> }
>
> static const struct of_device_id mtk_cqdma_match[] = {
> - { .compatible = "mediatek,mt6765-cqdma" },
> + { .compatible = "mediatek,cqdma" },
We can't just delete and old compatible. If other cqdma IP blocks are the same
as mt6795, we should instead add entries in the binding description with
fallback compatible. For example for mt6779 the DTS would look like this:
compatible = "mediatek,mt6779-cqdma", "mediatek,mt6765-cqdma";
This way we the kernel will take care to bind the device against the driver with
mt7665-cqdma, but leaves us the posibillity to add any changes to the driver in
the future if we find some bugs/features for mt6779 that are not present in mt6765.
Regards,
Matthias
> { /* sentinel */ }
> };
> MODULE_DEVICE_TABLE(of, mtk_cqdma_match);
>
WARNING: multiple messages have this Message-ID (diff)
From: Matthias Brugger <matthias.bgg@gmail.com>
To: EastL <EastL.Lee@mediatek.com>, Sean Wang <sean.wang@mediatek.com>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
wsd_upstream@mediatek.com, linux-kernel@vger.kernel.org,
vkoul@kernel.org, robh+dt@kernel.org,
linux-mediatek@lists.infradead.org, dmaengine@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v4 3/4] dmaengine: mediatek-cqdma: fix compatible
Date: Thu, 28 May 2020 15:39:54 +0200 [thread overview]
Message-ID: <b96e9b4d-880d-885e-fc2e-56e5618eb014@gmail.com> (raw)
In-Reply-To: <1590659832-31476-4-git-send-email-EastL.Lee@mediatek.com>
On 28/05/2020 11:57, EastL wrote:
> This patch fixes mediatek-cqdma compatible to common.
>
> Signed-off-by: EastL <EastL.Lee@mediatek.com>
> ---
> drivers/dma/mediatek/mtk-cqdma.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dma/mediatek/mtk-cqdma.c b/drivers/dma/mediatek/mtk-cqdma.c
> index 905bbcb..bca7118 100644
> --- a/drivers/dma/mediatek/mtk-cqdma.c
> +++ b/drivers/dma/mediatek/mtk-cqdma.c
> @@ -544,7 +544,7 @@ static void mtk_cqdma_hw_deinit(struct mtk_cqdma_device *cqdma)
> }
>
> static const struct of_device_id mtk_cqdma_match[] = {
> - { .compatible = "mediatek,mt6765-cqdma" },
> + { .compatible = "mediatek,cqdma" },
We can't just delete and old compatible. If other cqdma IP blocks are the same
as mt6795, we should instead add entries in the binding description with
fallback compatible. For example for mt6779 the DTS would look like this:
compatible = "mediatek,mt6779-cqdma", "mediatek,mt6765-cqdma";
This way we the kernel will take care to bind the device against the driver with
mt7665-cqdma, but leaves us the posibillity to add any changes to the driver in
the future if we find some bugs/features for mt6779 that are not present in mt6765.
Regards,
Matthias
> { /* sentinel */ }
> };
> MODULE_DEVICE_TABLE(of, mtk_cqdma_match);
>
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: Matthias Brugger <matthias.bgg@gmail.com>
To: EastL <EastL.Lee@mediatek.com>, Sean Wang <sean.wang@mediatek.com>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
wsd_upstream@mediatek.com, linux-kernel@vger.kernel.org,
vkoul@kernel.org, robh+dt@kernel.org,
linux-mediatek@lists.infradead.org, dmaengine@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v4 3/4] dmaengine: mediatek-cqdma: fix compatible
Date: Thu, 28 May 2020 15:39:54 +0200 [thread overview]
Message-ID: <b96e9b4d-880d-885e-fc2e-56e5618eb014@gmail.com> (raw)
In-Reply-To: <1590659832-31476-4-git-send-email-EastL.Lee@mediatek.com>
On 28/05/2020 11:57, EastL wrote:
> This patch fixes mediatek-cqdma compatible to common.
>
> Signed-off-by: EastL <EastL.Lee@mediatek.com>
> ---
> drivers/dma/mediatek/mtk-cqdma.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dma/mediatek/mtk-cqdma.c b/drivers/dma/mediatek/mtk-cqdma.c
> index 905bbcb..bca7118 100644
> --- a/drivers/dma/mediatek/mtk-cqdma.c
> +++ b/drivers/dma/mediatek/mtk-cqdma.c
> @@ -544,7 +544,7 @@ static void mtk_cqdma_hw_deinit(struct mtk_cqdma_device *cqdma)
> }
>
> static const struct of_device_id mtk_cqdma_match[] = {
> - { .compatible = "mediatek,mt6765-cqdma" },
> + { .compatible = "mediatek,cqdma" },
We can't just delete and old compatible. If other cqdma IP blocks are the same
as mt6795, we should instead add entries in the binding description with
fallback compatible. For example for mt6779 the DTS would look like this:
compatible = "mediatek,mt6779-cqdma", "mediatek,mt6765-cqdma";
This way we the kernel will take care to bind the device against the driver with
mt7665-cqdma, but leaves us the posibillity to add any changes to the driver in
the future if we find some bugs/features for mt6779 that are not present in mt6765.
Regards,
Matthias
> { /* sentinel */ }
> };
> MODULE_DEVICE_TABLE(of, mtk_cqdma_match);
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-05-28 13:40 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-28 9:57 [PATCH v4] dmaengine: mediatek-cqdma: add dt-bindings and remove redundant queue EastL
2020-05-28 9:57 ` EastL
2020-05-28 9:57 ` EastL
2020-05-28 9:57 ` [PATCH v4 1/4] dt-bindings: dmaengine: Add MediaTek Command-Queue DMA controller bindings EastL
2020-05-28 9:57 ` EastL
2020-05-28 9:57 ` EastL
2020-05-29 19:24 ` Rob Herring
2020-05-29 19:24 ` Rob Herring
2020-05-29 19:24 ` Rob Herring
2020-06-11 8:00 ` EastL
2020-06-11 8:00 ` EastL
2020-06-11 8:00 ` EastL
2020-05-28 9:57 ` [PATCH v4 2/4] dmaengine: mediatek-cqdma: remove redundant queue structure EastL
2020-05-28 9:57 ` EastL
2020-05-28 9:57 ` [PATCH v4 3/4] dmaengine: mediatek-cqdma: fix compatible EastL
2020-05-28 9:57 ` EastL
2020-05-28 9:57 ` EastL
2020-05-28 13:39 ` Matthias Brugger [this message]
2020-05-28 13:39 ` Matthias Brugger
2020-05-28 13:39 ` Matthias Brugger
2020-06-12 8:12 ` EastL
2020-06-12 8:12 ` EastL
2020-06-12 8:12 ` EastL
2020-05-28 9:57 ` [PATCH v4 4/4] dmaengine: mediatek-cqdma: add dma mask for capability EastL
2020-05-28 9:57 ` EastL
2020-05-28 9:57 ` EastL
2020-05-28 14:10 ` Matthias Brugger
2020-05-28 14:10 ` Matthias Brugger
2020-05-28 14:10 ` Matthias Brugger
2020-06-12 8:13 ` EastL
2020-06-12 8:13 ` EastL
2020-06-12 8:13 ` EastL
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b96e9b4d-880d-885e-fc2e-56e5618eb014@gmail.com \
--to=matthias.bgg@gmail.com \
--cc=EastL.Lee@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=sean.wang@mediatek.com \
--cc=vkoul@kernel.org \
--cc=wsd_upstream@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.