[Qemu-devel] [PATCH] tests: add mac99 and g3beige in boot-serial-test

[Qemu-devel] [PATCH] tests: add mac99 and g3beige in boot-serial-test

[Laurent Vivier]

g3beige (pmac_oldworld) and mac99 (pmac_newworld) are missing in
boot-serial-test.

Perhaps because serial output of OpenBIOS is only enabled with
'-nographic'

Signed-off-by: Laurent Vivier <lvivier@redhat.com>
---
 tests/boot-serial-test.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/tests/boot-serial-test.c b/tests/boot-serial-test.c
index d98c564..d477a6a 100644
--- a/tests/boot-serial-test.c
+++ b/tests/boot-serial-test.c
@@ -26,8 +26,12 @@ static testdef_t tests[] = {
     { "alpha", "clipper", "", "PCI:" },
     { "ppc", "ppce500", "", "U-Boot" },
     { "ppc", "prep", "", "Open Hack'Ware BIOS" },
+    { "ppc", "mac99", "-nographic", "OpenBIOS" },
+    { "ppc", "g3beige", "-nographic", "OpenBIOS" },
     { "ppc64", "ppce500", "", "U-Boot" },
     { "ppc64", "prep", "", "Open Hack'Ware BIOS" },
+    { "ppc64", "mac99", "-nographic", "OpenBIOS" },
+    { "ppc64", "g3beige", "-nographic", "OpenBIOS" },
     { "ppc64", "pseries", "", "Open Firmware" },
     { "i386", "isapc", "-cpu qemu32 -device sga", "SGABIOS" },
     { "i386", "pc", "-device sga", "SGABIOS" },
-- 
2.7.4

Re: [Qemu-devel] [PATCH] tests: add mac99 and g3beige in boot-serial-test

[Thomas Huth]

On 13.10.2016 21:53, Laurent Vivier wrote:
> g3beige (pmac_oldworld) and mac99 (pmac_newworld) are missing in
> boot-serial-test.
> 
> Perhaps because serial output of OpenBIOS is only enabled with
> '-nographic'

IIRC clearly, I've left them out because they are basically already
tested with the prom-env test. I was a little bit afraid that the
testing time would become too long, but since this test is quite fast,
and it makes sense to check whether the serial output is working, too, I
think it's also OK if you add them here.

Two thoughts though:

1) I think you do *not* need the "-nographic" here, because the test is
using the "-serial" parameter to get the output of the serial console.

2) While you're at it, you could enable the test for a sparc and a
sparc64 machine, too (preferably one that is not tested by the prom-env
test yet)

 Thomas

> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
> ---
>  tests/boot-serial-test.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/tests/boot-serial-test.c b/tests/boot-serial-test.c
> index d98c564..d477a6a 100644
> --- a/tests/boot-serial-test.c
> +++ b/tests/boot-serial-test.c
> @@ -26,8 +26,12 @@ static testdef_t tests[] = {
>      { "alpha", "clipper", "", "PCI:" },
>      { "ppc", "ppce500", "", "U-Boot" },
>      { "ppc", "prep", "", "Open Hack'Ware BIOS" },
> +    { "ppc", "mac99", "-nographic", "OpenBIOS" },
> +    { "ppc", "g3beige", "-nographic", "OpenBIOS" },
>      { "ppc64", "ppce500", "", "U-Boot" },
>      { "ppc64", "prep", "", "Open Hack'Ware BIOS" },
> +    { "ppc64", "mac99", "-nographic", "OpenBIOS" },
> +    { "ppc64", "g3beige", "-nographic", "OpenBIOS" },
>      { "ppc64", "pseries", "", "Open Firmware" },
>      { "i386", "isapc", "-cpu qemu32 -device sga", "SGABIOS" },
>      { "i386", "pc", "-device sga", "SGABIOS" },
> 

Re: [Qemu-devel] [PATCH] tests: add mac99 and g3beige in boot-serial-test

[Laurent Vivier]

On 13/10/2016 22:26, Thomas Huth wrote:
> On 13.10.2016 21:53, Laurent Vivier wrote:
>> g3beige (pmac_oldworld) and mac99 (pmac_newworld) are missing in
>> boot-serial-test.
>>
>> Perhaps because serial output of OpenBIOS is only enabled with
>> '-nographic'
> 
> IIRC clearly, I've left them out because they are basically already
> tested with the prom-env test. I was a little bit afraid that the
> testing time would become too long, but since this test is quite fast,
> and it makes sense to check whether the serial output is working, too, I
> think it's also OK if you add them here.
> 
> Two thoughts though:
> 
> 1) I think you do *not* need the "-nographic" here, because the test is
> using the "-serial" parameter to get the output of the serial console.

Yes, you're right, and as it was not an oversight, just forget this patch...

Thanks,
Laurent