All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rakib Mullick <rakib.mullick@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: jirislaby@gmail.com, LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH -mm] char, moxa: Make isabrds variable global.
Date: Tue, 3 Nov 2009 10:29:12 +0600	[thread overview]
Message-ID: <b9df5fa10911022029q197a0c5dkbbda609f4e41287@mail.gmail.com> (raw)

 When CONFIG_MODULE=n and CONFIG_PCI=n, then variable
isabrds becomes unused variable. So place it outside
moxa_init solves this problem.

 We were warned by the following warning:

drivers/char/moxa.c: In function `moxa_init':
drivers/char/moxa.c:1012: warning: unused variable `isabrds'

Signed-off-by: Rakib Mullick <rakib.mullick@gmail.com>
----

--- linus/drivers/char/moxa.c	2009-09-11 20:39:02.000000000 +0600
+++ rakib/drivers/char/moxa.c	2009-11-03 10:57:44.000000000 +0600
@@ -1007,9 +1007,10 @@ static struct pci_driver moxa_pci_driver
 };
 #endif /* CONFIG_PCI */

+static unsigned int __initdata isabrds;
+
 static int __init moxa_init(void)
 {
-	unsigned int isabrds = 0;
 	int retval = 0;

 	printk(KERN_INFO "MOXA Intellio family driver version %s\n",

             reply	other threads:[~2009-11-03  4:29 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-03  4:29 Rakib Mullick [this message]
2009-11-07  5:08 ` [PATCH -mm] char, moxa: Make isabrds variable global Rakib Mullick
2009-11-07 10:27   ` Jiri Slaby
2009-11-09  2:06     ` Rakib Mullick
2009-11-09  8:20       ` Jiri Slaby
2009-11-10 17:42         ` Rakib Mullick

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b9df5fa10911022029q197a0c5dkbbda609f4e41287@mail.gmail.com \
    --to=rakib.mullick@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=jirislaby@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.