All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rakib Mullick <rakib.mullick@gmail.com>
To: Jiri Slaby <jirislaby@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -mm] char, moxa: Make isabrds variable global.
Date: Mon, 9 Nov 2009 08:06:47 +0600	[thread overview]
Message-ID: <b9df5fa10911081806m7564f778k35e0308fc5ddfba4@mail.gmail.com> (raw)
In-Reply-To: <4AF54B77.2000605@gmail.com>

On 11/7/09, Jiri Slaby <jirislaby@gmail.com> wrote:
>
> Sorry I had no time to look into the first patch. And it makes no sense.
>  The driver is unusable on !MODULE && !PCI. So better fix is to disallow
>  whole build on such configurations. Care to fix that?
>
Hi Jiri, thanks for your care. Would you please checkout the
patch below? Is it okay?


 moxa:  Disallow moxa build when !MODULE && !PCI.
If MODULES support is not enabled then MODULE=y is not
possible.

Signed-off-by: Rakib Mullick <rakib.mullick@gmail.com>
-----

--- linus/drivers/char/Kconfig	2009-11-06 13:45:42.000000000 +0600
+++ rakib/drivers/char/Kconfig	2009-11-08 21:31:48.000000000 +0600
@@ -216,7 +216,7 @@ config ESPSERIAL

 config MOXA_INTELLIO
 	tristate "Moxa Intellio support"
-	depends on SERIAL_NONSTANDARD && (ISA || EISA || PCI)
+	depends on SERIAL_NONSTANDARD && (ISA || EISA || PCI) || MODULES
 	select FW_LOADER
 	help
 	  Say Y here if you have a Moxa Intellio multiport serial card.
@@ -226,7 +226,7 @@ config MOXA_INTELLIO

 config MOXA_SMARTIO
 	tristate "Moxa SmartIO support v. 2.0"
-	depends on SERIAL_NONSTANDARD && (PCI || EISA || ISA)
+	depends on SERIAL_NONSTANDARD && (PCI || EISA || ISA) || MODULES
 	help
 	  Say Y here if you have a Moxa SmartIO multiport serial card and/or
 	  want to help develop a new version of this driver.

  reply	other threads:[~2009-11-09  2:06 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-03  4:29 [PATCH -mm] char, moxa: Make isabrds variable global Rakib Mullick
2009-11-07  5:08 ` Rakib Mullick
2009-11-07 10:27   ` Jiri Slaby
2009-11-09  2:06     ` Rakib Mullick [this message]
2009-11-09  8:20       ` Jiri Slaby
2009-11-10 17:42         ` Rakib Mullick

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b9df5fa10911081806m7564f778k35e0308fc5ddfba4@mail.gmail.com \
    --to=rakib.mullick@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=jirislaby@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.