From: Jian Hu <jian.hu@amlogic.com>
To: Maxime Ripard <maxime@cerno.tech>
Cc: Jerome Brunet <jbrunet@baylibre.com>,
Neil Armstrong <narmstrong@baylibre.com>,
Kevin Hilman <khilman@baylibre.com>,
Rob Herring <robh@kernel.org>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Qiufang Dai <qiufang.dai@amlogic.com>,
Jianxin Pan <jianxin.pan@amlogic.com>,
Victor Wan <victor.wan@amlogic.com>,
Chandle Zou <chandle.zou@amlogic.com>,
<linux-clk@vger.kernel.org>, <linux-amlogic@lists.infradead.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>
Subject: Re: [PATCH v4 1/6] dt-bindings: clock: meson: add A1 PLL clock controller bindings
Date: Wed, 18 Dec 2019 16:00:20 +0800 [thread overview]
Message-ID: <ba16b846-1d5f-3d1e-e8e2-420687d11e8a@amlogic.com> (raw)
In-Reply-To: <20191213103856.qo7vlnuk4ajz3vq5@gilmour.lan>
Hi Maxime
Thanks for your review
On 2019/12/13 18:38, Maxime Ripard wrote:
> Hi,
>
> On Fri, Dec 06, 2019 at 03:40:47PM +0800, Jian Hu wrote:
>> Add the documentation to support Amlogic A1 PLL clock driver,
>> and add A1 PLL clock controller bindings.
>>
>> Signed-off-by: Jian Hu <jian.hu@amlogic.com>
>> ---
>> .../bindings/clock/amlogic,a1-pll-clkc.yaml | 59 +++++++++++++++++++
>> include/dt-bindings/clock/a1-pll-clkc.h | 16 +++++
>> 2 files changed, 75 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/clock/amlogic,a1-pll-clkc.yaml
>> create mode 100644 include/dt-bindings/clock/a1-pll-clkc.h
>>
>> diff --git a/Documentation/devicetree/bindings/clock/amlogic,a1-pll-clkc.yaml b/Documentation/devicetree/bindings/clock/amlogic,a1-pll-clkc.yaml
>> new file mode 100644
>> index 000000000000..7feeef5abf1b
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/clock/amlogic,a1-pll-clkc.yaml
>> @@ -0,0 +1,59 @@
>> +/* SPDX-License-Identifier: (GPL-2.0+ OR MIT) */
>> +/*
>> + * Copyright (c) 2019 Amlogic, Inc. All rights reserved.
>> + */
>> +%YAML 1.2
>> +---
>> +$id: "http://devicetree.org/schemas/clock/amlogic,a1-pll-clkc.yaml#"
>> +$schema: "http://devicetree.org/meta-schemas/core.yaml#"
>> +
>> +title: Amlogic Meson A/C serials PLL Clock Control Unit Device Tree Bindings
>> +
>> +maintainers:
>> + - Neil Armstrong <narmstrong@baylibre.com>
>> + - Jerome Brunet <jbrunet@baylibre.com>
>> + - Jian Hu <jian.hu@jian.hu.com>
>> +
>> +properties:
>> + compatible:
>> + - enum:
>> + - amlogic,a1-pll-clkc
>
> I'm not sure this works, compatible shouldn't contain a list.
>
I refered to
Documentation/devicetree/bindings/clock/allwinner,sun4i-a10-ccu.yaml.
I have used 'dt-doc-validate' tools to check, it will report something
wrong below.
properties:compatible: [{'enum': ['amlogic,a1-pll-clkc']}] is not of
type 'object', 'boolean'
Refer to
https://github.com/robherring/dt-schema/blob/master/example-schema.yaml
I will change it like this:
properties:
compatible:
oneOf:
- enum:
- amlogic,a1-pll-clkc
And It has been passed by 'dt-doc-validate' tools.
Is it right?
> You can write this like:
> compatible:
> const: amlogic,a1-pll-clkc
>
>> + "#clock-cells":
>> + const: 1
>> +
>> + reg:
>> + maxItems: 1
>> +
>> +clocks:
>> + minItems: 2
>> + maxItems: 2
>
> This is redundant, it will be added automatically by the tools ...
If I remove the minItems, it will pass by dt-doc-validate.
Would please tell how to use dt-schema to generate automatically it?
>
>> + items:
>> + - description: Input xtal_fixpll
>> + - description: Input xtal_hifipll
>
> ... When you have a list of items :)
>
>> +
>> +clock-names:
>> + minItems: 2
>> + maxItems: 2
>> + items:
>> + - const: xtal_fixpll
>> + - const: xtal_hifipll
>
> Same story here
OK, I will change it when I find the right way.
>
> Maxime
>
WARNING: multiple messages have this Message-ID (diff)
From: Jian Hu <jian.hu@amlogic.com>
To: Maxime Ripard <maxime@cerno.tech>
Cc: Rob Herring <robh@kernel.org>,
Victor Wan <victor.wan@amlogic.com>,
Jianxin Pan <jianxin.pan@amlogic.com>,
Neil Armstrong <narmstrong@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Kevin Hilman <khilman@baylibre.com>,
Michael Turquette <mturquette@baylibre.com>,
linux-kernel@vger.kernel.org, Stephen Boyd <sboyd@kernel.org>,
devicetree@vger.kernel.org, Qiufang Dai <qiufang.dai@amlogic.com>,
Chandle Zou <chandle.zou@amlogic.com>,
linux-amlogic@lists.infradead.org, linux-clk@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Jerome Brunet <jbrunet@baylibre.com>
Subject: Re: [PATCH v4 1/6] dt-bindings: clock: meson: add A1 PLL clock controller bindings
Date: Wed, 18 Dec 2019 16:00:20 +0800 [thread overview]
Message-ID: <ba16b846-1d5f-3d1e-e8e2-420687d11e8a@amlogic.com> (raw)
In-Reply-To: <20191213103856.qo7vlnuk4ajz3vq5@gilmour.lan>
Hi Maxime
Thanks for your review
On 2019/12/13 18:38, Maxime Ripard wrote:
> Hi,
>
> On Fri, Dec 06, 2019 at 03:40:47PM +0800, Jian Hu wrote:
>> Add the documentation to support Amlogic A1 PLL clock driver,
>> and add A1 PLL clock controller bindings.
>>
>> Signed-off-by: Jian Hu <jian.hu@amlogic.com>
>> ---
>> .../bindings/clock/amlogic,a1-pll-clkc.yaml | 59 +++++++++++++++++++
>> include/dt-bindings/clock/a1-pll-clkc.h | 16 +++++
>> 2 files changed, 75 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/clock/amlogic,a1-pll-clkc.yaml
>> create mode 100644 include/dt-bindings/clock/a1-pll-clkc.h
>>
>> diff --git a/Documentation/devicetree/bindings/clock/amlogic,a1-pll-clkc.yaml b/Documentation/devicetree/bindings/clock/amlogic,a1-pll-clkc.yaml
>> new file mode 100644
>> index 000000000000..7feeef5abf1b
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/clock/amlogic,a1-pll-clkc.yaml
>> @@ -0,0 +1,59 @@
>> +/* SPDX-License-Identifier: (GPL-2.0+ OR MIT) */
>> +/*
>> + * Copyright (c) 2019 Amlogic, Inc. All rights reserved.
>> + */
>> +%YAML 1.2
>> +---
>> +$id: "http://devicetree.org/schemas/clock/amlogic,a1-pll-clkc.yaml#"
>> +$schema: "http://devicetree.org/meta-schemas/core.yaml#"
>> +
>> +title: Amlogic Meson A/C serials PLL Clock Control Unit Device Tree Bindings
>> +
>> +maintainers:
>> + - Neil Armstrong <narmstrong@baylibre.com>
>> + - Jerome Brunet <jbrunet@baylibre.com>
>> + - Jian Hu <jian.hu@jian.hu.com>
>> +
>> +properties:
>> + compatible:
>> + - enum:
>> + - amlogic,a1-pll-clkc
>
> I'm not sure this works, compatible shouldn't contain a list.
>
I refered to
Documentation/devicetree/bindings/clock/allwinner,sun4i-a10-ccu.yaml.
I have used 'dt-doc-validate' tools to check, it will report something
wrong below.
properties:compatible: [{'enum': ['amlogic,a1-pll-clkc']}] is not of
type 'object', 'boolean'
Refer to
https://github.com/robherring/dt-schema/blob/master/example-schema.yaml
I will change it like this:
properties:
compatible:
oneOf:
- enum:
- amlogic,a1-pll-clkc
And It has been passed by 'dt-doc-validate' tools.
Is it right?
> You can write this like:
> compatible:
> const: amlogic,a1-pll-clkc
>
>> + "#clock-cells":
>> + const: 1
>> +
>> + reg:
>> + maxItems: 1
>> +
>> +clocks:
>> + minItems: 2
>> + maxItems: 2
>
> This is redundant, it will be added automatically by the tools ...
If I remove the minItems, it will pass by dt-doc-validate.
Would please tell how to use dt-schema to generate automatically it?
>
>> + items:
>> + - description: Input xtal_fixpll
>> + - description: Input xtal_hifipll
>
> ... When you have a list of items :)
>
>> +
>> +clock-names:
>> + minItems: 2
>> + maxItems: 2
>> + items:
>> + - const: xtal_fixpll
>> + - const: xtal_hifipll
>
> Same story here
OK, I will change it when I find the right way.
>
> Maxime
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Jian Hu <jian.hu@amlogic.com>
To: Maxime Ripard <maxime@cerno.tech>
Cc: Rob Herring <robh@kernel.org>,
Victor Wan <victor.wan@amlogic.com>,
Jianxin Pan <jianxin.pan@amlogic.com>,
Neil Armstrong <narmstrong@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Kevin Hilman <khilman@baylibre.com>,
Michael Turquette <mturquette@baylibre.com>,
linux-kernel@vger.kernel.org, Stephen Boyd <sboyd@kernel.org>,
devicetree@vger.kernel.org, Qiufang Dai <qiufang.dai@amlogic.com>,
Chandle Zou <chandle.zou@amlogic.com>,
linux-amlogic@lists.infradead.org, linux-clk@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Jerome Brunet <jbrunet@baylibre.com>
Subject: Re: [PATCH v4 1/6] dt-bindings: clock: meson: add A1 PLL clock controller bindings
Date: Wed, 18 Dec 2019 16:00:20 +0800 [thread overview]
Message-ID: <ba16b846-1d5f-3d1e-e8e2-420687d11e8a@amlogic.com> (raw)
In-Reply-To: <20191213103856.qo7vlnuk4ajz3vq5@gilmour.lan>
Hi Maxime
Thanks for your review
On 2019/12/13 18:38, Maxime Ripard wrote:
> Hi,
>
> On Fri, Dec 06, 2019 at 03:40:47PM +0800, Jian Hu wrote:
>> Add the documentation to support Amlogic A1 PLL clock driver,
>> and add A1 PLL clock controller bindings.
>>
>> Signed-off-by: Jian Hu <jian.hu@amlogic.com>
>> ---
>> .../bindings/clock/amlogic,a1-pll-clkc.yaml | 59 +++++++++++++++++++
>> include/dt-bindings/clock/a1-pll-clkc.h | 16 +++++
>> 2 files changed, 75 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/clock/amlogic,a1-pll-clkc.yaml
>> create mode 100644 include/dt-bindings/clock/a1-pll-clkc.h
>>
>> diff --git a/Documentation/devicetree/bindings/clock/amlogic,a1-pll-clkc.yaml b/Documentation/devicetree/bindings/clock/amlogic,a1-pll-clkc.yaml
>> new file mode 100644
>> index 000000000000..7feeef5abf1b
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/clock/amlogic,a1-pll-clkc.yaml
>> @@ -0,0 +1,59 @@
>> +/* SPDX-License-Identifier: (GPL-2.0+ OR MIT) */
>> +/*
>> + * Copyright (c) 2019 Amlogic, Inc. All rights reserved.
>> + */
>> +%YAML 1.2
>> +---
>> +$id: "http://devicetree.org/schemas/clock/amlogic,a1-pll-clkc.yaml#"
>> +$schema: "http://devicetree.org/meta-schemas/core.yaml#"
>> +
>> +title: Amlogic Meson A/C serials PLL Clock Control Unit Device Tree Bindings
>> +
>> +maintainers:
>> + - Neil Armstrong <narmstrong@baylibre.com>
>> + - Jerome Brunet <jbrunet@baylibre.com>
>> + - Jian Hu <jian.hu@jian.hu.com>
>> +
>> +properties:
>> + compatible:
>> + - enum:
>> + - amlogic,a1-pll-clkc
>
> I'm not sure this works, compatible shouldn't contain a list.
>
I refered to
Documentation/devicetree/bindings/clock/allwinner,sun4i-a10-ccu.yaml.
I have used 'dt-doc-validate' tools to check, it will report something
wrong below.
properties:compatible: [{'enum': ['amlogic,a1-pll-clkc']}] is not of
type 'object', 'boolean'
Refer to
https://github.com/robherring/dt-schema/blob/master/example-schema.yaml
I will change it like this:
properties:
compatible:
oneOf:
- enum:
- amlogic,a1-pll-clkc
And It has been passed by 'dt-doc-validate' tools.
Is it right?
> You can write this like:
> compatible:
> const: amlogic,a1-pll-clkc
>
>> + "#clock-cells":
>> + const: 1
>> +
>> + reg:
>> + maxItems: 1
>> +
>> +clocks:
>> + minItems: 2
>> + maxItems: 2
>
> This is redundant, it will be added automatically by the tools ...
If I remove the minItems, it will pass by dt-doc-validate.
Would please tell how to use dt-schema to generate automatically it?
>
>> + items:
>> + - description: Input xtal_fixpll
>> + - description: Input xtal_hifipll
>
> ... When you have a list of items :)
>
>> +
>> +clock-names:
>> + minItems: 2
>> + maxItems: 2
>> + items:
>> + - const: xtal_fixpll
>> + - const: xtal_hifipll
>
> Same story here
OK, I will change it when I find the right way.
>
> Maxime
>
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2019-12-18 8:00 UTC|newest]
Thread overview: 78+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-06 7:40 [PATCH v4 0/6] add Amlogic A1 clock controller driver Jian Hu
2019-12-06 7:40 ` Jian Hu
2019-12-06 7:40 ` Jian Hu
2019-12-06 7:40 ` [PATCH v4 1/6] dt-bindings: clock: meson: add A1 PLL clock controller bindings Jian Hu
2019-12-06 7:40 ` Jian Hu
2019-12-06 7:40 ` Jian Hu
2019-12-12 9:57 ` Jerome Brunet
2019-12-12 9:57 ` Jerome Brunet
2019-12-12 9:57 ` Jerome Brunet
2019-12-13 9:35 ` Jian Hu
2019-12-13 9:35 ` Jian Hu
2019-12-13 9:35 ` Jian Hu
2019-12-13 10:38 ` Maxime Ripard
2019-12-13 10:38 ` Maxime Ripard
2019-12-13 10:38 ` Maxime Ripard
2019-12-18 8:00 ` Jian Hu [this message]
2019-12-18 8:00 ` Jian Hu
2019-12-18 8:00 ` Jian Hu
2019-12-18 12:57 ` Maxime Ripard
2019-12-18 12:57 ` Maxime Ripard
2019-12-18 12:57 ` Maxime Ripard
2019-12-06 7:40 ` [PATCH v4 2/6] clk: meson: add support for A1 PLL clock ops Jian Hu
2019-12-06 7:40 ` Jian Hu
2019-12-06 7:40 ` Jian Hu
2019-12-12 10:16 ` Jerome Brunet
2019-12-12 10:16 ` Jerome Brunet
2019-12-12 10:16 ` Jerome Brunet
2019-12-17 8:41 ` Jian Hu
2019-12-17 8:41 ` Jian Hu
2019-12-17 8:41 ` Jian Hu
2019-12-17 9:29 ` Jerome Brunet
2019-12-17 9:29 ` Jerome Brunet
2019-12-17 9:29 ` Jerome Brunet
2019-12-18 8:37 ` Jian Hu
2019-12-18 8:37 ` Jian Hu
2019-12-18 8:37 ` Jian Hu
2019-12-20 7:03 ` Jian Hu
2019-12-20 7:03 ` Jian Hu
2019-12-20 7:03 ` Jian Hu
2019-12-06 7:40 ` [PATCH v4 3/6] clk: meson: eeclk: refactor eeclk common driver to support A1 Jian Hu
2019-12-06 7:40 ` Jian Hu
2019-12-06 7:40 ` Jian Hu
2019-12-12 10:19 ` Jerome Brunet
2019-12-12 10:19 ` Jerome Brunet
2019-12-12 10:19 ` Jerome Brunet
2019-12-17 9:36 ` Jian Hu
2019-12-17 9:36 ` Jian Hu
2019-12-17 9:36 ` Jian Hu
2019-12-06 7:40 ` [PATCH v4 4/6] clk: meson: a1: add support for Amlogic A1 PLL clock driver Jian Hu
2019-12-06 7:40 ` Jian Hu
2019-12-06 7:40 ` Jian Hu
2019-12-12 10:28 ` Jerome Brunet
2019-12-12 10:28 ` Jerome Brunet
2019-12-12 10:28 ` Jerome Brunet
2019-12-12 10:42 ` Jerome Brunet
2019-12-12 10:42 ` Jerome Brunet
2019-12-12 10:42 ` Jerome Brunet
2019-12-18 6:01 ` Jian Hu
2019-12-18 6:01 ` Jian Hu
2019-12-18 6:01 ` Jian Hu
2019-12-06 7:40 ` [PATCH v4 5/6] dt-bindings: clock: meson: add A1 peripheral clock controller bindings Jian Hu
2019-12-06 7:40 ` Jian Hu
2019-12-06 7:40 ` Jian Hu
2019-12-12 9:59 ` Jerome Brunet
2019-12-12 9:59 ` Jerome Brunet
2019-12-12 9:59 ` Jerome Brunet
2019-12-18 7:00 ` Jian Hu
2019-12-18 7:00 ` Jian Hu
2019-12-18 7:00 ` Jian Hu
2019-12-06 7:40 ` [PATCH v4 6/6] clk: meson: a1: add support for Amlogic A1 Peripheral clock driver Jian Hu
2019-12-06 7:40 ` Jian Hu
2019-12-06 7:40 ` Jian Hu
2019-12-12 11:01 ` Jerome Brunet
2019-12-12 11:01 ` Jerome Brunet
2019-12-12 11:01 ` Jerome Brunet
2019-12-18 7:20 ` Jian Hu
2019-12-18 7:20 ` Jian Hu
2019-12-18 7:20 ` Jian Hu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ba16b846-1d5f-3d1e-e8e2-420687d11e8a@amlogic.com \
--to=jian.hu@amlogic.com \
--cc=chandle.zou@amlogic.com \
--cc=devicetree@vger.kernel.org \
--cc=jbrunet@baylibre.com \
--cc=jianxin.pan@amlogic.com \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=maxime@cerno.tech \
--cc=mturquette@baylibre.com \
--cc=narmstrong@baylibre.com \
--cc=qiufang.dai@amlogic.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=victor.wan@amlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.