All of lore.kernel.org
 help / color / mirror / Atom feed
From: Markus Elfring <Markus.Elfring@web.de>
To: linux-tegra@vger.kernel.org, linux-pm@vger.kernel.org,
	Chanwoo Choi <cw00.choi@samsung.com>,
	Dmitry Osipenko <digetx@gmail.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	Kyungmin Park <kyungmin.park@samsung.com>,
	MyungJoo Ham <myungjoo.ham@samsung.com>,
	Thierry Reding <thierry.reding@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
	kernel-janitors@vger.kernel.org,
	Tang Bin <tangbin@cmss.chinamobile.com>
Subject: [PATCH] PM / devfreq: tegra30: Delete an error message in tegra_devfreq_probe()
Date: Sat, 4 Apr 2020 20:45:36 +0200	[thread overview]
Message-ID: <ba67e238-43a7-6c53-363e-7a2c12f09949@web.de> (raw)

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sat, 4 Apr 2020 20:34:02 +0200

The function “platform_get_irq” can log an error already.
Thus omit a redundant message for the exception handling in the
calling function.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 drivers/devfreq/tegra30-devfreq.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/devfreq/tegra30-devfreq.c b/drivers/devfreq/tegra30-devfreq.c
index 28b2c7ca416e..93e6f4b25b04 100644
--- a/drivers/devfreq/tegra30-devfreq.c
+++ b/drivers/devfreq/tegra30-devfreq.c
@@ -807,10 +807,9 @@ static int tegra_devfreq_probe(struct platform_device *pdev)
 	}

 	err = platform_get_irq(pdev, 0);
-	if (err < 0) {
-		dev_err(&pdev->dev, "Failed to get IRQ: %d\n", err);
+	if (err < 0)
 		return err;
-	}
+
 	tegra->irq = err;

 	irq_set_status_flags(tegra->irq, IRQ_NOAUTOEN);
--
2.26.0

WARNING: multiple messages have this Message-ID (diff)
From: Markus Elfring <Markus.Elfring@web.de>
To: linux-tegra@vger.kernel.org, linux-pm@vger.kernel.org,
	Chanwoo Choi <cw00.choi@samsung.com>,
	Dmitry Osipenko <digetx@gmail.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	Kyungmin Park <kyungmin.park@samsung.com>,
	MyungJoo Ham <myungjoo.ham@samsung.com>,
	Thierry Reding <thierry.reding@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
	kernel-janitors@vger.kernel.org,
	Tang Bin <tangbin@cmss.chinamobile.com>
Subject: [PATCH] PM / devfreq: tegra30: Delete an error message in tegra_devfreq_probe()
Date: Sat, 04 Apr 2020 18:45:36 +0000	[thread overview]
Message-ID: <ba67e238-43a7-6c53-363e-7a2c12f09949@web.de> (raw)

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sat, 4 Apr 2020 20:34:02 +0200

The function “platform_get_irq” can log an error already.
Thus omit a redundant message for the exception handling in the
calling function.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 drivers/devfreq/tegra30-devfreq.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/devfreq/tegra30-devfreq.c b/drivers/devfreq/tegra30-devfreq.c
index 28b2c7ca416e..93e6f4b25b04 100644
--- a/drivers/devfreq/tegra30-devfreq.c
+++ b/drivers/devfreq/tegra30-devfreq.c
@@ -807,10 +807,9 @@ static int tegra_devfreq_probe(struct platform_device *pdev)
 	}

 	err = platform_get_irq(pdev, 0);
-	if (err < 0) {
-		dev_err(&pdev->dev, "Failed to get IRQ: %d\n", err);
+	if (err < 0)
 		return err;
-	}
+
 	tegra->irq = err;

 	irq_set_status_flags(tegra->irq, IRQ_NOAUTOEN);
--
2.26.0

             reply	other threads:[~2020-04-04 18:45 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20200404184602epcas1p1e0188779ade7c393f9e37a4757e1b6cc@epcas1p1.samsung.com>
2020-04-04 18:45 ` Markus Elfring [this message]
2020-04-04 18:45   ` [PATCH] PM / devfreq: tegra30: Delete an error message in tegra_devfreq_probe() Markus Elfring
     [not found]   ` <ba67e238-43a7-6c53-363e-7a2c12f09949-S0/GAf8tV78@public.gmane.org>
2020-04-04 21:40     ` Dmitry Osipenko
2020-04-04 21:40       ` Dmitry Osipenko
2020-04-04 21:40       ` Dmitry Osipenko
     [not found]       ` <27bdd09b-0b8d-a6ef-2ffd-53421277fcca-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2020-04-05  6:00         ` Markus Elfring
2020-04-05  6:00           ` Markus Elfring
2020-04-05  6:00           ` Markus Elfring
     [not found]           ` <72e2319e-9b9b-9045-c007-320b2be1e886-S0/GAf8tV78@public.gmane.org>
2020-04-05 13:50             ` Dmitry Osipenko
2020-04-05 13:50               ` Dmitry Osipenko
2020-04-05 13:50               ` Dmitry Osipenko
2020-04-05 23:51   ` [PATCH] " Chanwoo Choi
2020-04-06  0:00     ` Chanwoo Choi
2020-04-06  0:00     ` Chanwoo Choi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ba67e238-43a7-6c53-363e-7a2c12f09949@web.de \
    --to=markus.elfring@web.de \
    --cc=cw00.choi@samsung.com \
    --cc=digetx@gmail.com \
    --cc=jonathanh@nvidia.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=kyungmin.park@samsung.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=myungjoo.ham@samsung.com \
    --cc=tangbin@cmss.chinamobile.com \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.