From: Jing-Ting Wu <jing-ting.wu@mediatek.com> To: Peter Zijlstra <peterz@infradead.org> Cc: Daniel Bristot de Oliveira <bristot@redhat.com>, Valentin Schneider <vschneid@redhat.com>, <tglx@linutronix.de>, <wsd_upstream@mediatek.com>, <linux-kernel@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>, <linux-mediatek@lists.infradead.org>, <Jonathan.JMChen@mediatek.com>, "chris.redpath@arm.com" <chris.redpath@arm.com>, Dietmar Eggemann <dietmar.eggemann@arm.com>, Vincent Donnefort <vdonnefort@gmail.com>, "Ingo Molnar" <mingo@redhat.com>, Juri Lelli <juri.lelli@redhat.com>, "Vincent Guittot" <vincent.guittot@linaro.org>, Steven Rostedt <rostedt@goodmis.org>, Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>, "Christian Brauner" <brauner@kernel.org> Subject: Re: [SPAM]Re: [Bug] Race condition between CPU hotplug off flow and __sched_setscheduler() Date: Thu, 26 May 2022 13:57:55 +0800 [thread overview] Message-ID: <ba7ddde1829ee9eedcd6673f923d731d60719dc5.camel@mediatek.com> (raw) In-Reply-To: <52eea711b8ce3151ff73bfb0289cc9da0e8c4a10.camel@mediatek.com> Hi Peter > > How easy can you reproduce; does the below hack make it better? > > > The issue can be reproduced in about 48 hours when hotplug up/down > frequently. > > Thanks for your suggestion. > I think the hack patch could stay the rq->balance_callback when rq- > > callback = &balance_push_callback. > > We can add hack patch to the stability test. Use the patch of previous mail, we pass the stability test at previous 48 hours and still testing. I think the patch could make the issue better. Do you suggest to upstream this patch to mainline? Thank you. > > > > diff --git a/kernel/sched/core.c b/kernel/sched/core.c > > index 95bac3b094b3..f18ee22b29bc 100644 > > --- a/kernel/sched/core.c > > +++ b/kernel/sched/core.c > > @@ -4763,20 +4763,30 @@ struct callback_head balance_push_callback > > = > > { > > .func = (void (*)(struct callback_head *))balance_push, > > }; > > > > -static inline struct callback_head > > *splice_balance_callbacks(struct > > rq *rq) > > +static inline struct callback_head * > > +__splice_balance_callbacks(struct rq *rq, bool foo) > > { > > struct callback_head *head = rq->balance_callback; > > > > lockdep_assert_rq_held(rq); > > - if (head) > > - rq->balance_callback = NULL; > > + if (head) { > > + if (foo && head == &balance_push_callback) > > + head = NULL; > > + else > > + rq->balance_callback = NULL; > > + } > > > > return head; > > } > > > > +static inline struct callback_head > > *splice_balance_callbacks(struct > > rq *rq) > > +{ > > + return __splice_balance_callbacks(rq, true); > > +} > > + > > static void __balance_callbacks(struct rq *rq) > > { > > - do_balance_callbacks(rq, splice_balance_callbacks(rq)); > > + do_balance_callbacks(rq, __splice_balance_callbacks(rq, > > false)); > > } > > > > static inline void balance_callbacks(struct rq *rq, struct > > callback_head *head) > > > Best Regards, Jing-Ting Wu _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: Jing-Ting Wu <jing-ting.wu@mediatek.com> To: Peter Zijlstra <peterz@infradead.org> Cc: Daniel Bristot de Oliveira <bristot@redhat.com>, Valentin Schneider <vschneid@redhat.com>, <tglx@linutronix.de>, <wsd_upstream@mediatek.com>, <linux-kernel@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>, <linux-mediatek@lists.infradead.org>, <Jonathan.JMChen@mediatek.com>, "chris.redpath@arm.com" <chris.redpath@arm.com>, Dietmar Eggemann <dietmar.eggemann@arm.com>, Vincent Donnefort <vdonnefort@gmail.com>, "Ingo Molnar" <mingo@redhat.com>, Juri Lelli <juri.lelli@redhat.com>, "Vincent Guittot" <vincent.guittot@linaro.org>, Steven Rostedt <rostedt@goodmis.org>, Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>, "Christian Brauner" <brauner@kernel.org> Subject: Re: [SPAM]Re: [Bug] Race condition between CPU hotplug off flow and __sched_setscheduler() Date: Thu, 26 May 2022 13:57:55 +0800 [thread overview] Message-ID: <ba7ddde1829ee9eedcd6673f923d731d60719dc5.camel@mediatek.com> (raw) In-Reply-To: <52eea711b8ce3151ff73bfb0289cc9da0e8c4a10.camel@mediatek.com> Hi Peter > > How easy can you reproduce; does the below hack make it better? > > > The issue can be reproduced in about 48 hours when hotplug up/down > frequently. > > Thanks for your suggestion. > I think the hack patch could stay the rq->balance_callback when rq- > > callback = &balance_push_callback. > > We can add hack patch to the stability test. Use the patch of previous mail, we pass the stability test at previous 48 hours and still testing. I think the patch could make the issue better. Do you suggest to upstream this patch to mainline? Thank you. > > > > diff --git a/kernel/sched/core.c b/kernel/sched/core.c > > index 95bac3b094b3..f18ee22b29bc 100644 > > --- a/kernel/sched/core.c > > +++ b/kernel/sched/core.c > > @@ -4763,20 +4763,30 @@ struct callback_head balance_push_callback > > = > > { > > .func = (void (*)(struct callback_head *))balance_push, > > }; > > > > -static inline struct callback_head > > *splice_balance_callbacks(struct > > rq *rq) > > +static inline struct callback_head * > > +__splice_balance_callbacks(struct rq *rq, bool foo) > > { > > struct callback_head *head = rq->balance_callback; > > > > lockdep_assert_rq_held(rq); > > - if (head) > > - rq->balance_callback = NULL; > > + if (head) { > > + if (foo && head == &balance_push_callback) > > + head = NULL; > > + else > > + rq->balance_callback = NULL; > > + } > > > > return head; > > } > > > > +static inline struct callback_head > > *splice_balance_callbacks(struct > > rq *rq) > > +{ > > + return __splice_balance_callbacks(rq, true); > > +} > > + > > static void __balance_callbacks(struct rq *rq) > > { > > - do_balance_callbacks(rq, splice_balance_callbacks(rq)); > > + do_balance_callbacks(rq, __splice_balance_callbacks(rq, > > false)); > > } > > > > static inline void balance_callbacks(struct rq *rq, struct > > callback_head *head) > > > Best Regards, Jing-Ting Wu _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-05-26 5:58 UTC|newest] Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-05-19 12:53 [Bug] Race condition between CPU hotplug off flow and __sched_setscheduler() Jing-Ting Wu 2022-05-19 12:53 ` Jing-Ting Wu 2022-05-19 12:53 ` Jing-Ting Wu 2022-05-19 13:14 ` Peter Zijlstra 2022-05-19 13:14 ` Peter Zijlstra 2022-05-19 13:14 ` Peter Zijlstra 2022-05-19 13:19 ` Peter Zijlstra 2022-05-19 13:19 ` Peter Zijlstra 2022-05-19 13:19 ` Peter Zijlstra 2022-05-19 13:47 ` Peter Zijlstra 2022-05-19 13:47 ` Peter Zijlstra 2022-05-19 13:47 ` Peter Zijlstra 2022-05-23 7:12 ` [SPAM]Re: " Jing-Ting Wu 2022-05-23 7:12 ` Jing-Ting Wu 2022-05-26 5:57 ` Jing-Ting Wu [this message] 2022-05-26 5:57 ` Jing-Ting Wu 2022-06-02 16:15 ` Jing-Ting Wu 2022-06-02 16:15 ` Jing-Ting Wu 2022-06-07 20:40 ` Peter Zijlstra 2022-06-07 20:40 ` Peter Zijlstra 2022-06-07 21:39 ` [PATCH] sched: Fix balance_push() vs __sched_setscheduler() Peter Zijlstra 2022-06-07 21:39 ` Peter Zijlstra 2022-06-07 21:39 ` Peter Zijlstra 2022-06-08 14:16 ` Jing-Ting Wu 2022-06-08 14:16 ` Jing-Ting Wu 2022-06-08 14:16 ` Jing-Ting Wu 2022-06-08 14:48 ` Peter Zijlstra 2022-06-08 14:48 ` Peter Zijlstra 2022-06-08 14:48 ` Peter Zijlstra 2022-06-13 8:29 ` [tip: sched/urgent] " tip-bot2 for Peter Zijlstra
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=ba7ddde1829ee9eedcd6673f923d731d60719dc5.camel@mediatek.com \ --to=jing-ting.wu@mediatek.com \ --cc=Jonathan.JMChen@mediatek.com \ --cc=brauner@kernel.org \ --cc=bristot@redhat.com \ --cc=bsegall@google.com \ --cc=chris.redpath@arm.com \ --cc=dietmar.eggemann@arm.com \ --cc=juri.lelli@redhat.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mediatek@lists.infradead.org \ --cc=mgorman@suse.de \ --cc=mingo@redhat.com \ --cc=peterz@infradead.org \ --cc=rostedt@goodmis.org \ --cc=tglx@linutronix.de \ --cc=vdonnefort@gmail.com \ --cc=vincent.guittot@linaro.org \ --cc=vschneid@redhat.com \ --cc=wsd_upstream@mediatek.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.