From: Vincenzo Frascino <vincenzo.frascino@arm.com> To: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com Cc: Andrew Morton <akpm@linux-foundation.org>, Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will@kernel.org>, Dmitry Vyukov <dvyukov@google.com>, Andrey Ryabinin <aryabinin@virtuozzo.com>, Alexander Potapenko <glider@google.com>, Marco Elver <elver@google.com>, Evgenii Stepanov <eugenis@google.com>, Branislav Rankov <Branislav.Rankov@arm.com>, Andrey Konovalov <andreyknvl@google.com> Subject: Re: [PATCH v11 5/5] kasan: don't run tests in async mode Date: Sat, 30 Jan 2021 17:01:48 +0000 [thread overview] Message-ID: <ba95b920-9007-bf10-a09d-59f5d715a8c2@arm.com> (raw) In-Reply-To: <20210130165225.54047-6-vincenzo.frascino@arm.com> On 1/30/21 4:52 PM, Vincenzo Frascino wrote: > From: Andrey Konovalov <andreyknvl@google.com> > > Asynchronous KASAN mode doesn't guarantee that a tag fault will be > detected immediately and causes tests to fail. Forbid running them > in asynchronous mode. > > Signed-off-by: Andrey Konovalov <andreyknvl@google.com> Reviewed-by: Vincenzo Frascino <vincenzo.frascino@arm.com> With: [ 18.283644] 1..1 [ 18.284167] # Subtest: kasan [ 18.284444] 1..45 [ 18.295536] # kmalloc_oob_right: can't run KASAN tests in async mode [ 18.296873] # kmalloc_oob_right: failed to initialize: -1 [ 18.303714] not ok 1 - kmalloc_oob_right [ 18.316439] # kmalloc_oob_left: can't run KASAN tests in async mode [ 18.319466] # kmalloc_oob_left: failed to initialize: -1 [ 18.325001] not ok 2 - kmalloc_oob_left Tested-by: Vincenzo Frascino <vincenzo.frascino@arm.com> > --- > lib/test_kasan.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/lib/test_kasan.c b/lib/test_kasan.c > index 7285dcf9fcc1..f82d9630cae1 100644 > --- a/lib/test_kasan.c > +++ b/lib/test_kasan.c > @@ -51,6 +51,10 @@ static int kasan_test_init(struct kunit *test) > kunit_err(test, "can't run KASAN tests with KASAN disabled"); > return -1; > } > + if (kasan_flag_async) { > + kunit_err(test, "can't run KASAN tests in async mode"); > + return -1; > + } > > multishot = kasan_save_enable_multi_shot(); > hw_set_tagging_report_once(false); > -- Regards, Vincenzo
WARNING: multiple messages have this Message-ID (diff)
From: Vincenzo Frascino <vincenzo.frascino@arm.com> To: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com Cc: Marco Elver <elver@google.com>, Catalin Marinas <catalin.marinas@arm.com>, Branislav Rankov <Branislav.Rankov@arm.com>, Alexander Potapenko <glider@google.com>, Evgenii Stepanov <eugenis@google.com>, Andrey Konovalov <andreyknvl@google.com>, Andrey Ryabinin <aryabinin@virtuozzo.com>, Andrew Morton <akpm@linux-foundation.org>, Will Deacon <will@kernel.org>, Dmitry Vyukov <dvyukov@google.com> Subject: Re: [PATCH v11 5/5] kasan: don't run tests in async mode Date: Sat, 30 Jan 2021 17:01:48 +0000 [thread overview] Message-ID: <ba95b920-9007-bf10-a09d-59f5d715a8c2@arm.com> (raw) In-Reply-To: <20210130165225.54047-6-vincenzo.frascino@arm.com> On 1/30/21 4:52 PM, Vincenzo Frascino wrote: > From: Andrey Konovalov <andreyknvl@google.com> > > Asynchronous KASAN mode doesn't guarantee that a tag fault will be > detected immediately and causes tests to fail. Forbid running them > in asynchronous mode. > > Signed-off-by: Andrey Konovalov <andreyknvl@google.com> Reviewed-by: Vincenzo Frascino <vincenzo.frascino@arm.com> With: [ 18.283644] 1..1 [ 18.284167] # Subtest: kasan [ 18.284444] 1..45 [ 18.295536] # kmalloc_oob_right: can't run KASAN tests in async mode [ 18.296873] # kmalloc_oob_right: failed to initialize: -1 [ 18.303714] not ok 1 - kmalloc_oob_right [ 18.316439] # kmalloc_oob_left: can't run KASAN tests in async mode [ 18.319466] # kmalloc_oob_left: failed to initialize: -1 [ 18.325001] not ok 2 - kmalloc_oob_left Tested-by: Vincenzo Frascino <vincenzo.frascino@arm.com> > --- > lib/test_kasan.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/lib/test_kasan.c b/lib/test_kasan.c > index 7285dcf9fcc1..f82d9630cae1 100644 > --- a/lib/test_kasan.c > +++ b/lib/test_kasan.c > @@ -51,6 +51,10 @@ static int kasan_test_init(struct kunit *test) > kunit_err(test, "can't run KASAN tests with KASAN disabled"); > return -1; > } > + if (kasan_flag_async) { > + kunit_err(test, "can't run KASAN tests in async mode"); > + return -1; > + } > > multishot = kasan_save_enable_multi_shot(); > hw_set_tagging_report_once(false); > -- Regards, Vincenzo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-01-30 16:59 UTC|newest] Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-01-30 16:52 [PATCH v11 0/5] arm64: ARMv8.5-A: MTE: Add async mode support Vincenzo Frascino 2021-01-30 16:52 ` Vincenzo Frascino 2021-01-30 16:52 ` [PATCH v11 1/5] arm64: mte: Add asynchronous " Vincenzo Frascino 2021-01-30 16:52 ` Vincenzo Frascino 2021-01-30 16:52 ` [PATCH v11 2/5] kasan: Add KASAN mode kernel parameter Vincenzo Frascino 2021-01-30 16:52 ` Vincenzo Frascino 2021-02-01 20:04 ` Andrey Konovalov 2021-02-01 20:04 ` Andrey Konovalov 2021-02-05 15:49 ` Andrey Konovalov 2021-02-05 15:49 ` Andrey Konovalov 2021-02-05 16:00 ` Vincenzo Frascino 2021-02-05 16:00 ` Vincenzo Frascino 2021-02-05 16:48 ` Will Deacon 2021-02-05 16:48 ` Will Deacon 2021-02-05 16:55 ` Vincenzo Frascino 2021-02-05 16:55 ` Vincenzo Frascino 2021-01-30 16:52 ` [PATCH v11 3/5] kasan: Add report for async mode Vincenzo Frascino 2021-01-30 16:52 ` Vincenzo Frascino 2021-01-30 16:52 ` [PATCH v11 4/5] arm64: mte: Enable async tag check fault Vincenzo Frascino 2021-01-30 16:52 ` Vincenzo Frascino 2021-02-05 15:39 ` Catalin Marinas 2021-02-05 15:39 ` Catalin Marinas 2021-02-05 15:45 ` Vincenzo Frascino 2021-02-05 15:45 ` Vincenzo Frascino 2021-01-30 16:52 ` [PATCH v11 5/5] kasan: don't run tests in async mode Vincenzo Frascino 2021-01-30 16:52 ` Vincenzo Frascino 2021-01-30 17:01 ` Vincenzo Frascino [this message] 2021-01-30 17:01 ` Vincenzo Frascino 2021-02-05 16:58 ` [PATCH v11 0/5] arm64: ARMv8.5-A: MTE: Add async mode support Vincenzo Frascino 2021-02-05 16:58 ` Vincenzo Frascino
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=ba95b920-9007-bf10-a09d-59f5d715a8c2@arm.com \ --to=vincenzo.frascino@arm.com \ --cc=Branislav.Rankov@arm.com \ --cc=akpm@linux-foundation.org \ --cc=andreyknvl@google.com \ --cc=aryabinin@virtuozzo.com \ --cc=catalin.marinas@arm.com \ --cc=dvyukov@google.com \ --cc=elver@google.com \ --cc=eugenis@google.com \ --cc=glider@google.com \ --cc=kasan-dev@googlegroups.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=will@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.