* [PATCH] nvme: Have NVME_FABRICS select NVME_CORE instead of transport drivers
@ 2021-05-25 15:59 Sagi Grimberg
2021-05-25 17:33 ` James Smart
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Sagi Grimberg @ 2021-05-25 15:59 UTC (permalink / raw)
To: linux-nvme, Christoph Hellwig, Keith Busch
Transport drivers need both core and fabrics modules, instead of
selecting both, have the selection transitive such that NVME_FABRICS
selects NVME_CORE and transport drivers select NVME_FABRICS.
Suggested-by: Keith Busch <kbusch@kernel.org>
Signed-off-by: Sagi Grimberg <sagi@grimberg.me>
---
drivers/nvme/host/Kconfig | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/nvme/host/Kconfig b/drivers/nvme/host/Kconfig
index c0826b3c617c..b6b731db0353 100644
--- a/drivers/nvme/host/Kconfig
+++ b/drivers/nvme/host/Kconfig
@@ -33,12 +33,12 @@ config NVME_HWMON
in the system.
config NVME_FABRICS
+ select NVME_CORE
tristate
config NVME_RDMA
tristate "NVM Express over Fabrics RDMA host driver"
depends on INFINIBAND && INFINIBAND_ADDR_TRANS && BLOCK
- select NVME_CORE
select NVME_FABRICS
select SG_POOL
help
@@ -55,7 +55,6 @@ config NVME_FC
tristate "NVM Express over Fabrics FC host driver"
depends on BLOCK
depends on HAS_DMA
- select NVME_CORE
select NVME_FABRICS
select SG_POOL
help
@@ -71,7 +70,6 @@ config NVME_FC
config NVME_TCP
tristate "NVM Express over Fabrics TCP host driver"
depends on INET
- select NVME_CORE
select NVME_FABRICS
select CRYPTO
select CRYPTO_CRC32C
--
2.27.0
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] nvme: Have NVME_FABRICS select NVME_CORE instead of transport drivers
2021-05-25 15:59 [PATCH] nvme: Have NVME_FABRICS select NVME_CORE instead of transport drivers Sagi Grimberg
@ 2021-05-25 17:33 ` James Smart
2021-05-25 20:17 ` Chaitanya Kulkarni
2021-08-16 16:47 ` Christoph Hellwig
2 siblings, 0 replies; 4+ messages in thread
From: James Smart @ 2021-05-25 17:33 UTC (permalink / raw)
To: Sagi Grimberg, linux-nvme, Christoph Hellwig, Keith Busch
On 5/25/2021 8:59 AM, Sagi Grimberg wrote:
> Transport drivers need both core and fabrics modules, instead of
> selecting both, have the selection transitive such that NVME_FABRICS
> selects NVME_CORE and transport drivers select NVME_FABRICS.
>
> Suggested-by: Keith Busch <kbusch@kernel.org>
> Signed-off-by: Sagi Grimberg <sagi@grimberg.me>
> ---
> drivers/nvme/host/Kconfig | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/nvme/host/Kconfig b/drivers/nvme/host/Kconfig
Agree...
Reviewed-by: James Smart <jsmart2021@gmail.com>
-- james
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] nvme: Have NVME_FABRICS select NVME_CORE instead of transport drivers
2021-05-25 15:59 [PATCH] nvme: Have NVME_FABRICS select NVME_CORE instead of transport drivers Sagi Grimberg
2021-05-25 17:33 ` James Smart
@ 2021-05-25 20:17 ` Chaitanya Kulkarni
2021-08-16 16:47 ` Christoph Hellwig
2 siblings, 0 replies; 4+ messages in thread
From: Chaitanya Kulkarni @ 2021-05-25 20:17 UTC (permalink / raw)
To: Sagi Grimberg, linux-nvme, Christoph Hellwig, Keith Busch
On 5/25/21 09:46, Sagi Grimberg wrote:
> Transport drivers need both core and fabrics modules, instead of
> selecting both, have the selection transitive such that NVME_FABRICS
> selects NVME_CORE and transport drivers select NVME_FABRICS.
>
> Suggested-by: Keith Busch <kbusch@kernel.org>
> Signed-off-by: Sagi Grimberg <sagi@grimberg.me>
Looks good.
Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] nvme: Have NVME_FABRICS select NVME_CORE instead of transport drivers
2021-05-25 15:59 [PATCH] nvme: Have NVME_FABRICS select NVME_CORE instead of transport drivers Sagi Grimberg
2021-05-25 17:33 ` James Smart
2021-05-25 20:17 ` Chaitanya Kulkarni
@ 2021-08-16 16:47 ` Christoph Hellwig
2 siblings, 0 replies; 4+ messages in thread
From: Christoph Hellwig @ 2021-08-16 16:47 UTC (permalink / raw)
To: Sagi Grimberg; +Cc: linux-nvme, Christoph Hellwig, Keith Busch
Thanks, applied to nvme-5.15.
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-08-16 16:47 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-25 15:59 [PATCH] nvme: Have NVME_FABRICS select NVME_CORE instead of transport drivers Sagi Grimberg
2021-05-25 17:33 ` James Smart
2021-05-25 20:17 ` Chaitanya Kulkarni
2021-08-16 16:47 ` Christoph Hellwig
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.