All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] libinput: remove obsolete touchpad patch
@ 2017-08-24  5:37 Jose Alarcon
  2017-08-24 17:45 ` Andre McCurdy
  0 siblings, 1 reply; 13+ messages in thread
From: Jose Alarcon @ 2017-08-24  5:37 UTC (permalink / raw)
  To: openembedded-core

This patch was a temporal workaround needed with 4.1 kernels.
Remove it.

Signed-off-by: Jose Alarcon <jose.alarcon@ge.com>
---
 ...ics-need-to-fake-new-touches-on-TRIPLETAP.patch | 72 ----------------------
 meta/recipes-graphics/wayland/libinput_1.8.1.bb    |  1 -
 2 files changed, 73 deletions(-)
 delete mode 100644 meta/recipes-graphics/wayland/libinput/touchpad-serial-synaptics-need-to-fake-new-touches-on-TRIPLETAP.patch

diff --git a/meta/recipes-graphics/wayland/libinput/touchpad-serial-synaptics-need-to-fake-new-touches-on-TRIPLETAP.patch b/meta/recipes-graphics/wayland/libinput/touchpad-serial-synaptics-need-to-fake-new-touches-on-TRIPLETAP.patch
deleted file mode 100644
index b52b496..0000000
--- a/meta/recipes-graphics/wayland/libinput/touchpad-serial-synaptics-need-to-fake-new-touches-on-TRIPLETAP.patch
+++ /dev/null
@@ -1,72 +0,0 @@
-This is a workaround upstream suggests for use with kernel 4.1.
-
-Upstream-Status: Inappropriate [temporary work-around]
-Signed-off-by: Jussi Kukkonen <jussi.kukkonen@intel.com>
-
-
-
-From: Peter Hutterer <peter.hutterer@who-t.net>
-Date: Mon Aug 3 18:23:12 PDT 2015
-Subject: [PATCH v3 libinput] touchpad: serial synaptics need to fake new touches on TRIPLETAP
-
-On the 4.1 kernels synaptics pretends to have 3 slots (the serial fw only does
-2). This was added to avoid cursor jumps but has since been reverted for 4.2
-(kernel commit dbf3c37086, 4.1.3 is still buggy). In some cases a TRIPLETAP
-may be triggered without slot 2 ever activating.
-
-While there are still those kernels out there, work around this bug by opening
-a new touch point where none exists if the fake finger count exceeds the slot
-count.
-
-Reported-by: Jan Alexander Steffens <jan.steffens at gmail.com>
-Signed-off-by: Peter Hutterer <peter.hutterer at who-t.net>
-Tested-by: Jan Alexander Steffens <jan.steffens at gmail.com>
-Reviewed-by: Hans de Goede <hdegoede at redhat.com>
----
-Changes to v2:
-- split out the handling instead of having a tmp state variable, see Hans'
-  comments from v2
-
-Mainly sending this to the list again so I have a link to point people to.
-If you're on 4.1.x add this patch to your distribution package.
-
- src/evdev-mt-touchpad.c | 22 ++++++++++++++++------
- 1 file changed, 16 insertions(+), 6 deletions(-)
-
-diff --git a/src/evdev-mt-touchpad.c b/src/evdev-mt-touchpad.c
-index a683d9a..5ef03d5 100644
---- a/src/evdev-mt-touchpad.c
-+++ b/src/evdev-mt-touchpad.c
-@@ -369,13 +369,23 @@ tp_restore_synaptics_touches(struct tp_dispatch *tp,
- 	for (i = 0; i < tp->num_slots; i++) {
- 		struct tp_touch *t = tp_get_touch(tp, i);
- 
--		if (t->state != TOUCH_END)
-+		switch(t->state) {
-+		case TOUCH_HOVERING:
-+		case TOUCH_BEGIN:
-+		case TOUCH_UPDATE:
- 			continue;
--
--		/* new touch, move it through begin to update immediately */
--		tp_new_touch(tp, t, time);
--		tp_begin_touch(tp, t, time);
--		t->state = TOUCH_UPDATE;
-+		case TOUCH_NONE:
-+			/* new touch, move it through to begin immediately */
-+			tp_new_touch(tp, t, time);
-+			tp_begin_touch(tp, t, time);
-+			break;
-+		case TOUCH_END:
-+			/* touch just ended ,we need need to restore it to update */
-+			tp_new_touch(tp, t, time);
-+			tp_begin_touch(tp, t, time);
-+			t->state = TOUCH_UPDATE;
-+			break;
-+		}
- 	}
- }
- 
--- 
-2.4.3
-
diff --git a/meta/recipes-graphics/wayland/libinput_1.8.1.bb b/meta/recipes-graphics/wayland/libinput_1.8.1.bb
index f75298b..a21babe 100644
--- a/meta/recipes-graphics/wayland/libinput_1.8.1.bb
+++ b/meta/recipes-graphics/wayland/libinput_1.8.1.bb
@@ -8,7 +8,6 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=2184aef38ff137ed33ce9a63b9d1eb8f"
 DEPENDS = "libevdev udev mtdev"
 
 SRC_URI = "http://www.freedesktop.org/software/${BPN}/${BP}.tar.xz \
-           file://touchpad-serial-synaptics-need-to-fake-new-touches-on-TRIPLETAP.patch \
            file://0001-tools-Fix-race-in-autotools-install.patch \
 "
 
-- 
2.10.1



^ permalink raw reply related	[flat|nested] 13+ messages in thread

* Re: [PATCH] libinput: remove obsolete touchpad patch
  2017-08-24  5:37 [PATCH] libinput: remove obsolete touchpad patch Jose Alarcon
@ 2017-08-24 17:45 ` Andre McCurdy
  2017-08-25  7:09   ` EXT: " Jose Alarcon
  0 siblings, 1 reply; 13+ messages in thread
From: Andre McCurdy @ 2017-08-24 17:45 UTC (permalink / raw)
  To: Jose Alarcon; +Cc: OE Core mailing list

On Wed, Aug 23, 2017 at 10:37 PM, Jose Alarcon <jose.alarcon@ge.com> wrote:
> This patch was a temporal workaround needed with 4.1 kernels.
> Remove it.

OLDEST_KERNEL is still set to 3.2.0

How can you be sure nobody is using 4.1 ?


^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: EXT: Re: [PATCH] libinput: remove obsolete touchpad patch
  2017-08-24 17:45 ` Andre McCurdy
@ 2017-08-25  7:09   ` Jose Alarcon
  2017-08-25 18:48     ` Andre McCurdy
  0 siblings, 1 reply; 13+ messages in thread
From: Jose Alarcon @ 2017-08-25  7:09 UTC (permalink / raw)
  To: Andre McCurdy; +Cc: OE Core mailing list



On 24.08.2017 20:45, Andre McCurdy wrote:
> On Wed, Aug 23, 2017 at 10:37 PM, Jose Alarcon <jose.alarcon@ge.com> wrote:
>> This patch was a temporal workaround needed with 4.1 kernels.
>> Remove it.
> OLDEST_KERNEL is still set to 3.2.0
>
> How can you be sure nobody is using 4.1 ?

That's a good point!

I didn't know about this variable. I believe we should not integrate
this change.
I will resend it once OLDEST_KERNEL is set to 4.2 or bigger.

Thanks,

--
Jose


^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: EXT: Re: [PATCH] libinput: remove obsolete touchpad patch
  2017-08-25  7:09   ` EXT: " Jose Alarcon
@ 2017-08-25 18:48     ` Andre McCurdy
  2017-08-25 18:55       ` Mark Hatle
  0 siblings, 1 reply; 13+ messages in thread
From: Andre McCurdy @ 2017-08-25 18:48 UTC (permalink / raw)
  To: Jose Alarcon; +Cc: OE Core mailing list

On Fri, Aug 25, 2017 at 12:09 AM, Jose Alarcon <jose.alarcon@ge.com> wrote:
> On 24.08.2017 20:45, Andre McCurdy wrote:
>> On Wed, Aug 23, 2017 at 10:37 PM, Jose Alarcon <jose.alarcon@ge.com> wrote:
>>> This patch was a temporal workaround needed with 4.1 kernels.
>>> Remove it.
>> OLDEST_KERNEL is still set to 3.2.0
>>
>> How can you be sure nobody is using 4.1 ?
>
> That's a good point!
>
> I didn't know about this variable. I believe we should not integrate
> this change.
> I will resend it once OLDEST_KERNEL is set to 4.2 or bigger.

The original patch has been merged to master so a second patch will be
needed to revert it.


^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: EXT: Re: [PATCH] libinput: remove obsolete touchpad patch
  2017-08-25 18:48     ` Andre McCurdy
@ 2017-08-25 18:55       ` Mark Hatle
  2017-08-25 18:59         ` Martin Jansa
  0 siblings, 1 reply; 13+ messages in thread
From: Mark Hatle @ 2017-08-25 18:55 UTC (permalink / raw)
  To: Andre McCurdy, Jose Alarcon; +Cc: OE Core mailing list

On 8/25/17 1:48 PM, Andre McCurdy wrote:
> On Fri, Aug 25, 2017 at 12:09 AM, Jose Alarcon <jose.alarcon@ge.com> wrote:
>> On 24.08.2017 20:45, Andre McCurdy wrote:
>>> On Wed, Aug 23, 2017 at 10:37 PM, Jose Alarcon <jose.alarcon@ge.com> wrote:
>>>> This patch was a temporal workaround needed with 4.1 kernels.
>>>> Remove it.
>>> OLDEST_KERNEL is still set to 3.2.0
>>>
>>> How can you be sure nobody is using 4.1 ?
>>
>> That's a good point!
>>
>> I didn't know about this variable. I believe we should not integrate
>> this change.
>> I will resend it once OLDEST_KERNEL is set to 4.2 or bigger.
> 
> The original patch has been merged to master so a second patch will be
> needed to revert it.
> 

It may make sense to selectively apply the patch based on what OLDEST_KERNEL is
set to.

This way if a user or distribution sets a newer 'OLDEST_KERNEL', that item can
be removed automatically.

--Mark


^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: EXT: Re: [PATCH] libinput: remove obsolete touchpad patch
  2017-08-25 18:55       ` Mark Hatle
@ 2017-08-25 18:59         ` Martin Jansa
  2017-08-25 22:42           ` Khem Raj
  2017-08-26 10:21           ` Jose Alarcon
  0 siblings, 2 replies; 13+ messages in thread
From: Martin Jansa @ 2017-08-25 18:59 UTC (permalink / raw)
  To: Mark Hatle; +Cc: OE Core mailing list

[-- Attachment #1: Type: text/plain, Size: 1463 bytes --]

Does the patch cause any harm when used on newer kernel?

If so shouldn't the patch be fixed to work correctly even with newer kernel?

Or what's the main reason to remove it?

On Fri, Aug 25, 2017 at 8:55 PM, Mark Hatle <mark.hatle@windriver.com>
wrote:

> On 8/25/17 1:48 PM, Andre McCurdy wrote:
> > On Fri, Aug 25, 2017 at 12:09 AM, Jose Alarcon <jose.alarcon@ge.com>
> wrote:
> >> On 24.08.2017 20:45, Andre McCurdy wrote:
> >>> On Wed, Aug 23, 2017 at 10:37 PM, Jose Alarcon <jose.alarcon@ge.com>
> wrote:
> >>>> This patch was a temporal workaround needed with 4.1 kernels.
> >>>> Remove it.
> >>> OLDEST_KERNEL is still set to 3.2.0
> >>>
> >>> How can you be sure nobody is using 4.1 ?
> >>
> >> That's a good point!
> >>
> >> I didn't know about this variable. I believe we should not integrate
> >> this change.
> >> I will resend it once OLDEST_KERNEL is set to 4.2 or bigger.
> >
> > The original patch has been merged to master so a second patch will be
> > needed to revert it.
> >
>
> It may make sense to selectively apply the patch based on what
> OLDEST_KERNEL is
> set to.
>
> This way if a user or distribution sets a newer 'OLDEST_KERNEL', that item
> can
> be removed automatically.
>
> --Mark
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>

[-- Attachment #2: Type: text/html, Size: 2464 bytes --]

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: EXT: Re: [PATCH] libinput: remove obsolete touchpad patch
  2017-08-25 18:59         ` Martin Jansa
@ 2017-08-25 22:42           ` Khem Raj
  2017-08-25 23:37             ` Andre McCurdy
  2017-08-26 10:21           ` Jose Alarcon
  1 sibling, 1 reply; 13+ messages in thread
From: Khem Raj @ 2017-08-25 22:42 UTC (permalink / raw)
  To: Martin Jansa; +Cc: OE Core mailing list

On Fri, Aug 25, 2017 at 11:59 AM, Martin Jansa <martin.jansa@gmail.com> wrote:
> Does the patch cause any harm when used on newer kernel?
>
> If so shouldn't the patch be fixed to work correctly even with newer kernel?
>
> Or what's the main reason to remove it?
>
> On Fri, Aug 25, 2017 at 8:55 PM, Mark Hatle <mark.hatle@windriver.com>
> wrote:
>>
>> On 8/25/17 1:48 PM, Andre McCurdy wrote:
>> > On Fri, Aug 25, 2017 at 12:09 AM, Jose Alarcon <jose.alarcon@ge.com>
>> > wrote:
>> >> On 24.08.2017 20:45, Andre McCurdy wrote:
>> >>> On Wed, Aug 23, 2017 at 10:37 PM, Jose Alarcon <jose.alarcon@ge.com>
>> >>> wrote:
>> >>>> This patch was a temporal workaround needed with 4.1 kernels.
>> >>>> Remove it.
>> >>> OLDEST_KERNEL is still set to 3.2.0
>> >>>
>> >>> How can you be sure nobody is using 4.1 ?
>> >>
>> >> That's a good point!
>> >>
>> >> I didn't know about this variable. I believe we should not integrate
>> >> this change.
>> >> I will resend it once OLDEST_KERNEL is set to 4.2 or bigger.
>> >
>> > The original patch has been merged to master so a second patch will be
>> > needed to revert it.
>> >
>>
>> It may make sense to selectively apply the patch based on what
>> OLDEST_KERNEL is
>> set to.
>>
>> This way if a user or distribution sets a newer 'OLDEST_KERNEL', that item
>> can
>> be removed automatically.

OE-core minimal kernel has been bumped to 4.4
so at this point I think its fine to remove it since there
is no reliable way for OE-Core to test out validity of
this patch


^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: EXT: Re: [PATCH] libinput: remove obsolete touchpad patch
  2017-08-25 22:42           ` Khem Raj
@ 2017-08-25 23:37             ` Andre McCurdy
  2017-08-26  0:16               ` Khem Raj
  0 siblings, 1 reply; 13+ messages in thread
From: Andre McCurdy @ 2017-08-25 23:37 UTC (permalink / raw)
  To: Khem Raj; +Cc: OE Core mailing list

On Fri, Aug 25, 2017 at 3:42 PM, Khem Raj <raj.khem@gmail.com> wrote:
> OE-core minimal kernel has been bumped to 4.4
> so at this point I think its fine to remove it since there
> is no reliable way for OE-Core to test out validity of
> this patch

If that's the official policy then let's bump OLDEST_KERNEL and make
the point clear to everyone.


^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: EXT: Re: [PATCH] libinput: remove obsolete touchpad patch
  2017-08-25 23:37             ` Andre McCurdy
@ 2017-08-26  0:16               ` Khem Raj
  2017-08-26  0:44                 ` Andre McCurdy
  0 siblings, 1 reply; 13+ messages in thread
From: Khem Raj @ 2017-08-26  0:16 UTC (permalink / raw)
  To: Andre McCurdy; +Cc: OE Core mailing list

On Fri, Aug 25, 2017 at 4:37 PM, Andre McCurdy <armccurdy@gmail.com> wrote:
> On Fri, Aug 25, 2017 at 3:42 PM, Khem Raj <raj.khem@gmail.com> wrote:
>> OE-core minimal kernel has been bumped to 4.4
>> so at this point I think its fine to remove it since there
>> is no reliable way for OE-Core to test out validity of
>> this patch
>
> If that's the official policy then let's bump OLDEST_KERNEL and make
> the point clear to everyone.

its not official policy. However we do try to minimise patches we
carry as much as we can moreover I was thinking from testability point
of view, we don't know what harm it can cause when you dont need this
patch. More clarity on that is desirable.


^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: EXT: Re: [PATCH] libinput: remove obsolete touchpad patch
  2017-08-26  0:16               ` Khem Raj
@ 2017-08-26  0:44                 ` Andre McCurdy
  2017-08-26  0:48                   ` Khem Raj
  0 siblings, 1 reply; 13+ messages in thread
From: Andre McCurdy @ 2017-08-26  0:44 UTC (permalink / raw)
  To: Khem Raj; +Cc: OE Core mailing list

On Fri, Aug 25, 2017 at 5:16 PM, Khem Raj <raj.khem@gmail.com> wrote:
> On Fri, Aug 25, 2017 at 4:37 PM, Andre McCurdy <armccurdy@gmail.com> wrote:
>> On Fri, Aug 25, 2017 at 3:42 PM, Khem Raj <raj.khem@gmail.com> wrote:
>>> OE-core minimal kernel has been bumped to 4.4
>>> so at this point I think its fine to remove it since there
>>> is no reliable way for OE-Core to test out validity of
>>> this patch
>>
>> If that's the official policy then let's bump OLDEST_KERNEL and make
>> the point clear to everyone.
>
> its not official policy. However we do try to minimise patches we
> carry as much as we can moreover I was thinking from testability point
> of view, we don't know what harm it can cause when you dont need this
> patch.

Yes we do. The case where we don't need the patch (ie kernel 4.4) is
the case we *can* test.

If the patch is found to cause problems with newer kernels then
certainly it should be removed (or updated as Martin suggested), but I
haven't seen anyone suggest that it's causing any issues.


^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: EXT: Re: [PATCH] libinput: remove obsolete touchpad patch
  2017-08-26  0:44                 ` Andre McCurdy
@ 2017-08-26  0:48                   ` Khem Raj
  0 siblings, 0 replies; 13+ messages in thread
From: Khem Raj @ 2017-08-26  0:48 UTC (permalink / raw)
  To: Andre McCurdy; +Cc: OE Core mailing list

On 8/25/17 5:44 PM, Andre McCurdy wrote:
> On Fri, Aug 25, 2017 at 5:16 PM, Khem Raj <raj.khem@gmail.com> wrote:
>> On Fri, Aug 25, 2017 at 4:37 PM, Andre McCurdy <armccurdy@gmail.com> wrote:
>>> On Fri, Aug 25, 2017 at 3:42 PM, Khem Raj <raj.khem@gmail.com> wrote:
>>>> OE-core minimal kernel has been bumped to 4.4
>>>> so at this point I think its fine to remove it since there
>>>> is no reliable way for OE-Core to test out validity of
>>>> this patch
>>>
>>> If that's the official policy then let's bump OLDEST_KERNEL and make
>>> the point clear to everyone.
>>
>> its not official policy. However we do try to minimise patches we
>> carry as much as we can moreover I was thinking from testability point
>> of view, we don't know what harm it can cause when you dont need this
>> patch.
> 
> Yes we do. The case where we don't need the patch (ie kernel 4.4) is
> the case we *can* test.
> 
> If the patch is found to cause problems with newer kernels then
> certainly it should be removed (or updated as Martin suggested), but I
> haven't seen anyone suggest that it's causing any issues.
> 

Just being there it could have side-effects too, I dont think we have
enough testing scenario to establish the effect. so removing is best
unless someone with 4.1 kernel or older can test it out with newer
kernels and establish that its not causing any undesired effects on
kernels where its not required. Until then it should stay removed.


^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: EXT: Re: [PATCH] libinput: remove obsolete touchpad patch
  2017-08-25 18:59         ` Martin Jansa
  2017-08-25 22:42           ` Khem Raj
@ 2017-08-26 10:21           ` Jose Alarcon
  2017-08-26 13:22             ` Alarcon, Jose (GE Healthcare)
  1 sibling, 1 reply; 13+ messages in thread
From: Jose Alarcon @ 2017-08-26 10:21 UTC (permalink / raw)
  To: Martin Jansa, Mark Hatle; +Cc: OE Core mailing list



On 25.08.2017 21:59, Martin Jansa wrote:
> Does the patch cause any harm when used on newer kernel?

Based on my limited testing on our devices running kernel 4.11.0, no.

>
> If so shouldn't the patch be fixed to work correctly even with newer
> kernel?
>
> Or what's the main reason to remove it?

I am going through each and every patch that we carry on our layers. If
upstreaming status is pending, we try to upstream it. If the patch is no
longer needed, we remove it.

When I came across this particular patch, I thought it was obsolete and
that it should be removed upstream too. I was not aware of OLDEST_KERNEL.

I will send a revert now.

Thanks,

--
Jose

>
> On Fri, Aug 25, 2017 at 8:55 PM, Mark Hatle <mark.hatle@windriver.com
> <mailto:mark.hatle@windriver.com>> wrote:
>
>     On 8/25/17 1:48 PM, Andre McCurdy wrote:
>     > On Fri, Aug 25, 2017 at 12:09 AM, Jose Alarcon
>     <jose.alarcon@ge.com <mailto:jose.alarcon@ge.com>> wrote:
>     >> On 24.08.2017 20 <tel:24.08.2017%2020>:45, Andre McCurdy wrote:
>     >>> On Wed, Aug 23, 2017 at 10:37 PM, Jose Alarcon
>     <jose.alarcon@ge.com <mailto:jose.alarcon@ge.com>> wrote:
>     >>>> This patch was a temporal workaround needed with 4.1 kernels.
>     >>>> Remove it.
>     >>> OLDEST_KERNEL is still set to 3.2.0
>     >>>
>     >>> How can you be sure nobody is using 4.1 ?
>     >>
>     >> That's a good point!
>     >>
>     >> I didn't know about this variable. I believe we should not
>     integrate
>     >> this change.
>     >> I will resend it once OLDEST_KERNEL is set to 4.2 or bigger.
>     >
>     > The original patch has been merged to master so a second patch
>     will be
>     > needed to revert it.
>     >
>
>     It may make sense to selectively apply the patch based on what
>     OLDEST_KERNEL is
>     set to.
>
>     This way if a user or distribution sets a newer 'OLDEST_KERNEL',
>     that item can
>     be removed automatically.
>
>     --Mark
>     --
>     _______________________________________________
>     Openembedded-core mailing list
>     Openembedded-core@lists.openembedded.org
>     <mailto:Openembedded-core@lists.openembedded.org>
>     http://lists.openembedded.org/mailman/listinfo/openembedded-core
>     <http://lists.openembedded.org/mailman/listinfo/openembedded-core>
>
>



^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: EXT: Re: [PATCH] libinput: remove obsolete touchpad patch
  2017-08-26 10:21           ` Jose Alarcon
@ 2017-08-26 13:22             ` Alarcon, Jose (GE Healthcare)
  0 siblings, 0 replies; 13+ messages in thread
From: Alarcon, Jose (GE Healthcare) @ 2017-08-26 13:22 UTC (permalink / raw)
  To: Martin Jansa, Mark Hatle; +Cc: OE Core mailing list

Sorry, I failed to read the whole thread (inbox filters).

I sent the revert this morning.

As I said, we have been running our devices with this patch in and kernels newer than 4.1 and we have not observed any issues with the touchpad. But of course that is quite limited testing.

Thanks,

--
Jose

> El 26 ago 2017, a las 13:22, Alarcon, Jose (GE Healthcare) <jose.alarcon@ge.com> escribió:
> 
> 
> 
>> On 25.08.2017 21:59, Martin Jansa wrote:
>> Does the patch cause any harm when used on newer kernel?
> 
> Based on my limited testing on our devices running kernel 4.11.0, no.
> 
>> 
>> If so shouldn't the patch be fixed to work correctly even with newer
>> kernel?
>> 
>> Or what's the main reason to remove it?
> 
> I am going through each and every patch that we carry on our layers. If
> upstreaming status is pending, we try to upstream it. If the patch is no
> longer needed, we remove it.
> 
> When I came across this particular patch, I thought it was obsolete and
> that it should be removed upstream too. I was not aware of OLDEST_KERNEL.
> 
> I will send a revert now.
> 
> Thanks,
> 
> --
> Jose
> 
>> 
>> On Fri, Aug 25, 2017 at 8:55 PM, Mark Hatle <mark.hatle@windriver.com
>> <mailto:mark.hatle@windriver.com>> wrote:
>> 
>>>    On 8/25/17 1:48 PM, Andre McCurdy wrote:
>>> On Fri, Aug 25, 2017 at 12:09 AM, Jose Alarcon
>>    <jose.alarcon@ge.com <mailto:jose.alarcon@ge.com>> wrote:
>>>> On 24.08.2017 20 <tel:24.08.2017%2020>:45, Andre McCurdy wrote:
>>>>> On Wed, Aug 23, 2017 at 10:37 PM, Jose Alarcon
>>    <jose.alarcon@ge.com <mailto:jose.alarcon@ge.com>> wrote:
>>>>>> This patch was a temporal workaround needed with 4.1 kernels.
>>>>>> Remove it.
>>>>> OLDEST_KERNEL is still set to 3.2.0
>>>>> 
>>>>> How can you be sure nobody is using 4.1 ?
>>>> 
>>>> That's a good point!
>>>> 
>>>> I didn't know about this variable. I believe we should not
>>    integrate
>>>> this change.
>>>> I will resend it once OLDEST_KERNEL is set to 4.2 or bigger.
>>> 
>>> The original patch has been merged to master so a second patch
>>    will be
>>> needed to revert it.
>>> 
>> 
>>    It may make sense to selectively apply the patch based on what
>>    OLDEST_KERNEL is
>>    set to.
>> 
>>    This way if a user or distribution sets a newer 'OLDEST_KERNEL',
>>    that item can
>>    be removed automatically.
>> 
>>    --Mark
>>    --
>>    _______________________________________________
>>    Openembedded-core mailing list
>>    Openembedded-core@lists.openembedded.org
>>    <mailto:Openembedded-core@lists.openembedded.org>
>>    http://lists.openembedded.org/mailman/listinfo/openembedded-core
>>    <http://lists.openembedded.org/mailman/listinfo/openembedded-core>
>> 
>> 
> 
> -- 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core


^ permalink raw reply	[flat|nested] 13+ messages in thread

end of thread, other threads:[~2017-08-26 13:22 UTC | newest]

Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-24  5:37 [PATCH] libinput: remove obsolete touchpad patch Jose Alarcon
2017-08-24 17:45 ` Andre McCurdy
2017-08-25  7:09   ` EXT: " Jose Alarcon
2017-08-25 18:48     ` Andre McCurdy
2017-08-25 18:55       ` Mark Hatle
2017-08-25 18:59         ` Martin Jansa
2017-08-25 22:42           ` Khem Raj
2017-08-25 23:37             ` Andre McCurdy
2017-08-26  0:16               ` Khem Raj
2017-08-26  0:44                 ` Andre McCurdy
2017-08-26  0:48                   ` Khem Raj
2017-08-26 10:21           ` Jose Alarcon
2017-08-26 13:22             ` Alarcon, Jose (GE Healthcare)

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.