* [PATCH] tests/qtest/netdev-socket: Raise connection timeout to 60 seconds
@ 2023-02-07 16:51 Peter Maydell
2023-02-07 18:47 ` Thomas Huth
0 siblings, 1 reply; 3+ messages in thread
From: Peter Maydell @ 2023-02-07 16:51 UTC (permalink / raw)
To: qemu-devel; +Cc: Thomas Huth, Laurent Vivier
The netdev-socket test intermittently fails on our s390x CI runner:
633/659 ERROR:../tests/qtest/netdev-socket.c:197:test_stream_unix:
assertion failed (resp == expect): ("st0: index=0,type=stream,connection error\r\n" == "st0: index=0,type=stream,unix:/tmp/netdev-socket.GZUG01/stream_unix\r\n")
ERROR
633/659 qemu:qtest+qtest-xtensa / qtest-xtensa/netdev-socket
ERROR 5.47s killed by signal 6 SIGABRT
This may just be because when the machine is under heavy load
running the CI tests it hits the timeout before the QEMU
under test has started to the point of being able to respond
to HMP queries.
Bump the timeout to 60 seconds to see if the intermittent
goes away.
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
tests/qtest/netdev-socket.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/qtest/netdev-socket.c b/tests/qtest/netdev-socket.c
index 6ba256e1730..1d98dca821f 100644
--- a/tests/qtest/netdev-socket.c
+++ b/tests/qtest/netdev-socket.c
@@ -12,7 +12,7 @@
#include "../unit/socket-helpers.h"
#include "libqtest.h"
-#define CONNECTION_TIMEOUT 5
+#define CONNECTION_TIMEOUT 60
#define EXPECT_STATE(q, e, t) \
do { \
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] tests/qtest/netdev-socket: Raise connection timeout to 60 seconds
2023-02-07 16:51 [PATCH] tests/qtest/netdev-socket: Raise connection timeout to 60 seconds Peter Maydell
@ 2023-02-07 18:47 ` Thomas Huth
2023-02-09 11:24 ` Peter Maydell
0 siblings, 1 reply; 3+ messages in thread
From: Thomas Huth @ 2023-02-07 18:47 UTC (permalink / raw)
To: Peter Maydell, qemu-devel; +Cc: Laurent Vivier
On 07/02/2023 17.51, Peter Maydell wrote:
> The netdev-socket test intermittently fails on our s390x CI runner:
>
> 633/659 ERROR:../tests/qtest/netdev-socket.c:197:test_stream_unix:
> assertion failed (resp == expect): ("st0: index=0,type=stream,connection error\r\n" == "st0: index=0,type=stream,unix:/tmp/netdev-socket.GZUG01/stream_unix\r\n")
> ERROR
> 633/659 qemu:qtest+qtest-xtensa / qtest-xtensa/netdev-socket
> ERROR 5.47s killed by signal 6 SIGABRT
>
> This may just be because when the machine is under heavy load
> running the CI tests it hits the timeout before the QEMU
> under test has started to the point of being able to respond
> to HMP queries.
>
> Bump the timeout to 60 seconds to see if the intermittent
> goes away.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> tests/qtest/netdev-socket.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/qtest/netdev-socket.c b/tests/qtest/netdev-socket.c
> index 6ba256e1730..1d98dca821f 100644
> --- a/tests/qtest/netdev-socket.c
> +++ b/tests/qtest/netdev-socket.c
> @@ -12,7 +12,7 @@
> #include "../unit/socket-helpers.h"
> #include "libqtest.h"
>
> -#define CONNECTION_TIMEOUT 5
> +#define CONNECTION_TIMEOUT 60
Acked-by: Thomas Huth <thuth@redhat.com>
Feel free to apply directly as a CI fix, I don't have any pull request
planned in the next days.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] tests/qtest/netdev-socket: Raise connection timeout to 60 seconds
2023-02-07 18:47 ` Thomas Huth
@ 2023-02-09 11:24 ` Peter Maydell
0 siblings, 0 replies; 3+ messages in thread
From: Peter Maydell @ 2023-02-09 11:24 UTC (permalink / raw)
To: Thomas Huth; +Cc: qemu-devel, Laurent Vivier
On Tue, 7 Feb 2023 at 18:47, Thomas Huth <thuth@redhat.com> wrote:
>
> On 07/02/2023 17.51, Peter Maydell wrote:
> > The netdev-socket test intermittently fails on our s390x CI runner:
> >
> > 633/659 ERROR:../tests/qtest/netdev-socket.c:197:test_stream_unix:
> > assertion failed (resp == expect): ("st0: index=0,type=stream,connection error\r\n" == "st0: index=0,type=stream,unix:/tmp/netdev-socket.GZUG01/stream_unix\r\n")
> > ERROR
> > 633/659 qemu:qtest+qtest-xtensa / qtest-xtensa/netdev-socket
> > ERROR 5.47s killed by signal 6 SIGABRT
> >
> > This may just be because when the machine is under heavy load
> > running the CI tests it hits the timeout before the QEMU
> > under test has started to the point of being able to respond
> > to HMP queries.
> >
> > Bump the timeout to 60 seconds to see if the intermittent
> > goes away.
> >
> > Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> > ---
> > tests/qtest/netdev-socket.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tests/qtest/netdev-socket.c b/tests/qtest/netdev-socket.c
> > index 6ba256e1730..1d98dca821f 100644
> > --- a/tests/qtest/netdev-socket.c
> > +++ b/tests/qtest/netdev-socket.c
> > @@ -12,7 +12,7 @@
> > #include "../unit/socket-helpers.h"
> > #include "libqtest.h"
> >
> > -#define CONNECTION_TIMEOUT 5
> > +#define CONNECTION_TIMEOUT 60
>
> Acked-by: Thomas Huth <thuth@redhat.com>
>
> Feel free to apply directly as a CI fix, I don't have any pull request
> planned in the next days.
OK, I've applied this directly.
-- PMM
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-02-09 11:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-07 16:51 [PATCH] tests/qtest/netdev-socket: Raise connection timeout to 60 seconds Peter Maydell
2023-02-07 18:47 ` Thomas Huth
2023-02-09 11:24 ` Peter Maydell
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.