All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Jason Ekstrand <jason@jlekstrand.net>
Cc: Intel GFX <intel-gfx@lists.freedesktop.org>,
	Maling list - DRI developers <dri-devel@lists.freedesktop.org>
Subject: Re: [Intel-gfx] [PATCH 3/6] drm/i915: Always call i915_globals_exit() from i915_exit()
Date: Tue, 20 Jul 2021 16:30:08 +0100	[thread overview]
Message-ID: <bb07da62-2c6b-e7a3-3563-72ca24ebee9f@linux.intel.com> (raw)
In-Reply-To: <CAOFGe96CemtS4hBoOR8g+V-6synP_WNdHj3ed0MgRaNasV24Xw@mail.gmail.com>


Now you confused me with two replies I forgot to reply to all... :))

On 20/07/2021 15:53, Jason Ekstrand wrote:
> On Tue, Jul 20, 2021 at 3:25 AM Tvrtko Ursulin
> <tvrtko.ursulin@linux.intel.com> wrote:

[snip]

>>> +
>>>    static int __init i915_init(void)
>>>    {
>>>        bool use_kms = true;
>>>        int err;
>>>
>>> +     i915_fully_loaded = false;
>>
>> Ditto.
> 
> So, this is something I'm unclear on.  I know that static memory gets
> auto-initialized to zero but what happens if you unload and reload a
> module?  Is it re-initialized to zero?  If it is then we can drop
> this.

Well it's not in memory after it is unloaded so clearly it has to get 
initialised by the module loader every time it loads it.

Regards,

Tvrtko

WARNING: multiple messages have this Message-ID (diff)
From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Jason Ekstrand <jason@jlekstrand.net>
Cc: Intel GFX <intel-gfx@lists.freedesktop.org>,
	Maling list - DRI developers <dri-devel@lists.freedesktop.org>
Subject: Re: [Intel-gfx] [PATCH 3/6] drm/i915: Always call i915_globals_exit() from i915_exit()
Date: Tue, 20 Jul 2021 16:30:08 +0100	[thread overview]
Message-ID: <bb07da62-2c6b-e7a3-3563-72ca24ebee9f@linux.intel.com> (raw)
In-Reply-To: <CAOFGe96CemtS4hBoOR8g+V-6synP_WNdHj3ed0MgRaNasV24Xw@mail.gmail.com>


Now you confused me with two replies I forgot to reply to all... :))

On 20/07/2021 15:53, Jason Ekstrand wrote:
> On Tue, Jul 20, 2021 at 3:25 AM Tvrtko Ursulin
> <tvrtko.ursulin@linux.intel.com> wrote:

[snip]

>>> +
>>>    static int __init i915_init(void)
>>>    {
>>>        bool use_kms = true;
>>>        int err;
>>>
>>> +     i915_fully_loaded = false;
>>
>> Ditto.
> 
> So, this is something I'm unclear on.  I know that static memory gets
> auto-initialized to zero but what happens if you unload and reload a
> module?  Is it re-initialized to zero?  If it is then we can drop
> this.

Well it's not in memory after it is unloaded so clearly it has to get 
initialised by the module loader every time it loads it.

Regards,

Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2021-07-20 15:30 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-19 18:30 [PATCH 0/6] Fix the debugfs splat from mock selftests Jason Ekstrand
2021-07-19 18:30 ` [Intel-gfx] " Jason Ekstrand
2021-07-19 18:30 ` [PATCH 1/6] drm/i915: Call i915_globals_exit() after i915_pmu_exit() Jason Ekstrand
2021-07-19 18:30   ` [Intel-gfx] " Jason Ekstrand
2021-07-19 18:30 ` [PATCH 2/6] drm/i915: Call i915_globals_exit() if pci_register_device() fails Jason Ekstrand
2021-07-19 18:30   ` [Intel-gfx] " Jason Ekstrand
2021-07-20 14:11   ` Daniel Vetter
2021-07-20 14:11     ` [Intel-gfx] " Daniel Vetter
2021-07-19 18:30 ` [PATCH 3/6] drm/i915: Always call i915_globals_exit() from i915_exit() Jason Ekstrand
2021-07-19 18:30   ` [Intel-gfx] " Jason Ekstrand
2021-07-20  8:25   ` Tvrtko Ursulin
2021-07-20  8:25     ` Tvrtko Ursulin
2021-07-20 14:53     ` Jason Ekstrand
2021-07-20 14:53       ` Jason Ekstrand
2021-07-20 15:22       ` Tvrtko Ursulin
2021-07-20 15:22         ` Tvrtko Ursulin
2021-07-20 15:30       ` Tvrtko Ursulin [this message]
2021-07-20 15:30         ` Tvrtko Ursulin
2021-07-20 15:05     ` Jason Ekstrand
2021-07-20 15:05       ` Jason Ekstrand
2021-07-20 15:25       ` Tvrtko Ursulin
2021-07-20 15:25         ` Tvrtko Ursulin
2021-07-20 14:18   ` Daniel Vetter
2021-07-20 14:18     ` [Intel-gfx] " Daniel Vetter
2021-07-20 14:55     ` Jason Ekstrand
2021-07-20 14:55       ` [Intel-gfx] " Jason Ekstrand
2021-07-21 11:26       ` Daniel Vetter
2021-07-21 11:26         ` [Intel-gfx] " Daniel Vetter
2021-07-21 15:20         ` Jason Ekstrand
2021-07-21 15:20           ` [Intel-gfx] " Jason Ekstrand
2021-07-19 18:30 ` [PATCH 4/6] drm/ttm: Force re-init if ttm_global_init() fails Jason Ekstrand
2021-07-19 18:30   ` [Intel-gfx] " Jason Ekstrand
2021-07-19 19:21   ` Christian König
2021-07-19 19:21     ` [Intel-gfx] " Christian König
2021-07-19 18:30 ` [PATCH 5/6] drm/ttm: Initialize debugfs from ttm_global_init() Jason Ekstrand
2021-07-19 18:30   ` [Intel-gfx] " Jason Ekstrand
2021-07-20 14:22   ` Daniel Vetter
2021-07-20 14:22     ` [Intel-gfx] " Daniel Vetter
2021-07-19 18:30 ` [PATCH 6/6] drm/i915: Make the kmem slab for i915_buddy_block a global Jason Ekstrand
2021-07-19 18:30   ` [Intel-gfx] " Jason Ekstrand
2021-07-19 18:38 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Fix the debugfs splat from mock selftests Patchwork
2021-07-19 18:38 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2021-07-19 18:42 ` [Intel-gfx] ✗ Fi.CI.DOCS: " Patchwork
2021-07-19 19:05 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-07-19 23:32 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bb07da62-2c6b-e7a3-3563-72ca24ebee9f@linux.intel.com \
    --to=tvrtko.ursulin@linux.intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jason@jlekstrand.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.