All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@intel.com>
To: dri-devel@lists.freedesktop.org
Cc: jani.nikula@intel.com, intel-gfx@lists.freedesktop.org,
	manasi.d.navare@intel.com, vandita.kulkarni@intel.com,
	Harry Wentland <hwentlan@amd.com>
Subject: [PATCH 1/7] drm/dsc: use rc_model_size from DSC config for PPS
Date: Wed, 22 Jan 2020 15:45:07 +0200	[thread overview]
Message-ID: <bb0a934e0cf3afd9c801ffe27b5ef14bc3cf69b8.1579700414.git.jani.nikula@intel.com> (raw)
In-Reply-To: <cover.1579700414.git.jani.nikula@intel.com>

The PPS is supposed to reflect the DSC config instead of hard coding the
rc_model_size. Make it so.

Currently all users of drm_dsc_pps_payload_pack() hard code the size to
8192 also in the DSC config, so this change should have no impact, other
than allowing the drivers to use other sizes as needed.

Cc: Alex Deucher <alexdeucher@gmail.com>
Cc: Harry Wentland <hwentlan@amd.com>
Cc: Manasi Navare <manasi.d.navare@intel.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
 drivers/gpu/drm/drm_dsc.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/drm_dsc.c b/drivers/gpu/drm/drm_dsc.c
index 4a475d9696ff..09afbc01ea94 100644
--- a/drivers/gpu/drm/drm_dsc.c
+++ b/drivers/gpu/drm/drm_dsc.c
@@ -186,8 +186,7 @@ void drm_dsc_pps_payload_pack(struct drm_dsc_picture_parameter_set *pps_payload,
 	pps_payload->flatness_max_qp = dsc_cfg->flatness_max_qp;
 
 	/* PPS 38, 39 */
-	pps_payload->rc_model_size =
-		cpu_to_be16(DSC_RC_MODEL_SIZE_CONST);
+	pps_payload->rc_model_size = cpu_to_be16(dsc_cfg->rc_model_size);
 
 	/* PPS 40 */
 	pps_payload->rc_edge_factor = DSC_RC_EDGE_FACTOR_CONST;
-- 
2.20.1

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: Jani Nikula <jani.nikula@intel.com>
To: dri-devel@lists.freedesktop.org
Cc: jani.nikula@intel.com, intel-gfx@lists.freedesktop.org,
	Alex Deucher <alexdeucher@gmail.com>,
	Harry Wentland <hwentlan@amd.com>
Subject: [Intel-gfx] [PATCH 1/7] drm/dsc: use rc_model_size from DSC config for PPS
Date: Wed, 22 Jan 2020 15:45:07 +0200	[thread overview]
Message-ID: <bb0a934e0cf3afd9c801ffe27b5ef14bc3cf69b8.1579700414.git.jani.nikula@intel.com> (raw)
In-Reply-To: <cover.1579700414.git.jani.nikula@intel.com>

The PPS is supposed to reflect the DSC config instead of hard coding the
rc_model_size. Make it so.

Currently all users of drm_dsc_pps_payload_pack() hard code the size to
8192 also in the DSC config, so this change should have no impact, other
than allowing the drivers to use other sizes as needed.

Cc: Alex Deucher <alexdeucher@gmail.com>
Cc: Harry Wentland <hwentlan@amd.com>
Cc: Manasi Navare <manasi.d.navare@intel.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
 drivers/gpu/drm/drm_dsc.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/drm_dsc.c b/drivers/gpu/drm/drm_dsc.c
index 4a475d9696ff..09afbc01ea94 100644
--- a/drivers/gpu/drm/drm_dsc.c
+++ b/drivers/gpu/drm/drm_dsc.c
@@ -186,8 +186,7 @@ void drm_dsc_pps_payload_pack(struct drm_dsc_picture_parameter_set *pps_payload,
 	pps_payload->flatness_max_qp = dsc_cfg->flatness_max_qp;
 
 	/* PPS 38, 39 */
-	pps_payload->rc_model_size =
-		cpu_to_be16(DSC_RC_MODEL_SIZE_CONST);
+	pps_payload->rc_model_size = cpu_to_be16(dsc_cfg->rc_model_size);
 
 	/* PPS 40 */
 	pps_payload->rc_edge_factor = DSC_RC_EDGE_FACTOR_CONST;
-- 
2.20.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2020-01-22 13:45 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-22 13:45 [PATCH 0/7] drm/dsc: fixes and cleanups around rc_model_size Jani Nikula
2020-01-22 13:45 ` [Intel-gfx] " Jani Nikula
2020-01-22 13:45 ` Jani Nikula [this message]
2020-01-22 13:45   ` [Intel-gfx] [PATCH 1/7] drm/dsc: use rc_model_size from DSC config for PPS Jani Nikula
2020-01-22 13:45 ` [PATCH 2/7] drm/dsc: add helper for calculating rc buffer size from DPCD Jani Nikula
2020-01-22 13:45   ` [Intel-gfx] " Jani Nikula
2020-01-22 13:45 ` [PATCH 3/7] drm/amd/display: use drm_dsc_dp_rc_buffer_size() to get rc buffer size Jani Nikula
2020-01-22 13:45   ` [Intel-gfx] " Jani Nikula
2020-01-22 13:45 ` [PATCH 4/7] drm/i915/dsc: configure hardware using specified rc_model_size Jani Nikula
2020-01-22 13:45   ` [Intel-gfx] " Jani Nikula
2020-01-22 13:45 ` [PATCH 5/7] drm/i915/dsc: make rc_model_size an encoder defined value Jani Nikula
2020-01-22 13:45   ` [Intel-gfx] " Jani Nikula
2020-01-22 13:45 ` [PATCH 6/7] drm/i915/bios: fill in DSC rc_model_size from VBT Jani Nikula
2020-01-22 13:45   ` [Intel-gfx] " Jani Nikula
2020-01-22 13:45 ` [PATCH 7/7] drm/i915/dsi: use VBT data for rc_model_size Jani Nikula
2020-01-22 13:45   ` [Intel-gfx] " Jani Nikula
2020-01-22 14:03 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/dsc: fixes and cleanups around rc_model_size Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bb0a934e0cf3afd9c801ffe27b5ef14bc3cf69b8.1579700414.git.jani.nikula@intel.com \
    --to=jani.nikula@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=hwentlan@amd.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=manasi.d.navare@intel.com \
    --cc=vandita.kulkarni@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.