From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Vinod Koul <vkoul@kernel.org>
Cc: alsa-devel@alsa-project.org, tiwai@suse.de,
gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
liam.r.girdwood@linux.intel.com, broonie@kernel.org,
srinivas.kandagatla@linaro.org, jank@cadence.com,
joe@perches.com
Subject: Re: [alsa-devel] [PATCH v3 0/5] soundwire: code cleanup
Date: Fri, 19 Apr 2019 12:07:38 -0500 [thread overview]
Message-ID: <bb335979-61de-e2d7-d1b4-8e29e2beda49@linux.intel.com> (raw)
In-Reply-To: <df6040ba-ab69-ae64-a27f-236e8ac95c14@linux.intel.com>
On 4/15/19 7:57 AM, Pierre-Louis Bossart wrote:
>
>
> On 4/14/19 5:04 AM, Vinod Koul wrote:
>> On 10-04-19, 22:16, Pierre-Louis Bossart wrote:
>>> SoundWire support will be provided in Linux with the Sound Open
>>> Firmware (SOF) on Intel platforms. Before we start adding the missing
>>> pieces, there are a number of warnings and style issues reported by
>>> checkpatch, cppcheck and Coccinelle that need to be cleaned-up.
>>
>> Applied, 1, 3 and 4 (5 looked good but didnt apply)
>
> this applies on top of Mark Brown's for-next tree. This should be the
> reference really for SoundWire work, if we start having another tree
> with deltas it's really counter productive. I already have dependencies
> on acpi...
Vinod, can you please double-check why patch 5 didn't work for you. I
tried on Mark and Linus' trees and no issues, see below.
$ git reset --hard v5.1-rc5
HEAD is now at dc4060a5dc25 Linux 5.1-rc5
$ git am ~/Downloads/alsa/39/\[PATCH\ v3\ *.eml
Applying: soundwire: intel: fix inversion in devm_kcalloc parameters
Applying: soundwire: fix style issues
Applying: soundwire: bus: remove useless initializations
Applying: soundwire: stream: remove useless initialization of local variable
Applying: soundwire: add missing newlines in dynamic debug logs
$ git reset --hard broonie/for-next
HEAD is now at 84fdefca04a7 Merge branch 'asoc-5.2' into asoc-next
$ git am ~/Downloads/alsa/39/\[PATCH\ v3\ *.eml
Applying: soundwire: intel: fix inversion in devm_kcalloc parameters
Applying: soundwire: fix style issues
Applying: soundwire: bus: remove useless initializations
Applying: soundwire: stream: remove useless initialization of local variable
Applying: soundwire: add missing newlines in dynamic debug logs
WARNING: multiple messages have this Message-ID (diff)
From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Vinod Koul <vkoul@kernel.org>
Cc: alsa-devel@alsa-project.org, tiwai@suse.de,
gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
liam.r.girdwood@linux.intel.com, broonie@kernel.org,
srinivas.kandagatla@linaro.org, jank@cadence.com,
joe@perches.com
Subject: Re: [PATCH v3 0/5] soundwire: code cleanup
Date: Fri, 19 Apr 2019 12:07:38 -0500 [thread overview]
Message-ID: <bb335979-61de-e2d7-d1b4-8e29e2beda49@linux.intel.com> (raw)
In-Reply-To: <df6040ba-ab69-ae64-a27f-236e8ac95c14@linux.intel.com>
On 4/15/19 7:57 AM, Pierre-Louis Bossart wrote:
>
>
> On 4/14/19 5:04 AM, Vinod Koul wrote:
>> On 10-04-19, 22:16, Pierre-Louis Bossart wrote:
>>> SoundWire support will be provided in Linux with the Sound Open
>>> Firmware (SOF) on Intel platforms. Before we start adding the missing
>>> pieces, there are a number of warnings and style issues reported by
>>> checkpatch, cppcheck and Coccinelle that need to be cleaned-up.
>>
>> Applied, 1, 3 and 4 (5 looked good but didnt apply)
>
> this applies on top of Mark Brown's for-next tree. This should be the
> reference really for SoundWire work, if we start having another tree
> with deltas it's really counter productive. I already have dependencies
> on acpi...
Vinod, can you please double-check why patch 5 didn't work for you. I
tried on Mark and Linus' trees and no issues, see below.
$ git reset --hard v5.1-rc5
HEAD is now at dc4060a5dc25 Linux 5.1-rc5
$ git am ~/Downloads/alsa/39/\[PATCH\ v3\ *.eml
Applying: soundwire: intel: fix inversion in devm_kcalloc parameters
Applying: soundwire: fix style issues
Applying: soundwire: bus: remove useless initializations
Applying: soundwire: stream: remove useless initialization of local variable
Applying: soundwire: add missing newlines in dynamic debug logs
$ git reset --hard broonie/for-next
HEAD is now at 84fdefca04a7 Merge branch 'asoc-5.2' into asoc-next
$ git am ~/Downloads/alsa/39/\[PATCH\ v3\ *.eml
Applying: soundwire: intel: fix inversion in devm_kcalloc parameters
Applying: soundwire: fix style issues
Applying: soundwire: bus: remove useless initializations
Applying: soundwire: stream: remove useless initialization of local variable
Applying: soundwire: add missing newlines in dynamic debug logs
next prev parent reply other threads:[~2019-04-19 18:32 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-11 3:16 [PATCH v3 0/5] soundwire: code cleanup Pierre-Louis Bossart
2019-04-11 3:16 ` [PATCH v3 1/5] soundwire: intel: fix inversion in devm_kcalloc parameters Pierre-Louis Bossart
2019-04-11 8:43 ` Takashi Iwai
2019-04-11 3:16 ` [PATCH v3 2/5] soundwire: fix style issues Pierre-Louis Bossart
2019-04-14 9:58 ` Vinod Koul
2019-04-15 13:09 ` [alsa-devel] " Pierre-Louis Bossart
2019-04-17 9:33 ` Johan Hovold
2019-04-17 17:18 ` Pierre-Louis Bossart
2019-04-18 17:29 ` Johan Hovold
2019-04-19 17:14 ` Pierre-Louis Bossart
2019-04-19 17:14 ` Pierre-Louis Bossart
2019-04-30 8:57 ` [alsa-devel] " Vinod Koul
2019-04-30 8:51 ` Vinod Koul
2019-04-30 13:38 ` Pierre-Louis Bossart
2019-04-30 14:05 ` Greg KH
2019-04-30 14:13 ` Pierre-Louis Bossart
2019-04-30 14:25 ` Greg KH
2019-04-30 14:54 ` Vfi
2019-04-30 16:29 ` Pierre-Louis Bossart
2019-04-11 3:16 ` [PATCH v3 3/5] soundwire: bus: remove useless initializations Pierre-Louis Bossart
2019-04-11 3:17 ` [PATCH v3 4/5] soundwire: stream: remove useless initialization of local variable Pierre-Louis Bossart
2019-04-11 3:17 ` [PATCH v3 5/5] soundwire: add missing newlines in dynamic debug logs Pierre-Louis Bossart
2019-04-11 8:43 ` [PATCH v3 0/5] soundwire: code cleanup Takashi Iwai
2019-04-14 10:04 ` Vinod Koul
2019-04-15 12:57 ` [alsa-devel] " Pierre-Louis Bossart
2019-04-19 17:07 ` Pierre-Louis Bossart [this message]
2019-04-19 17:07 ` Pierre-Louis Bossart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bb335979-61de-e2d7-d1b4-8e29e2beda49@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jank@cadence.com \
--cc=joe@perches.com \
--cc=liam.r.girdwood@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=tiwai@suse.de \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.