All of lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Alexander Stein <alexander.stein@ew.tq-group.com>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	Markus Niebel <Markus.Niebel@tq-group.com>
Subject: Re: (EXT) Re: [PATCH 2/2] arm64: dts: freescale: add initial device tree for TQMa8MPQL with i.MX8MP
Date: Fri, 17 Jun 2022 16:15:35 -0700	[thread overview]
Message-ID: <bb6b5271-1dce-bbd8-eb39-34a5ac550cc4@linaro.org> (raw)
In-Reply-To: <5819581.iIbC2pHGDl@steina-w>

On 17/06/2022 04:21, Alexander Stein wrote:
>> What's this node about? There is no compatible.
> 
> As mentioned in the cover letter, some nodes are not used yet. In this case 
> the intention is to apply an overlay for enabling the display later on. As the 
> MBa8MPxL is a starter kit mainboard there is no fixed display attached. So a 
> user might use our supported display or chose his own. But the backlight and 
> display are fixed, so anything related to that can be part of the general 
> mainboad DTS.
> The display specific overlay will then have (among other things) the following 
> snippet:
> 

Sure. Could you add such explanation to the comment in DTS next to this
unusual node? This would answer people's question if they wonder about
the display node.

>> &display0 {
>> 	compatible = "tianma,tm070jvhg33";
>> 	status = "okay";
>> };
> 
> Power supply and enable GPIO are fixed, so there the can be part of the 
> mainboard DTS while the actual compatible for the display might change.
> 
> I hope this makes this approach a bit more clear and this approach is 
> acceptable.


Best regards,
Krzysztof

WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Alexander Stein <alexander.stein@ew.tq-group.com>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	Markus Niebel <Markus.Niebel@tq-group.com>
Subject: Re: (EXT) Re: [PATCH 2/2] arm64: dts: freescale: add initial device tree for TQMa8MPQL with i.MX8MP
Date: Fri, 17 Jun 2022 16:15:35 -0700	[thread overview]
Message-ID: <bb6b5271-1dce-bbd8-eb39-34a5ac550cc4@linaro.org> (raw)
In-Reply-To: <5819581.iIbC2pHGDl@steina-w>

On 17/06/2022 04:21, Alexander Stein wrote:
>> What's this node about? There is no compatible.
> 
> As mentioned in the cover letter, some nodes are not used yet. In this case 
> the intention is to apply an overlay for enabling the display later on. As the 
> MBa8MPxL is a starter kit mainboard there is no fixed display attached. So a 
> user might use our supported display or chose his own. But the backlight and 
> display are fixed, so anything related to that can be part of the general 
> mainboad DTS.
> The display specific overlay will then have (among other things) the following 
> snippet:
> 

Sure. Could you add such explanation to the comment in DTS next to this
unusual node? This would answer people's question if they wonder about
the display node.

>> &display0 {
>> 	compatible = "tianma,tm070jvhg33";
>> 	status = "okay";
>> };
> 
> Power supply and enable GPIO are fixed, so there the can be part of the 
> mainboard DTS while the actual compatible for the display might change.
> 
> I hope this makes this approach a bit more clear and this approach is 
> acceptable.


Best regards,
Krzysztof

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2022-06-17 23:16 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-16 14:22 [PATCH 0/2] TQMa8MPxL + MBa8MPxL support Alexander Stein
2022-06-16 14:22 ` Alexander Stein
2022-06-16 14:22 ` [PATCH 1/2] dt-bindings: arm: add TQMa8MPxL board Alexander Stein
2022-06-16 14:22   ` Alexander Stein
2022-06-16 21:57   ` Krzysztof Kozlowski
2022-06-16 21:57     ` Krzysztof Kozlowski
2022-06-16 14:22 ` [PATCH 2/2] arm64: dts: freescale: add initial device tree for TQMa8MPQL with i.MX8MP Alexander Stein
2022-06-16 14:22   ` Alexander Stein
2022-06-16 14:26   ` Krzysztof Kozlowski
2022-06-16 14:26     ` Krzysztof Kozlowski
2022-06-17 11:21     ` (EXT) " Alexander Stein
2022-06-17 11:21       ` Alexander Stein
2022-06-17 23:15       ` Krzysztof Kozlowski [this message]
2022-06-17 23:15         ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bb6b5271-1dce-bbd8-eb39-34a5ac550cc4@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=Markus.Niebel@tq-group.com \
    --cc=alexander.stein@ew.tq-group.com \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=robh+dt@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.