All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/2] arm: socfpga: gen5: don't zero bss in board_init_f()
Date: Fri, 12 Jul 2019 06:07:30 +0200	[thread overview]
Message-ID: <bb772b6a-af58-9630-a075-9a3e9c9fe500@denx.de> (raw)
In-Reply-To: <20190711191813.19550-3-simon.k.r.goldschmidt@gmail.com>

On 7/11/19 9:18 PM, Simon Goldschmidt wrote:
> The socfpga gen5 SPL manually zeroed bss in board_init_f(). Now that the
> DDR driver does not use bss any more, bss is not used before board_init_r()
> and we can remove this hack.
> 
> Signed-off-by: Simon Goldschmidt <simon.k.r.goldschmidt@gmail.com>
> ---
> 
>  arch/arm/mach-socfpga/spl_gen5.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/arch/arm/mach-socfpga/spl_gen5.c b/arch/arm/mach-socfpga/spl_gen5.c
> index 87b76b47de..47e63709ad 100644
> --- a/arch/arm/mach-socfpga/spl_gen5.c
> +++ b/arch/arm/mach-socfpga/spl_gen5.c
> @@ -79,8 +79,6 @@ void board_init_f(ulong dummy)
>  		writel(SYSMGR_ECC_OCRAM_DERR  | SYSMGR_ECC_OCRAM_EN,
>  		       &sysmgr_regs->eccgrp_ocram);
>  
> -	memset(__bss_start, 0, __bss_end - __bss_start);
> -
>  	socfpga_sdram_remap_zero();
>  	socfpga_pl310_clear();

So who will zero out the BSS ?

[...]

  reply	other threads:[~2019-07-12  4:07 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-11 19:18 [U-Boot] [PATCH 0/2] arm: socfpga: gen5 SPL bss cleanup Simon Goldschmidt
2019-07-11 19:18 ` [U-Boot] [PATCH 1/2] dm: ddr: socfpga: fix gen5 ddr driver to not use bss Simon Goldschmidt
2019-07-12  4:07   ` Marek Vasut
2019-07-11 19:18 ` [U-Boot] [PATCH 2/2] arm: socfpga: gen5: don't zero bss in board_init_f() Simon Goldschmidt
2019-07-12  4:07   ` Marek Vasut [this message]
2019-07-12  5:29     ` Simon Goldschmidt
2019-07-12 10:00       ` Marek Vasut
2019-07-12 10:30         ` Simon Goldschmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bb772b6a-af58-9630-a075-9a3e9c9fe500@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.