All of lore.kernel.org
 help / color / mirror / Atom feed
From: Florian Fainelli <f.fainelli@gmail.com>
To: Jon Mason <jon.mason@broadcom.com>,
	Hauke Mehrtens <hauke@hauke-m.de>,
	zajec5@gmail.com
Cc: Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Florian Fainelli <f.fainelli@gmail.com>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	bcm-kernel-feedback-list@broadcom.com,
	Jon Mason <jonmason@broadcom.com>
Subject: Re: [PATCH v2 3/3] ARM: dts: bcm5301x: Add I2C support to the DT
Date: Sun, 5 Mar 2017 17:13:34 -0800	[thread overview]
Message-ID: <bb91cbbd-f5e5-9ce8-e925-89e6f831e50c@gmail.com> (raw)
In-Reply-To: <1488500494-20622-4-git-send-email-jon.mason@broadcom.com>



On 03/02/2017 04:21 PM, Jon Mason wrote:
> From: Jon Mason <jonmason@broadcom.com>
> 
> Add I2C support to the bcm5301x Device Tree.  Since no driver changes
> are needed to enable this hardware, only the device tree changes are
> required to make this functional.
> 
> Signed-off-by: Jon Mason <jonmason@broadcom.com>
> ---
>  arch/arm/boot/dts/bcm5301x.dtsi | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/bcm5301x.dtsi b/arch/arm/boot/dts/bcm5301x.dtsi
> index 4e3fbce..2a343f2 100644
> --- a/arch/arm/boot/dts/bcm5301x.dtsi
> +++ b/arch/arm/boot/dts/bcm5301x.dtsi
> @@ -338,6 +338,15 @@
>  		};
>  	};
>  
> +	i2c0: i2c@18009000 {
> +		compatible = "brcm,iproc-i2c";
> +		reg = <0x18009000 0x50>;
> +		interrupts = <GIC_SPI 121 IRQ_TYPE_NONE>;
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +		clock-frequency = <100000>;

Should not this have a:
		status = "disabled"

property by default such that boards can override this by phandle when
there are actual I2C devices available?

> +	};
> +
>  	lcpll0: lcpll0@1800c100 {
>  		#clock-cells = <1>;
>  		compatible = "brcm,nsp-lcpll0";
> 

-- 
Florian

WARNING: multiple messages have this Message-ID (diff)
From: Florian Fainelli <f.fainelli@gmail.com>
To: Jon Mason <jon.mason@broadcom.com>,
	Hauke Mehrtens <hauke@hauke-m.de>,
	zajec5@gmail.com
Cc: Mark Rutland <mark.rutland@arm.com>,
	devicetree@vger.kernel.org,
	Florian Fainelli <f.fainelli@gmail.com>,
	Jon Mason <jonmason@broadcom.com>,
	linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
	bcm-kernel-feedback-list@broadcom.com,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 3/3] ARM: dts: bcm5301x: Add I2C support to the DT
Date: Sun, 5 Mar 2017 17:13:34 -0800	[thread overview]
Message-ID: <bb91cbbd-f5e5-9ce8-e925-89e6f831e50c@gmail.com> (raw)
In-Reply-To: <1488500494-20622-4-git-send-email-jon.mason@broadcom.com>



On 03/02/2017 04:21 PM, Jon Mason wrote:
> From: Jon Mason <jonmason@broadcom.com>
> 
> Add I2C support to the bcm5301x Device Tree.  Since no driver changes
> are needed to enable this hardware, only the device tree changes are
> required to make this functional.
> 
> Signed-off-by: Jon Mason <jonmason@broadcom.com>
> ---
>  arch/arm/boot/dts/bcm5301x.dtsi | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/bcm5301x.dtsi b/arch/arm/boot/dts/bcm5301x.dtsi
> index 4e3fbce..2a343f2 100644
> --- a/arch/arm/boot/dts/bcm5301x.dtsi
> +++ b/arch/arm/boot/dts/bcm5301x.dtsi
> @@ -338,6 +338,15 @@
>  		};
>  	};
>  
> +	i2c0: i2c@18009000 {
> +		compatible = "brcm,iproc-i2c";
> +		reg = <0x18009000 0x50>;
> +		interrupts = <GIC_SPI 121 IRQ_TYPE_NONE>;
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +		clock-frequency = <100000>;

Should not this have a:
		status = "disabled"

property by default such that boards can override this by phandle when
there are actual I2C devices available?

> +	};
> +
>  	lcpll0: lcpll0@1800c100 {
>  		#clock-cells = <1>;
>  		compatible = "brcm,nsp-lcpll0";
> 

-- 
Florian

WARNING: multiple messages have this Message-ID (diff)
From: f.fainelli@gmail.com (Florian Fainelli)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 3/3] ARM: dts: bcm5301x: Add I2C support to the DT
Date: Sun, 5 Mar 2017 17:13:34 -0800	[thread overview]
Message-ID: <bb91cbbd-f5e5-9ce8-e925-89e6f831e50c@gmail.com> (raw)
In-Reply-To: <1488500494-20622-4-git-send-email-jon.mason@broadcom.com>



On 03/02/2017 04:21 PM, Jon Mason wrote:
> From: Jon Mason <jonmason@broadcom.com>
> 
> Add I2C support to the bcm5301x Device Tree.  Since no driver changes
> are needed to enable this hardware, only the device tree changes are
> required to make this functional.
> 
> Signed-off-by: Jon Mason <jonmason@broadcom.com>
> ---
>  arch/arm/boot/dts/bcm5301x.dtsi | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/bcm5301x.dtsi b/arch/arm/boot/dts/bcm5301x.dtsi
> index 4e3fbce..2a343f2 100644
> --- a/arch/arm/boot/dts/bcm5301x.dtsi
> +++ b/arch/arm/boot/dts/bcm5301x.dtsi
> @@ -338,6 +338,15 @@
>  		};
>  	};
>  
> +	i2c0: i2c at 18009000 {
> +		compatible = "brcm,iproc-i2c";
> +		reg = <0x18009000 0x50>;
> +		interrupts = <GIC_SPI 121 IRQ_TYPE_NONE>;
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +		clock-frequency = <100000>;

Should not this have a:
		status = "disabled"

property by default such that boards can override this by phandle when
there are actual I2C devices available?

> +	};
> +
>  	lcpll0: lcpll0 at 1800c100 {
>  		#clock-cells = <1>;
>  		compatible = "brcm,nsp-lcpll0";
> 

-- 
Florian

  reply	other threads:[~2017-03-06  1:22 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-03  0:21 [PATCH v2 0/3] ARM: dts: BCM5301X: GIC_PPI bug, TWD WD and i2c Support Jon Mason
2017-03-03  0:21 ` Jon Mason
2017-03-03  0:21 ` Jon Mason
2017-03-03  0:21 ` [PATCH v2 1/3] ARM: dts: BCM5301X: Correct GIC_PPI interrupt flags Jon Mason
2017-03-03  0:21   ` Jon Mason
2017-03-03  0:21   ` Jon Mason
2017-03-06  1:11   ` Florian Fainelli
2017-03-06  1:11     ` Florian Fainelli
2017-03-03  0:21 ` [PATCH v2 2/3] ARM: dts: bcm5301x: Add TWD WD Support to DT Jon Mason
2017-03-03  0:21   ` Jon Mason
2017-03-03  0:21   ` Jon Mason
2017-03-03  0:21 ` [PATCH v2 3/3] ARM: dts: bcm5301x: Add I2C support to the DT Jon Mason
2017-03-03  0:21   ` Jon Mason
2017-03-03  0:21   ` Jon Mason
2017-03-06  1:13   ` Florian Fainelli [this message]
2017-03-06  1:13     ` Florian Fainelli
2017-03-06  1:13     ` Florian Fainelli
2017-03-06 15:12     ` Jon Mason
2017-03-06 15:12       ` Jon Mason
2017-03-06 15:12       ` Jon Mason

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bb91cbbd-f5e5-9ce8-e925-89e6f831e50c@gmail.com \
    --to=f.fainelli@gmail.com \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=devicetree@vger.kernel.org \
    --cc=hauke@hauke-m.de \
    --cc=jon.mason@broadcom.com \
    --cc=jonmason@broadcom.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=zajec5@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.