From: James Morse <james.morse@arm.com>
To: Pavel Tatashin <pasha.tatashin@soleen.com>
Cc: jmorris@namei.org, sashal@kernel.org, ebiederm@xmission.com,
kexec@lists.infradead.org, linux-kernel@vger.kernel.org,
corbet@lwn.net, catalin.marinas@arm.com, will@kernel.org,
linux-arm-kernel@lists.infradead.org, marc.zyngier@arm.com,
vladimir.murzin@arm.com, matthias.bgg@gmail.com,
bhsharma@redhat.com, linux-mm@kvack.org, mark.rutland@arm.com
Subject: Re: [PATCH v6 02/17] arm64: hibernate: pass the allocated pgdp to ttbr0
Date: Fri, 11 Oct 2019 19:17:22 +0100 [thread overview]
Message-ID: <bb937db3-f23a-809b-4ad8-ca86f689554d@arm.com> (raw)
In-Reply-To: <20191004185234.31471-3-pasha.tatashin@soleen.com>
Hi Pavel,
On 04/10/2019 19:52, Pavel Tatashin wrote:
> ttbr0 should be set to the beginning of pgdp, however, currently
> in create_safe_exec_page it is set to pgdp after pgd_offset_raw(),
> which works by accident.
>
> Fixes: 0194e760f7d2 ("arm64: hibernate: avoid potential TLB conflict")
(That was a 'break before make' fix, the affected code comes from:
82869ac57b5d (""arm64: kernel: Add support for hibernate/suspend-to-disk))
But, it works in all one circumstances its used: we know all the top bits will be zero.
I agree its by accident and we should fix it.
I don't think we should send it to stable.
Please drop the fixes tag, with that:
Reviewed-by: James Morse <james.morse@arm.com>
Thanks,
James
[0] https://lore.kernel.org/linux-arm-kernel/ddd81093-89fc-5146-0b33-ad3bd9a1c10c@arm.com/
WARNING: multiple messages have this Message-ID (diff)
From: James Morse <james.morse@arm.com>
To: Pavel Tatashin <pasha.tatashin@soleen.com>
Cc: sashal@kernel.org, mark.rutland@arm.com, vladimir.murzin@arm.com,
corbet@lwn.net, marc.zyngier@arm.com, catalin.marinas@arm.com,
bhsharma@redhat.com, kexec@lists.infradead.org,
linux-kernel@vger.kernel.org, jmorris@namei.org,
linux-mm@kvack.org, ebiederm@xmission.com,
matthias.bgg@gmail.com, will@kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v6 02/17] arm64: hibernate: pass the allocated pgdp to ttbr0
Date: Fri, 11 Oct 2019 19:17:22 +0100 [thread overview]
Message-ID: <bb937db3-f23a-809b-4ad8-ca86f689554d@arm.com> (raw)
In-Reply-To: <20191004185234.31471-3-pasha.tatashin@soleen.com>
Hi Pavel,
On 04/10/2019 19:52, Pavel Tatashin wrote:
> ttbr0 should be set to the beginning of pgdp, however, currently
> in create_safe_exec_page it is set to pgdp after pgd_offset_raw(),
> which works by accident.
>
> Fixes: 0194e760f7d2 ("arm64: hibernate: avoid potential TLB conflict")
(That was a 'break before make' fix, the affected code comes from:
82869ac57b5d (""arm64: kernel: Add support for hibernate/suspend-to-disk))
But, it works in all one circumstances its used: we know all the top bits will be zero.
I agree its by accident and we should fix it.
I don't think we should send it to stable.
Please drop the fixes tag, with that:
Reviewed-by: James Morse <james.morse@arm.com>
Thanks,
James
[0] https://lore.kernel.org/linux-arm-kernel/ddd81093-89fc-5146-0b33-ad3bd9a1c10c@arm.com/
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: James Morse <james.morse@arm.com>
To: Pavel Tatashin <pasha.tatashin@soleen.com>
Cc: sashal@kernel.org, mark.rutland@arm.com, vladimir.murzin@arm.com,
corbet@lwn.net, marc.zyngier@arm.com, catalin.marinas@arm.com,
bhsharma@redhat.com, kexec@lists.infradead.org,
linux-kernel@vger.kernel.org, jmorris@namei.org,
linux-mm@kvack.org, ebiederm@xmission.com,
matthias.bgg@gmail.com, will@kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v6 02/17] arm64: hibernate: pass the allocated pgdp to ttbr0
Date: Fri, 11 Oct 2019 19:17:22 +0100 [thread overview]
Message-ID: <bb937db3-f23a-809b-4ad8-ca86f689554d@arm.com> (raw)
In-Reply-To: <20191004185234.31471-3-pasha.tatashin@soleen.com>
Hi Pavel,
On 04/10/2019 19:52, Pavel Tatashin wrote:
> ttbr0 should be set to the beginning of pgdp, however, currently
> in create_safe_exec_page it is set to pgdp after pgd_offset_raw(),
> which works by accident.
>
> Fixes: 0194e760f7d2 ("arm64: hibernate: avoid potential TLB conflict")
(That was a 'break before make' fix, the affected code comes from:
82869ac57b5d (""arm64: kernel: Add support for hibernate/suspend-to-disk))
But, it works in all one circumstances its used: we know all the top bits will be zero.
I agree its by accident and we should fix it.
I don't think we should send it to stable.
Please drop the fixes tag, with that:
Reviewed-by: James Morse <james.morse@arm.com>
Thanks,
James
[0] https://lore.kernel.org/linux-arm-kernel/ddd81093-89fc-5146-0b33-ad3bd9a1c10c@arm.com/
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2019-10-11 18:17 UTC|newest]
Thread overview: 93+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-04 18:52 [PATCH v6 00/17] arm64: MMU enabled kexec relocation Pavel Tatashin
2019-10-04 18:52 ` Pavel Tatashin
2019-10-04 18:52 ` Pavel Tatashin
2019-10-04 18:52 ` [PATCH v6 01/17] kexec: quiet down kexec reboot Pavel Tatashin
2019-10-04 18:52 ` Pavel Tatashin
2019-10-04 18:52 ` Pavel Tatashin
2019-10-04 18:52 ` [PATCH v6 02/17] arm64: hibernate: pass the allocated pgdp to ttbr0 Pavel Tatashin
2019-10-04 18:52 ` Pavel Tatashin
2019-10-04 18:52 ` Pavel Tatashin
2019-10-11 18:17 ` James Morse [this message]
2019-10-11 18:17 ` James Morse
2019-10-11 18:17 ` James Morse
2019-10-14 14:11 ` Pavel Tatashin
2019-10-14 14:11 ` Pavel Tatashin
2019-10-14 14:11 ` Pavel Tatashin
2019-10-04 18:52 ` [PATCH v6 03/17] arm64: hibernate: check pgd table allocation Pavel Tatashin
2019-10-04 18:52 ` Pavel Tatashin
2019-10-04 18:52 ` Pavel Tatashin
2019-10-11 18:17 ` James Morse
2019-10-11 18:17 ` James Morse
2019-10-11 18:17 ` James Morse
2019-10-14 14:51 ` Pavel Tatashin
2019-10-14 14:51 ` Pavel Tatashin
2019-10-14 14:51 ` Pavel Tatashin
2019-10-04 18:52 ` [PATCH v6 04/17] arm64: hibernate: use get_safe_page directly Pavel Tatashin
2019-10-04 18:52 ` Pavel Tatashin
2019-10-04 18:52 ` Pavel Tatashin
2019-10-04 18:52 ` [PATCH v6 05/17] arm64: hibernate: remove gotos as they are not needed Pavel Tatashin
2019-10-04 18:52 ` Pavel Tatashin
2019-10-04 18:52 ` Pavel Tatashin
2019-10-04 18:52 ` [PATCH v6 06/17] arm64: hibernate: rename dst to page in create_safe_exec_page Pavel Tatashin
2019-10-04 18:52 ` Pavel Tatashin
2019-10-04 18:52 ` Pavel Tatashin
2019-10-04 18:52 ` [PATCH v6 07/17] arm64: hibernate: add PUD_SECT_RDONLY Pavel Tatashin
2019-10-04 18:52 ` Pavel Tatashin
2019-10-04 18:52 ` Pavel Tatashin
2019-10-04 18:52 ` [PATCH v6 08/17] arm64: hibernate: add trans_pgd public functions Pavel Tatashin
2019-10-04 18:52 ` Pavel Tatashin
2019-10-04 18:52 ` Pavel Tatashin
2019-10-11 18:18 ` James Morse
2019-10-11 18:18 ` James Morse
2019-10-11 18:18 ` James Morse
2019-10-14 15:34 ` Pavel Tatashin
2019-10-14 15:34 ` Pavel Tatashin
2019-10-14 15:34 ` Pavel Tatashin
2019-10-04 18:52 ` [PATCH v6 09/17] arm64: hibernate: move page handling function to new trans_pgd.c Pavel Tatashin
2019-10-04 18:52 ` Pavel Tatashin
2019-10-04 18:52 ` Pavel Tatashin
2019-10-04 18:52 ` [PATCH v6 10/17] arm64: trans_pgd: make trans_pgd_map_page generic Pavel Tatashin
2019-10-04 18:52 ` Pavel Tatashin
2019-10-04 18:52 ` Pavel Tatashin
2019-10-04 18:52 ` [PATCH v6 11/17] arm64: trans_pgd: pass allocator trans_pgd_create_copy Pavel Tatashin
2019-10-04 18:52 ` Pavel Tatashin
2019-10-04 18:52 ` Pavel Tatashin
2019-10-04 18:52 ` [PATCH v6 12/17] arm64: trans_pgd: pass NULL instead of init_mm to *_populate functions Pavel Tatashin
2019-10-04 18:52 ` Pavel Tatashin
2019-10-04 18:52 ` Pavel Tatashin
2019-10-04 18:52 ` [PATCH v6 13/17] kexec: add machine_kexec_post_load() Pavel Tatashin
2019-10-04 18:52 ` Pavel Tatashin
2019-10-04 18:52 ` Pavel Tatashin
2019-10-04 18:52 ` [PATCH v6 14/17] arm64: kexec: move relocation function setup and clean up Pavel Tatashin
2019-10-04 18:52 ` Pavel Tatashin
2019-10-04 18:52 ` Pavel Tatashin
2019-10-11 18:19 ` James Morse
2019-10-11 18:19 ` James Morse
2019-10-11 18:19 ` James Morse
2019-10-14 19:29 ` Pavel Tatashin
2019-10-14 19:29 ` Pavel Tatashin
2019-10-14 19:29 ` Pavel Tatashin
2019-10-14 19:29 ` Pavel Tatashin
2019-10-04 18:52 ` [PATCH v6 15/17] arm64: kexec: add expandable argument to relocation function Pavel Tatashin
2019-10-04 18:52 ` Pavel Tatashin
2019-10-04 18:52 ` Pavel Tatashin
2019-10-11 18:19 ` James Morse
2019-10-11 18:19 ` James Morse
2019-10-11 18:19 ` James Morse
2019-10-14 23:35 ` Pavel Tatashin
2019-10-14 23:35 ` Pavel Tatashin
2019-10-14 23:35 ` Pavel Tatashin
2019-10-14 23:35 ` Pavel Tatashin
2019-10-04 18:52 ` [PATCH v6 16/17] arm64: kexec: configure trans_pgd page table for kexec Pavel Tatashin
2019-10-04 18:52 ` Pavel Tatashin
2019-10-04 18:52 ` Pavel Tatashin
2019-10-11 18:21 ` James Morse
2019-10-11 18:21 ` James Morse
2019-10-11 18:21 ` James Morse
2019-10-15 2:12 ` Pavel Tatashin
2019-10-15 2:12 ` Pavel Tatashin
2019-10-15 2:12 ` Pavel Tatashin
2019-10-15 2:12 ` Pavel Tatashin
2019-10-04 18:52 ` [PATCH v6 17/17] arm64: kexec: enable MMU during kexec relocation Pavel Tatashin
2019-10-04 18:52 ` Pavel Tatashin
2019-10-04 18:52 ` Pavel Tatashin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bb937db3-f23a-809b-4ad8-ca86f689554d@arm.com \
--to=james.morse@arm.com \
--cc=bhsharma@redhat.com \
--cc=catalin.marinas@arm.com \
--cc=corbet@lwn.net \
--cc=ebiederm@xmission.com \
--cc=jmorris@namei.org \
--cc=kexec@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=marc.zyngier@arm.com \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=pasha.tatashin@soleen.com \
--cc=sashal@kernel.org \
--cc=vladimir.murzin@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.