From: Giulio Benetti <giulio.benetti@micronovasrl.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 02/12] package/atop: fix BUG_85180 build timeout
Date: Wed, 22 May 2019 23:27:22 +0200 [thread overview]
Message-ID: <bb93c490-20ef-c57f-9f2c-94a8839d99ad@micronovasrl.com> (raw)
In-Reply-To: <20190522230752.6ee8fc34@windsurf.home>
Hello,
Il 22/05/2019 23:07, Thomas Petazzoni ha scritto:
> Hello Giulio,
>
> On Tue, 21 May 2019 15:39:22 +0200
> Giulio Benetti <giulio.benetti@micronovasrl.com> wrote:
>
>> With Microblaze Gcc version < 8.x build hangs on compiling last files
>> before linking. This is due to bug 85180:
>> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85180
>> Bug shows up building atop with optimization but not when building with
>> -O0.
>>
>> If BR2_TOOLCHAIN_HAS_GCC_BUG_85180=y force using -O0 passing it to
>> CFLAGS.
>>
>> Fixes:
>> http://autobuild.buildroot.net/results/94a/94aa00f776b8a3491ac0b3212c95f5e666c5a29a/
>>
>> Signed-off-by: Giulio Benetti <giulio.benetti@micronovasrl.com>
>
> I have applied to master after reworking the commit title and commit
> log,
Again... Need to improve commit logs.
> and also adjusting the code a bit (see below).
>
>> diff --git a/package/atop/atop.mk b/package/atop/atop.mk
>> index aaf02908c4..afce71f6cb 100644
>> --- a/package/atop/atop.mk
>> +++ b/package/atop/atop.mk
>> @@ -10,8 +10,13 @@ ATOP_LICENSE = GPL-2.0+
>> ATOP_LICENSE_FILES = COPYING
>> ATOP_DEPENDENCIES = ncurses zlib
>>
>> +ifeq ($(BR2_TOOLCHAIN_HAS_GCC_BUG_85180),y)
>> +ATOP_CFLAGS += $(TARGET_CFLAGS) -O0
>> +endif
>
> I believe:
>
> ATOP_CFLAGS = $(TARGET_CFLAGS)
>
> ifeq ($(BR2_TOOLCHAIN_HAS_GCC_BUG_85180),y)
> ATOP_CFLAGS += -O0
> endif
>
> is more correct, otherwise you pass an empty CFLAGS when
> BR2_TOOLCHAIN_HAS_GCC_BUG_85180 is false.
Yes totally right. Then I need to modify other patches for
$(generic-package) packages as well as their commit logs at this point.
>
>> +
>> define ATOP_BUILD_CMDS
>> - $(MAKE) $(TARGET_CONFIGURE_OPTS) -C $(@D)
>> + $(MAKE) $(TARGET_CONFIGURE_OPTS) CFLAGS="$(ATOP_CFLAGS)" \
>> + -C $(@D)
>
> The second line is typically indented with one more tab.
Ok. I've never noticed it. Thanks for pointing.
Best regards!
--
Giulio Benetti
CTO
MICRONOVA SRL
Sede: Via A. Niedda 3 - 35010 Vigonza (PD)
Tel. 049/8931563 - Fax 049/8931346
Cod.Fiscale - P.IVA 02663420285
Capitale Sociale ? 26.000 i.v.
Iscritta al Reg. Imprese di Padova N. 02663420285
Numero R.E.A. 258642
> As I said, I've applied to master after fixing those issues.
>
> Thanks!
>
> Thomas
>
next prev parent reply other threads:[~2019-05-22 21:27 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-21 13:39 [Buildroot] [PATCH v2 00/12] Fix GCC BUG 85180 per-package Giulio Benetti
2019-05-21 13:39 ` [Buildroot] [PATCH v2 01/12] toolchain: specify GCC_BUG_85180 is true only if GCC version < 8.x Giulio Benetti
2019-05-22 20:52 ` Thomas Petazzoni
2019-05-22 21:23 ` Giulio Benetti
2019-06-06 12:46 ` Peter Korsgaard
2019-05-21 13:39 ` [Buildroot] [PATCH v2 02/12] package/atop: fix BUG_85180 build timeout Giulio Benetti
2019-05-22 21:07 ` Thomas Petazzoni
2019-05-22 21:27 ` Giulio Benetti [this message]
2019-06-06 12:45 ` Peter Korsgaard
2019-05-21 13:39 ` [Buildroot] [PATCH v2 03/12] package/chocolate-doom: " Giulio Benetti
2019-05-24 19:58 ` Thomas Petazzoni
2019-06-06 15:05 ` Peter Korsgaard
2019-05-21 13:39 ` [Buildroot] [PATCH v2 04/12] package/ddrescue: " Giulio Benetti
2019-05-24 19:58 ` Thomas Petazzoni
2019-06-06 15:05 ` Peter Korsgaard
2019-05-21 13:39 ` [Buildroot] [PATCH v2 05/12] package/flare-engine: " Giulio Benetti
2019-05-24 19:58 ` Thomas Petazzoni
2019-05-24 20:05 ` Giulio Benetti
2019-05-24 20:30 ` Thomas Petazzoni
2019-05-27 17:20 ` Giulio Benetti
2019-05-27 21:03 ` Arnout Vandecappelle
2019-05-27 21:44 ` Arnout Vandecappelle
2019-05-27 21:45 ` Giulio Benetti
2019-05-21 13:39 ` [Buildroot] [PATCH v2 06/12] package/glibmm: " Giulio Benetti
2019-05-24 19:59 ` Thomas Petazzoni
2019-06-06 15:05 ` Peter Korsgaard
2019-05-21 13:39 ` [Buildroot] [PATCH v2 07/12] package/gst-ffmpeg: re-enable package if BUG_85180 is present Giulio Benetti
2019-05-24 20:17 ` Thomas Petazzoni
2019-06-06 15:05 ` Peter Korsgaard
2019-05-21 13:39 ` [Buildroot] [PATCH v2 08/12] package/jasper: fix BUG_85180 build timeout Giulio Benetti
2019-05-24 19:59 ` Thomas Petazzoni
2019-06-06 15:04 ` Peter Korsgaard
2019-05-21 13:39 ` [Buildroot] [PATCH v2 09/12] package/kismet: " Giulio Benetti
2019-05-24 19:59 ` Thomas Petazzoni
2019-06-06 15:04 ` Peter Korsgaard
2019-05-21 13:39 ` [Buildroot] [PATCH v2 10/12] package/libcpprestsdk: " Giulio Benetti
2019-05-24 20:03 ` Thomas Petazzoni
2019-05-24 20:07 ` Giulio Benetti
2019-05-21 13:39 ` [Buildroot] [PATCH v2 11/12] package/opus: " Giulio Benetti
2019-05-24 20:07 ` Thomas Petazzoni
2019-06-06 15:04 ` Peter Korsgaard
2019-05-21 13:39 ` [Buildroot] [PATCH v2 12/12] package/postgresql: " Giulio Benetti
2019-05-24 20:09 ` Thomas Petazzoni
2019-06-06 15:04 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bb93c490-20ef-c57f-9f2c-94a8839d99ad@micronovasrl.com \
--to=giulio.benetti@micronovasrl.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.