All of lore.kernel.org
 help / color / mirror / Atom feed
From: Giulio Benetti <giulio.benetti@micronovasrl.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 05/12] package/flare-engine: fix BUG_85180 build timeout
Date: Mon, 27 May 2019 23:45:11 +0200	[thread overview]
Message-ID: <d25427ff-e5d8-39a6-b836-1fae61e25c6d@micronovasrl.com> (raw)
In-Reply-To: <63837120-fdd2-b32f-89e8-e43cc53d420e@mind.be>

Il 27/05/2019 23:44, Arnout Vandecappelle ha scritto:
> 
> 
> On 27/05/2019 23:03, Arnout Vandecappelle wrote:
>>
>>
>> On 27/05/2019 19:20, Giulio Benetti wrote:
>>> Hello Thomas,
>>>
>>> Il 24/05/2019 22:30, Thomas Petazzoni ha scritto:
>>>> On Fri, 24 May 2019 22:05:12 +0200
>>>> Giulio Benetti <giulio.benetti@micronovasrl.com> wrote:
>>>>
>>>>>> Why does flare-engine need this, but not jasper, which is also a
>>>>>> CMake-based package ?
>>>>>
>>>>> Because in flare-engine CMakeLists.txt there is no fallback to -O0, so
>>>>> that was the only decent way to force CMake to generate Makefiles
>>>>> without optimizations.
>>>>
>>>> Could you be more specific ? How does it work for jasper and
>>>> libcpprestsdk, which are also based on CMake ?
>>>
>>> Yes, the problem here is that even if there's the way to append something to
>>> CMAKE_CXX_FLAGS, then any other CMAKE_CXX_FLAGS_* will be appended, so if I set
>>> CMAKE_CXX_FLAGS to -O0, I will obtain "-O0 -O2 -g".
>>>
>>> This is due to the fact that we fall into one of the cases of the next if-elseif
>>> statements(in CMakeLists.txt):
>>> "
>>> if(CMAKE_BUILD_TYPE STREQUAL "Release")
>>>  ? set(CMAKE_CXX_FLAGS_RELEASE "-O2 -g0")
>>
>>   Note that you could also get away without overriding CMAKE_BUILD_TYPE, and just
>> setting CMAKE_CXX_FLAGS_RELEASE. Definitions passed on the command line will
>> override the ones in CMakeFiles.txt (at least, I think so...).
>>
>>   However, since we now still set CMAKE_BUILD_TYPE based on BR2_ENABLE_DEBUG,
>> that won't work :-(
> 
>   Because of this (and because we can't wait for CMake refactoring), I've
> improved the comment in the .mk file a little and also rewrote the commit log
> based on what Thomas wrote for the other commits, and applied to master, thanks.

Thank you instead!

Best regards
-- 
Giulio Benetti
CTO

MICRONOVA SRL
Sede: Via A. Niedda 3 - 35010 Vigonza (PD)
Tel. 049/8931563 - Fax 049/8931346
Cod.Fiscale - P.IVA 02663420285
Capitale Sociale ? 26.000 i.v.
Iscritta al Reg. Imprese di Padova N. 02663420285
Numero R.E.A. 258642

  reply	other threads:[~2019-05-27 21:45 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-21 13:39 [Buildroot] [PATCH v2 00/12] Fix GCC BUG 85180 per-package Giulio Benetti
2019-05-21 13:39 ` [Buildroot] [PATCH v2 01/12] toolchain: specify GCC_BUG_85180 is true only if GCC version < 8.x Giulio Benetti
2019-05-22 20:52   ` Thomas Petazzoni
2019-05-22 21:23     ` Giulio Benetti
2019-06-06 12:46   ` Peter Korsgaard
2019-05-21 13:39 ` [Buildroot] [PATCH v2 02/12] package/atop: fix BUG_85180 build timeout Giulio Benetti
2019-05-22 21:07   ` Thomas Petazzoni
2019-05-22 21:27     ` Giulio Benetti
2019-06-06 12:45   ` Peter Korsgaard
2019-05-21 13:39 ` [Buildroot] [PATCH v2 03/12] package/chocolate-doom: " Giulio Benetti
2019-05-24 19:58   ` Thomas Petazzoni
2019-06-06 15:05   ` Peter Korsgaard
2019-05-21 13:39 ` [Buildroot] [PATCH v2 04/12] package/ddrescue: " Giulio Benetti
2019-05-24 19:58   ` Thomas Petazzoni
2019-06-06 15:05   ` Peter Korsgaard
2019-05-21 13:39 ` [Buildroot] [PATCH v2 05/12] package/flare-engine: " Giulio Benetti
2019-05-24 19:58   ` Thomas Petazzoni
2019-05-24 20:05     ` Giulio Benetti
2019-05-24 20:30       ` Thomas Petazzoni
2019-05-27 17:20         ` Giulio Benetti
2019-05-27 21:03           ` Arnout Vandecappelle
2019-05-27 21:44             ` Arnout Vandecappelle
2019-05-27 21:45               ` Giulio Benetti [this message]
2019-05-21 13:39 ` [Buildroot] [PATCH v2 06/12] package/glibmm: " Giulio Benetti
2019-05-24 19:59   ` Thomas Petazzoni
2019-06-06 15:05   ` Peter Korsgaard
2019-05-21 13:39 ` [Buildroot] [PATCH v2 07/12] package/gst-ffmpeg: re-enable package if BUG_85180 is present Giulio Benetti
2019-05-24 20:17   ` Thomas Petazzoni
2019-06-06 15:05   ` Peter Korsgaard
2019-05-21 13:39 ` [Buildroot] [PATCH v2 08/12] package/jasper: fix BUG_85180 build timeout Giulio Benetti
2019-05-24 19:59   ` Thomas Petazzoni
2019-06-06 15:04   ` Peter Korsgaard
2019-05-21 13:39 ` [Buildroot] [PATCH v2 09/12] package/kismet: " Giulio Benetti
2019-05-24 19:59   ` Thomas Petazzoni
2019-06-06 15:04   ` Peter Korsgaard
2019-05-21 13:39 ` [Buildroot] [PATCH v2 10/12] package/libcpprestsdk: " Giulio Benetti
2019-05-24 20:03   ` Thomas Petazzoni
2019-05-24 20:07     ` Giulio Benetti
2019-05-21 13:39 ` [Buildroot] [PATCH v2 11/12] package/opus: " Giulio Benetti
2019-05-24 20:07   ` Thomas Petazzoni
2019-06-06 15:04   ` Peter Korsgaard
2019-05-21 13:39 ` [Buildroot] [PATCH v2 12/12] package/postgresql: " Giulio Benetti
2019-05-24 20:09   ` Thomas Petazzoni
2019-06-06 15:04   ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d25427ff-e5d8-39a6-b836-1fae61e25c6d@micronovasrl.com \
    --to=giulio.benetti@micronovasrl.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.