* [PATCH] xen: Add missing space in append to IMAGE_INSTALL
@ 2022-04-22 16:18 Bertrand Marquis
2022-04-22 17:04 ` [meta-virtualization] " Christopher Clark
2022-04-27 3:04 ` Bruce Ashfield
0 siblings, 2 replies; 3+ messages in thread
From: Bertrand Marquis @ 2022-04-22 16:18 UTC (permalink / raw)
To: meta-virtualization; +Cc: nd
Add a space before doing an append in IMAGE_INSTALL on x86.
This is solving issues happening if someone is using IMAGE_INSTALL in
local.conf to add things to the generated image.
Signed-off-by: Bertrand Marquis <bertrand.marquis@arm.com>
---
recipes-extended/images/xen-image-minimal.bb | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/recipes-extended/images/xen-image-minimal.bb b/recipes-extended/images/xen-image-minimal.bb
index f6fa5ed..3cf4230 100644
--- a/recipes-extended/images/xen-image-minimal.bb
+++ b/recipes-extended/images/xen-image-minimal.bb
@@ -21,8 +21,8 @@ IMAGE_INSTALL += " \
do_build[depends] += "xen:do_deploy"
# Networking for HVM-mode guests (x86/64 only) requires the tun kernel module
-IMAGE_INSTALL:append:x86 = "kernel-module-tun"
-IMAGE_INSTALL:append:x86-64 = "kernel-module-tun"
+IMAGE_INSTALL:append:x86 = " kernel-module-tun"
+IMAGE_INSTALL:append:x86-64 = " kernel-module-tun"
# Linux kernel option CONFIG_XEN_PCIDEV_BACKEND depends on X86
XEN_PCIBACK_MODULE = ""
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [meta-virtualization] [PATCH] xen: Add missing space in append to IMAGE_INSTALL
2022-04-22 16:18 [PATCH] xen: Add missing space in append to IMAGE_INSTALL Bertrand Marquis
@ 2022-04-22 17:04 ` Christopher Clark
2022-04-27 3:04 ` Bruce Ashfield
1 sibling, 0 replies; 3+ messages in thread
From: Christopher Clark @ 2022-04-22 17:04 UTC (permalink / raw)
To: Bertrand Marquis; +Cc: meta-virtualization, nd
On Fri, Apr 22, 2022 at 9:19 AM Bertrand Marquis
<bertrand.marquis@arm.com> wrote:
>
> Add a space before doing an append in IMAGE_INSTALL on x86.
> This is solving issues happening if someone is using IMAGE_INSTALL in
> local.conf to add things to the generated image.
Thanks, Bertrand.
> Signed-off-by: Bertrand Marquis <bertrand.marquis@arm.com>
Reviewed-by: Christopher Clark <christopher.w.clark@gmail.com>
Christopher
> ---
> recipes-extended/images/xen-image-minimal.bb | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/recipes-extended/images/xen-image-minimal.bb b/recipes-extended/images/xen-image-minimal.bb
> index f6fa5ed..3cf4230 100644
> --- a/recipes-extended/images/xen-image-minimal.bb
> +++ b/recipes-extended/images/xen-image-minimal.bb
> @@ -21,8 +21,8 @@ IMAGE_INSTALL += " \
> do_build[depends] += "xen:do_deploy"
>
> # Networking for HVM-mode guests (x86/64 only) requires the tun kernel module
> -IMAGE_INSTALL:append:x86 = "kernel-module-tun"
> -IMAGE_INSTALL:append:x86-64 = "kernel-module-tun"
> +IMAGE_INSTALL:append:x86 = " kernel-module-tun"
> +IMAGE_INSTALL:append:x86-64 = " kernel-module-tun"
>
> # Linux kernel option CONFIG_XEN_PCIDEV_BACKEND depends on X86
> XEN_PCIBACK_MODULE = ""
> --
> 2.25.1
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#7211): https://lists.yoctoproject.org/g/meta-virtualization/message/7211
> Mute This Topic: https://lists.yoctoproject.org/mt/90631753/3619036
> Group Owner: meta-virtualization+owner@lists.yoctoproject.org
> Unsubscribe: https://lists.yoctoproject.org/g/meta-virtualization/unsub [christopher.w.clark+meta-virt@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [meta-virtualization] [PATCH] xen: Add missing space in append to IMAGE_INSTALL
2022-04-22 16:18 [PATCH] xen: Add missing space in append to IMAGE_INSTALL Bertrand Marquis
2022-04-22 17:04 ` [meta-virtualization] " Christopher Clark
@ 2022-04-27 3:04 ` Bruce Ashfield
1 sibling, 0 replies; 3+ messages in thread
From: Bruce Ashfield @ 2022-04-27 3:04 UTC (permalink / raw)
To: Bertrand Marquis; +Cc: meta-virtualization, nd
merged.
Bruce
In message: [meta-virtualization] [PATCH] xen: Add missing space in append to IMAGE_INSTALL
on 22/04/2022 Bertrand Marquis wrote:
> Add a space before doing an append in IMAGE_INSTALL on x86.
> This is solving issues happening if someone is using IMAGE_INSTALL in
> local.conf to add things to the generated image.
>
> Signed-off-by: Bertrand Marquis <bertrand.marquis@arm.com>
> ---
> recipes-extended/images/xen-image-minimal.bb | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/recipes-extended/images/xen-image-minimal.bb b/recipes-extended/images/xen-image-minimal.bb
> index f6fa5ed..3cf4230 100644
> --- a/recipes-extended/images/xen-image-minimal.bb
> +++ b/recipes-extended/images/xen-image-minimal.bb
> @@ -21,8 +21,8 @@ IMAGE_INSTALL += " \
> do_build[depends] += "xen:do_deploy"
>
> # Networking for HVM-mode guests (x86/64 only) requires the tun kernel module
> -IMAGE_INSTALL:append:x86 = "kernel-module-tun"
> -IMAGE_INSTALL:append:x86-64 = "kernel-module-tun"
> +IMAGE_INSTALL:append:x86 = " kernel-module-tun"
> +IMAGE_INSTALL:append:x86-64 = " kernel-module-tun"
>
> # Linux kernel option CONFIG_XEN_PCIDEV_BACKEND depends on X86
> XEN_PCIBACK_MODULE = ""
> --
> 2.25.1
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#7211): https://lists.yoctoproject.org/g/meta-virtualization/message/7211
> Mute This Topic: https://lists.yoctoproject.org/mt/90631753/1050810
> Group Owner: meta-virtualization+owner@lists.yoctoproject.org
> Unsubscribe: https://lists.yoctoproject.org/g/meta-virtualization/unsub [bruce.ashfield@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-04-27 3:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-22 16:18 [PATCH] xen: Add missing space in append to IMAGE_INSTALL Bertrand Marquis
2022-04-22 17:04 ` [meta-virtualization] " Christopher Clark
2022-04-27 3:04 ` Bruce Ashfield
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.