From: Neil Armstrong <narmstrong@baylibre.com>
To: Fabio Estevam <festevam@gmail.com>
Cc: Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <kernel@pengutronix.de>,
Fabio Estevam <fabio.estevam@nxp.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2 4/6] ARM: dts: imx6qdl: Add Variscite DART-MX6 SoM support
Date: Fri, 24 Nov 2017 15:41:13 +0100 [thread overview]
Message-ID: <bbbd71e2-eb31-4d43-7dfc-0ef817c5e13e@baylibre.com> (raw)
In-Reply-To: <CAOMZO5CuxBsMv1zabi3JtYyX0wNpv1rZZmZG28BBfo9a155siQ@mail.gmail.com>
Hi Fabio,
On 24/11/2017 15:31, Fabio Estevam wrote:
> On Wed, Nov 22, 2017 at 9:02 AM, Neil Armstrong <narmstrong@baylibre.com> wrote:
>
>> + reg_wl18xx_vmmc: regulator-wl18xx {
>> + compatible = "regulator-fixed";
>> + regulator-name = "vwl1807";
>> + regulator-min-microvolt = <1800000>;
>> + regulator-max-microvolt = <1800000>;
>> + gpio = <&gpio7 8 GPIO_ACTIVE_HIGH>;
>
> Is this really GPIO_ACTIVE_HIGH?
>
> If so, then a 'enable-active-high' property would be needed.
Indeed, it's quite redundant with the GPIO_ACTIVE_* flag, but whatever.
>
>> +&hdmi {
>
> No ddc-i2c-bus property?
It's in the board dts.
>
>> + pinctrl_pmic: pmicgrp {
>> + fsl,pins = <
>> + /* PMIC INT */
>> + MX6QDL_PAD_GPIO_17__GPIO7_IO12 0x80000000
>
> No 0x80000000 please. Use the real IOMUX value here instead.
Ok
>
>> +&pcie {
>> + fsl,tx-swing-full = <103>;
>> + fsl,tx-swing-low = <103>;
>> + status = "disabled";
>
> No 'reset-gpio' property?
>
It will be in the board dts.
Neil
WARNING: multiple messages have this Message-ID (diff)
From: narmstrong@baylibre.com (Neil Armstrong)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 4/6] ARM: dts: imx6qdl: Add Variscite DART-MX6 SoM support
Date: Fri, 24 Nov 2017 15:41:13 +0100 [thread overview]
Message-ID: <bbbd71e2-eb31-4d43-7dfc-0ef817c5e13e@baylibre.com> (raw)
In-Reply-To: <CAOMZO5CuxBsMv1zabi3JtYyX0wNpv1rZZmZG28BBfo9a155siQ@mail.gmail.com>
Hi Fabio,
On 24/11/2017 15:31, Fabio Estevam wrote:
> On Wed, Nov 22, 2017 at 9:02 AM, Neil Armstrong <narmstrong@baylibre.com> wrote:
>
>> + reg_wl18xx_vmmc: regulator-wl18xx {
>> + compatible = "regulator-fixed";
>> + regulator-name = "vwl1807";
>> + regulator-min-microvolt = <1800000>;
>> + regulator-max-microvolt = <1800000>;
>> + gpio = <&gpio7 8 GPIO_ACTIVE_HIGH>;
>
> Is this really GPIO_ACTIVE_HIGH?
>
> If so, then a 'enable-active-high' property would be needed.
Indeed, it's quite redundant with the GPIO_ACTIVE_* flag, but whatever.
>
>> +&hdmi {
>
> No ddc-i2c-bus property?
It's in the board dts.
>
>> + pinctrl_pmic: pmicgrp {
>> + fsl,pins = <
>> + /* PMIC INT */
>> + MX6QDL_PAD_GPIO_17__GPIO7_IO12 0x80000000
>
> No 0x80000000 please. Use the real IOMUX value here instead.
Ok
>
>> +&pcie {
>> + fsl,tx-swing-full = <103>;
>> + fsl,tx-swing-low = <103>;
>> + status = "disabled";
>
> No 'reset-gpio' property?
>
It will be in the board dts.
Neil
next prev parent reply other threads:[~2017-11-24 14:41 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-22 11:02 [PATCH v2 0/6] ARM: Add Variscite DART-MX6 SoM and Carrier-board support Neil Armstrong
2017-11-22 11:02 ` Neil Armstrong
2017-11-22 11:02 ` [PATCH v2 1/6] ARM: dts: imx6qdl-pinfunc: Add missing MX6QDL_PAD_ENET_RXD0__OSC32K_32K_OUT Neil Armstrong
2017-11-22 11:02 ` Neil Armstrong
2017-11-22 11:02 ` [PATCH v2 2/6] dt-bindings: Add vendor prefix for Solomon Goldentek Display Corporation Neil Armstrong
2017-11-22 11:02 ` Neil Armstrong
2017-11-26 18:58 ` Rob Herring
2017-11-26 18:58 ` Rob Herring
2017-11-26 18:58 ` Rob Herring
2017-11-22 11:02 ` [PATCH v2 3/6] devicetree/bindings: display: Add bindings for SGD GKTW70SDAE4SE Panel Neil Armstrong
2017-11-22 11:02 ` Neil Armstrong
2017-11-26 19:00 ` Rob Herring
2017-11-26 19:00 ` Rob Herring
2017-11-26 19:00 ` Rob Herring
2017-11-22 11:02 ` [PATCH v2 4/6] ARM: dts: imx6qdl: Add Variscite DART-MX6 SoM support Neil Armstrong
2017-11-22 11:02 ` Neil Armstrong
2017-11-24 14:31 ` Fabio Estevam
2017-11-24 14:31 ` Fabio Estevam
2017-11-24 14:41 ` Neil Armstrong [this message]
2017-11-24 14:41 ` Neil Armstrong
2017-11-24 14:44 ` Fabio Estevam
2017-11-24 14:44 ` Fabio Estevam
2017-11-24 14:46 ` Neil Armstrong
2017-11-24 14:46 ` Neil Armstrong
2017-11-22 11:02 ` [PATCH v2 5/6] ARM: dts: imx6q: Add Variscite DART-MX6 Carrier-board support Neil Armstrong
2017-11-22 11:02 ` Neil Armstrong
2017-11-24 14:33 ` Fabio Estevam
2017-11-24 14:33 ` Fabio Estevam
2017-11-24 14:41 ` Neil Armstrong
2017-11-24 14:41 ` Neil Armstrong
2017-11-22 11:02 ` [PATCH v2 6/6] ARM: configs: Add missing config for DART-MX6 SoM Neil Armstrong
2017-11-22 11:02 ` Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bbbd71e2-eb31-4d43-7dfc-0ef817c5e13e@baylibre.com \
--to=narmstrong@baylibre.com \
--cc=fabio.estevam@nxp.com \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.