All of lore.kernel.org
 help / color / mirror / Atom feed
From: John Hubbard <jhubbard@nvidia.com>
To: Matthew Wilcox <willy@infradead.org>,
	Alistair Popple <apopple@nvidia.com>
Cc: <linux-mm@kvack.org>, Andrew Morton <akpm@linux-foundation.org>,
	"Ralph Campbell" <rcampbell@nvidia.com>,
	<nouveau@lists.freedesktop.org>, <stable@vger.kernel.org>
Subject: Re: [PATCH] mm: Take a page reference when removing device exclusive entries
Date: Tue, 28 Mar 2023 20:45:15 -0700	[thread overview]
Message-ID: <bbc8bc42-5f2a-9238-94e9-b2191e2f8c7e@nvidia.com> (raw)
In-Reply-To: <ZCOtiZFoxC6w/eoZ@casper.infradead.org>

On 3/28/23 20:16, Matthew Wilcox wrote:
...
>> +	if (!get_page_unless_zero(vmf->page))
>> +		return 0;
> 
>  From a folio point of view: what the hell are you doing here?  Tail
> pages don't have individual refcounts; all the refcounts are actually

ohh, and I really should have caught that too. I plead spending too much
time recently in a somewhat more driver-centric mindset, and failing to
mentally shift gears properly for this case.

Sorry for missing that!

thanks,
-- 
John Hubbard
NVIDIA


WARNING: multiple messages have this Message-ID (diff)
From: John Hubbard <jhubbard@nvidia.com>
To: Matthew Wilcox <willy@infradead.org>,
	Alistair Popple <apopple@nvidia.com>
Cc: linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org>,
	Ralph Campbell <rcampbell@nvidia.com>,
	stable@vger.kernel.org, nouveau@lists.freedesktop.org
Subject: Re: [Nouveau] [PATCH] mm: Take a page reference when removing device exclusive entries
Date: Tue, 28 Mar 2023 20:45:15 -0700	[thread overview]
Message-ID: <bbc8bc42-5f2a-9238-94e9-b2191e2f8c7e@nvidia.com> (raw)
In-Reply-To: <ZCOtiZFoxC6w/eoZ@casper.infradead.org>

On 3/28/23 20:16, Matthew Wilcox wrote:
...
>> +	if (!get_page_unless_zero(vmf->page))
>> +		return 0;
> 
>  From a folio point of view: what the hell are you doing here?  Tail
> pages don't have individual refcounts; all the refcounts are actually

ohh, and I really should have caught that too. I plead spending too much
time recently in a somewhat more driver-centric mindset, and failing to
mentally shift gears properly for this case.

Sorry for missing that!

thanks,
-- 
John Hubbard
NVIDIA


  reply	other threads:[~2023-03-29  3:45 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-28  2:14 [PATCH] mm: Take a page reference when removing device exclusive entries Alistair Popple
2023-03-28  2:14 ` [Nouveau] " Alistair Popple
2023-03-28  6:25 ` John Hubbard
2023-03-28  6:25   ` [Nouveau] " John Hubbard
2023-03-28 19:55   ` Andrew Morton
2023-03-28 19:55     ` [Nouveau] " Andrew Morton
2023-03-29  1:45     ` Alistair Popple
2023-03-29  1:45       ` [Nouveau] " Alistair Popple
2023-03-28 19:59 ` Ralph Campbell
2023-03-28 19:59   ` Ralph Campbell
2023-03-29  3:16 ` Matthew Wilcox
2023-03-29  3:16   ` [Nouveau] " Matthew Wilcox
2023-03-29  3:45   ` John Hubbard [this message]
2023-03-29  3:45     ` John Hubbard
2023-03-30  0:26     ` Alistair Popple
2023-03-30  0:26       ` [Nouveau] " Alistair Popple
2023-03-30  0:55       ` Alistair Popple
2023-03-30  0:55         ` [Nouveau] " Alistair Popple

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bbc8bc42-5f2a-9238-94e9-b2191e2f8c7e@nvidia.com \
    --to=jhubbard@nvidia.com \
    --cc=akpm@linux-foundation.org \
    --cc=apopple@nvidia.com \
    --cc=linux-mm@kvack.org \
    --cc=nouveau@lists.freedesktop.org \
    --cc=rcampbell@nvidia.com \
    --cc=stable@vger.kernel.org \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.