* [PATCH 0/1] mfd: axp20x-i2c: Add i2c-ids to fix module auto-loading
@ 2016-10-05 15:51 ` Hans de Goede
0 siblings, 0 replies; 24+ messages in thread
From: Hans de Goede @ 2016-10-05 15:51 UTC (permalink / raw)
To: Lee Jones, Sebastian Reichel
Cc: Dennis Gilmore, Maxime Ripard, Chen-Yu Tsai, linux-pm, linux-arm-kernel
Hi all,
Dennis Gilmore (in the Cc) reports that axp20x-i2c does not auto-load
on e.g. the CHIP. I believe this is caused by the i2c-ids table not being
populated.
I believe the patch in the next mail should fix this.
Regards,
Hans
^ permalink raw reply [flat|nested] 24+ messages in thread
* [PATCH 0/1] mfd: axp20x-i2c: Add i2c-ids to fix module auto-loading
@ 2016-10-05 15:51 ` Hans de Goede
0 siblings, 0 replies; 24+ messages in thread
From: Hans de Goede @ 2016-10-05 15:51 UTC (permalink / raw)
To: linux-arm-kernel
Hi all,
Dennis Gilmore (in the Cc) reports that axp20x-i2c does not auto-load
on e.g. the CHIP. I believe this is caused by the i2c-ids table not being
populated.
I believe the patch in the next mail should fix this.
Regards,
Hans
^ permalink raw reply [flat|nested] 24+ messages in thread
* [PATCH] mfd: axp20x-i2c: Add i2c-ids to fix module auto-loading
2016-10-05 15:51 ` Hans de Goede
@ 2016-10-05 15:51 ` Hans de Goede
-1 siblings, 0 replies; 24+ messages in thread
From: Hans de Goede @ 2016-10-05 15:51 UTC (permalink / raw)
To: Lee Jones, Sebastian Reichel
Cc: Dennis Gilmore, Maxime Ripard, Chen-Yu Tsai, linux-pm,
linux-arm-kernel, Hans de Goede
The i2c subsys does not load modules by compatible, only by
i2c-id, with e.g. a modalias of: "i2c:axp209".
Populate the axp20x_i2c_id[] table with supported ids, so that
module auto-loading will work.
Reported-by: Dennis Gilmore <dennis@ausil.us>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
drivers/mfd/axp20x-i2c.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/mfd/axp20x-i2c.c b/drivers/mfd/axp20x-i2c.c
index b1b8658..d35a5fe 100644
--- a/drivers/mfd/axp20x-i2c.c
+++ b/drivers/mfd/axp20x-i2c.c
@@ -69,10 +69,11 @@ static const struct of_device_id axp20x_i2c_of_match[] = {
};
MODULE_DEVICE_TABLE(of, axp20x_i2c_of_match);
-/*
- * This is useless for OF-enabled devices, but it is needed by I2C subsystem
- */
static const struct i2c_device_id axp20x_i2c_id[] = {
+ { "axp152", 0 },
+ { "axp202", 0 },
+ { "axp209", 0 },
+ { "axp221", 0 },
{ },
};
MODULE_DEVICE_TABLE(i2c, axp20x_i2c_id);
--
2.9.3
^ permalink raw reply related [flat|nested] 24+ messages in thread
* [PATCH] mfd: axp20x-i2c: Add i2c-ids to fix module auto-loading
@ 2016-10-05 15:51 ` Hans de Goede
0 siblings, 0 replies; 24+ messages in thread
From: Hans de Goede @ 2016-10-05 15:51 UTC (permalink / raw)
To: linux-arm-kernel
The i2c subsys does not load modules by compatible, only by
i2c-id, with e.g. a modalias of: "i2c:axp209".
Populate the axp20x_i2c_id[] table with supported ids, so that
module auto-loading will work.
Reported-by: Dennis Gilmore <dennis@ausil.us>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
drivers/mfd/axp20x-i2c.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/mfd/axp20x-i2c.c b/drivers/mfd/axp20x-i2c.c
index b1b8658..d35a5fe 100644
--- a/drivers/mfd/axp20x-i2c.c
+++ b/drivers/mfd/axp20x-i2c.c
@@ -69,10 +69,11 @@ static const struct of_device_id axp20x_i2c_of_match[] = {
};
MODULE_DEVICE_TABLE(of, axp20x_i2c_of_match);
-/*
- * This is useless for OF-enabled devices, but it is needed by I2C subsystem
- */
static const struct i2c_device_id axp20x_i2c_id[] = {
+ { "axp152", 0 },
+ { "axp202", 0 },
+ { "axp209", 0 },
+ { "axp221", 0 },
{ },
};
MODULE_DEVICE_TABLE(i2c, axp20x_i2c_id);
--
2.9.3
^ permalink raw reply related [flat|nested] 24+ messages in thread
* Re: [PATCH] mfd: axp20x-i2c: Add i2c-ids to fix module auto-loading
2016-10-05 15:51 ` Hans de Goede
@ 2016-10-18 5:25 ` Chen-Yu Tsai
-1 siblings, 0 replies; 24+ messages in thread
From: Chen-Yu Tsai @ 2016-10-18 5:25 UTC (permalink / raw)
To: Hans de Goede
Cc: Lee Jones, Sebastian Reichel, Dennis Gilmore, Maxime Ripard,
Chen-Yu Tsai, open list:THERMAL, linux-arm-kernel, Wolfram Sang,
linux-i2c
On Wed, Oct 5, 2016 at 11:51 PM, Hans de Goede <hdegoede@redhat.com> wrote:
> The i2c subsys does not load modules by compatible, only by
> i2c-id, with e.g. a modalias of: "i2c:axp209".
>
> Populate the axp20x_i2c_id[] table with supported ids, so that
> module auto-loading will work.
>
> Reported-by: Dennis Gilmore <dennis@ausil.us>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Acked-by: Chen-Yu Tsai <wens@csie.org>
Even though axp20x-i2c seems to be the only "DT only" i2c client,
would it make sense to add DT-based module autoloading to the i2c
core?
This also made me realize we probably don't have module auto-loading
for sunxi-rsb either.
Both should be doable with Stephen Boyd's "of: device: Export
of_device_{get_modalias, uvent_modalias} to modules" patch.
Regards
ChenYu
^ permalink raw reply [flat|nested] 24+ messages in thread
* [PATCH] mfd: axp20x-i2c: Add i2c-ids to fix module auto-loading
@ 2016-10-18 5:25 ` Chen-Yu Tsai
0 siblings, 0 replies; 24+ messages in thread
From: Chen-Yu Tsai @ 2016-10-18 5:25 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Oct 5, 2016 at 11:51 PM, Hans de Goede <hdegoede@redhat.com> wrote:
> The i2c subsys does not load modules by compatible, only by
> i2c-id, with e.g. a modalias of: "i2c:axp209".
>
> Populate the axp20x_i2c_id[] table with supported ids, so that
> module auto-loading will work.
>
> Reported-by: Dennis Gilmore <dennis@ausil.us>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Acked-by: Chen-Yu Tsai <wens@csie.org>
Even though axp20x-i2c seems to be the only "DT only" i2c client,
would it make sense to add DT-based module autoloading to the i2c
core?
This also made me realize we probably don't have module auto-loading
for sunxi-rsb either.
Both should be doable with Stephen Boyd's "of: device: Export
of_device_{get_modalias, uvent_modalias} to modules" patch.
Regards
ChenYu
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH] mfd: axp20x-i2c: Add i2c-ids to fix module auto-loading
2016-10-18 5:25 ` Chen-Yu Tsai
@ 2016-10-18 10:25 ` Hans de Goede
-1 siblings, 0 replies; 24+ messages in thread
From: Hans de Goede @ 2016-10-18 10:25 UTC (permalink / raw)
To: Chen-Yu Tsai
Cc: Lee Jones, Sebastian Reichel, Dennis Gilmore, Maxime Ripard,
open list:THERMAL, linux-arm-kernel, Wolfram Sang, linux-i2c
Hi,
On 18-10-16 07:25, Chen-Yu Tsai wrote:
> On Wed, Oct 5, 2016 at 11:51 PM, Hans de Goede <hdegoede@redhat.com> wrote:
>> The i2c subsys does not load modules by compatible, only by
>> i2c-id, with e.g. a modalias of: "i2c:axp209".
>>
>> Populate the axp20x_i2c_id[] table with supported ids, so that
>> module auto-loading will work.
>>
>> Reported-by: Dennis Gilmore <dennis@ausil.us>
>> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
>
> Acked-by: Chen-Yu Tsai <wens@csie.org>
>
> Even though axp20x-i2c seems to be the only "DT only" i2c client,
> would it make sense to add DT-based module autoloading to the i2c
> core?
If it is not too invasive, then yes that would be a sensible addition IMHO.
Regards,
Hans
^ permalink raw reply [flat|nested] 24+ messages in thread
* [PATCH] mfd: axp20x-i2c: Add i2c-ids to fix module auto-loading
@ 2016-10-18 10:25 ` Hans de Goede
0 siblings, 0 replies; 24+ messages in thread
From: Hans de Goede @ 2016-10-18 10:25 UTC (permalink / raw)
To: linux-arm-kernel
Hi,
On 18-10-16 07:25, Chen-Yu Tsai wrote:
> On Wed, Oct 5, 2016 at 11:51 PM, Hans de Goede <hdegoede@redhat.com> wrote:
>> The i2c subsys does not load modules by compatible, only by
>> i2c-id, with e.g. a modalias of: "i2c:axp209".
>>
>> Populate the axp20x_i2c_id[] table with supported ids, so that
>> module auto-loading will work.
>>
>> Reported-by: Dennis Gilmore <dennis@ausil.us>
>> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
>
> Acked-by: Chen-Yu Tsai <wens@csie.org>
>
> Even though axp20x-i2c seems to be the only "DT only" i2c client,
> would it make sense to add DT-based module autoloading to the i2c
> core?
If it is not too invasive, then yes that would be a sensible addition IMHO.
Regards,
Hans
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH] mfd: axp20x-i2c: Add i2c-ids to fix module auto-loading
2016-10-05 15:51 ` Hans de Goede
@ 2016-10-19 2:51 ` Sebastian Reichel
-1 siblings, 0 replies; 24+ messages in thread
From: Sebastian Reichel @ 2016-10-19 2:51 UTC (permalink / raw)
To: Hans de Goede
Cc: Lee Jones, Dennis Gilmore, Maxime Ripard, Chen-Yu Tsai, linux-pm,
linux-arm-kernel
[-- Attachment #1: Type: text/plain, Size: 1151 bytes --]
Hi,
On Wed, Oct 05, 2016 at 05:51:12PM +0200, Hans de Goede wrote:
> The i2c subsys does not load modules by compatible, only by
> i2c-id, with e.g. a modalias of: "i2c:axp209".
>
> Populate the axp20x_i2c_id[] table with supported ids, so that
> module auto-loading will work.
>
> Reported-by: Dennis Gilmore <dennis@ausil.us>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---
> drivers/mfd/axp20x-i2c.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/mfd/axp20x-i2c.c b/drivers/mfd/axp20x-i2c.c
> index b1b8658..d35a5fe 100644
> --- a/drivers/mfd/axp20x-i2c.c
> +++ b/drivers/mfd/axp20x-i2c.c
> @@ -69,10 +69,11 @@ static const struct of_device_id axp20x_i2c_of_match[] = {
> };
> MODULE_DEVICE_TABLE(of, axp20x_i2c_of_match);
>
> -/*
> - * This is useless for OF-enabled devices, but it is needed by I2C subsystem
> - */
> static const struct i2c_device_id axp20x_i2c_id[] = {
> + { "axp152", 0 },
> + { "axp202", 0 },
> + { "axp209", 0 },
> + { "axp221", 0 },
> { },
> };
> MODULE_DEVICE_TABLE(i2c, axp20x_i2c_id);
Thanks, queued.
-- Sebastian
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
^ permalink raw reply [flat|nested] 24+ messages in thread
* [PATCH] mfd: axp20x-i2c: Add i2c-ids to fix module auto-loading
@ 2016-10-19 2:51 ` Sebastian Reichel
0 siblings, 0 replies; 24+ messages in thread
From: Sebastian Reichel @ 2016-10-19 2:51 UTC (permalink / raw)
To: linux-arm-kernel
Hi,
On Wed, Oct 05, 2016 at 05:51:12PM +0200, Hans de Goede wrote:
> The i2c subsys does not load modules by compatible, only by
> i2c-id, with e.g. a modalias of: "i2c:axp209".
>
> Populate the axp20x_i2c_id[] table with supported ids, so that
> module auto-loading will work.
>
> Reported-by: Dennis Gilmore <dennis@ausil.us>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---
> drivers/mfd/axp20x-i2c.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/mfd/axp20x-i2c.c b/drivers/mfd/axp20x-i2c.c
> index b1b8658..d35a5fe 100644
> --- a/drivers/mfd/axp20x-i2c.c
> +++ b/drivers/mfd/axp20x-i2c.c
> @@ -69,10 +69,11 @@ static const struct of_device_id axp20x_i2c_of_match[] = {
> };
> MODULE_DEVICE_TABLE(of, axp20x_i2c_of_match);
>
> -/*
> - * This is useless for OF-enabled devices, but it is needed by I2C subsystem
> - */
> static const struct i2c_device_id axp20x_i2c_id[] = {
> + { "axp152", 0 },
> + { "axp202", 0 },
> + { "axp209", 0 },
> + { "axp221", 0 },
> { },
> };
> MODULE_DEVICE_TABLE(i2c, axp20x_i2c_id);
Thanks, queued.
-- Sebastian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20161019/fe135abd/attachment.sig>
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH] mfd: axp20x-i2c: Add i2c-ids to fix module auto-loading
2016-10-19 2:51 ` Sebastian Reichel
@ 2016-10-19 2:56 ` Sebastian Reichel
-1 siblings, 0 replies; 24+ messages in thread
From: Sebastian Reichel @ 2016-10-19 2:56 UTC (permalink / raw)
To: Hans de Goede
Cc: Lee Jones, Dennis Gilmore, Maxime Ripard, Chen-Yu Tsai, linux-pm,
linux-arm-kernel
[-- Attachment #1: Type: text/plain, Size: 890 bytes --]
Hi,
On Wed, Oct 19, 2016 at 04:51:55AM +0200, Sebastian Reichel wrote:
> > diff --git a/drivers/mfd/axp20x-i2c.c b/drivers/mfd/axp20x-i2c.c
> > index b1b8658..d35a5fe 100644
> > --- a/drivers/mfd/axp20x-i2c.c
> > +++ b/drivers/mfd/axp20x-i2c.c
> > @@ -69,10 +69,11 @@ static const struct of_device_id axp20x_i2c_of_match[] = {
> > };
> > MODULE_DEVICE_TABLE(of, axp20x_i2c_of_match);
> >
> > -/*
> > - * This is useless for OF-enabled devices, but it is needed by I2C subsystem
> > - */
> > static const struct i2c_device_id axp20x_i2c_id[] = {
> > + { "axp152", 0 },
> > + { "axp202", 0 },
> > + { "axp209", 0 },
> > + { "axp221", 0 },
> > { },
> > };
> > MODULE_DEVICE_TABLE(i2c, axp20x_i2c_id);
>
> Thanks, queued.
My mistake. It should obviously go through mfd. So take this instead:
Acked-By: Sebastian Reichel <sre@kernel.org>
-- Sebastian
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
^ permalink raw reply [flat|nested] 24+ messages in thread
* [PATCH] mfd: axp20x-i2c: Add i2c-ids to fix module auto-loading
@ 2016-10-19 2:56 ` Sebastian Reichel
0 siblings, 0 replies; 24+ messages in thread
From: Sebastian Reichel @ 2016-10-19 2:56 UTC (permalink / raw)
To: linux-arm-kernel
Hi,
On Wed, Oct 19, 2016 at 04:51:55AM +0200, Sebastian Reichel wrote:
> > diff --git a/drivers/mfd/axp20x-i2c.c b/drivers/mfd/axp20x-i2c.c
> > index b1b8658..d35a5fe 100644
> > --- a/drivers/mfd/axp20x-i2c.c
> > +++ b/drivers/mfd/axp20x-i2c.c
> > @@ -69,10 +69,11 @@ static const struct of_device_id axp20x_i2c_of_match[] = {
> > };
> > MODULE_DEVICE_TABLE(of, axp20x_i2c_of_match);
> >
> > -/*
> > - * This is useless for OF-enabled devices, but it is needed by I2C subsystem
> > - */
> > static const struct i2c_device_id axp20x_i2c_id[] = {
> > + { "axp152", 0 },
> > + { "axp202", 0 },
> > + { "axp209", 0 },
> > + { "axp221", 0 },
> > { },
> > };
> > MODULE_DEVICE_TABLE(i2c, axp20x_i2c_id);
>
> Thanks, queued.
My mistake. It should obviously go through mfd. So take this instead:
Acked-By: Sebastian Reichel <sre@kernel.org>
-- Sebastian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20161019/aa748c19/attachment.sig>
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH] mfd: axp20x-i2c: Add i2c-ids to fix module auto-loading
2016-10-18 10:25 ` Hans de Goede
@ 2016-10-24 10:09 ` Lee Jones
-1 siblings, 0 replies; 24+ messages in thread
From: Lee Jones @ 2016-10-24 10:09 UTC (permalink / raw)
To: Hans de Goede
Cc: Chen-Yu Tsai, Sebastian Reichel, Dennis Gilmore, Maxime Ripard,
open list:THERMAL, linux-arm-kernel, Wolfram Sang, linux-i2c
On Tue, 18 Oct 2016, Hans de Goede wrote:
> On 18-10-16 07:25, Chen-Yu Tsai wrote:
> > On Wed, Oct 5, 2016 at 11:51 PM, Hans de Goede <hdegoede@redhat.com> wrote:
> > > The i2c subsys does not load modules by compatible, only by
> > > i2c-id, with e.g. a modalias of: "i2c:axp209".
> > >
> > > Populate the axp20x_i2c_id[] table with supported ids, so that
> > > module auto-loading will work.
> > >
> > > Reported-by: Dennis Gilmore <dennis@ausil.us>
> > > Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> >
> > Acked-by: Chen-Yu Tsai <wens@csie.org>
> >
> > Even though axp20x-i2c seems to be the only "DT only" i2c client,
> > would it make sense to add DT-based module autoloading to the i2c
> > core?
>
> If it is not too invasive, then yes that would be a sensible addition IMHO.
If I understand you correctly, I already have a patch-set on the ML
that does this.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 24+ messages in thread
* [PATCH] mfd: axp20x-i2c: Add i2c-ids to fix module auto-loading
@ 2016-10-24 10:09 ` Lee Jones
0 siblings, 0 replies; 24+ messages in thread
From: Lee Jones @ 2016-10-24 10:09 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, 18 Oct 2016, Hans de Goede wrote:
> On 18-10-16 07:25, Chen-Yu Tsai wrote:
> > On Wed, Oct 5, 2016 at 11:51 PM, Hans de Goede <hdegoede@redhat.com> wrote:
> > > The i2c subsys does not load modules by compatible, only by
> > > i2c-id, with e.g. a modalias of: "i2c:axp209".
> > >
> > > Populate the axp20x_i2c_id[] table with supported ids, so that
> > > module auto-loading will work.
> > >
> > > Reported-by: Dennis Gilmore <dennis@ausil.us>
> > > Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> >
> > Acked-by: Chen-Yu Tsai <wens@csie.org>
> >
> > Even though axp20x-i2c seems to be the only "DT only" i2c client,
> > would it make sense to add DT-based module autoloading to the i2c
> > core?
>
> If it is not too invasive, then yes that would be a sensible addition IMHO.
If I understand you correctly, I already have a patch-set on the ML
that does this.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH] mfd: axp20x-i2c: Add i2c-ids to fix module auto-loading
2016-10-24 10:09 ` Lee Jones
@ 2016-10-24 10:17 ` Wolfram Sang
-1 siblings, 0 replies; 24+ messages in thread
From: Wolfram Sang @ 2016-10-24 10:17 UTC (permalink / raw)
To: Lee Jones
Cc: Hans de Goede, Chen-Yu Tsai, Sebastian Reichel, Dennis Gilmore,
Maxime Ripard, open list:THERMAL, linux-arm-kernel, linux-i2c
[-- Attachment #1: Type: text/plain, Size: 416 bytes --]
> > > Even though axp20x-i2c seems to be the only "DT only" i2c client,
> > > would it make sense to add DT-based module autoloading to the i2c
> > > core?
> >
> > If it is not too invasive, then yes that would be a sensible addition IMHO.
>
> If I understand you correctly, I already have a patch-set on the ML
> that does this.
Incomplete, though. But we will see if Kieran finds time somewhen...
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 24+ messages in thread
* [PATCH] mfd: axp20x-i2c: Add i2c-ids to fix module auto-loading
@ 2016-10-24 10:17 ` Wolfram Sang
0 siblings, 0 replies; 24+ messages in thread
From: Wolfram Sang @ 2016-10-24 10:17 UTC (permalink / raw)
To: linux-arm-kernel
> > > Even though axp20x-i2c seems to be the only "DT only" i2c client,
> > > would it make sense to add DT-based module autoloading to the i2c
> > > core?
> >
> > If it is not too invasive, then yes that would be a sensible addition IMHO.
>
> If I understand you correctly, I already have a patch-set on the ML
> that does this.
Incomplete, though. But we will see if Kieran finds time somewhen...
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20161024/f6b74cf4/attachment.sig>
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH] mfd: axp20x-i2c: Add i2c-ids to fix module auto-loading
2016-10-24 10:17 ` Wolfram Sang
@ 2016-10-24 10:34 ` Lee Jones
-1 siblings, 0 replies; 24+ messages in thread
From: Lee Jones @ 2016-10-24 10:34 UTC (permalink / raw)
To: Wolfram Sang
Cc: Hans de Goede, Chen-Yu Tsai, Sebastian Reichel, Dennis Gilmore,
Maxime Ripard, open list:THERMAL, linux-arm-kernel, linux-i2c
On Mon, 24 Oct 2016, Wolfram Sang wrote:
>
> > > > Even though axp20x-i2c seems to be the only "DT only" i2c client,
> > > > would it make sense to add DT-based module autoloading to the i2c
> > > > core?
> > >
> > > If it is not too invasive, then yes that would be a sensible addition IMHO.
> >
> > If I understand you correctly, I already have a patch-set on the ML
> > that does this.
>
> Incomplete, though. But we will see if Kieran finds time somewhen...
I was under the impression it was all but ready.
What are you waiting on?
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 24+ messages in thread
* [PATCH] mfd: axp20x-i2c: Add i2c-ids to fix module auto-loading
@ 2016-10-24 10:34 ` Lee Jones
0 siblings, 0 replies; 24+ messages in thread
From: Lee Jones @ 2016-10-24 10:34 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, 24 Oct 2016, Wolfram Sang wrote:
>
> > > > Even though axp20x-i2c seems to be the only "DT only" i2c client,
> > > > would it make sense to add DT-based module autoloading to the i2c
> > > > core?
> > >
> > > If it is not too invasive, then yes that would be a sensible addition IMHO.
> >
> > If I understand you correctly, I already have a patch-set on the ML
> > that does this.
>
> Incomplete, though. But we will see if Kieran finds time somewhen...
I was under the impression it was all but ready.
What are you waiting on?
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH] mfd: axp20x-i2c: Add i2c-ids to fix module auto-loading
2016-10-24 10:34 ` Lee Jones
@ 2016-10-24 10:47 ` Wolfram Sang
-1 siblings, 0 replies; 24+ messages in thread
From: Wolfram Sang @ 2016-10-24 10:47 UTC (permalink / raw)
To: Lee Jones
Cc: Hans de Goede, Chen-Yu Tsai, Sebastian Reichel, Dennis Gilmore,
Maxime Ripard, open list:THERMAL, linux-arm-kernel, linux-i2c
[-- Attachment #1: Type: text/plain, Size: 193 bytes --]
> I was under the impression it was all but ready.
Then, I would have applied it.
> What are you waiting on?
Lee, I don't want to explain it *again*. Please re-read Kieran's last
attempt.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 24+ messages in thread
* [PATCH] mfd: axp20x-i2c: Add i2c-ids to fix module auto-loading
@ 2016-10-24 10:47 ` Wolfram Sang
0 siblings, 0 replies; 24+ messages in thread
From: Wolfram Sang @ 2016-10-24 10:47 UTC (permalink / raw)
To: linux-arm-kernel
> I was under the impression it was all but ready.
Then, I would have applied it.
> What are you waiting on?
Lee, I don't want to explain it *again*. Please re-read Kieran's last
attempt.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20161024/241ed28c/attachment.sig>
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH] mfd: axp20x-i2c: Add i2c-ids to fix module auto-loading
2016-10-24 10:47 ` Wolfram Sang
@ 2016-10-26 14:00 ` Lee Jones
-1 siblings, 0 replies; 24+ messages in thread
From: Lee Jones @ 2016-10-26 14:00 UTC (permalink / raw)
To: Wolfram Sang
Cc: Hans de Goede, Chen-Yu Tsai, Sebastian Reichel, Dennis Gilmore,
Maxime Ripard, open list:THERMAL, linux-arm-kernel, linux-i2c
On Mon, 24 Oct 2016, Wolfram Sang wrote:
>
> > I was under the impression it was all but ready.
>
> Then, I would have applied it.
>
> > What are you waiting on?
>
> Lee, I don't want to explain it *again*. Please re-read Kieran's last
> attempt.
I met with Kieran. He's submitted a new version.
Here's hoping! ;)
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 24+ messages in thread
* [PATCH] mfd: axp20x-i2c: Add i2c-ids to fix module auto-loading
@ 2016-10-26 14:00 ` Lee Jones
0 siblings, 0 replies; 24+ messages in thread
From: Lee Jones @ 2016-10-26 14:00 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, 24 Oct 2016, Wolfram Sang wrote:
>
> > I was under the impression it was all but ready.
>
> Then, I would have applied it.
>
> > What are you waiting on?
>
> Lee, I don't want to explain it *again*. Please re-read Kieran's last
> attempt.
I met with Kieran. He's submitted a new version.
Here's hoping! ;)
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH] mfd: axp20x-i2c: Add i2c-ids to fix module auto-loading
2016-10-05 15:51 ` Hans de Goede
@ 2016-10-26 14:01 ` Lee Jones
-1 siblings, 0 replies; 24+ messages in thread
From: Lee Jones @ 2016-10-26 14:01 UTC (permalink / raw)
To: Hans de Goede
Cc: Sebastian Reichel, Dennis Gilmore, Maxime Ripard, Chen-Yu Tsai,
linux-pm, linux-arm-kernel
On Wed, 05 Oct 2016, Hans de Goede wrote:
> The i2c subsys does not load modules by compatible, only by
> i2c-id, with e.g. a modalias of: "i2c:axp209".
>
> Populate the axp20x_i2c_id[] table with supported ids, so that
> module auto-loading will work.
>
> Reported-by: Dennis Gilmore <dennis@ausil.us>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---
> drivers/mfd/axp20x-i2c.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
Applied (for now), thanks.
> diff --git a/drivers/mfd/axp20x-i2c.c b/drivers/mfd/axp20x-i2c.c
> index b1b8658..d35a5fe 100644
> --- a/drivers/mfd/axp20x-i2c.c
> +++ b/drivers/mfd/axp20x-i2c.c
> @@ -69,10 +69,11 @@ static const struct of_device_id axp20x_i2c_of_match[] = {
> };
> MODULE_DEVICE_TABLE(of, axp20x_i2c_of_match);
>
> -/*
> - * This is useless for OF-enabled devices, but it is needed by I2C subsystem
> - */
> static const struct i2c_device_id axp20x_i2c_id[] = {
> + { "axp152", 0 },
> + { "axp202", 0 },
> + { "axp209", 0 },
> + { "axp221", 0 },
> { },
> };
> MODULE_DEVICE_TABLE(i2c, axp20x_i2c_id);
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 24+ messages in thread
* [PATCH] mfd: axp20x-i2c: Add i2c-ids to fix module auto-loading
@ 2016-10-26 14:01 ` Lee Jones
0 siblings, 0 replies; 24+ messages in thread
From: Lee Jones @ 2016-10-26 14:01 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, 05 Oct 2016, Hans de Goede wrote:
> The i2c subsys does not load modules by compatible, only by
> i2c-id, with e.g. a modalias of: "i2c:axp209".
>
> Populate the axp20x_i2c_id[] table with supported ids, so that
> module auto-loading will work.
>
> Reported-by: Dennis Gilmore <dennis@ausil.us>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---
> drivers/mfd/axp20x-i2c.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
Applied (for now), thanks.
> diff --git a/drivers/mfd/axp20x-i2c.c b/drivers/mfd/axp20x-i2c.c
> index b1b8658..d35a5fe 100644
> --- a/drivers/mfd/axp20x-i2c.c
> +++ b/drivers/mfd/axp20x-i2c.c
> @@ -69,10 +69,11 @@ static const struct of_device_id axp20x_i2c_of_match[] = {
> };
> MODULE_DEVICE_TABLE(of, axp20x_i2c_of_match);
>
> -/*
> - * This is useless for OF-enabled devices, but it is needed by I2C subsystem
> - */
> static const struct i2c_device_id axp20x_i2c_id[] = {
> + { "axp152", 0 },
> + { "axp202", 0 },
> + { "axp209", 0 },
> + { "axp221", 0 },
> { },
> };
> MODULE_DEVICE_TABLE(i2c, axp20x_i2c_id);
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 24+ messages in thread
end of thread, other threads:[~2016-10-26 14:01 UTC | newest]
Thread overview: 24+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-10-05 15:51 [PATCH 0/1] mfd: axp20x-i2c: Add i2c-ids to fix module auto-loading Hans de Goede
2016-10-05 15:51 ` Hans de Goede
2016-10-05 15:51 ` [PATCH] " Hans de Goede
2016-10-05 15:51 ` Hans de Goede
2016-10-18 5:25 ` Chen-Yu Tsai
2016-10-18 5:25 ` Chen-Yu Tsai
2016-10-18 10:25 ` Hans de Goede
2016-10-18 10:25 ` Hans de Goede
2016-10-24 10:09 ` Lee Jones
2016-10-24 10:09 ` Lee Jones
2016-10-24 10:17 ` Wolfram Sang
2016-10-24 10:17 ` Wolfram Sang
2016-10-24 10:34 ` Lee Jones
2016-10-24 10:34 ` Lee Jones
2016-10-24 10:47 ` Wolfram Sang
2016-10-24 10:47 ` Wolfram Sang
2016-10-26 14:00 ` Lee Jones
2016-10-26 14:00 ` Lee Jones
2016-10-19 2:51 ` Sebastian Reichel
2016-10-19 2:51 ` Sebastian Reichel
2016-10-19 2:56 ` Sebastian Reichel
2016-10-19 2:56 ` Sebastian Reichel
2016-10-26 14:01 ` Lee Jones
2016-10-26 14:01 ` Lee Jones
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.