* [PATCH 0/8] fix multiple checkpatch issues
@ 2016-09-16 2:46 Gargi Sharma
2016-09-16 2:46 ` [PATCH 1/8] staging: wlan-ng: add spaces around + Gargi Sharma
` (7 more replies)
0 siblings, 8 replies; 17+ messages in thread
From: Gargi Sharma @ 2016-09-16 2:46 UTC (permalink / raw)
To: outreachy-kernel; +Cc: gregkh, Gargi Sharma
Fix issues detected using checkpatch.pl
Gargi Sharma (8):
staging: wlan-ng: add spaces around +
staging: wlan-ng: add spaces around &
staging: wlan-ng: add spaces around >>
staging: wlan-ng: add spaces around |
staging: wlan-ng: add spaces around <<
staging: wlan-ng: delete space after a cast
staging: wlan-ng: add blank line after declaration
staging: wlan-ng: fix block comment style
drivers/staging/wlan-ng/hfa384x.h | 251 +++++++++--------
pace | 567 ++++++++++++++++++++++++++++++++++++++
2 files changed, 707 insertions(+), 111 deletions(-)
create mode 100644 pace
--
2.9.2
^ permalink raw reply [flat|nested] 17+ messages in thread
* [PATCH 1/8] staging: wlan-ng: add spaces around +
2016-09-16 2:46 [PATCH 0/8] fix multiple checkpatch issues Gargi Sharma
@ 2016-09-16 2:46 ` Gargi Sharma
2016-09-16 2:46 ` [PATCH 2/8] staging: wlan-ng: add spaces around & Gargi Sharma
` (6 subsequent siblings)
7 siblings, 0 replies; 17+ messages in thread
From: Gargi Sharma @ 2016-09-16 2:46 UTC (permalink / raw)
To: outreachy-kernel; +Cc: gregkh, Gargi Sharma
add spaces around + to fix the checkpatch issue,
spaces preferred around that '&'.
Signed-off-by: Gargi Sharma <gs051095@gmail.com>
---
drivers/staging/wlan-ng/hfa384x.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h
index cec6d0b..5bb8c58 100644
--- a/drivers/staging/wlan-ng/hfa384x.h
+++ b/drivers/staging/wlan-ng/hfa384x.h
@@ -63,7 +63,7 @@
/*--- Mins & Maxs -----------------------------------*/
#define HFA384x_PORTID_MAX ((u16)7)
-#define HFA384x_NUMPORTS_MAX ((u16)(HFA384x_PORTID_MAX+1))
+#define HFA384x_NUMPORTS_MAX ((u16)(HFA384x_PORTID_MAX + 1))
#define HFA384x_PDR_LEN_MAX ((u16)512) /* in bytes, from EK */
#define HFA384x_PDA_RECS_MAX ((u16)200) /* a guess */
#define HFA384x_PDA_LEN_MAX ((u16)1024) /* in bytes, from EK*/
--
2.9.2
^ permalink raw reply related [flat|nested] 17+ messages in thread
* [PATCH 2/8] staging: wlan-ng: add spaces around &
2016-09-16 2:46 [PATCH 0/8] fix multiple checkpatch issues Gargi Sharma
2016-09-16 2:46 ` [PATCH 1/8] staging: wlan-ng: add spaces around + Gargi Sharma
@ 2016-09-16 2:46 ` Gargi Sharma
2016-09-16 2:46 ` [PATCH 3/8] staging: wlan-ng: add spaces around >> Gargi Sharma
` (5 subsequent siblings)
7 siblings, 0 replies; 17+ messages in thread
From: Gargi Sharma @ 2016-09-16 2:46 UTC (permalink / raw)
To: outreachy-kernel; +Cc: gregkh, Gargi Sharma
add space around & to fix the checkpatch issue spaces preferred around
that '&'.
Signed-off-by: Gargi Sharma <gs051095@gmail.com>
---
drivers/staging/wlan-ng/hfa384x.h | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h
index 5bb8c58..e466883 100644
--- a/drivers/staging/wlan-ng/hfa384x.h
+++ b/drivers/staging/wlan-ng/hfa384x.h
@@ -116,14 +116,14 @@
/* Make a 32-bit flat address from AUX format 16-bit page and offset */
#define HFA384x_ADDR_AUX_MKFLAT(p, o) \
- ((((u32)(((u16)(p))&HFA384x_ADDR_AUX_PAGE_MASK)) << 7) | \
- ((u32)(((u16)(o))&HFA384x_ADDR_AUX_OFF_MASK)))
+ ((((u32)(((u16)(p)) & HFA384x_ADDR_AUX_PAGE_MASK)) << 7) | \
+ ((u32)(((u16)(o)) & HFA384x_ADDR_AUX_OFF_MASK)))
/* Make CMD format offset and page from a 32-bit flat address */
#define HFA384x_ADDR_CMD_MKPAGE(f) \
- ((u16)((((u32)(f))&HFA384x_ADDR_FLAT_CMD_PAGE_MASK)>>16))
+ ((u16)((((u32)(f)) & HFA384x_ADDR_FLAT_CMD_PAGE_MASK)>>16))
#define HFA384x_ADDR_CMD_MKOFF(f) \
- ((u16)(((u32)(f))&HFA384x_ADDR_FLAT_CMD_OFF_MASK))
+ ((u16)(((u32)(f)) & HFA384x_ADDR_FLAT_CMD_OFF_MASK))
/*--- Controller Memory addresses -------------------*/
#define HFA3842_PDA_BASE (0x007f0000UL)
@@ -503,12 +503,12 @@ Communication Frames: Test/Get/Set Field Values for Transmit Frames
--------------------------------------------------------------------*/
/*-- Status Field --*/
#define HFA384x_TXSTATUS_ISERROR(v) \
- (((u16)(v))&\
+ (((u16)(v)) & \
(HFA384x_TXSTATUS_ACKERR|HFA384x_TXSTATUS_FORMERR|\
HFA384x_TXSTATUS_DISCON|HFA384x_TXSTATUS_AGEDERR|\
HFA384x_TXSTATUS_RETRYERR))
-#define HFA384x_TX_SET(v, m, s) ((((u16)(v))<<((u16)(s)))&((u16)(m)))
+#define HFA384x_TX_SET(v, m, s) ((((u16)(v))<<((u16)(s))) & ((u16)(m)))
#define HFA384x_TX_MACPORT_SET(v) HFA384x_TX_SET(v, HFA384x_TX_MACPORT, 8)
#define HFA384x_TX_STRUCTYPE_SET(v) HFA384x_TX_SET(v, \
--
2.9.2
^ permalink raw reply related [flat|nested] 17+ messages in thread
* [PATCH 3/8] staging: wlan-ng: add spaces around >>
2016-09-16 2:46 [PATCH 0/8] fix multiple checkpatch issues Gargi Sharma
2016-09-16 2:46 ` [PATCH 1/8] staging: wlan-ng: add spaces around + Gargi Sharma
2016-09-16 2:46 ` [PATCH 2/8] staging: wlan-ng: add spaces around & Gargi Sharma
@ 2016-09-16 2:46 ` Gargi Sharma
2016-09-16 5:41 ` [Outreachy kernel] " Julia Lawall
2016-09-16 2:46 ` [PATCH 4/8] staging: wlan-ng: add spaces around | Gargi Sharma
` (4 subsequent siblings)
7 siblings, 1 reply; 17+ messages in thread
From: Gargi Sharma @ 2016-09-16 2:46 UTC (permalink / raw)
To: outreachy-kernel; +Cc: gregkh, Gargi Sharma
add spaces around >> to fix the checkpatch issue, spaces preferred
around that '>>'.
Signed-off-by: Gargi Sharma <gs051095@gmail.com>
---
drivers/staging/wlan-ng/hfa384x.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h
index e466883..d4b1dbf 100644
--- a/drivers/staging/wlan-ng/hfa384x.h
+++ b/drivers/staging/wlan-ng/hfa384x.h
@@ -121,7 +121,7 @@
/* Make CMD format offset and page from a 32-bit flat address */
#define HFA384x_ADDR_CMD_MKPAGE(f) \
- ((u16)((((u32)(f)) & HFA384x_ADDR_FLAT_CMD_PAGE_MASK)>>16))
+ ((u16)((((u32)(f)) & HFA384x_ADDR_FLAT_CMD_PAGE_MASK) >> 16))
#define HFA384x_ADDR_CMD_MKOFF(f) \
((u16)(((u32)(f)) & HFA384x_ADDR_FLAT_CMD_OFF_MASK))
--
2.9.2
^ permalink raw reply related [flat|nested] 17+ messages in thread
* [PATCH 4/8] staging: wlan-ng: add spaces around |
2016-09-16 2:46 [PATCH 0/8] fix multiple checkpatch issues Gargi Sharma
` (2 preceding siblings ...)
2016-09-16 2:46 ` [PATCH 3/8] staging: wlan-ng: add spaces around >> Gargi Sharma
@ 2016-09-16 2:46 ` Gargi Sharma
2016-09-16 2:46 ` [PATCH 5/8] staging: wlan-ng: add spaces around << Gargi Sharma
` (3 subsequent siblings)
7 siblings, 0 replies; 17+ messages in thread
From: Gargi Sharma @ 2016-09-16 2:46 UTC (permalink / raw)
To: outreachy-kernel; +Cc: gregkh, Gargi Sharma
add spaces around | to fix the checkpatch issue, spaces preferred around
that '|'.
Signed-off-by: Gargi Sharma <gs051095@gmail.com>
---
drivers/staging/wlan-ng/hfa384x.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h
index d4b1dbf..4bbbce5 100644
--- a/drivers/staging/wlan-ng/hfa384x.h
+++ b/drivers/staging/wlan-ng/hfa384x.h
@@ -504,8 +504,8 @@ Communication Frames: Test/Get/Set Field Values for Transmit Frames
/*-- Status Field --*/
#define HFA384x_TXSTATUS_ISERROR(v) \
(((u16)(v)) & \
- (HFA384x_TXSTATUS_ACKERR|HFA384x_TXSTATUS_FORMERR|\
- HFA384x_TXSTATUS_DISCON|HFA384x_TXSTATUS_AGEDERR|\
+ (HFA384x_TXSTATUS_ACKERR | HFA384x_TXSTATUS_FORMERR | \
+ HFA384x_TXSTATUS_DISCON | HFA384x_TXSTATUS_AGEDERR | \
HFA384x_TXSTATUS_RETRYERR))
#define HFA384x_TX_SET(v, m, s) ((((u16)(v))<<((u16)(s))) & ((u16)(m)))
--
2.9.2
^ permalink raw reply related [flat|nested] 17+ messages in thread
* [PATCH 5/8] staging: wlan-ng: add spaces around <<
2016-09-16 2:46 [PATCH 0/8] fix multiple checkpatch issues Gargi Sharma
` (3 preceding siblings ...)
2016-09-16 2:46 ` [PATCH 4/8] staging: wlan-ng: add spaces around | Gargi Sharma
@ 2016-09-16 2:46 ` Gargi Sharma
2016-09-16 5:39 ` [Outreachy kernel] " Julia Lawall
2016-09-16 2:46 ` [PATCH 6/8] staging: wlan-ng: delete space after a cast Gargi Sharma
` (2 subsequent siblings)
7 siblings, 1 reply; 17+ messages in thread
From: Gargi Sharma @ 2016-09-16 2:46 UTC (permalink / raw)
To: outreachy-kernel; +Cc: gregkh, Gargi Sharma
add spaces around << to fix the checkpatch issue, spaces preferred
around that '<<'.
Signed-off-by: Gargi Sharma <gs051095@gmail.com>
---
drivers/staging/wlan-ng/hfa384x.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h
index 4bbbce5..616da07 100644
--- a/drivers/staging/wlan-ng/hfa384x.h
+++ b/drivers/staging/wlan-ng/hfa384x.h
@@ -508,7 +508,7 @@ Communication Frames: Test/Get/Set Field Values for Transmit Frames
HFA384x_TXSTATUS_DISCON | HFA384x_TXSTATUS_AGEDERR | \
HFA384x_TXSTATUS_RETRYERR))
-#define HFA384x_TX_SET(v, m, s) ((((u16)(v))<<((u16)(s))) & ((u16)(m)))
+#define HFA384x_TX_SET(v, m, s) ((((u16)(v)) << ((u16)(s))) & ((u16)(m)))
#define HFA384x_TX_MACPORT_SET(v) HFA384x_TX_SET(v, HFA384x_TX_MACPORT, 8)
#define HFA384x_TX_STRUCTYPE_SET(v) HFA384x_TX_SET(v, \
--
2.9.2
^ permalink raw reply related [flat|nested] 17+ messages in thread
* [PATCH 6/8] staging: wlan-ng: delete space after a cast
2016-09-16 2:46 [PATCH 0/8] fix multiple checkpatch issues Gargi Sharma
` (4 preceding siblings ...)
2016-09-16 2:46 ` [PATCH 5/8] staging: wlan-ng: add spaces around << Gargi Sharma
@ 2016-09-16 2:46 ` Gargi Sharma
2016-09-16 5:37 ` [Outreachy kernel] " Julia Lawall
2016-09-16 2:46 ` [PATCH 7/8] staging: wlan-ng: add blank line after declaration Gargi Sharma
2016-09-16 2:46 ` [PATCH 8/8] staging: wlan-ng: fix block comment style Gargi Sharma
7 siblings, 1 reply; 17+ messages in thread
From: Gargi Sharma @ 2016-09-16 2:46 UTC (permalink / raw)
To: outreachy-kernel; +Cc: gregkh, Gargi Sharma
delete space after a cast to fix the checkpatch issue, No space is
necessary after a cast.
Signed-off-by: Gargi Sharma <gs051095@gmail.com>
---
drivers/staging/wlan-ng/hfa384x.h | 4 +-
pace | 567 ++++++++++++++++++++++++++++++++++++++
2 files changed, 569 insertions(+), 2 deletions(-)
create mode 100644 pace
diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h
index 616da07..2ff3805 100644
--- a/drivers/staging/wlan-ng/hfa384x.h
+++ b/drivers/staging/wlan-ng/hfa384x.h
@@ -255,7 +255,7 @@ Information RID Lengths: MAC Information
include the len or code fields)
--------------------------------------------------------------------*/
#define HFA384x_RID_DBMCOMMSQUALITY_LEN \
- ((u16) sizeof(hfa384x_dbmcommsquality_t))
+ ((u16)sizeof(hfa384x_dbmcommsquality_t))
#define HFA384x_RID_JOINREQUEST_LEN \
((u16)sizeof(hfa384x_JoinRequest_data_t))
@@ -1378,7 +1378,7 @@ static inline int hfa384x_drvr_getconfig16(hfa384x_t *hw, u16 rid, void *val)
result = hfa384x_drvr_getconfig(hw, rid, val, sizeof(u16));
if (result == 0)
- *((u16 *) val) = le16_to_cpu(*((u16 *) val));
+ *((u16 *)val) = le16_to_cpu(*((u16 *) val));
return result;
}
diff --git a/pace b/pace
new file mode 100644
index 0000000..7cc2eea
--- /dev/null
+++ b/pace
@@ -0,0 +1,567 @@
+CHECK: No space is necessary after a cast
+#267: FILE: drivers/staging/wlan-ng/hfa384x.h:267:
++ ((u16) sizeof(hfa384x_dbmcommsquality_t))
+
+CHECK: Avoid CamelCase: <hfa384x_JoinRequest_data_t>
+#269: FILE: drivers/staging/wlan-ng/hfa384x.h:269:
++ ((u16)sizeof(hfa384x_JoinRequest_data_t))
+
+CHECK: Avoid CamelCase: <HFA384x_RID_CNFAPBCNint>
+#289: FILE: drivers/staging/wlan-ng/hfa384x.h:289:
++#define HFA384x_RID_CNFAPBCNint ((u16)0xFC33)
+
+WARNING: do not add new typedefs
+#370: FILE: drivers/staging/wlan-ng/hfa384x.h:370:
++typedef struct hfa384x_bytestr32 {
+
+WARNING: do not add new typedefs
+#382: FILE: drivers/staging/wlan-ng/hfa384x.h:382:
++typedef struct hfa384x_compident {
+
+WARNING: do not add new typedefs
+#389: FILE: drivers/staging/wlan-ng/hfa384x.h:389:
++typedef struct hfa384x_caplevel {
+
+WARNING: do not add new typedefs
+#411: FILE: drivers/staging/wlan-ng/hfa384x.h:411:
++typedef struct hfa384x_HostScanRequest_data {
+
+CHECK: Avoid CamelCase: <hfa384x_HostScanRequest_data>
+#411: FILE: drivers/staging/wlan-ng/hfa384x.h:411:
++typedef struct hfa384x_HostScanRequest_data {
+
+CHECK: Avoid CamelCase: <channelList>
+#412: FILE: drivers/staging/wlan-ng/hfa384x.h:412:
++ u16 channelList;
+
+CHECK: Avoid CamelCase: <txRate>
+#413: FILE: drivers/staging/wlan-ng/hfa384x.h:413:
++ u16 txRate;
+
+CHECK: Avoid CamelCase: <hfa384x_HostScanRequest_data_t>
+#415: FILE: drivers/staging/wlan-ng/hfa384x.h:415:
++} __packed hfa384x_HostScanRequest_data_t;
+
+WARNING: do not add new typedefs
+#418: FILE: drivers/staging/wlan-ng/hfa384x.h:418:
++typedef struct hfa384x_JoinRequest_data {
+
+CHECK: Avoid CamelCase: <hfa384x_JoinRequest_data>
+#418: FILE: drivers/staging/wlan-ng/hfa384x.h:418:
++typedef struct hfa384x_JoinRequest_data {
+
+WARNING: do not add new typedefs
+#424: FILE: drivers/staging/wlan-ng/hfa384x.h:424:
++typedef struct hfa384x_authenticateStation_data {
+
+CHECK: Avoid CamelCase: <hfa384x_authenticateStation_data>
+#424: FILE: drivers/staging/wlan-ng/hfa384x.h:424:
++typedef struct hfa384x_authenticateStation_data {
+
+CHECK: Avoid CamelCase: <hfa384x_authenticateStation_data_t>
+#428: FILE: drivers/staging/wlan-ng/hfa384x.h:428:
++} __packed hfa384x_authenticateStation_data_t;
+
+WARNING: do not add new typedefs
+#431: FILE: drivers/staging/wlan-ng/hfa384x.h:431:
++typedef struct hfa384x_WPAData {
+
+CHECK: Avoid CamelCase: <hfa384x_WPAData>
+#431: FILE: drivers/staging/wlan-ng/hfa384x.h:431:
++typedef struct hfa384x_WPAData {
+
+CHECK: Avoid CamelCase: <hfa384x_WPAData_t>
+#434: FILE: drivers/staging/wlan-ng/hfa384x.h:434:
++} __packed hfa384x_WPAData_t;
+
+WARNING: do not add new typedefs
+#443: FILE: drivers/staging/wlan-ng/hfa384x.h:443:
++typedef struct hfa384x_downloadbuffer {
+
+WARNING: do not add new typedefs
+#457: FILE: drivers/staging/wlan-ng/hfa384x.h:457:
++typedef struct hfa384x_commsquality {
+
+CHECK: Avoid CamelCase: <CQ_currBSS>
+#458: FILE: drivers/staging/wlan-ng/hfa384x.h:458:
++ u16 CQ_currBSS;
+
+CHECK: Avoid CamelCase: <ASL_currBSS>
+#459: FILE: drivers/staging/wlan-ng/hfa384x.h:459:
++ u16 ASL_currBSS;
+
+CHECK: Avoid CamelCase: <ANL_currFC>
+#460: FILE: drivers/staging/wlan-ng/hfa384x.h:460:
++ u16 ANL_currFC;
+
+WARNING: do not add new typedefs
+#464: FILE: drivers/staging/wlan-ng/hfa384x.h:464:
++typedef struct hfa384x_dbmcommsquality {
+
+CHECK: Avoid CamelCase: <CQdbm_currBSS>
+#465: FILE: drivers/staging/wlan-ng/hfa384x.h:465:
++ u16 CQdbm_currBSS;
+
+CHECK: Avoid CamelCase: <ASLdbm_currBSS>
+#466: FILE: drivers/staging/wlan-ng/hfa384x.h:466:
++ u16 ASLdbm_currBSS;
+
+CHECK: Avoid CamelCase: <ANLdbm_currFC>
+#467: FILE: drivers/staging/wlan-ng/hfa384x.h:467:
++ u16 ANLdbm_currFC;
+
+WARNING: do not add new typedefs
+#477: FILE: drivers/staging/wlan-ng/hfa384x.h:477:
++typedef struct hfa384x_tx_frame {
+
+WARNING: line over 80 characters
+#530: FILE: drivers/staging/wlan-ng/hfa384x.h:530:
++#define HFA384x_TX_SET(v, m, s) ((((u16)(v)) << ((u16)(s))) & ((u16)(m)))
+
+WARNING: do not add new typedefs
+#542: FILE: drivers/staging/wlan-ng/hfa384x.h:542:
++typedef struct hfa384x_rx_frame {
+
+WARNING: do not add new typedefs
+#613: FILE: drivers/staging/wlan-ng/hfa384x.h:613:
++typedef struct hfa384x_CommTallies16 {
+
+CHECK: Avoid CamelCase: <hfa384x_CommTallies16>
+#613: FILE: drivers/staging/wlan-ng/hfa384x.h:613:
++typedef struct hfa384x_CommTallies16 {
+
+CHECK: Avoid CamelCase: <hfa384x_CommTallies16_t>
+#635: FILE: drivers/staging/wlan-ng/hfa384x.h:635:
++} __packed hfa384x_CommTallies16_t;
+
+WARNING: do not add new typedefs
+#637: FILE: drivers/staging/wlan-ng/hfa384x.h:637:
++typedef struct hfa384x_CommTallies32 {
+
+CHECK: Avoid CamelCase: <hfa384x_CommTallies32>
+#637: FILE: drivers/staging/wlan-ng/hfa384x.h:637:
++typedef struct hfa384x_CommTallies32 {
+
+CHECK: Avoid CamelCase: <hfa384x_CommTallies32_t>
+#659: FILE: drivers/staging/wlan-ng/hfa384x.h:659:
++} __packed hfa384x_CommTallies32_t;
+
+WARNING: do not add new typedefs
+#662: FILE: drivers/staging/wlan-ng/hfa384x.h:662:
++typedef struct hfa384x_ScanResultSub {
+
+CHECK: Avoid CamelCase: <hfa384x_ScanResultSub>
+#662: FILE: drivers/staging/wlan-ng/hfa384x.h:662:
++typedef struct hfa384x_ScanResultSub {
+
+CHECK: Avoid CamelCase: <hfa384x_ScanResultSub_t>
+#672: FILE: drivers/staging/wlan-ng/hfa384x.h:672:
++} __packed hfa384x_ScanResultSub_t;
+
+WARNING: do not add new typedefs
+#674: FILE: drivers/staging/wlan-ng/hfa384x.h:674:
++typedef struct hfa384x_ScanResult {
+
+CHECK: Avoid CamelCase: <hfa384x_ScanResult>
+#674: FILE: drivers/staging/wlan-ng/hfa384x.h:674:
++typedef struct hfa384x_ScanResult {
+
+CHECK: Avoid CamelCase: <hfa384x_ScanResult_t>
+#678: FILE: drivers/staging/wlan-ng/hfa384x.h:678:
++} __packed hfa384x_ScanResult_t;
+
+WARNING: do not add new typedefs
+#681: FILE: drivers/staging/wlan-ng/hfa384x.h:681:
++typedef struct hfa384x_ChInfoResultSub {
+
+CHECK: Avoid CamelCase: <hfa384x_ChInfoResultSub>
+#681: FILE: drivers/staging/wlan-ng/hfa384x.h:681:
++typedef struct hfa384x_ChInfoResultSub {
+
+CHECK: Avoid CamelCase: <hfa384x_ChInfoResultSub_t>
+#686: FILE: drivers/staging/wlan-ng/hfa384x.h:686:
++} __packed hfa384x_ChInfoResultSub_t;
+
+WARNING: do not add new typedefs
+#691: FILE: drivers/staging/wlan-ng/hfa384x.h:691:
++typedef struct hfa384x_ChInfoResult {
+
+CHECK: Avoid CamelCase: <hfa384x_ChInfoResult>
+#691: FILE: drivers/staging/wlan-ng/hfa384x.h:691:
++typedef struct hfa384x_ChInfoResult {
+
+CHECK: Avoid CamelCase: <hfa384x_ChInfoResult_t>
+#694: FILE: drivers/staging/wlan-ng/hfa384x.h:694:
++} __packed hfa384x_ChInfoResult_t;
+
+WARNING: do not add new typedefs
+#697: FILE: drivers/staging/wlan-ng/hfa384x.h:697:
++typedef struct hfa384x_HScanResultSub {
+
+CHECK: Avoid CamelCase: <hfa384x_HScanResultSub>
+#697: FILE: drivers/staging/wlan-ng/hfa384x.h:697:
++typedef struct hfa384x_HScanResultSub {
+
+CHECK: Avoid CamelCase: <hfa384x_HScanResultSub_t>
+#708: FILE: drivers/staging/wlan-ng/hfa384x.h:708:
++} __packed hfa384x_HScanResultSub_t;
+
+WARNING: do not add new typedefs
+#710: FILE: drivers/staging/wlan-ng/hfa384x.h:710:
++typedef struct hfa384x_HScanResult {
+
+CHECK: Avoid CamelCase: <hfa384x_HScanResult>
+#710: FILE: drivers/staging/wlan-ng/hfa384x.h:710:
++typedef struct hfa384x_HScanResult {
+
+CHECK: Avoid CamelCase: <hfa384x_HScanResult_t>
+#714: FILE: drivers/staging/wlan-ng/hfa384x.h:714:
++} __packed hfa384x_HScanResult_t;
+
+WARNING: do not add new typedefs
+#726: FILE: drivers/staging/wlan-ng/hfa384x.h:726:
++typedef struct hfa384x_LinkStatus {
+
+CHECK: Avoid CamelCase: <hfa384x_LinkStatus>
+#726: FILE: drivers/staging/wlan-ng/hfa384x.h:726:
++typedef struct hfa384x_LinkStatus {
+
+CHECK: Avoid CamelCase: <hfa384x_LinkStatus_t>
+#728: FILE: drivers/staging/wlan-ng/hfa384x.h:728:
++} __packed hfa384x_LinkStatus_t;
+
+WARNING: do not add new typedefs
+#736: FILE: drivers/staging/wlan-ng/hfa384x.h:736:
++typedef struct hfa384x_AssocStatus {
+
+CHECK: Avoid CamelCase: <hfa384x_AssocStatus>
+#736: FILE: drivers/staging/wlan-ng/hfa384x.h:736:
++typedef struct hfa384x_AssocStatus {
+
+CHECK: Avoid CamelCase: <hfa384x_AssocStatus_t>
+#743: FILE: drivers/staging/wlan-ng/hfa384x.h:743:
++} __packed hfa384x_AssocStatus_t;
+
+WARNING: do not add new typedefs
+#747: FILE: drivers/staging/wlan-ng/hfa384x.h:747:
++typedef struct hfa384x_AuthRequest {
+
+CHECK: Avoid CamelCase: <hfa384x_AuthRequest>
+#747: FILE: drivers/staging/wlan-ng/hfa384x.h:747:
++typedef struct hfa384x_AuthRequest {
+
+CHECK: Avoid CamelCase: <hfa384x_AuthReq_t>
+#750: FILE: drivers/staging/wlan-ng/hfa384x.h:750:
++} __packed hfa384x_AuthReq_t;
+
+WARNING: do not add new typedefs
+#754: FILE: drivers/staging/wlan-ng/hfa384x.h:754:
++typedef struct hfa384x_PSUserCount {
+
+CHECK: Avoid CamelCase: <hfa384x_PSUserCount>
+#754: FILE: drivers/staging/wlan-ng/hfa384x.h:754:
++typedef struct hfa384x_PSUserCount {
+
+CHECK: Avoid CamelCase: <hfa384x_PSUserCount_t>
+#756: FILE: drivers/staging/wlan-ng/hfa384x.h:756:
++} __packed hfa384x_PSUserCount_t;
+
+WARNING: do not add new typedefs
+#758: FILE: drivers/staging/wlan-ng/hfa384x.h:758:
++typedef struct hfa384x_KeyIDChanged {
+
+CHECK: Avoid CamelCase: <hfa384x_KeyIDChanged>
+#758: FILE: drivers/staging/wlan-ng/hfa384x.h:758:
++typedef struct hfa384x_KeyIDChanged {
+
+CHECK: Avoid CamelCase: <hfa384x_KeyIDChanged_t>
+#761: FILE: drivers/staging/wlan-ng/hfa384x.h:761:
++} __packed hfa384x_KeyIDChanged_t;
+
+WARNING: do not add new typedefs
+#764: FILE: drivers/staging/wlan-ng/hfa384x.h:764:
++typedef union hfa384x_infodata {
+
+WARNING: do not add new typedefs
+#777: FILE: drivers/staging/wlan-ng/hfa384x.h:777:
++typedef struct hfa384x_InfFrame {
+
+CHECK: Avoid CamelCase: <hfa384x_InfFrame>
+#777: FILE: drivers/staging/wlan-ng/hfa384x.h:777:
++typedef struct hfa384x_InfFrame {
+
+CHECK: Avoid CamelCase: <hfa384x_InfFrame_t>
+#781: FILE: drivers/staging/wlan-ng/hfa384x.h:781:
++} __packed hfa384x_InfFrame_t;
+
+WARNING: do not add new typedefs
+#811: FILE: drivers/staging/wlan-ng/hfa384x.h:811:
++typedef struct hfa384x_usb_txfrm {
+
+WARNING: do not add new typedefs
+#816: FILE: drivers/staging/wlan-ng/hfa384x.h:816:
++typedef struct hfa384x_usb_cmdreq {
+
+WARNING: do not add new typedefs
+#825: FILE: drivers/staging/wlan-ng/hfa384x.h:825:
++typedef struct hfa384x_usb_wridreq {
+
+WARNING: do not add new typedefs
+#832: FILE: drivers/staging/wlan-ng/hfa384x.h:832:
++typedef struct hfa384x_usb_rridreq {
+
+WARNING: do not add new typedefs
+#839: FILE: drivers/staging/wlan-ng/hfa384x.h:839:
++typedef struct hfa384x_usb_wmemreq {
+
+WARNING: do not add new typedefs
+#847: FILE: drivers/staging/wlan-ng/hfa384x.h:847:
++typedef struct hfa384x_usb_rmemreq {
+
+WARNING: do not add new typedefs
+#858: FILE: drivers/staging/wlan-ng/hfa384x.h:858:
++typedef struct hfa384x_usb_rxfrm {
+
+WARNING: do not add new typedefs
+#863: FILE: drivers/staging/wlan-ng/hfa384x.h:863:
++typedef struct hfa384x_usb_infofrm {
+
+WARNING: do not add new typedefs
+#868: FILE: drivers/staging/wlan-ng/hfa384x.h:868:
++typedef struct hfa384x_usb_statusresp {
+
+WARNING: do not add new typedefs
+#876: FILE: drivers/staging/wlan-ng/hfa384x.h:876:
++typedef hfa384x_usb_cmdresp_t hfa384x_usb_wridresp_t;
+
+WARNING: do not add new typedefs
+#878: FILE: drivers/staging/wlan-ng/hfa384x.h:878:
++typedef struct hfa384x_usb_rridresp {
+
+WARNING: do not add new typedefs
+#885: FILE: drivers/staging/wlan-ng/hfa384x.h:885:
++typedef hfa384x_usb_cmdresp_t hfa384x_usb_wmemresp_t;
+
+WARNING: do not add new typedefs
+#887: FILE: drivers/staging/wlan-ng/hfa384x.h:887:
++typedef struct hfa384x_usb_rmemresp {
+
+WARNING: do not add new typedefs
+#893: FILE: drivers/staging/wlan-ng/hfa384x.h:893:
++typedef struct hfa384x_usb_bufavail {
+
+WARNING: do not add new typedefs
+#898: FILE: drivers/staging/wlan-ng/hfa384x.h:898:
++typedef struct hfa384x_usb_error {
+
+WARNING: do not add new typedefs
+#906: FILE: drivers/staging/wlan-ng/hfa384x.h:906:
++typedef union hfa384x_usbout {
+
+WARNING: do not add new typedefs
+#916: FILE: drivers/staging/wlan-ng/hfa384x.h:916:
++typedef union hfa384x_usbin {
+
+WARNING: do not add new typedefs
+#936: FILE: drivers/staging/wlan-ng/hfa384x.h:936:
++typedef struct hfa384x_pdr_pcb_partnum {
+
+WARNING: do not add new typedefs
+#940: FILE: drivers/staging/wlan-ng/hfa384x.h:940:
++typedef struct hfa384x_pdr_pcb_tracenum {
+
+WARNING: do not add new typedefs
+#944: FILE: drivers/staging/wlan-ng/hfa384x.h:944:
++typedef struct hfa384x_pdr_nic_serial {
+
+WARNING: do not add new typedefs
+#948: FILE: drivers/staging/wlan-ng/hfa384x.h:948:
++typedef struct hfa384x_pdr_mkk_measurements {
+
+WARNING: do not add new typedefs
+#966: FILE: drivers/staging/wlan-ng/hfa384x.h:966:
++typedef struct hfa384x_pdr_nic_ramsize {
+
+WARNING: do not add new typedefs
+#970: FILE: drivers/staging/wlan-ng/hfa384x.h:970:
++typedef struct hfa384x_pdr_mfisuprange {
+
+WARNING: do not add new typedefs
+#977: FILE: drivers/staging/wlan-ng/hfa384x.h:977:
++typedef struct hfa384x_pdr_cfisuprange {
+
+WARNING: do not add new typedefs
+#984: FILE: drivers/staging/wlan-ng/hfa384x.h:984:
++typedef struct hfa384x_pdr_nicid {
+
+WARNING: do not add new typedefs
+#991: FILE: drivers/staging/wlan-ng/hfa384x.h:991:
++typedef struct hfa384x_pdr_refdac_measurements {
+
+WARNING: do not add new typedefs
+#995: FILE: drivers/staging/wlan-ng/hfa384x.h:995:
++typedef struct hfa384x_pdr_vgdac_measurements {
+
+WARNING: do not add new typedefs
+#999: FILE: drivers/staging/wlan-ng/hfa384x.h:999:
++typedef struct hfa384x_pdr_level_comp_measurements {
+
+WARNING: do not add new typedefs
+#1003: FILE: drivers/staging/wlan-ng/hfa384x.h:1003:
++typedef struct hfa384x_pdr_mac_address {
+
+WARNING: do not add new typedefs
+#1007: FILE: drivers/staging/wlan-ng/hfa384x.h:1007:
++typedef struct hfa384x_pdr_mkk_callname {
+
+WARNING: do not add new typedefs
+#1011: FILE: drivers/staging/wlan-ng/hfa384x.h:1011:
++typedef struct hfa384x_pdr_regdomain {
+
+WARNING: do not add new typedefs
+#1016: FILE: drivers/staging/wlan-ng/hfa384x.h:1016:
++typedef struct hfa384x_pdr_allowed_channel {
+
+WARNING: do not add new typedefs
+#1020: FILE: drivers/staging/wlan-ng/hfa384x.h:1020:
++typedef struct hfa384x_pdr_default_channel {
+
+WARNING: do not add new typedefs
+#1024: FILE: drivers/staging/wlan-ng/hfa384x.h:1024:
++typedef struct hfa384x_pdr_privacy_option {
+
+WARNING: do not add new typedefs
+#1028: FILE: drivers/staging/wlan-ng/hfa384x.h:1028:
++typedef struct hfa384x_pdr_temptype {
+
+WARNING: do not add new typedefs
+#1032: FILE: drivers/staging/wlan-ng/hfa384x.h:1032:
++typedef struct hfa384x_pdr_refdac_setup {
+
+WARNING: do not add new typedefs
+#1036: FILE: drivers/staging/wlan-ng/hfa384x.h:1036:
++typedef struct hfa384x_pdr_vgdac_setup {
+
+WARNING: do not add new typedefs
+#1040: FILE: drivers/staging/wlan-ng/hfa384x.h:1040:
++typedef struct hfa384x_pdr_level_comp_setup {
+
+WARNING: do not add new typedefs
+#1044: FILE: drivers/staging/wlan-ng/hfa384x.h:1044:
++typedef struct hfa384x_pdr_trimdac_setup {
+
+WARNING: do not add new typedefs
+#1049: FILE: drivers/staging/wlan-ng/hfa384x.h:1049:
++typedef struct hfa384x_pdr_ifr_setting {
+
+WARNING: do not add new typedefs
+#1053: FILE: drivers/staging/wlan-ng/hfa384x.h:1053:
++typedef struct hfa384x_pdr_rfr_setting {
+
+WARNING: do not add new typedefs
+#1057: FILE: drivers/staging/wlan-ng/hfa384x.h:1057:
++typedef struct hfa384x_pdr_hfa3861_baseline {
+
+WARNING: do not add new typedefs
+#1061: FILE: drivers/staging/wlan-ng/hfa384x.h:1061:
++typedef struct hfa384x_pdr_hfa3861_shadow {
+
+WARNING: do not add new typedefs
+#1065: FILE: drivers/staging/wlan-ng/hfa384x.h:1065:
++typedef struct hfa384x_pdr_hfa3861_ifrf {
+
+WARNING: do not add new typedefs
+#1069: FILE: drivers/staging/wlan-ng/hfa384x.h:1069:
++typedef struct hfa384x_pdr_hfa3861_chcalsp {
+
+WARNING: do not add new typedefs
+#1073: FILE: drivers/staging/wlan-ng/hfa384x.h:1073:
++typedef struct hfa384x_pdr_hfa3861_chcali {
+
+WARNING: do not add new typedefs
+#1077: FILE: drivers/staging/wlan-ng/hfa384x.h:1077:
++typedef struct hfa384x_pdr_hfa3861_nic_config {
+
+WARNING: do not add new typedefs
+#1081: FILE: drivers/staging/wlan-ng/hfa384x.h:1081:
++typedef struct hfa384x_pdr_hfo_delay {
+
+WARNING: do not add new typedefs
+#1085: FILE: drivers/staging/wlan-ng/hfa384x.h:1085:
++typedef struct hfa384x_pdr_hfa3861_manf_testsp {
+
+WARNING: do not add new typedefs
+#1089: FILE: drivers/staging/wlan-ng/hfa384x.h:1089:
++typedef struct hfa384x_pdr_hfa3861_manf_testi {
+
+WARNING: do not add new typedefs
+#1093: FILE: drivers/staging/wlan-ng/hfa384x.h:1093:
++typedef struct hfa384x_end_of_pda {
+
+WARNING: do not add new typedefs
+#1097: FILE: drivers/staging/wlan-ng/hfa384x.h:1097:
++typedef struct hfa384x_pdrec {
+
+WARNING: do not add new typedefs
+#1145: FILE: drivers/staging/wlan-ng/hfa384x.h:1145:
++typedef struct hfa384x_statusresult {
+
+WARNING: do not add new typedefs
+#1159: FILE: drivers/staging/wlan-ng/hfa384x.h:1159:
++typedef struct hfa384x_rridresult {
+
+CHECK: Please use a blank line after function/struct/union/enum declarations
+#1176: FILE: drivers/staging/wlan-ng/hfa384x.h:1176:
++};
++typedef enum ctlx_state CTLX_STATE;
+
+WARNING: do not add new typedefs
+#1176: FILE: drivers/staging/wlan-ng/hfa384x.h:1176:
++typedef enum ctlx_state CTLX_STATE;
+
+WARNING: do not add new typedefs
+#1186: FILE: drivers/staging/wlan-ng/hfa384x.h:1186:
++typedef struct hfa384x_usbctlx {
+
+WARNING: Missing a blank line after declarations
+#1196: FILE: drivers/staging/wlan-ng/hfa384x.h:1196:
++ struct completion done;
++ volatile int reapable; /* Food for the reaper task */
+
+WARNING: Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt
+#1196: FILE: drivers/staging/wlan-ng/hfa384x.h:1196:
++ volatile int reapable; /* Food for the reaper task */
+
+WARNING: do not add new typedefs
+#1205: FILE: drivers/staging/wlan-ng/hfa384x.h:1205:
++typedef struct hfa384x_usbctlxq {
+
+CHECK: spinlock_t definition without comment
+#1206: FILE: drivers/staging/wlan-ng/hfa384x.h:1206:
++ spinlock_t lock;
+
+WARNING: do not add new typedefs
+#1213: FILE: drivers/staging/wlan-ng/hfa384x.h:1213:
++typedef struct hfa484x_metacmd {
+
+WARNING: do not add new typedefs
+#1248: FILE: drivers/staging/wlan-ng/hfa384x.h:1248:
++typedef struct hfa384x {
+
+WARNING: line over 80 characters
+#1379: FILE: drivers/staging/wlan-ng/hfa384x.h:1379:
++ struct prism2sta_authlist authlist; /* Authenticated station list. */
+
+CHECK: No space is necessary after a cast
+#1409: FILE: drivers/staging/wlan-ng/hfa384x.h:1409:
++ *((u16 *) val) = le16_to_cpu(*((u16 *) val));
+
+total: 0 errors, 90 warnings, 49 checks, 1454 lines checked
+
+NOTE: For some of the reported defects, checkpatch may be able to
+ mechanically convert to the typical style using --fix or --fix-inplace.
+
+drivers/staging/wlan-ng/hfa384x.h has style problems, please review.
+
+NOTE: If any of the errors are false positives, please report
+ them to the maintainer, see CHECKPATCH in MAINTAINERS.
--
2.9.2
^ permalink raw reply related [flat|nested] 17+ messages in thread
* [PATCH 7/8] staging: wlan-ng: add blank line after declaration
2016-09-16 2:46 [PATCH 0/8] fix multiple checkpatch issues Gargi Sharma
` (5 preceding siblings ...)
2016-09-16 2:46 ` [PATCH 6/8] staging: wlan-ng: delete space after a cast Gargi Sharma
@ 2016-09-16 2:46 ` Gargi Sharma
2016-09-16 5:35 ` [Outreachy kernel] " Julia Lawall
2016-09-16 2:46 ` [PATCH 8/8] staging: wlan-ng: fix block comment style Gargi Sharma
7 siblings, 1 reply; 17+ messages in thread
From: Gargi Sharma @ 2016-09-16 2:46 UTC (permalink / raw)
To: outreachy-kernel; +Cc: gregkh, Gargi Sharma
add blank line after struct declaration to fix the checkpatch issue,
Missing a blank line after declarations.
Signed-off-by: Gargi Sharma <gs051095@gmail.com>
---
drivers/staging/wlan-ng/hfa384x.h | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h
index 2ff3805..1fc34c7 100644
--- a/drivers/staging/wlan-ng/hfa384x.h
+++ b/drivers/staging/wlan-ng/hfa384x.h
@@ -1166,7 +1166,8 @@ typedef struct hfa384x_usbctlx {
CTLX_STATE state; /* Tracks running state */
struct completion done;
- volatile int reapable; /* Food for the reaper task */
+
+ volatile int reapable;/* Food for the reaper task */
ctlx_cmdcb_t cmdcb; /* Async command callback */
ctlx_usercb_t usercb; /* Async user callback, */
@@ -1378,7 +1379,7 @@ static inline int hfa384x_drvr_getconfig16(hfa384x_t *hw, u16 rid, void *val)
result = hfa384x_drvr_getconfig(hw, rid, val, sizeof(u16));
if (result == 0)
- *((u16 *)val) = le16_to_cpu(*((u16 *) val));
+ *((u16 *)val) = le16_to_cpu(*((u16 *)val));
return result;
}
--
2.9.2
^ permalink raw reply related [flat|nested] 17+ messages in thread
* [PATCH 8/8] staging: wlan-ng: fix block comment style
2016-09-16 2:46 [PATCH 0/8] fix multiple checkpatch issues Gargi Sharma
` (6 preceding siblings ...)
2016-09-16 2:46 ` [PATCH 7/8] staging: wlan-ng: add blank line after declaration Gargi Sharma
@ 2016-09-16 2:46 ` Gargi Sharma
2016-09-16 5:33 ` [Outreachy kernel] " Julia Lawall
7 siblings, 1 reply; 17+ messages in thread
From: Gargi Sharma @ 2016-09-16 2:46 UTC (permalink / raw)
To: outreachy-kernel; +Cc: gregkh, Gargi Sharma
move trailing markers to next line to fix the checkpatch issue Block
comments use a trailing */ on a separate line. Also, added * to the
multi-line comment to increase readability.
Signed-off-by: Gargi Sharma <gs051095@gmail.com>
---
drivers/staging/wlan-ng/hfa384x.h | 226 +++++++++++++++++++++-----------------
1 file changed, 127 insertions(+), 99 deletions(-)
diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h
index 1fc34c7..7a7ba27 100644
--- a/drivers/staging/wlan-ng/hfa384x.h
+++ b/drivers/staging/wlan-ng/hfa384x.h
@@ -110,7 +110,8 @@
#define HFA384x_ADDR_FLAT_CMD_OFF_MASK (0x0000ffff)
/* Mask bits for discarding unwanted pieces in AUX format
- 16-bit address parts */
+ * 16-bit address parts
+ */
#define HFA384x_ADDR_AUX_PAGE_MASK (0xffff)
#define HFA384x_ADDR_AUX_OFF_MASK (0x007f)
@@ -172,21 +173,23 @@
/*--- Result Codes --------------------------*/
#define HFA384x_CMD_ERR ((u16)(0x7F))
-/*--- Programming Modes --------------------------
- MODE 0: Disable programming
- MODE 1: Enable volatile memory programming
- MODE 2: Enable non-volatile memory programming
- MODE 3: Program non-volatile memory section
---------------------------------------------------*/
+/* --- Programming Modes --------------------------
+ * MODE 0: Disable programming
+ * MODE 1: Enable volatile memory programming
+ * MODE 2: Enable non-volatile memory programming
+ * MODE 3: Program non-volatile memory section
+ * ------------------------------------------------
+ */
#define HFA384x_PROGMODE_DISABLE ((u16)0x00)
#define HFA384x_PROGMODE_RAM ((u16)0x01)
#define HFA384x_PROGMODE_NV ((u16)0x02)
#define HFA384x_PROGMODE_NVWRITE ((u16)0x03)
/*--- Record ID Constants --------------------------*/
-/*--------------------------------------------------------------------
-Configuration RIDs: Network Parameters, Static Configuration Entities
---------------------------------------------------------------------*/
+/* -------------------------------------------------------------------
+ * Configuration RIDs: Network Parameters, Static Configuration Entities
+ * -------------------------------------------------------------------
+ */
#define HFA384x_RID_CNFPORTTYPE ((u16)0xFC00)
#define HFA384x_RID_CNFOWNMACADDR ((u16)0xFC01)
#define HFA384x_RID_CNFDESIREDSSID ((u16)0xFC02)
@@ -194,27 +197,30 @@ Configuration RIDs: Network Parameters, Static Configuration Entities
#define HFA384x_RID_CNFOWNSSID ((u16)0xFC04)
#define HFA384x_RID_CNFMAXDATALEN ((u16)0xFC07)
-/*--------------------------------------------------------------------
-Configuration RID lengths: Network Params, Static Config Entities
- This is the length of JUST the DATA part of the RID (does not
- include the len or code fields)
---------------------------------------------------------------------*/
+/* -------------------------------------------------------------------
+ * Configuration RID lengths: Network Params, Static Config Entities
+ * This is the length of JUST the DATA part of the RID (does not
+ * include the len or code fields)
+ * -------------------------------------------------------------------
+ */
#define HFA384x_RID_CNFOWNMACADDR_LEN ((u16)6)
#define HFA384x_RID_CNFDESIREDSSID_LEN ((u16)34)
#define HFA384x_RID_CNFOWNSSID_LEN ((u16)34)
-/*--------------------------------------------------------------------
-Configuration RIDs: Network Parameters, Dynamic Configuration Entities
---------------------------------------------------------------------*/
+/* --------------------------------------------------------------------
+ * Configuration RIDs: Network Parameters, Dynamic Configuration Entities
+ * --------------------------------------------------------------------
+ */
#define HFA384x_RID_CREATEIBSS ((u16)0xFC81)
#define HFA384x_RID_FRAGTHRESH ((u16)0xFC82)
#define HFA384x_RID_RTSTHRESH ((u16)0xFC83)
#define HFA384x_RID_TXRATECNTL ((u16)0xFC84)
#define HFA384x_RID_PROMISCMODE ((u16)0xFC85)
-/*----------------------------------------------------------------------
-Information RIDs: NIC Information
---------------------------------------------------------------------*/
+/* --------------------------------------------------------------------
+ * Information RIDs: NIC Information
+ * --------------------------------------------------------------------
+ */
#define HFA384x_RID_MAXLOADTIME ((u16)0xFD00)
#define HFA384x_RID_DOWNLOADBUFFER ((u16)0xFD01)
#define HFA384x_RID_PRIIDENTITY ((u16)0xFD02)
@@ -229,16 +235,18 @@ Information RIDs: NIC Information
#define HFA384x_RID_STA_MFIACTRANGES ((u16)0xFD22)
#define HFA384x_RID_STA_CFIACTRANGES ((u16)0xFD23)
-/*----------------------------------------------------------------------
-Information RID Lengths: NIC Information
- This is the length of JUST the DATA part of the RID (does not
- include the len or code fields)
---------------------------------------------------------------------*/
+/* --------------------------------------------------------------------
+ * Information RID Lengths: NIC Information
+ * This is the length of JUST the DATA part of the RID (does not
+ * include the len or code fields)
+ * --------------------------------------------------------------------
+ */
#define HFA384x_RID_NICSERIALNUMBER_LEN ((u16)12)
-/*--------------------------------------------------------------------
-Information RIDs: MAC Information
---------------------------------------------------------------------*/
+/* --------------------------------------------------------------------
+ * Information RIDs: MAC Information
+ * --------------------------------------------------------------------
+ */
#define HFA384x_RID_PORTSTATUS ((u16)0xFD40)
#define HFA384x_RID_CURRENTSSID ((u16)0xFD41)
#define HFA384x_RID_CURRENTBSSID ((u16)0xFD42)
@@ -249,24 +257,27 @@ Information RIDs: MAC Information
#define HFA384x_RID_PRIVACYOPTIMP ((u16)0xFD4F)
#define HFA384x_RID_DBMCOMMSQUALITY ((u16)0xFD51)
-/*--------------------------------------------------------------------
-Information RID Lengths: MAC Information
- This is the length of JUST the DATA part of the RID (does not
- include the len or code fields)
---------------------------------------------------------------------*/
+/* -------------------------------------------------------------------
+ * Information RID Lengths: MAC Information
+ * This is the length of JUST the DATA part of the RID (does not
+ * include the len or code fields)
+ * -------------------------------------------------------------------
+ */
#define HFA384x_RID_DBMCOMMSQUALITY_LEN \
((u16)sizeof(hfa384x_dbmcommsquality_t))
#define HFA384x_RID_JOINREQUEST_LEN \
((u16)sizeof(hfa384x_JoinRequest_data_t))
-/*--------------------------------------------------------------------
-Information RIDs: Modem Information
---------------------------------------------------------------------*/
+/* --------------------------------------------------------------------
+ * Information RIDs: Modem Information
+ * --------------------------------------------------------------------
+ */
#define HFA384x_RID_CURRENTCHANNEL ((u16)0xFDC1)
-/*--------------------------------------------------------------------
-API ENHANCEMENTS (NOT ALREADY IMPLEMENTED)
---------------------------------------------------------------------*/
+/* --------------------------------------------------------------------
+ * API ENHANCEMENTS (NOT ALREADY IMPLEMENTED)
+ * --------------------------------------------------------------------
+ */
#define HFA384x_RID_CNFWEPDEFAULTKEYID ((u16)0xFC23)
#define HFA384x_RID_CNFWEPDEFAULTKEY0 ((u16)0xFC24)
#define HFA384x_RID_CNFWEPDEFAULTKEY1 ((u16)0xFC25)
@@ -289,9 +300,10 @@ API ENHANCEMENTS (NOT ALREADY IMPLEMENTED)
#define HFA384x_RID_CNFWEPDEFAULTKEY_LEN ((u16)6)
#define HFA384x_RID_CNFWEP128DEFAULTKEY_LEN ((u16)14)
-/*--------------------------------------------------------------------
-PD Record codes
---------------------------------------------------------------------*/
+/* --------------------------------------------------------------------
+ * PD Record codes
+ * --------------------------------------------------------------------
+ */
#define HFA384x_PDR_PCB_PARTNUM ((u16)0x0001)
#define HFA384x_PDR_PDAVER ((u16)0x0002)
#define HFA384x_PDR_NIC_SERIAL ((u16)0x0003)
@@ -360,10 +372,11 @@ typedef struct hfa384x_bytestr32 {
u8 data[32];
} __packed hfa384x_bytestr32_t;
-/*--------------------------------------------------------------------
-Configuration Record Structures:
- Network Parameters, Static Configuration Entities
---------------------------------------------------------------------*/
+/* --------------------------------------------------------------------
+ * Configuration Record Structures:
+ * Network Parameters, Static Configuration Entities
+ * --------------------------------------------------------------------
+ */
/*-- Hardware/Firmware Component Information ----------*/
typedef struct hfa384x_compident {
@@ -386,10 +399,11 @@ typedef struct hfa384x_caplevel {
#define HFA384x_CNFAUTHENTICATION_SHAREDKEY 0x0002
#define HFA384x_CNFAUTHENTICATION_LEAP 0x0004
-/*--------------------------------------------------------------------
-Configuration Record Structures:
- Network Parameters, Dynamic Configuration Entities
---------------------------------------------------------------------*/
+/* --------------------------------------------------------------------
+ * Configuration Record Structures:
+ * Network Parameters, Dynamic Configuration Entities
+ * --------------------------------------------------------------------
+ */
#define HFA384x_CREATEIBSS_JOINCREATEIBSS 0
@@ -419,9 +433,10 @@ typedef struct hfa384x_WPAData {
u8 data[0]; /* max 80 */
} __packed hfa384x_WPAData_t;
-/*--------------------------------------------------------------------
-Information Record Structures: NIC Information
---------------------------------------------------------------------*/
+/* --------------------------------------------------------------------
+ * Information Record Structures: NIC Information
+ * --------------------------------------------------------------------
+ */
/*-- Information Record: DownLoadBuffer --*/
/* NOTE: The page and offset are in AUX format */
@@ -431,9 +446,10 @@ typedef struct hfa384x_downloadbuffer {
u16 len;
} __packed hfa384x_downloadbuffer_t;
-/*--------------------------------------------------------------------
-Information Record Structures: NIC Information
---------------------------------------------------------------------*/
+/* --------------------------------------------------------------------
+ * Information Record Structures: NIC Information
+ * --------------------------------------------------------------------
+ */
#define HFA384x_PSTATUS_CONN_IBSS ((u16)3)
@@ -451,11 +467,12 @@ typedef struct hfa384x_dbmcommsquality {
u16 ANLdbm_currFC;
} __packed hfa384x_dbmcommsquality_t;
-/*--------------------------------------------------------------------
-FRAME STRUCTURES: Communication Frames
-----------------------------------------------------------------------
-Communication Frames: Transmit Frames
---------------------------------------------------------------------*/
+/* --------------------------------------------------------------------
+ * FRAME STRUCTURES: Communication Frames
+ * --------------------------------------------------------------------
+ * Communication Frames: Transmit Frames
+ * --------------------------------------------------------------------
+ */
/*-- Communication Frame: Transmit Frame Structure --*/
typedef struct hfa384x_tx_frame {
u16 status;
@@ -483,9 +500,10 @@ typedef struct hfa384x_tx_frame {
u8 src_addr[6];
u16 data_length; /* big endian format */
} __packed hfa384x_tx_frame_t;
-/*--------------------------------------------------------------------
-Communication Frames: Field Masks for Transmit Frames
---------------------------------------------------------------------*/
+/* --------------------------------------------------------------------
+ * Communication Frames: Field Masks for Transmit Frames
+ * --------------------------------------------------------------------
+ */
/*-- Status Field --*/
#define HFA384x_TXSTATUS_ACKERR ((u16)BIT(5))
#define HFA384x_TXSTATUS_FORMERR ((u16)BIT(3))
@@ -498,9 +516,10 @@ Communication Frames: Field Masks for Transmit Frames
#define HFA384x_TX_STRUCTYPE ((u16)(BIT(4) | BIT(3)))
#define HFA384x_TX_TXEX ((u16)BIT(2))
#define HFA384x_TX_TXOK ((u16)BIT(1))
-/*--------------------------------------------------------------------
-Communication Frames: Test/Get/Set Field Values for Transmit Frames
---------------------------------------------------------------------*/
+/* --------------------------------------------------------------------
+ * Communication Frames: Test/Get/Set Field Values for Transmit Frames
+ * --------------------------------------------------------------------
+ */
/*-- Status Field --*/
#define HFA384x_TXSTATUS_ISERROR(v) \
(((u16)(v)) & \
@@ -515,9 +534,10 @@ Communication Frames: Test/Get/Set Field Values for Transmit Frames
HFA384x_TX_STRUCTYPE, 3)
#define HFA384x_TX_TXEX_SET(v) HFA384x_TX_SET(v, HFA384x_TX_TXEX, 2)
#define HFA384x_TX_TXOK_SET(v) HFA384x_TX_SET(v, HFA384x_TX_TXOK, 1)
-/*--------------------------------------------------------------------
-Communication Frames: Receive Frames
---------------------------------------------------------------------*/
+/* --------------------------------------------------------------------
+ * Communication Frames: Receive Frames
+ * --------------------------------------------------------------------
+ */
/*-- Communication Frame: Receive Frame Structure --*/
typedef struct hfa384x_rx_frame {
/*-- MAC rx descriptor (hfa384x byte order) --*/
@@ -545,27 +565,30 @@ typedef struct hfa384x_rx_frame {
u8 src_addr[6];
u16 data_length; /* IEEE? (big endian) format */
} __packed hfa384x_rx_frame_t;
-/*--------------------------------------------------------------------
-Communication Frames: Field Masks for Receive Frames
---------------------------------------------------------------------*/
+/* --------------------------------------------------------------------
+ * Communication Frames: Field Masks for Receive Frames
+ * --------------------------------------------------------------------
+ */
/*-- Status Fields --*/
#define HFA384x_RXSTATUS_MACPORT ((u16)(BIT(10) | \
BIT(9) | \
BIT(8)))
#define HFA384x_RXSTATUS_FCSERR ((u16)BIT(0))
-/*--------------------------------------------------------------------
-Communication Frames: Test/Get/Set Field Values for Receive Frames
---------------------------------------------------------------------*/
+/* --------------------------------------------------------------------
+ * Communication Frames: Test/Get/Set Field Values for Receive Frames
+ * --------------------------------------------------------------------
+ */
#define HFA384x_RXSTATUS_MACPORT_GET(value) ((u16)((((u16)(value)) \
& HFA384x_RXSTATUS_MACPORT) >> 8))
#define HFA384x_RXSTATUS_ISFCSERR(value) ((u16)(((u16)(value)) \
& HFA384x_RXSTATUS_FCSERR))
-/*--------------------------------------------------------------------
- FRAME STRUCTURES: Information Types and Information Frame Structures
-----------------------------------------------------------------------
-Information Types
---------------------------------------------------------------------*/
+/* --------------------------------------------------------------------
+ * FRAME STRUCTURES: Information Types and Information Frame Structures
+ * --------------------------------------------------------------------
+ * Information Types
+ * --------------------------------------------------------------------
+ */
#define HFA384x_IT_HANDOVERADDR ((u16)0xF000UL)
#define HFA384x_IT_COMMTALLIES ((u16)0xF100UL)
#define HFA384x_IT_SCANRESULTS ((u16)0xF101UL)
@@ -579,11 +602,12 @@ Information Types
#define HFA384x_IT_ASSOCREQ ((u16)0xF205UL)
#define HFA384x_IT_MICFAILURE ((u16)0xF206UL)
-/*--------------------------------------------------------------------
-Information Frames Structures
-----------------------------------------------------------------------
-Information Frames: Notification Frame Structures
---------------------------------------------------------------------*/
+/* --------------------------------------------------------------------
+ * Information Frames Structures
+ * --------------------------------------------------------------------
+ * Information Frames: Notification Frame Structures
+ * --------------------------------------------------------------------
+ */
/*-- Inquiry Frame, Diagnose: Communication Tallies --*/
typedef struct hfa384x_CommTallies16 {
@@ -756,9 +780,10 @@ typedef struct hfa384x_InfFrame {
hfa384x_infodata_t info;
} __packed hfa384x_InfFrame_t;
-/*--------------------------------------------------------------------
-USB Packet structures and constants.
---------------------------------------------------------------------*/
+/* --------------------------------------------------------------------
+ * USB Packet structures and constants.
+ * --------------------------------------------------------------------
+ */
/* Should be sent to the bulkout endpoint */
#define HFA384x_USB_TXFRM 0
@@ -903,9 +928,10 @@ typedef union hfa384x_usbin {
u8 boguspad[3000];
} __packed hfa384x_usbin_t;
-/*--------------------------------------------------------------------
-PD record structures.
---------------------------------------------------------------------*/
+/* --------------------------------------------------------------------
+ * PD record structures.
+ * --------------------------------------------------------------------
+ */
typedef struct hfa384x_pdr_pcb_partnum {
u8 num[8];
@@ -1111,10 +1137,11 @@ typedef struct hfa384x_pdrec {
} __packed hfa384x_pdrec_t;
#ifdef __KERNEL__
-/*--------------------------------------------------------------------
---- MAC state structure, argument to all functions --
---- Also, a collection of support types --
---------------------------------------------------------------------*/
+/* --------------------------------------------------------------------
+ * --- MAC state structure, argument to all functions --
+ * --- Also, a collection of support types --
+ * --------------------------------------------------------------------
+ */
typedef struct hfa384x_statusresult {
u16 status;
u16 resp0;
@@ -1298,7 +1325,8 @@ typedef struct hfa384x {
int dbmadjust;
/* Group Addresses - right now, there are up to a total
- of MAX_GRP_ADDR group addresses */
+ * of MAX_GRP_ADDR group addresses
+ */
u8 dot11_grp_addr[MAX_GRP_ADDR][ETH_ALEN];
unsigned int dot11_grpcnt;
@@ -1424,4 +1452,4 @@ hfa384x_cmd_download(hfa384x_t *hw,
#endif /*__KERNEL__ */
-#endif /*_HFA384x_H */
+#endif /*_HFA384x_H */
\ No newline at end of file
--
2.9.2
^ permalink raw reply related [flat|nested] 17+ messages in thread
* Re: [Outreachy kernel] [PATCH 8/8] staging: wlan-ng: fix block comment style
2016-09-16 2:46 ` [PATCH 8/8] staging: wlan-ng: fix block comment style Gargi Sharma
@ 2016-09-16 5:33 ` Julia Lawall
2016-09-16 5:40 ` Alison Schofield
0 siblings, 1 reply; 17+ messages in thread
From: Julia Lawall @ 2016-09-16 5:33 UTC (permalink / raw)
To: Gargi Sharma; +Cc: outreachy-kernel, gregkh
On Fri, 16 Sep 2016, Gargi Sharma wrote:
> move trailing markers to next line to fix the checkpatch issue Block
> comments use a trailing */ on a separate line. Also, added * to the
> multi-line comment to increase readability.
I think you could drop all of the --------------------.
That serves sort of the same role as the /* and */ on separate lines.
Most of the kernel doesn't do that.
julia
> Signed-off-by: Gargi Sharma <gs051095@gmail.com>
> ---
> drivers/staging/wlan-ng/hfa384x.h | 226 +++++++++++++++++++++-----------------
> 1 file changed, 127 insertions(+), 99 deletions(-)
>
> diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h
> index 1fc34c7..7a7ba27 100644
> --- a/drivers/staging/wlan-ng/hfa384x.h
> +++ b/drivers/staging/wlan-ng/hfa384x.h
> @@ -110,7 +110,8 @@
> #define HFA384x_ADDR_FLAT_CMD_OFF_MASK (0x0000ffff)
>
> /* Mask bits for discarding unwanted pieces in AUX format
> - 16-bit address parts */
> + * 16-bit address parts
> + */
> #define HFA384x_ADDR_AUX_PAGE_MASK (0xffff)
> #define HFA384x_ADDR_AUX_OFF_MASK (0x007f)
>
> @@ -172,21 +173,23 @@
> /*--- Result Codes --------------------------*/
> #define HFA384x_CMD_ERR ((u16)(0x7F))
>
> -/*--- Programming Modes --------------------------
> - MODE 0: Disable programming
> - MODE 1: Enable volatile memory programming
> - MODE 2: Enable non-volatile memory programming
> - MODE 3: Program non-volatile memory section
> ---------------------------------------------------*/
> +/* --- Programming Modes --------------------------
> + * MODE 0: Disable programming
> + * MODE 1: Enable volatile memory programming
> + * MODE 2: Enable non-volatile memory programming
> + * MODE 3: Program non-volatile memory section
> + * ------------------------------------------------
> + */
> #define HFA384x_PROGMODE_DISABLE ((u16)0x00)
> #define HFA384x_PROGMODE_RAM ((u16)0x01)
> #define HFA384x_PROGMODE_NV ((u16)0x02)
> #define HFA384x_PROGMODE_NVWRITE ((u16)0x03)
>
> /*--- Record ID Constants --------------------------*/
> -/*--------------------------------------------------------------------
> -Configuration RIDs: Network Parameters, Static Configuration Entities
> ---------------------------------------------------------------------*/
> +/* -------------------------------------------------------------------
> + * Configuration RIDs: Network Parameters, Static Configuration Entities
> + * -------------------------------------------------------------------
> + */
> #define HFA384x_RID_CNFPORTTYPE ((u16)0xFC00)
> #define HFA384x_RID_CNFOWNMACADDR ((u16)0xFC01)
> #define HFA384x_RID_CNFDESIREDSSID ((u16)0xFC02)
> @@ -194,27 +197,30 @@ Configuration RIDs: Network Parameters, Static Configuration Entities
> #define HFA384x_RID_CNFOWNSSID ((u16)0xFC04)
> #define HFA384x_RID_CNFMAXDATALEN ((u16)0xFC07)
>
> -/*--------------------------------------------------------------------
> -Configuration RID lengths: Network Params, Static Config Entities
> - This is the length of JUST the DATA part of the RID (does not
> - include the len or code fields)
> ---------------------------------------------------------------------*/
> +/* -------------------------------------------------------------------
> + * Configuration RID lengths: Network Params, Static Config Entities
> + * This is the length of JUST the DATA part of the RID (does not
> + * include the len or code fields)
> + * -------------------------------------------------------------------
> + */
> #define HFA384x_RID_CNFOWNMACADDR_LEN ((u16)6)
> #define HFA384x_RID_CNFDESIREDSSID_LEN ((u16)34)
> #define HFA384x_RID_CNFOWNSSID_LEN ((u16)34)
>
> -/*--------------------------------------------------------------------
> -Configuration RIDs: Network Parameters, Dynamic Configuration Entities
> ---------------------------------------------------------------------*/
> +/* --------------------------------------------------------------------
> + * Configuration RIDs: Network Parameters, Dynamic Configuration Entities
> + * --------------------------------------------------------------------
> + */
> #define HFA384x_RID_CREATEIBSS ((u16)0xFC81)
> #define HFA384x_RID_FRAGTHRESH ((u16)0xFC82)
> #define HFA384x_RID_RTSTHRESH ((u16)0xFC83)
> #define HFA384x_RID_TXRATECNTL ((u16)0xFC84)
> #define HFA384x_RID_PROMISCMODE ((u16)0xFC85)
>
> -/*----------------------------------------------------------------------
> -Information RIDs: NIC Information
> ---------------------------------------------------------------------*/
> +/* --------------------------------------------------------------------
> + * Information RIDs: NIC Information
> + * --------------------------------------------------------------------
> + */
> #define HFA384x_RID_MAXLOADTIME ((u16)0xFD00)
> #define HFA384x_RID_DOWNLOADBUFFER ((u16)0xFD01)
> #define HFA384x_RID_PRIIDENTITY ((u16)0xFD02)
> @@ -229,16 +235,18 @@ Information RIDs: NIC Information
> #define HFA384x_RID_STA_MFIACTRANGES ((u16)0xFD22)
> #define HFA384x_RID_STA_CFIACTRANGES ((u16)0xFD23)
>
> -/*----------------------------------------------------------------------
> -Information RID Lengths: NIC Information
> - This is the length of JUST the DATA part of the RID (does not
> - include the len or code fields)
> ---------------------------------------------------------------------*/
> +/* --------------------------------------------------------------------
> + * Information RID Lengths: NIC Information
> + * This is the length of JUST the DATA part of the RID (does not
> + * include the len or code fields)
> + * --------------------------------------------------------------------
> + */
> #define HFA384x_RID_NICSERIALNUMBER_LEN ((u16)12)
>
> -/*--------------------------------------------------------------------
> -Information RIDs: MAC Information
> ---------------------------------------------------------------------*/
> +/* --------------------------------------------------------------------
> + * Information RIDs: MAC Information
> + * --------------------------------------------------------------------
> + */
> #define HFA384x_RID_PORTSTATUS ((u16)0xFD40)
> #define HFA384x_RID_CURRENTSSID ((u16)0xFD41)
> #define HFA384x_RID_CURRENTBSSID ((u16)0xFD42)
> @@ -249,24 +257,27 @@ Information RIDs: MAC Information
> #define HFA384x_RID_PRIVACYOPTIMP ((u16)0xFD4F)
> #define HFA384x_RID_DBMCOMMSQUALITY ((u16)0xFD51)
>
> -/*--------------------------------------------------------------------
> -Information RID Lengths: MAC Information
> - This is the length of JUST the DATA part of the RID (does not
> - include the len or code fields)
> ---------------------------------------------------------------------*/
> +/* -------------------------------------------------------------------
> + * Information RID Lengths: MAC Information
> + * This is the length of JUST the DATA part of the RID (does not
> + * include the len or code fields)
> + * -------------------------------------------------------------------
> + */
> #define HFA384x_RID_DBMCOMMSQUALITY_LEN \
> ((u16)sizeof(hfa384x_dbmcommsquality_t))
> #define HFA384x_RID_JOINREQUEST_LEN \
> ((u16)sizeof(hfa384x_JoinRequest_data_t))
>
> -/*--------------------------------------------------------------------
> -Information RIDs: Modem Information
> ---------------------------------------------------------------------*/
> +/* --------------------------------------------------------------------
> + * Information RIDs: Modem Information
> + * --------------------------------------------------------------------
> + */
> #define HFA384x_RID_CURRENTCHANNEL ((u16)0xFDC1)
>
> -/*--------------------------------------------------------------------
> -API ENHANCEMENTS (NOT ALREADY IMPLEMENTED)
> ---------------------------------------------------------------------*/
> +/* --------------------------------------------------------------------
> + * API ENHANCEMENTS (NOT ALREADY IMPLEMENTED)
> + * --------------------------------------------------------------------
> + */
> #define HFA384x_RID_CNFWEPDEFAULTKEYID ((u16)0xFC23)
> #define HFA384x_RID_CNFWEPDEFAULTKEY0 ((u16)0xFC24)
> #define HFA384x_RID_CNFWEPDEFAULTKEY1 ((u16)0xFC25)
> @@ -289,9 +300,10 @@ API ENHANCEMENTS (NOT ALREADY IMPLEMENTED)
> #define HFA384x_RID_CNFWEPDEFAULTKEY_LEN ((u16)6)
> #define HFA384x_RID_CNFWEP128DEFAULTKEY_LEN ((u16)14)
>
> -/*--------------------------------------------------------------------
> -PD Record codes
> ---------------------------------------------------------------------*/
> +/* --------------------------------------------------------------------
> + * PD Record codes
> + * --------------------------------------------------------------------
> + */
> #define HFA384x_PDR_PCB_PARTNUM ((u16)0x0001)
> #define HFA384x_PDR_PDAVER ((u16)0x0002)
> #define HFA384x_PDR_NIC_SERIAL ((u16)0x0003)
> @@ -360,10 +372,11 @@ typedef struct hfa384x_bytestr32 {
> u8 data[32];
> } __packed hfa384x_bytestr32_t;
>
> -/*--------------------------------------------------------------------
> -Configuration Record Structures:
> - Network Parameters, Static Configuration Entities
> ---------------------------------------------------------------------*/
> +/* --------------------------------------------------------------------
> + * Configuration Record Structures:
> + * Network Parameters, Static Configuration Entities
> + * --------------------------------------------------------------------
> + */
>
> /*-- Hardware/Firmware Component Information ----------*/
> typedef struct hfa384x_compident {
> @@ -386,10 +399,11 @@ typedef struct hfa384x_caplevel {
> #define HFA384x_CNFAUTHENTICATION_SHAREDKEY 0x0002
> #define HFA384x_CNFAUTHENTICATION_LEAP 0x0004
>
> -/*--------------------------------------------------------------------
> -Configuration Record Structures:
> - Network Parameters, Dynamic Configuration Entities
> ---------------------------------------------------------------------*/
> +/* --------------------------------------------------------------------
> + * Configuration Record Structures:
> + * Network Parameters, Dynamic Configuration Entities
> + * --------------------------------------------------------------------
> + */
>
> #define HFA384x_CREATEIBSS_JOINCREATEIBSS 0
>
> @@ -419,9 +433,10 @@ typedef struct hfa384x_WPAData {
> u8 data[0]; /* max 80 */
> } __packed hfa384x_WPAData_t;
>
> -/*--------------------------------------------------------------------
> -Information Record Structures: NIC Information
> ---------------------------------------------------------------------*/
> +/* --------------------------------------------------------------------
> + * Information Record Structures: NIC Information
> + * --------------------------------------------------------------------
> + */
>
> /*-- Information Record: DownLoadBuffer --*/
> /* NOTE: The page and offset are in AUX format */
> @@ -431,9 +446,10 @@ typedef struct hfa384x_downloadbuffer {
> u16 len;
> } __packed hfa384x_downloadbuffer_t;
>
> -/*--------------------------------------------------------------------
> -Information Record Structures: NIC Information
> ---------------------------------------------------------------------*/
> +/* --------------------------------------------------------------------
> + * Information Record Structures: NIC Information
> + * --------------------------------------------------------------------
> + */
>
> #define HFA384x_PSTATUS_CONN_IBSS ((u16)3)
>
> @@ -451,11 +467,12 @@ typedef struct hfa384x_dbmcommsquality {
> u16 ANLdbm_currFC;
> } __packed hfa384x_dbmcommsquality_t;
>
> -/*--------------------------------------------------------------------
> -FRAME STRUCTURES: Communication Frames
> -----------------------------------------------------------------------
> -Communication Frames: Transmit Frames
> ---------------------------------------------------------------------*/
> +/* --------------------------------------------------------------------
> + * FRAME STRUCTURES: Communication Frames
> + * --------------------------------------------------------------------
> + * Communication Frames: Transmit Frames
> + * --------------------------------------------------------------------
> + */
> /*-- Communication Frame: Transmit Frame Structure --*/
> typedef struct hfa384x_tx_frame {
> u16 status;
> @@ -483,9 +500,10 @@ typedef struct hfa384x_tx_frame {
> u8 src_addr[6];
> u16 data_length; /* big endian format */
> } __packed hfa384x_tx_frame_t;
> -/*--------------------------------------------------------------------
> -Communication Frames: Field Masks for Transmit Frames
> ---------------------------------------------------------------------*/
> +/* --------------------------------------------------------------------
> + * Communication Frames: Field Masks for Transmit Frames
> + * --------------------------------------------------------------------
> + */
> /*-- Status Field --*/
> #define HFA384x_TXSTATUS_ACKERR ((u16)BIT(5))
> #define HFA384x_TXSTATUS_FORMERR ((u16)BIT(3))
> @@ -498,9 +516,10 @@ Communication Frames: Field Masks for Transmit Frames
> #define HFA384x_TX_STRUCTYPE ((u16)(BIT(4) | BIT(3)))
> #define HFA384x_TX_TXEX ((u16)BIT(2))
> #define HFA384x_TX_TXOK ((u16)BIT(1))
> -/*--------------------------------------------------------------------
> -Communication Frames: Test/Get/Set Field Values for Transmit Frames
> ---------------------------------------------------------------------*/
> +/* --------------------------------------------------------------------
> + * Communication Frames: Test/Get/Set Field Values for Transmit Frames
> + * --------------------------------------------------------------------
> + */
> /*-- Status Field --*/
> #define HFA384x_TXSTATUS_ISERROR(v) \
> (((u16)(v)) & \
> @@ -515,9 +534,10 @@ Communication Frames: Test/Get/Set Field Values for Transmit Frames
> HFA384x_TX_STRUCTYPE, 3)
> #define HFA384x_TX_TXEX_SET(v) HFA384x_TX_SET(v, HFA384x_TX_TXEX, 2)
> #define HFA384x_TX_TXOK_SET(v) HFA384x_TX_SET(v, HFA384x_TX_TXOK, 1)
> -/*--------------------------------------------------------------------
> -Communication Frames: Receive Frames
> ---------------------------------------------------------------------*/
> +/* --------------------------------------------------------------------
> + * Communication Frames: Receive Frames
> + * --------------------------------------------------------------------
> + */
> /*-- Communication Frame: Receive Frame Structure --*/
> typedef struct hfa384x_rx_frame {
> /*-- MAC rx descriptor (hfa384x byte order) --*/
> @@ -545,27 +565,30 @@ typedef struct hfa384x_rx_frame {
> u8 src_addr[6];
> u16 data_length; /* IEEE? (big endian) format */
> } __packed hfa384x_rx_frame_t;
> -/*--------------------------------------------------------------------
> -Communication Frames: Field Masks for Receive Frames
> ---------------------------------------------------------------------*/
> +/* --------------------------------------------------------------------
> + * Communication Frames: Field Masks for Receive Frames
> + * --------------------------------------------------------------------
> + */
>
> /*-- Status Fields --*/
> #define HFA384x_RXSTATUS_MACPORT ((u16)(BIT(10) | \
> BIT(9) | \
> BIT(8)))
> #define HFA384x_RXSTATUS_FCSERR ((u16)BIT(0))
> -/*--------------------------------------------------------------------
> -Communication Frames: Test/Get/Set Field Values for Receive Frames
> ---------------------------------------------------------------------*/
> +/* --------------------------------------------------------------------
> + * Communication Frames: Test/Get/Set Field Values for Receive Frames
> + * --------------------------------------------------------------------
> + */
> #define HFA384x_RXSTATUS_MACPORT_GET(value) ((u16)((((u16)(value)) \
> & HFA384x_RXSTATUS_MACPORT) >> 8))
> #define HFA384x_RXSTATUS_ISFCSERR(value) ((u16)(((u16)(value)) \
> & HFA384x_RXSTATUS_FCSERR))
> -/*--------------------------------------------------------------------
> - FRAME STRUCTURES: Information Types and Information Frame Structures
> -----------------------------------------------------------------------
> -Information Types
> ---------------------------------------------------------------------*/
> +/* --------------------------------------------------------------------
> + * FRAME STRUCTURES: Information Types and Information Frame Structures
> + * --------------------------------------------------------------------
> + * Information Types
> + * --------------------------------------------------------------------
> + */
> #define HFA384x_IT_HANDOVERADDR ((u16)0xF000UL)
> #define HFA384x_IT_COMMTALLIES ((u16)0xF100UL)
> #define HFA384x_IT_SCANRESULTS ((u16)0xF101UL)
> @@ -579,11 +602,12 @@ Information Types
> #define HFA384x_IT_ASSOCREQ ((u16)0xF205UL)
> #define HFA384x_IT_MICFAILURE ((u16)0xF206UL)
>
> -/*--------------------------------------------------------------------
> -Information Frames Structures
> -----------------------------------------------------------------------
> -Information Frames: Notification Frame Structures
> ---------------------------------------------------------------------*/
> +/* --------------------------------------------------------------------
> + * Information Frames Structures
> + * --------------------------------------------------------------------
> + * Information Frames: Notification Frame Structures
> + * --------------------------------------------------------------------
> + */
>
> /*-- Inquiry Frame, Diagnose: Communication Tallies --*/
> typedef struct hfa384x_CommTallies16 {
> @@ -756,9 +780,10 @@ typedef struct hfa384x_InfFrame {
> hfa384x_infodata_t info;
> } __packed hfa384x_InfFrame_t;
>
> -/*--------------------------------------------------------------------
> -USB Packet structures and constants.
> ---------------------------------------------------------------------*/
> +/* --------------------------------------------------------------------
> + * USB Packet structures and constants.
> + * --------------------------------------------------------------------
> + */
>
> /* Should be sent to the bulkout endpoint */
> #define HFA384x_USB_TXFRM 0
> @@ -903,9 +928,10 @@ typedef union hfa384x_usbin {
> u8 boguspad[3000];
> } __packed hfa384x_usbin_t;
>
> -/*--------------------------------------------------------------------
> -PD record structures.
> ---------------------------------------------------------------------*/
> +/* --------------------------------------------------------------------
> + * PD record structures.
> + * --------------------------------------------------------------------
> + */
>
> typedef struct hfa384x_pdr_pcb_partnum {
> u8 num[8];
> @@ -1111,10 +1137,11 @@ typedef struct hfa384x_pdrec {
> } __packed hfa384x_pdrec_t;
>
> #ifdef __KERNEL__
> -/*--------------------------------------------------------------------
> ---- MAC state structure, argument to all functions --
> ---- Also, a collection of support types --
> ---------------------------------------------------------------------*/
> +/* --------------------------------------------------------------------
> + * --- MAC state structure, argument to all functions --
> + * --- Also, a collection of support types --
> + * --------------------------------------------------------------------
> + */
> typedef struct hfa384x_statusresult {
> u16 status;
> u16 resp0;
> @@ -1298,7 +1325,8 @@ typedef struct hfa384x {
> int dbmadjust;
>
> /* Group Addresses - right now, there are up to a total
> - of MAX_GRP_ADDR group addresses */
> + * of MAX_GRP_ADDR group addresses
> + */
> u8 dot11_grp_addr[MAX_GRP_ADDR][ETH_ALEN];
> unsigned int dot11_grpcnt;
>
> @@ -1424,4 +1452,4 @@ hfa384x_cmd_download(hfa384x_t *hw,
>
> #endif /*__KERNEL__ */
>
> -#endif /*_HFA384x_H */
> +#endif /*_HFA384x_H */
> \ No newline at end of file
> --
> 2.9.2
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/be09e4935621ebe770021ab141611304221b5adf.1473993585.git.gs051095%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [Outreachy kernel] [PATCH 7/8] staging: wlan-ng: add blank line after declaration
2016-09-16 2:46 ` [PATCH 7/8] staging: wlan-ng: add blank line after declaration Gargi Sharma
@ 2016-09-16 5:35 ` Julia Lawall
0 siblings, 0 replies; 17+ messages in thread
From: Julia Lawall @ 2016-09-16 5:35 UTC (permalink / raw)
To: Gargi Sharma; +Cc: outreachy-kernel, gregkh
On Fri, 16 Sep 2016, Gargi Sharma wrote:
> add blank line after struct declaration to fix the checkpatch issue,
Sentences should start with a capital letter.
> Missing a blank line after declarations.
>
> Signed-off-by: Gargi Sharma <gs051095@gmail.com>
> ---
> drivers/staging/wlan-ng/hfa384x.h | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h
> index 2ff3805..1fc34c7 100644
> --- a/drivers/staging/wlan-ng/hfa384x.h
> +++ b/drivers/staging/wlan-ng/hfa384x.h
> @@ -1166,7 +1166,8 @@ typedef struct hfa384x_usbctlx {
> CTLX_STATE state; /* Tracks running state */
>
> struct completion done;
> - volatile int reapable; /* Food for the reaper task */
> +
> + volatile int reapable;/* Food for the reaper task */
Checkpatch is wrong, apparently. volatile int reapable; is a variable
declaration too. Also, it's not clear why you deleted the space before
the comment.
>
> ctlx_cmdcb_t cmdcb; /* Async command callback */
> ctlx_usercb_t usercb; /* Async user callback, */
> @@ -1378,7 +1379,7 @@ static inline int hfa384x_drvr_getconfig16(hfa384x_t *hw, u16 rid, void *val)
>
> result = hfa384x_drvr_getconfig(hw, rid, val, sizeof(u16));
> if (result == 0)
> - *((u16 *)val) = le16_to_cpu(*((u16 *) val));
> + *((u16 *)val) = le16_to_cpu(*((u16 *)val));
This is not covered by the commit message.
julia
> return result;
> }
>
> --
> 2.9.2
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/6443337325af6b99b15ee79e394a8433b2707aea.1473993585.git.gs051095%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [Outreachy kernel] [PATCH 6/8] staging: wlan-ng: delete space after a cast
2016-09-16 2:46 ` [PATCH 6/8] staging: wlan-ng: delete space after a cast Gargi Sharma
@ 2016-09-16 5:37 ` Julia Lawall
0 siblings, 0 replies; 17+ messages in thread
From: Julia Lawall @ 2016-09-16 5:37 UTC (permalink / raw)
To: Gargi Sharma; +Cc: outreachy-kernel, gregkh
On Fri, 16 Sep 2016, Gargi Sharma wrote:
> delete space after a cast to fix the checkpatch issue, No space is
> necessary after a cast.
>
> Signed-off-by: Gargi Sharma <gs051095@gmail.com>
> ---
> drivers/staging/wlan-ng/hfa384x.h | 4 +-
> pace | 567 ++++++++++++++++++++++++++++++++++++++
> 2 files changed, 569 insertions(+), 2 deletions(-)
> create mode 100644 pace
>
> diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h
> index 616da07..2ff3805 100644
> --- a/drivers/staging/wlan-ng/hfa384x.h
> +++ b/drivers/staging/wlan-ng/hfa384x.h
> @@ -255,7 +255,7 @@ Information RID Lengths: MAC Information
> include the len or code fields)
> --------------------------------------------------------------------*/
> #define HFA384x_RID_DBMCOMMSQUALITY_LEN \
> - ((u16) sizeof(hfa384x_dbmcommsquality_t))
> + ((u16)sizeof(hfa384x_dbmcommsquality_t))
> #define HFA384x_RID_JOINREQUEST_LEN \
> ((u16)sizeof(hfa384x_JoinRequest_data_t))
>
> @@ -1378,7 +1378,7 @@ static inline int hfa384x_drvr_getconfig16(hfa384x_t *hw, u16 rid, void *val)
>
> result = hfa384x_drvr_getconfig(hw, rid, val, sizeof(u16));
> if (result == 0)
> - *((u16 *) val) = le16_to_cpu(*((u16 *) val));
> + *((u16 *)val) = le16_to_cpu(*((u16 *) val));
> return result;
> }
>
> diff --git a/pace b/pace
This looks like a file of your own that should not have been committed.
Always check your patches before sending them to be sure that they contain
only the changes that you expect.
julia
> new file mode 100644
> index 0000000..7cc2eea
> --- /dev/null
> +++ b/pace
> @@ -0,0 +1,567 @@
> +CHECK: No space is necessary after a cast
> +#267: FILE: drivers/staging/wlan-ng/hfa384x.h:267:
> ++ ((u16) sizeof(hfa384x_dbmcommsquality_t))
> +
> +CHECK: Avoid CamelCase: <hfa384x_JoinRequest_data_t>
> +#269: FILE: drivers/staging/wlan-ng/hfa384x.h:269:
> ++ ((u16)sizeof(hfa384x_JoinRequest_data_t))
> +
> +CHECK: Avoid CamelCase: <HFA384x_RID_CNFAPBCNint>
> +#289: FILE: drivers/staging/wlan-ng/hfa384x.h:289:
> ++#define HFA384x_RID_CNFAPBCNint ((u16)0xFC33)
> +
> +WARNING: do not add new typedefs
> +#370: FILE: drivers/staging/wlan-ng/hfa384x.h:370:
> ++typedef struct hfa384x_bytestr32 {
> +
> +WARNING: do not add new typedefs
> +#382: FILE: drivers/staging/wlan-ng/hfa384x.h:382:
> ++typedef struct hfa384x_compident {
> +
> +WARNING: do not add new typedefs
> +#389: FILE: drivers/staging/wlan-ng/hfa384x.h:389:
> ++typedef struct hfa384x_caplevel {
> +
> +WARNING: do not add new typedefs
> +#411: FILE: drivers/staging/wlan-ng/hfa384x.h:411:
> ++typedef struct hfa384x_HostScanRequest_data {
> +
> +CHECK: Avoid CamelCase: <hfa384x_HostScanRequest_data>
> +#411: FILE: drivers/staging/wlan-ng/hfa384x.h:411:
> ++typedef struct hfa384x_HostScanRequest_data {
> +
> +CHECK: Avoid CamelCase: <channelList>
> +#412: FILE: drivers/staging/wlan-ng/hfa384x.h:412:
> ++ u16 channelList;
> +
> +CHECK: Avoid CamelCase: <txRate>
> +#413: FILE: drivers/staging/wlan-ng/hfa384x.h:413:
> ++ u16 txRate;
> +
> +CHECK: Avoid CamelCase: <hfa384x_HostScanRequest_data_t>
> +#415: FILE: drivers/staging/wlan-ng/hfa384x.h:415:
> ++} __packed hfa384x_HostScanRequest_data_t;
> +
> +WARNING: do not add new typedefs
> +#418: FILE: drivers/staging/wlan-ng/hfa384x.h:418:
> ++typedef struct hfa384x_JoinRequest_data {
> +
> +CHECK: Avoid CamelCase: <hfa384x_JoinRequest_data>
> +#418: FILE: drivers/staging/wlan-ng/hfa384x.h:418:
> ++typedef struct hfa384x_JoinRequest_data {
> +
> +WARNING: do not add new typedefs
> +#424: FILE: drivers/staging/wlan-ng/hfa384x.h:424:
> ++typedef struct hfa384x_authenticateStation_data {
> +
> +CHECK: Avoid CamelCase: <hfa384x_authenticateStation_data>
> +#424: FILE: drivers/staging/wlan-ng/hfa384x.h:424:
> ++typedef struct hfa384x_authenticateStation_data {
> +
> +CHECK: Avoid CamelCase: <hfa384x_authenticateStation_data_t>
> +#428: FILE: drivers/staging/wlan-ng/hfa384x.h:428:
> ++} __packed hfa384x_authenticateStation_data_t;
> +
> +WARNING: do not add new typedefs
> +#431: FILE: drivers/staging/wlan-ng/hfa384x.h:431:
> ++typedef struct hfa384x_WPAData {
> +
> +CHECK: Avoid CamelCase: <hfa384x_WPAData>
> +#431: FILE: drivers/staging/wlan-ng/hfa384x.h:431:
> ++typedef struct hfa384x_WPAData {
> +
> +CHECK: Avoid CamelCase: <hfa384x_WPAData_t>
> +#434: FILE: drivers/staging/wlan-ng/hfa384x.h:434:
> ++} __packed hfa384x_WPAData_t;
> +
> +WARNING: do not add new typedefs
> +#443: FILE: drivers/staging/wlan-ng/hfa384x.h:443:
> ++typedef struct hfa384x_downloadbuffer {
> +
> +WARNING: do not add new typedefs
> +#457: FILE: drivers/staging/wlan-ng/hfa384x.h:457:
> ++typedef struct hfa384x_commsquality {
> +
> +CHECK: Avoid CamelCase: <CQ_currBSS>
> +#458: FILE: drivers/staging/wlan-ng/hfa384x.h:458:
> ++ u16 CQ_currBSS;
> +
> +CHECK: Avoid CamelCase: <ASL_currBSS>
> +#459: FILE: drivers/staging/wlan-ng/hfa384x.h:459:
> ++ u16 ASL_currBSS;
> +
> +CHECK: Avoid CamelCase: <ANL_currFC>
> +#460: FILE: drivers/staging/wlan-ng/hfa384x.h:460:
> ++ u16 ANL_currFC;
> +
> +WARNING: do not add new typedefs
> +#464: FILE: drivers/staging/wlan-ng/hfa384x.h:464:
> ++typedef struct hfa384x_dbmcommsquality {
> +
> +CHECK: Avoid CamelCase: <CQdbm_currBSS>
> +#465: FILE: drivers/staging/wlan-ng/hfa384x.h:465:
> ++ u16 CQdbm_currBSS;
> +
> +CHECK: Avoid CamelCase: <ASLdbm_currBSS>
> +#466: FILE: drivers/staging/wlan-ng/hfa384x.h:466:
> ++ u16 ASLdbm_currBSS;
> +
> +CHECK: Avoid CamelCase: <ANLdbm_currFC>
> +#467: FILE: drivers/staging/wlan-ng/hfa384x.h:467:
> ++ u16 ANLdbm_currFC;
> +
> +WARNING: do not add new typedefs
> +#477: FILE: drivers/staging/wlan-ng/hfa384x.h:477:
> ++typedef struct hfa384x_tx_frame {
> +
> +WARNING: line over 80 characters
> +#530: FILE: drivers/staging/wlan-ng/hfa384x.h:530:
> ++#define HFA384x_TX_SET(v, m, s) ((((u16)(v)) << ((u16)(s))) & ((u16)(m)))
> +
> +WARNING: do not add new typedefs
> +#542: FILE: drivers/staging/wlan-ng/hfa384x.h:542:
> ++typedef struct hfa384x_rx_frame {
> +
> +WARNING: do not add new typedefs
> +#613: FILE: drivers/staging/wlan-ng/hfa384x.h:613:
> ++typedef struct hfa384x_CommTallies16 {
> +
> +CHECK: Avoid CamelCase: <hfa384x_CommTallies16>
> +#613: FILE: drivers/staging/wlan-ng/hfa384x.h:613:
> ++typedef struct hfa384x_CommTallies16 {
> +
> +CHECK: Avoid CamelCase: <hfa384x_CommTallies16_t>
> +#635: FILE: drivers/staging/wlan-ng/hfa384x.h:635:
> ++} __packed hfa384x_CommTallies16_t;
> +
> +WARNING: do not add new typedefs
> +#637: FILE: drivers/staging/wlan-ng/hfa384x.h:637:
> ++typedef struct hfa384x_CommTallies32 {
> +
> +CHECK: Avoid CamelCase: <hfa384x_CommTallies32>
> +#637: FILE: drivers/staging/wlan-ng/hfa384x.h:637:
> ++typedef struct hfa384x_CommTallies32 {
> +
> +CHECK: Avoid CamelCase: <hfa384x_CommTallies32_t>
> +#659: FILE: drivers/staging/wlan-ng/hfa384x.h:659:
> ++} __packed hfa384x_CommTallies32_t;
> +
> +WARNING: do not add new typedefs
> +#662: FILE: drivers/staging/wlan-ng/hfa384x.h:662:
> ++typedef struct hfa384x_ScanResultSub {
> +
> +CHECK: Avoid CamelCase: <hfa384x_ScanResultSub>
> +#662: FILE: drivers/staging/wlan-ng/hfa384x.h:662:
> ++typedef struct hfa384x_ScanResultSub {
> +
> +CHECK: Avoid CamelCase: <hfa384x_ScanResultSub_t>
> +#672: FILE: drivers/staging/wlan-ng/hfa384x.h:672:
> ++} __packed hfa384x_ScanResultSub_t;
> +
> +WARNING: do not add new typedefs
> +#674: FILE: drivers/staging/wlan-ng/hfa384x.h:674:
> ++typedef struct hfa384x_ScanResult {
> +
> +CHECK: Avoid CamelCase: <hfa384x_ScanResult>
> +#674: FILE: drivers/staging/wlan-ng/hfa384x.h:674:
> ++typedef struct hfa384x_ScanResult {
> +
> +CHECK: Avoid CamelCase: <hfa384x_ScanResult_t>
> +#678: FILE: drivers/staging/wlan-ng/hfa384x.h:678:
> ++} __packed hfa384x_ScanResult_t;
> +
> +WARNING: do not add new typedefs
> +#681: FILE: drivers/staging/wlan-ng/hfa384x.h:681:
> ++typedef struct hfa384x_ChInfoResultSub {
> +
> +CHECK: Avoid CamelCase: <hfa384x_ChInfoResultSub>
> +#681: FILE: drivers/staging/wlan-ng/hfa384x.h:681:
> ++typedef struct hfa384x_ChInfoResultSub {
> +
> +CHECK: Avoid CamelCase: <hfa384x_ChInfoResultSub_t>
> +#686: FILE: drivers/staging/wlan-ng/hfa384x.h:686:
> ++} __packed hfa384x_ChInfoResultSub_t;
> +
> +WARNING: do not add new typedefs
> +#691: FILE: drivers/staging/wlan-ng/hfa384x.h:691:
> ++typedef struct hfa384x_ChInfoResult {
> +
> +CHECK: Avoid CamelCase: <hfa384x_ChInfoResult>
> +#691: FILE: drivers/staging/wlan-ng/hfa384x.h:691:
> ++typedef struct hfa384x_ChInfoResult {
> +
> +CHECK: Avoid CamelCase: <hfa384x_ChInfoResult_t>
> +#694: FILE: drivers/staging/wlan-ng/hfa384x.h:694:
> ++} __packed hfa384x_ChInfoResult_t;
> +
> +WARNING: do not add new typedefs
> +#697: FILE: drivers/staging/wlan-ng/hfa384x.h:697:
> ++typedef struct hfa384x_HScanResultSub {
> +
> +CHECK: Avoid CamelCase: <hfa384x_HScanResultSub>
> +#697: FILE: drivers/staging/wlan-ng/hfa384x.h:697:
> ++typedef struct hfa384x_HScanResultSub {
> +
> +CHECK: Avoid CamelCase: <hfa384x_HScanResultSub_t>
> +#708: FILE: drivers/staging/wlan-ng/hfa384x.h:708:
> ++} __packed hfa384x_HScanResultSub_t;
> +
> +WARNING: do not add new typedefs
> +#710: FILE: drivers/staging/wlan-ng/hfa384x.h:710:
> ++typedef struct hfa384x_HScanResult {
> +
> +CHECK: Avoid CamelCase: <hfa384x_HScanResult>
> +#710: FILE: drivers/staging/wlan-ng/hfa384x.h:710:
> ++typedef struct hfa384x_HScanResult {
> +
> +CHECK: Avoid CamelCase: <hfa384x_HScanResult_t>
> +#714: FILE: drivers/staging/wlan-ng/hfa384x.h:714:
> ++} __packed hfa384x_HScanResult_t;
> +
> +WARNING: do not add new typedefs
> +#726: FILE: drivers/staging/wlan-ng/hfa384x.h:726:
> ++typedef struct hfa384x_LinkStatus {
> +
> +CHECK: Avoid CamelCase: <hfa384x_LinkStatus>
> +#726: FILE: drivers/staging/wlan-ng/hfa384x.h:726:
> ++typedef struct hfa384x_LinkStatus {
> +
> +CHECK: Avoid CamelCase: <hfa384x_LinkStatus_t>
> +#728: FILE: drivers/staging/wlan-ng/hfa384x.h:728:
> ++} __packed hfa384x_LinkStatus_t;
> +
> +WARNING: do not add new typedefs
> +#736: FILE: drivers/staging/wlan-ng/hfa384x.h:736:
> ++typedef struct hfa384x_AssocStatus {
> +
> +CHECK: Avoid CamelCase: <hfa384x_AssocStatus>
> +#736: FILE: drivers/staging/wlan-ng/hfa384x.h:736:
> ++typedef struct hfa384x_AssocStatus {
> +
> +CHECK: Avoid CamelCase: <hfa384x_AssocStatus_t>
> +#743: FILE: drivers/staging/wlan-ng/hfa384x.h:743:
> ++} __packed hfa384x_AssocStatus_t;
> +
> +WARNING: do not add new typedefs
> +#747: FILE: drivers/staging/wlan-ng/hfa384x.h:747:
> ++typedef struct hfa384x_AuthRequest {
> +
> +CHECK: Avoid CamelCase: <hfa384x_AuthRequest>
> +#747: FILE: drivers/staging/wlan-ng/hfa384x.h:747:
> ++typedef struct hfa384x_AuthRequest {
> +
> +CHECK: Avoid CamelCase: <hfa384x_AuthReq_t>
> +#750: FILE: drivers/staging/wlan-ng/hfa384x.h:750:
> ++} __packed hfa384x_AuthReq_t;
> +
> +WARNING: do not add new typedefs
> +#754: FILE: drivers/staging/wlan-ng/hfa384x.h:754:
> ++typedef struct hfa384x_PSUserCount {
> +
> +CHECK: Avoid CamelCase: <hfa384x_PSUserCount>
> +#754: FILE: drivers/staging/wlan-ng/hfa384x.h:754:
> ++typedef struct hfa384x_PSUserCount {
> +
> +CHECK: Avoid CamelCase: <hfa384x_PSUserCount_t>
> +#756: FILE: drivers/staging/wlan-ng/hfa384x.h:756:
> ++} __packed hfa384x_PSUserCount_t;
> +
> +WARNING: do not add new typedefs
> +#758: FILE: drivers/staging/wlan-ng/hfa384x.h:758:
> ++typedef struct hfa384x_KeyIDChanged {
> +
> +CHECK: Avoid CamelCase: <hfa384x_KeyIDChanged>
> +#758: FILE: drivers/staging/wlan-ng/hfa384x.h:758:
> ++typedef struct hfa384x_KeyIDChanged {
> +
> +CHECK: Avoid CamelCase: <hfa384x_KeyIDChanged_t>
> +#761: FILE: drivers/staging/wlan-ng/hfa384x.h:761:
> ++} __packed hfa384x_KeyIDChanged_t;
> +
> +WARNING: do not add new typedefs
> +#764: FILE: drivers/staging/wlan-ng/hfa384x.h:764:
> ++typedef union hfa384x_infodata {
> +
> +WARNING: do not add new typedefs
> +#777: FILE: drivers/staging/wlan-ng/hfa384x.h:777:
> ++typedef struct hfa384x_InfFrame {
> +
> +CHECK: Avoid CamelCase: <hfa384x_InfFrame>
> +#777: FILE: drivers/staging/wlan-ng/hfa384x.h:777:
> ++typedef struct hfa384x_InfFrame {
> +
> +CHECK: Avoid CamelCase: <hfa384x_InfFrame_t>
> +#781: FILE: drivers/staging/wlan-ng/hfa384x.h:781:
> ++} __packed hfa384x_InfFrame_t;
> +
> +WARNING: do not add new typedefs
> +#811: FILE: drivers/staging/wlan-ng/hfa384x.h:811:
> ++typedef struct hfa384x_usb_txfrm {
> +
> +WARNING: do not add new typedefs
> +#816: FILE: drivers/staging/wlan-ng/hfa384x.h:816:
> ++typedef struct hfa384x_usb_cmdreq {
> +
> +WARNING: do not add new typedefs
> +#825: FILE: drivers/staging/wlan-ng/hfa384x.h:825:
> ++typedef struct hfa384x_usb_wridreq {
> +
> +WARNING: do not add new typedefs
> +#832: FILE: drivers/staging/wlan-ng/hfa384x.h:832:
> ++typedef struct hfa384x_usb_rridreq {
> +
> +WARNING: do not add new typedefs
> +#839: FILE: drivers/staging/wlan-ng/hfa384x.h:839:
> ++typedef struct hfa384x_usb_wmemreq {
> +
> +WARNING: do not add new typedefs
> +#847: FILE: drivers/staging/wlan-ng/hfa384x.h:847:
> ++typedef struct hfa384x_usb_rmemreq {
> +
> +WARNING: do not add new typedefs
> +#858: FILE: drivers/staging/wlan-ng/hfa384x.h:858:
> ++typedef struct hfa384x_usb_rxfrm {
> +
> +WARNING: do not add new typedefs
> +#863: FILE: drivers/staging/wlan-ng/hfa384x.h:863:
> ++typedef struct hfa384x_usb_infofrm {
> +
> +WARNING: do not add new typedefs
> +#868: FILE: drivers/staging/wlan-ng/hfa384x.h:868:
> ++typedef struct hfa384x_usb_statusresp {
> +
> +WARNING: do not add new typedefs
> +#876: FILE: drivers/staging/wlan-ng/hfa384x.h:876:
> ++typedef hfa384x_usb_cmdresp_t hfa384x_usb_wridresp_t;
> +
> +WARNING: do not add new typedefs
> +#878: FILE: drivers/staging/wlan-ng/hfa384x.h:878:
> ++typedef struct hfa384x_usb_rridresp {
> +
> +WARNING: do not add new typedefs
> +#885: FILE: drivers/staging/wlan-ng/hfa384x.h:885:
> ++typedef hfa384x_usb_cmdresp_t hfa384x_usb_wmemresp_t;
> +
> +WARNING: do not add new typedefs
> +#887: FILE: drivers/staging/wlan-ng/hfa384x.h:887:
> ++typedef struct hfa384x_usb_rmemresp {
> +
> +WARNING: do not add new typedefs
> +#893: FILE: drivers/staging/wlan-ng/hfa384x.h:893:
> ++typedef struct hfa384x_usb_bufavail {
> +
> +WARNING: do not add new typedefs
> +#898: FILE: drivers/staging/wlan-ng/hfa384x.h:898:
> ++typedef struct hfa384x_usb_error {
> +
> +WARNING: do not add new typedefs
> +#906: FILE: drivers/staging/wlan-ng/hfa384x.h:906:
> ++typedef union hfa384x_usbout {
> +
> +WARNING: do not add new typedefs
> +#916: FILE: drivers/staging/wlan-ng/hfa384x.h:916:
> ++typedef union hfa384x_usbin {
> +
> +WARNING: do not add new typedefs
> +#936: FILE: drivers/staging/wlan-ng/hfa384x.h:936:
> ++typedef struct hfa384x_pdr_pcb_partnum {
> +
> +WARNING: do not add new typedefs
> +#940: FILE: drivers/staging/wlan-ng/hfa384x.h:940:
> ++typedef struct hfa384x_pdr_pcb_tracenum {
> +
> +WARNING: do not add new typedefs
> +#944: FILE: drivers/staging/wlan-ng/hfa384x.h:944:
> ++typedef struct hfa384x_pdr_nic_serial {
> +
> +WARNING: do not add new typedefs
> +#948: FILE: drivers/staging/wlan-ng/hfa384x.h:948:
> ++typedef struct hfa384x_pdr_mkk_measurements {
> +
> +WARNING: do not add new typedefs
> +#966: FILE: drivers/staging/wlan-ng/hfa384x.h:966:
> ++typedef struct hfa384x_pdr_nic_ramsize {
> +
> +WARNING: do not add new typedefs
> +#970: FILE: drivers/staging/wlan-ng/hfa384x.h:970:
> ++typedef struct hfa384x_pdr_mfisuprange {
> +
> +WARNING: do not add new typedefs
> +#977: FILE: drivers/staging/wlan-ng/hfa384x.h:977:
> ++typedef struct hfa384x_pdr_cfisuprange {
> +
> +WARNING: do not add new typedefs
> +#984: FILE: drivers/staging/wlan-ng/hfa384x.h:984:
> ++typedef struct hfa384x_pdr_nicid {
> +
> +WARNING: do not add new typedefs
> +#991: FILE: drivers/staging/wlan-ng/hfa384x.h:991:
> ++typedef struct hfa384x_pdr_refdac_measurements {
> +
> +WARNING: do not add new typedefs
> +#995: FILE: drivers/staging/wlan-ng/hfa384x.h:995:
> ++typedef struct hfa384x_pdr_vgdac_measurements {
> +
> +WARNING: do not add new typedefs
> +#999: FILE: drivers/staging/wlan-ng/hfa384x.h:999:
> ++typedef struct hfa384x_pdr_level_comp_measurements {
> +
> +WARNING: do not add new typedefs
> +#1003: FILE: drivers/staging/wlan-ng/hfa384x.h:1003:
> ++typedef struct hfa384x_pdr_mac_address {
> +
> +WARNING: do not add new typedefs
> +#1007: FILE: drivers/staging/wlan-ng/hfa384x.h:1007:
> ++typedef struct hfa384x_pdr_mkk_callname {
> +
> +WARNING: do not add new typedefs
> +#1011: FILE: drivers/staging/wlan-ng/hfa384x.h:1011:
> ++typedef struct hfa384x_pdr_regdomain {
> +
> +WARNING: do not add new typedefs
> +#1016: FILE: drivers/staging/wlan-ng/hfa384x.h:1016:
> ++typedef struct hfa384x_pdr_allowed_channel {
> +
> +WARNING: do not add new typedefs
> +#1020: FILE: drivers/staging/wlan-ng/hfa384x.h:1020:
> ++typedef struct hfa384x_pdr_default_channel {
> +
> +WARNING: do not add new typedefs
> +#1024: FILE: drivers/staging/wlan-ng/hfa384x.h:1024:
> ++typedef struct hfa384x_pdr_privacy_option {
> +
> +WARNING: do not add new typedefs
> +#1028: FILE: drivers/staging/wlan-ng/hfa384x.h:1028:
> ++typedef struct hfa384x_pdr_temptype {
> +
> +WARNING: do not add new typedefs
> +#1032: FILE: drivers/staging/wlan-ng/hfa384x.h:1032:
> ++typedef struct hfa384x_pdr_refdac_setup {
> +
> +WARNING: do not add new typedefs
> +#1036: FILE: drivers/staging/wlan-ng/hfa384x.h:1036:
> ++typedef struct hfa384x_pdr_vgdac_setup {
> +
> +WARNING: do not add new typedefs
> +#1040: FILE: drivers/staging/wlan-ng/hfa384x.h:1040:
> ++typedef struct hfa384x_pdr_level_comp_setup {
> +
> +WARNING: do not add new typedefs
> +#1044: FILE: drivers/staging/wlan-ng/hfa384x.h:1044:
> ++typedef struct hfa384x_pdr_trimdac_setup {
> +
> +WARNING: do not add new typedefs
> +#1049: FILE: drivers/staging/wlan-ng/hfa384x.h:1049:
> ++typedef struct hfa384x_pdr_ifr_setting {
> +
> +WARNING: do not add new typedefs
> +#1053: FILE: drivers/staging/wlan-ng/hfa384x.h:1053:
> ++typedef struct hfa384x_pdr_rfr_setting {
> +
> +WARNING: do not add new typedefs
> +#1057: FILE: drivers/staging/wlan-ng/hfa384x.h:1057:
> ++typedef struct hfa384x_pdr_hfa3861_baseline {
> +
> +WARNING: do not add new typedefs
> +#1061: FILE: drivers/staging/wlan-ng/hfa384x.h:1061:
> ++typedef struct hfa384x_pdr_hfa3861_shadow {
> +
> +WARNING: do not add new typedefs
> +#1065: FILE: drivers/staging/wlan-ng/hfa384x.h:1065:
> ++typedef struct hfa384x_pdr_hfa3861_ifrf {
> +
> +WARNING: do not add new typedefs
> +#1069: FILE: drivers/staging/wlan-ng/hfa384x.h:1069:
> ++typedef struct hfa384x_pdr_hfa3861_chcalsp {
> +
> +WARNING: do not add new typedefs
> +#1073: FILE: drivers/staging/wlan-ng/hfa384x.h:1073:
> ++typedef struct hfa384x_pdr_hfa3861_chcali {
> +
> +WARNING: do not add new typedefs
> +#1077: FILE: drivers/staging/wlan-ng/hfa384x.h:1077:
> ++typedef struct hfa384x_pdr_hfa3861_nic_config {
> +
> +WARNING: do not add new typedefs
> +#1081: FILE: drivers/staging/wlan-ng/hfa384x.h:1081:
> ++typedef struct hfa384x_pdr_hfo_delay {
> +
> +WARNING: do not add new typedefs
> +#1085: FILE: drivers/staging/wlan-ng/hfa384x.h:1085:
> ++typedef struct hfa384x_pdr_hfa3861_manf_testsp {
> +
> +WARNING: do not add new typedefs
> +#1089: FILE: drivers/staging/wlan-ng/hfa384x.h:1089:
> ++typedef struct hfa384x_pdr_hfa3861_manf_testi {
> +
> +WARNING: do not add new typedefs
> +#1093: FILE: drivers/staging/wlan-ng/hfa384x.h:1093:
> ++typedef struct hfa384x_end_of_pda {
> +
> +WARNING: do not add new typedefs
> +#1097: FILE: drivers/staging/wlan-ng/hfa384x.h:1097:
> ++typedef struct hfa384x_pdrec {
> +
> +WARNING: do not add new typedefs
> +#1145: FILE: drivers/staging/wlan-ng/hfa384x.h:1145:
> ++typedef struct hfa384x_statusresult {
> +
> +WARNING: do not add new typedefs
> +#1159: FILE: drivers/staging/wlan-ng/hfa384x.h:1159:
> ++typedef struct hfa384x_rridresult {
> +
> +CHECK: Please use a blank line after function/struct/union/enum declarations
> +#1176: FILE: drivers/staging/wlan-ng/hfa384x.h:1176:
> ++};
> ++typedef enum ctlx_state CTLX_STATE;
> +
> +WARNING: do not add new typedefs
> +#1176: FILE: drivers/staging/wlan-ng/hfa384x.h:1176:
> ++typedef enum ctlx_state CTLX_STATE;
> +
> +WARNING: do not add new typedefs
> +#1186: FILE: drivers/staging/wlan-ng/hfa384x.h:1186:
> ++typedef struct hfa384x_usbctlx {
> +
> +WARNING: Missing a blank line after declarations
> +#1196: FILE: drivers/staging/wlan-ng/hfa384x.h:1196:
> ++ struct completion done;
> ++ volatile int reapable; /* Food for the reaper task */
> +
> +WARNING: Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt
> +#1196: FILE: drivers/staging/wlan-ng/hfa384x.h:1196:
> ++ volatile int reapable; /* Food for the reaper task */
> +
> +WARNING: do not add new typedefs
> +#1205: FILE: drivers/staging/wlan-ng/hfa384x.h:1205:
> ++typedef struct hfa384x_usbctlxq {
> +
> +CHECK: spinlock_t definition without comment
> +#1206: FILE: drivers/staging/wlan-ng/hfa384x.h:1206:
> ++ spinlock_t lock;
> +
> +WARNING: do not add new typedefs
> +#1213: FILE: drivers/staging/wlan-ng/hfa384x.h:1213:
> ++typedef struct hfa484x_metacmd {
> +
> +WARNING: do not add new typedefs
> +#1248: FILE: drivers/staging/wlan-ng/hfa384x.h:1248:
> ++typedef struct hfa384x {
> +
> +WARNING: line over 80 characters
> +#1379: FILE: drivers/staging/wlan-ng/hfa384x.h:1379:
> ++ struct prism2sta_authlist authlist; /* Authenticated station list. */
> +
> +CHECK: No space is necessary after a cast
> +#1409: FILE: drivers/staging/wlan-ng/hfa384x.h:1409:
> ++ *((u16 *) val) = le16_to_cpu(*((u16 *) val));
> +
> +total: 0 errors, 90 warnings, 49 checks, 1454 lines checked
> +
> +NOTE: For some of the reported defects, checkpatch may be able to
> + mechanically convert to the typical style using --fix or --fix-inplace.
> +
> +drivers/staging/wlan-ng/hfa384x.h has style problems, please review.
> +
> +NOTE: If any of the errors are false positives, please report
> + them to the maintainer, see CHECKPATCH in MAINTAINERS.
> --
> 2.9.2
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/184bf0cf735c495cb964324f4a49d4dfcb363f2c.1473993585.git.gs051095%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [Outreachy kernel] [PATCH 5/8] staging: wlan-ng: add spaces around <<
2016-09-16 2:46 ` [PATCH 5/8] staging: wlan-ng: add spaces around << Gargi Sharma
@ 2016-09-16 5:39 ` Julia Lawall
2016-09-16 9:58 ` Gargi Sharma
0 siblings, 1 reply; 17+ messages in thread
From: Julia Lawall @ 2016-09-16 5:39 UTC (permalink / raw)
To: Gargi Sharma; +Cc: outreachy-kernel, gregkh
On Fri, 16 Sep 2016, Gargi Sharma wrote:
> add spaces around << to fix the checkpatch issue, spaces preferred
> around that '<<'.
>
> Signed-off-by: Gargi Sharma <gs051095@gmail.com>
> ---
> drivers/staging/wlan-ng/hfa384x.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h
> index 4bbbce5..616da07 100644
> --- a/drivers/staging/wlan-ng/hfa384x.h
> +++ b/drivers/staging/wlan-ng/hfa384x.h
> @@ -508,7 +508,7 @@ Communication Frames: Test/Get/Set Field Values for Transmit Frames
> HFA384x_TXSTATUS_DISCON | HFA384x_TXSTATUS_AGEDERR | \
> HFA384x_TXSTATUS_RETRYERR))
>
> -#define HFA384x_TX_SET(v, m, s) ((((u16)(v))<<((u16)(s))) & ((u16)(m)))
> +#define HFA384x_TX_SET(v, m, s) ((((u16)(v)) << ((u16)(s))) & ((u16)(m)))
>
> #define HFA384x_TX_MACPORT_SET(v) HFA384x_TX_SET(v, HFA384x_TX_MACPORT, 8)
> #define HFA384x_TX_STRUCTYPE_SET(v) HFA384x_TX_SET(v, \
This code quite unnecessarily exceeds 80 characters. Add another patch to
the series that moves the macro names to their normal position, one space
after the #define.
julia
> --
> 2.9.2
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/73a02d3096f26d75f39cc09779e7d9f74eda9828.1473993585.git.gs051095%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [Outreachy kernel] [PATCH 8/8] staging: wlan-ng: fix block comment style
2016-09-16 5:33 ` [Outreachy kernel] " Julia Lawall
@ 2016-09-16 5:40 ` Alison Schofield
0 siblings, 0 replies; 17+ messages in thread
From: Alison Schofield @ 2016-09-16 5:40 UTC (permalink / raw)
To: Julia Lawall; +Cc: Gargi Sharma, outreachy-kernel, gregkh
On Fri, Sep 16, 2016 at 07:33:33AM +0200, Julia Lawall wrote:
>
>
> On Fri, 16 Sep 2016, Gargi Sharma wrote:
>
> > move trailing markers to next line to fix the checkpatch issue Block
> > comments use a trailing */ on a separate line. Also, added * to the
> > multi-line comment to increase readability.
>
> I think you could drop all of the --------------------.
> That serves sort of the same role as the /* and */ on separate lines.
> Most of the kernel doesn't do that.
>
> julia
Gargi -
Since you are going to rev this, I'll add another comment.
Patches 1,2,3,4,5,6,7 had perfect commit messages! Then this one,
used the word 'fix' and broke the streak ;) How about saying:
"use kernel preferred block commenting style"
Thanks,
alisons
>
> > Signed-off-by: Gargi Sharma <gs051095@gmail.com>
> > ---
> > drivers/staging/wlan-ng/hfa384x.h | 226 +++++++++++++++++++++-----------------
> > 1 file changed, 127 insertions(+), 99 deletions(-)
> >
> > diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h
> > index 1fc34c7..7a7ba27 100644
> > --- a/drivers/staging/wlan-ng/hfa384x.h
> > +++ b/drivers/staging/wlan-ng/hfa384x.h
> > @@ -110,7 +110,8 @@
> > #define HFA384x_ADDR_FLAT_CMD_OFF_MASK (0x0000ffff)
> >
> > /* Mask bits for discarding unwanted pieces in AUX format
> > - 16-bit address parts */
> > + * 16-bit address parts
> > + */
> > #define HFA384x_ADDR_AUX_PAGE_MASK (0xffff)
> > #define HFA384x_ADDR_AUX_OFF_MASK (0x007f)
> >
> > @@ -172,21 +173,23 @@
> > /*--- Result Codes --------------------------*/
> > #define HFA384x_CMD_ERR ((u16)(0x7F))
> >
> > -/*--- Programming Modes --------------------------
> > - MODE 0: Disable programming
> > - MODE 1: Enable volatile memory programming
> > - MODE 2: Enable non-volatile memory programming
> > - MODE 3: Program non-volatile memory section
> > ---------------------------------------------------*/
> > +/* --- Programming Modes --------------------------
> > + * MODE 0: Disable programming
> > + * MODE 1: Enable volatile memory programming
> > + * MODE 2: Enable non-volatile memory programming
> > + * MODE 3: Program non-volatile memory section
> > + * ------------------------------------------------
> > + */
> > #define HFA384x_PROGMODE_DISABLE ((u16)0x00)
> > #define HFA384x_PROGMODE_RAM ((u16)0x01)
> > #define HFA384x_PROGMODE_NV ((u16)0x02)
> > #define HFA384x_PROGMODE_NVWRITE ((u16)0x03)
> >
> > /*--- Record ID Constants --------------------------*/
> > -/*--------------------------------------------------------------------
> > -Configuration RIDs: Network Parameters, Static Configuration Entities
> > ---------------------------------------------------------------------*/
> > +/* -------------------------------------------------------------------
> > + * Configuration RIDs: Network Parameters, Static Configuration Entities
> > + * -------------------------------------------------------------------
> > + */
> > #define HFA384x_RID_CNFPORTTYPE ((u16)0xFC00)
> > #define HFA384x_RID_CNFOWNMACADDR ((u16)0xFC01)
> > #define HFA384x_RID_CNFDESIREDSSID ((u16)0xFC02)
> > @@ -194,27 +197,30 @@ Configuration RIDs: Network Parameters, Static Configuration Entities
> > #define HFA384x_RID_CNFOWNSSID ((u16)0xFC04)
> > #define HFA384x_RID_CNFMAXDATALEN ((u16)0xFC07)
> >
> > -/*--------------------------------------------------------------------
> > -Configuration RID lengths: Network Params, Static Config Entities
> > - This is the length of JUST the DATA part of the RID (does not
> > - include the len or code fields)
> > ---------------------------------------------------------------------*/
> > +/* -------------------------------------------------------------------
> > + * Configuration RID lengths: Network Params, Static Config Entities
> > + * This is the length of JUST the DATA part of the RID (does not
> > + * include the len or code fields)
> > + * -------------------------------------------------------------------
> > + */
> > #define HFA384x_RID_CNFOWNMACADDR_LEN ((u16)6)
> > #define HFA384x_RID_CNFDESIREDSSID_LEN ((u16)34)
> > #define HFA384x_RID_CNFOWNSSID_LEN ((u16)34)
> >
> > -/*--------------------------------------------------------------------
> > -Configuration RIDs: Network Parameters, Dynamic Configuration Entities
> > ---------------------------------------------------------------------*/
> > +/* --------------------------------------------------------------------
> > + * Configuration RIDs: Network Parameters, Dynamic Configuration Entities
> > + * --------------------------------------------------------------------
> > + */
> > #define HFA384x_RID_CREATEIBSS ((u16)0xFC81)
> > #define HFA384x_RID_FRAGTHRESH ((u16)0xFC82)
> > #define HFA384x_RID_RTSTHRESH ((u16)0xFC83)
> > #define HFA384x_RID_TXRATECNTL ((u16)0xFC84)
> > #define HFA384x_RID_PROMISCMODE ((u16)0xFC85)
> >
> > -/*----------------------------------------------------------------------
> > -Information RIDs: NIC Information
> > ---------------------------------------------------------------------*/
> > +/* --------------------------------------------------------------------
> > + * Information RIDs: NIC Information
> > + * --------------------------------------------------------------------
> > + */
> > #define HFA384x_RID_MAXLOADTIME ((u16)0xFD00)
> > #define HFA384x_RID_DOWNLOADBUFFER ((u16)0xFD01)
> > #define HFA384x_RID_PRIIDENTITY ((u16)0xFD02)
> > @@ -229,16 +235,18 @@ Information RIDs: NIC Information
> > #define HFA384x_RID_STA_MFIACTRANGES ((u16)0xFD22)
> > #define HFA384x_RID_STA_CFIACTRANGES ((u16)0xFD23)
> >
> > -/*----------------------------------------------------------------------
> > -Information RID Lengths: NIC Information
> > - This is the length of JUST the DATA part of the RID (does not
> > - include the len or code fields)
> > ---------------------------------------------------------------------*/
> > +/* --------------------------------------------------------------------
> > + * Information RID Lengths: NIC Information
> > + * This is the length of JUST the DATA part of the RID (does not
> > + * include the len or code fields)
> > + * --------------------------------------------------------------------
> > + */
> > #define HFA384x_RID_NICSERIALNUMBER_LEN ((u16)12)
> >
> > -/*--------------------------------------------------------------------
> > -Information RIDs: MAC Information
> > ---------------------------------------------------------------------*/
> > +/* --------------------------------------------------------------------
> > + * Information RIDs: MAC Information
> > + * --------------------------------------------------------------------
> > + */
> > #define HFA384x_RID_PORTSTATUS ((u16)0xFD40)
> > #define HFA384x_RID_CURRENTSSID ((u16)0xFD41)
> > #define HFA384x_RID_CURRENTBSSID ((u16)0xFD42)
> > @@ -249,24 +257,27 @@ Information RIDs: MAC Information
> > #define HFA384x_RID_PRIVACYOPTIMP ((u16)0xFD4F)
> > #define HFA384x_RID_DBMCOMMSQUALITY ((u16)0xFD51)
> >
> > -/*--------------------------------------------------------------------
> > -Information RID Lengths: MAC Information
> > - This is the length of JUST the DATA part of the RID (does not
> > - include the len or code fields)
> > ---------------------------------------------------------------------*/
> > +/* -------------------------------------------------------------------
> > + * Information RID Lengths: MAC Information
> > + * This is the length of JUST the DATA part of the RID (does not
> > + * include the len or code fields)
> > + * -------------------------------------------------------------------
> > + */
> > #define HFA384x_RID_DBMCOMMSQUALITY_LEN \
> > ((u16)sizeof(hfa384x_dbmcommsquality_t))
> > #define HFA384x_RID_JOINREQUEST_LEN \
> > ((u16)sizeof(hfa384x_JoinRequest_data_t))
> >
> > -/*--------------------------------------------------------------------
> > -Information RIDs: Modem Information
> > ---------------------------------------------------------------------*/
> > +/* --------------------------------------------------------------------
> > + * Information RIDs: Modem Information
> > + * --------------------------------------------------------------------
> > + */
> > #define HFA384x_RID_CURRENTCHANNEL ((u16)0xFDC1)
> >
> > -/*--------------------------------------------------------------------
> > -API ENHANCEMENTS (NOT ALREADY IMPLEMENTED)
> > ---------------------------------------------------------------------*/
> > +/* --------------------------------------------------------------------
> > + * API ENHANCEMENTS (NOT ALREADY IMPLEMENTED)
> > + * --------------------------------------------------------------------
> > + */
> > #define HFA384x_RID_CNFWEPDEFAULTKEYID ((u16)0xFC23)
> > #define HFA384x_RID_CNFWEPDEFAULTKEY0 ((u16)0xFC24)
> > #define HFA384x_RID_CNFWEPDEFAULTKEY1 ((u16)0xFC25)
> > @@ -289,9 +300,10 @@ API ENHANCEMENTS (NOT ALREADY IMPLEMENTED)
> > #define HFA384x_RID_CNFWEPDEFAULTKEY_LEN ((u16)6)
> > #define HFA384x_RID_CNFWEP128DEFAULTKEY_LEN ((u16)14)
> >
> > -/*--------------------------------------------------------------------
> > -PD Record codes
> > ---------------------------------------------------------------------*/
> > +/* --------------------------------------------------------------------
> > + * PD Record codes
> > + * --------------------------------------------------------------------
> > + */
> > #define HFA384x_PDR_PCB_PARTNUM ((u16)0x0001)
> > #define HFA384x_PDR_PDAVER ((u16)0x0002)
> > #define HFA384x_PDR_NIC_SERIAL ((u16)0x0003)
> > @@ -360,10 +372,11 @@ typedef struct hfa384x_bytestr32 {
> > u8 data[32];
> > } __packed hfa384x_bytestr32_t;
> >
> > -/*--------------------------------------------------------------------
> > -Configuration Record Structures:
> > - Network Parameters, Static Configuration Entities
> > ---------------------------------------------------------------------*/
> > +/* --------------------------------------------------------------------
> > + * Configuration Record Structures:
> > + * Network Parameters, Static Configuration Entities
> > + * --------------------------------------------------------------------
> > + */
> >
> > /*-- Hardware/Firmware Component Information ----------*/
> > typedef struct hfa384x_compident {
> > @@ -386,10 +399,11 @@ typedef struct hfa384x_caplevel {
> > #define HFA384x_CNFAUTHENTICATION_SHAREDKEY 0x0002
> > #define HFA384x_CNFAUTHENTICATION_LEAP 0x0004
> >
> > -/*--------------------------------------------------------------------
> > -Configuration Record Structures:
> > - Network Parameters, Dynamic Configuration Entities
> > ---------------------------------------------------------------------*/
> > +/* --------------------------------------------------------------------
> > + * Configuration Record Structures:
> > + * Network Parameters, Dynamic Configuration Entities
> > + * --------------------------------------------------------------------
> > + */
> >
> > #define HFA384x_CREATEIBSS_JOINCREATEIBSS 0
> >
> > @@ -419,9 +433,10 @@ typedef struct hfa384x_WPAData {
> > u8 data[0]; /* max 80 */
> > } __packed hfa384x_WPAData_t;
> >
> > -/*--------------------------------------------------------------------
> > -Information Record Structures: NIC Information
> > ---------------------------------------------------------------------*/
> > +/* --------------------------------------------------------------------
> > + * Information Record Structures: NIC Information
> > + * --------------------------------------------------------------------
> > + */
> >
> > /*-- Information Record: DownLoadBuffer --*/
> > /* NOTE: The page and offset are in AUX format */
> > @@ -431,9 +446,10 @@ typedef struct hfa384x_downloadbuffer {
> > u16 len;
> > } __packed hfa384x_downloadbuffer_t;
> >
> > -/*--------------------------------------------------------------------
> > -Information Record Structures: NIC Information
> > ---------------------------------------------------------------------*/
> > +/* --------------------------------------------------------------------
> > + * Information Record Structures: NIC Information
> > + * --------------------------------------------------------------------
> > + */
> >
> > #define HFA384x_PSTATUS_CONN_IBSS ((u16)3)
> >
> > @@ -451,11 +467,12 @@ typedef struct hfa384x_dbmcommsquality {
> > u16 ANLdbm_currFC;
> > } __packed hfa384x_dbmcommsquality_t;
> >
> > -/*--------------------------------------------------------------------
> > -FRAME STRUCTURES: Communication Frames
> > -----------------------------------------------------------------------
> > -Communication Frames: Transmit Frames
> > ---------------------------------------------------------------------*/
> > +/* --------------------------------------------------------------------
> > + * FRAME STRUCTURES: Communication Frames
> > + * --------------------------------------------------------------------
> > + * Communication Frames: Transmit Frames
> > + * --------------------------------------------------------------------
> > + */
> > /*-- Communication Frame: Transmit Frame Structure --*/
> > typedef struct hfa384x_tx_frame {
> > u16 status;
> > @@ -483,9 +500,10 @@ typedef struct hfa384x_tx_frame {
> > u8 src_addr[6];
> > u16 data_length; /* big endian format */
> > } __packed hfa384x_tx_frame_t;
> > -/*--------------------------------------------------------------------
> > -Communication Frames: Field Masks for Transmit Frames
> > ---------------------------------------------------------------------*/
> > +/* --------------------------------------------------------------------
> > + * Communication Frames: Field Masks for Transmit Frames
> > + * --------------------------------------------------------------------
> > + */
> > /*-- Status Field --*/
> > #define HFA384x_TXSTATUS_ACKERR ((u16)BIT(5))
> > #define HFA384x_TXSTATUS_FORMERR ((u16)BIT(3))
> > @@ -498,9 +516,10 @@ Communication Frames: Field Masks for Transmit Frames
> > #define HFA384x_TX_STRUCTYPE ((u16)(BIT(4) | BIT(3)))
> > #define HFA384x_TX_TXEX ((u16)BIT(2))
> > #define HFA384x_TX_TXOK ((u16)BIT(1))
> > -/*--------------------------------------------------------------------
> > -Communication Frames: Test/Get/Set Field Values for Transmit Frames
> > ---------------------------------------------------------------------*/
> > +/* --------------------------------------------------------------------
> > + * Communication Frames: Test/Get/Set Field Values for Transmit Frames
> > + * --------------------------------------------------------------------
> > + */
> > /*-- Status Field --*/
> > #define HFA384x_TXSTATUS_ISERROR(v) \
> > (((u16)(v)) & \
> > @@ -515,9 +534,10 @@ Communication Frames: Test/Get/Set Field Values for Transmit Frames
> > HFA384x_TX_STRUCTYPE, 3)
> > #define HFA384x_TX_TXEX_SET(v) HFA384x_TX_SET(v, HFA384x_TX_TXEX, 2)
> > #define HFA384x_TX_TXOK_SET(v) HFA384x_TX_SET(v, HFA384x_TX_TXOK, 1)
> > -/*--------------------------------------------------------------------
> > -Communication Frames: Receive Frames
> > ---------------------------------------------------------------------*/
> > +/* --------------------------------------------------------------------
> > + * Communication Frames: Receive Frames
> > + * --------------------------------------------------------------------
> > + */
> > /*-- Communication Frame: Receive Frame Structure --*/
> > typedef struct hfa384x_rx_frame {
> > /*-- MAC rx descriptor (hfa384x byte order) --*/
> > @@ -545,27 +565,30 @@ typedef struct hfa384x_rx_frame {
> > u8 src_addr[6];
> > u16 data_length; /* IEEE? (big endian) format */
> > } __packed hfa384x_rx_frame_t;
> > -/*--------------------------------------------------------------------
> > -Communication Frames: Field Masks for Receive Frames
> > ---------------------------------------------------------------------*/
> > +/* --------------------------------------------------------------------
> > + * Communication Frames: Field Masks for Receive Frames
> > + * --------------------------------------------------------------------
> > + */
> >
> > /*-- Status Fields --*/
> > #define HFA384x_RXSTATUS_MACPORT ((u16)(BIT(10) | \
> > BIT(9) | \
> > BIT(8)))
> > #define HFA384x_RXSTATUS_FCSERR ((u16)BIT(0))
> > -/*--------------------------------------------------------------------
> > -Communication Frames: Test/Get/Set Field Values for Receive Frames
> > ---------------------------------------------------------------------*/
> > +/* --------------------------------------------------------------------
> > + * Communication Frames: Test/Get/Set Field Values for Receive Frames
> > + * --------------------------------------------------------------------
> > + */
> > #define HFA384x_RXSTATUS_MACPORT_GET(value) ((u16)((((u16)(value)) \
> > & HFA384x_RXSTATUS_MACPORT) >> 8))
> > #define HFA384x_RXSTATUS_ISFCSERR(value) ((u16)(((u16)(value)) \
> > & HFA384x_RXSTATUS_FCSERR))
> > -/*--------------------------------------------------------------------
> > - FRAME STRUCTURES: Information Types and Information Frame Structures
> > -----------------------------------------------------------------------
> > -Information Types
> > ---------------------------------------------------------------------*/
> > +/* --------------------------------------------------------------------
> > + * FRAME STRUCTURES: Information Types and Information Frame Structures
> > + * --------------------------------------------------------------------
> > + * Information Types
> > + * --------------------------------------------------------------------
> > + */
> > #define HFA384x_IT_HANDOVERADDR ((u16)0xF000UL)
> > #define HFA384x_IT_COMMTALLIES ((u16)0xF100UL)
> > #define HFA384x_IT_SCANRESULTS ((u16)0xF101UL)
> > @@ -579,11 +602,12 @@ Information Types
> > #define HFA384x_IT_ASSOCREQ ((u16)0xF205UL)
> > #define HFA384x_IT_MICFAILURE ((u16)0xF206UL)
> >
> > -/*--------------------------------------------------------------------
> > -Information Frames Structures
> > -----------------------------------------------------------------------
> > -Information Frames: Notification Frame Structures
> > ---------------------------------------------------------------------*/
> > +/* --------------------------------------------------------------------
> > + * Information Frames Structures
> > + * --------------------------------------------------------------------
> > + * Information Frames: Notification Frame Structures
> > + * --------------------------------------------------------------------
> > + */
> >
> > /*-- Inquiry Frame, Diagnose: Communication Tallies --*/
> > typedef struct hfa384x_CommTallies16 {
> > @@ -756,9 +780,10 @@ typedef struct hfa384x_InfFrame {
> > hfa384x_infodata_t info;
> > } __packed hfa384x_InfFrame_t;
> >
> > -/*--------------------------------------------------------------------
> > -USB Packet structures and constants.
> > ---------------------------------------------------------------------*/
> > +/* --------------------------------------------------------------------
> > + * USB Packet structures and constants.
> > + * --------------------------------------------------------------------
> > + */
> >
> > /* Should be sent to the bulkout endpoint */
> > #define HFA384x_USB_TXFRM 0
> > @@ -903,9 +928,10 @@ typedef union hfa384x_usbin {
> > u8 boguspad[3000];
> > } __packed hfa384x_usbin_t;
> >
> > -/*--------------------------------------------------------------------
> > -PD record structures.
> > ---------------------------------------------------------------------*/
> > +/* --------------------------------------------------------------------
> > + * PD record structures.
> > + * --------------------------------------------------------------------
> > + */
> >
> > typedef struct hfa384x_pdr_pcb_partnum {
> > u8 num[8];
> > @@ -1111,10 +1137,11 @@ typedef struct hfa384x_pdrec {
> > } __packed hfa384x_pdrec_t;
> >
> > #ifdef __KERNEL__
> > -/*--------------------------------------------------------------------
> > ---- MAC state structure, argument to all functions --
> > ---- Also, a collection of support types --
> > ---------------------------------------------------------------------*/
> > +/* --------------------------------------------------------------------
> > + * --- MAC state structure, argument to all functions --
> > + * --- Also, a collection of support types --
> > + * --------------------------------------------------------------------
> > + */
> > typedef struct hfa384x_statusresult {
> > u16 status;
> > u16 resp0;
> > @@ -1298,7 +1325,8 @@ typedef struct hfa384x {
> > int dbmadjust;
> >
> > /* Group Addresses - right now, there are up to a total
> > - of MAX_GRP_ADDR group addresses */
> > + * of MAX_GRP_ADDR group addresses
> > + */
> > u8 dot11_grp_addr[MAX_GRP_ADDR][ETH_ALEN];
> > unsigned int dot11_grpcnt;
> >
> > @@ -1424,4 +1452,4 @@ hfa384x_cmd_download(hfa384x_t *hw,
> >
> > #endif /*__KERNEL__ */
> >
> > -#endif /*_HFA384x_H */
> > +#endif /*_HFA384x_H */
> > \ No newline at end of file
> > --
> > 2.9.2
> >
> > --
> > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> > To post to this group, send email to outreachy-kernel@googlegroups.com.
> > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/be09e4935621ebe770021ab141611304221b5adf.1473993585.git.gs051095%40gmail.com.
> > For more options, visit https://groups.google.com/d/optout.
> >
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [Outreachy kernel] [PATCH 3/8] staging: wlan-ng: add spaces around >>
2016-09-16 2:46 ` [PATCH 3/8] staging: wlan-ng: add spaces around >> Gargi Sharma
@ 2016-09-16 5:41 ` Julia Lawall
0 siblings, 0 replies; 17+ messages in thread
From: Julia Lawall @ 2016-09-16 5:41 UTC (permalink / raw)
To: Gargi Sharma; +Cc: outreachy-kernel, gregkh
On Fri, 16 Sep 2016, Gargi Sharma wrote:
> add spaces around >> to fix the checkpatch issue, spaces preferred
> around that '>>'.
>
> Signed-off-by: Gargi Sharma <gs051095@gmail.com>
> ---
> drivers/staging/wlan-ng/hfa384x.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h
> index e466883..d4b1dbf 100644
> --- a/drivers/staging/wlan-ng/hfa384x.h
> +++ b/drivers/staging/wlan-ng/hfa384x.h
> @@ -121,7 +121,7 @@
>
> /* Make CMD format offset and page from a 32-bit flat address */
> #define HFA384x_ADDR_CMD_MKPAGE(f) \
> - ((u16)((((u32)(f)) & HFA384x_ADDR_FLAT_CMD_PAGE_MASK)>>16))
> + ((u16)((((u32)(f)) & HFA384x_ADDR_FLAT_CMD_PAGE_MASK) >> 16))
> #define HFA384x_ADDR_CMD_MKOFF(f) \
> ((u16)(((u32)(f)) & HFA384x_ADDR_FLAT_CMD_OFF_MASK))
This code really looks ugly, with the name of the macro to the right of
the definition of the macro. You can fix all of the macro definitions in
the file.
julia
>
> --
> 2.9.2
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/2aa356783543963ae0896dea62b2297687c46b32.1473993585.git.gs051095%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [Outreachy kernel] [PATCH 5/8] staging: wlan-ng: add spaces around <<
2016-09-16 5:39 ` [Outreachy kernel] " Julia Lawall
@ 2016-09-16 9:58 ` Gargi Sharma
2016-09-16 10:07 ` Julia Lawall
0 siblings, 1 reply; 17+ messages in thread
From: Gargi Sharma @ 2016-09-16 9:58 UTC (permalink / raw)
To: Julia Lawall; +Cc: outreachy-kernel, Greg KH
[-- Attachment #1: Type: text/plain, Size: 2083 bytes --]
On Fri, Sep 16, 2016 at 11:09 AM, Julia Lawall <julia.lawall@lip6.fr> wrote:
>
>
>
> On Fri, 16 Sep 2016, Gargi Sharma wrote:
>
> > add spaces around << to fix the checkpatch issue, spaces preferred
> > around that '<<'.
> >
> > Signed-off-by: Gargi Sharma <gs051095@gmail.com>
> > ---
> > drivers/staging/wlan-ng/hfa384x.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/staging/wlan-ng/hfa384x.h
b/drivers/staging/wlan-ng/hfa384x.h
> > index 4bbbce5..616da07 100644
> > --- a/drivers/staging/wlan-ng/hfa384x.h
> > +++ b/drivers/staging/wlan-ng/hfa384x.h
> > @@ -508,7 +508,7 @@ Communication Frames: Test/Get/Set Field Values for
Transmit Frames
> > HFA384x_TXSTATUS_DISCON | HFA384x_TXSTATUS_AGEDERR | \
> > HFA384x_TXSTATUS_RETRYERR))
> >
> > -#define HFA384x_TX_SET(v, m, s) ((((u16)(v))<<((u16)(s)))
& ((u16)(m)))
> > +#define HFA384x_TX_SET(v, m, s) ((((u16)(v)) <<
((u16)(s))) & ((u16)(m)))
> >
> > #define HFA384x_TX_MACPORT_SET(v) HFA384x_TX_SET(v,
HFA384x_TX_MACPORT, 8)
> > #define HFA384x_TX_STRUCTYPE_SET(v) HFA384x_TX_SET(v, \
>
> This code quite unnecessarily exceeds 80 characters. Add another patch to
> the series that moves the macro names to their normal position, one space
> after the #define.
I will add another patch to the series. :) A few of the patches from this
series have been accepted by Greg, should I drop them from the next series?
Thanks,
gargi
>
> julia
>
> > --
> > 2.9.2
> >
> > --
> > You received this message because you are subscribed to the Google
Groups "outreachy-kernel" group.
> > To unsubscribe from this group and stop receiving emails from it, send
an email to outreachy-kernel+unsubscribe@googlegroups.com.
> > To post to this group, send email to outreachy-kernel@googlegroups.com.
> > To view this discussion on the web visit https://groups.google.com/d/
msgid/outreachy-kernel/73a02d3096f26d75f39cc09779e7d9
f74eda9828.1473993585.git.gs051095%40gmail.com.
> > For more options, visit https://groups.google.com/d/optout.
> >
[-- Attachment #2: Type: text/html, Size: 3175 bytes --]
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [Outreachy kernel] [PATCH 5/8] staging: wlan-ng: add spaces around <<
2016-09-16 9:58 ` Gargi Sharma
@ 2016-09-16 10:07 ` Julia Lawall
0 siblings, 0 replies; 17+ messages in thread
From: Julia Lawall @ 2016-09-16 10:07 UTC (permalink / raw)
To: Gargi Sharma; +Cc: outreachy-kernel, Greg KH
[-- Attachment #1: Type: TEXT/PLAIN, Size: 2986 bytes --]
On Fri, 16 Sep 2016, Gargi Sharma wrote:
> On Fri, Sep 16, 2016 at 11:09 AM, Julia Lawall <julia.lawall@lip6.fr> wrote:
> >
> >
> >
> > On Fri, 16 Sep 2016, Gargi Sharma wrote:
> >
> > > add spaces around << to fix the checkpatch issue, spaces preferred
> > > around that '<<'.
> > >
> > > Signed-off-by: Gargi Sharma <gs051095@gmail.com>
> > > ---
> > > drivers/staging/wlan-ng/hfa384x.h | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/staging/wlan-ng/hfa384x.h
> b/drivers/staging/wlan-ng/hfa384x.h
> > > index 4bbbce5..616da07 100644
> > > --- a/drivers/staging/wlan-ng/hfa384x.h
> > > +++ b/drivers/staging/wlan-ng/hfa384x.h
> > > @@ -508,7 +508,7 @@ Communication Frames: Test/Get/Set Field Values for
> Transmit Frames
> > > HFA384x_TXSTATUS_DISCON | HFA384x_TXSTATUS_AGEDERR | \
> > > HFA384x_TXSTATUS_RETRYERR))
> > >
> > > -#define HFA384x_TX_SET(v, m, s) ((((u16)(v))<<((u16)(s)))
> & ((u16)(m)))
> > > +#define HFA384x_TX_SET(v, m, s) ((((u16)(v)) <<
> ((u16)(s))) & ((u16)(m)))
> > >
> > > #define HFA384x_TX_MACPORT_SET(v) HFA384x_TX_SET(v,
> HFA384x_TX_MACPORT, 8)
> > > #define HFA384x_TX_STRUCTYPE_SET(v) HFA384x_TX_SET(v, \
> >
> > This code quite unnecessarily exceeds 80 characters. Add another patch to
> > the series that moves the macro names to their normal position, one space
> > after the #define.
> I will add another patch to the series. :) A few of the patches from this
> series have been accepted by Greg, should I drop them from the next series?
Greg said that he is caught up. So you can just start over in terms of
the version numbers. You should be sure to first pull his most recent
code.
julia
>
> Thanks,
> gargi
>
> >
> > julia
> >
> > > --
> > > 2.9.2
> > >
> > > --
> > > You received this message because you are subscribed to the Google
> Groups "outreachy-kernel" group.
> > > To unsubscribe from this group and stop receiving emails from it, send
> an email to outreachy-kernel+unsubscribe@googlegroups.com.
> > > To post to this group, send email to outreachy-kernel@googlegroups.com.
> > > To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/73a02d3096f26d75f39cc097
> 79e7d9f74eda9828.1473993585.git.gs051095%40gmail.com.
> > > For more options, visit https://groups.google.com/d/optout.
> > >
>
> --
> You received this message because you are subscribed to the Google Groups
> "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/CAOCi2DFFBUX825dA0oKCysy
> aKRaVDegwLBc3d2UDEpgkKc%3DmOg%40mail.gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>
>
^ permalink raw reply [flat|nested] 17+ messages in thread
end of thread, other threads:[~2016-09-16 10:07 UTC | newest]
Thread overview: 17+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-16 2:46 [PATCH 0/8] fix multiple checkpatch issues Gargi Sharma
2016-09-16 2:46 ` [PATCH 1/8] staging: wlan-ng: add spaces around + Gargi Sharma
2016-09-16 2:46 ` [PATCH 2/8] staging: wlan-ng: add spaces around & Gargi Sharma
2016-09-16 2:46 ` [PATCH 3/8] staging: wlan-ng: add spaces around >> Gargi Sharma
2016-09-16 5:41 ` [Outreachy kernel] " Julia Lawall
2016-09-16 2:46 ` [PATCH 4/8] staging: wlan-ng: add spaces around | Gargi Sharma
2016-09-16 2:46 ` [PATCH 5/8] staging: wlan-ng: add spaces around << Gargi Sharma
2016-09-16 5:39 ` [Outreachy kernel] " Julia Lawall
2016-09-16 9:58 ` Gargi Sharma
2016-09-16 10:07 ` Julia Lawall
2016-09-16 2:46 ` [PATCH 6/8] staging: wlan-ng: delete space after a cast Gargi Sharma
2016-09-16 5:37 ` [Outreachy kernel] " Julia Lawall
2016-09-16 2:46 ` [PATCH 7/8] staging: wlan-ng: add blank line after declaration Gargi Sharma
2016-09-16 5:35 ` [Outreachy kernel] " Julia Lawall
2016-09-16 2:46 ` [PATCH 8/8] staging: wlan-ng: fix block comment style Gargi Sharma
2016-09-16 5:33 ` [Outreachy kernel] " Julia Lawall
2016-09-16 5:40 ` Alison Schofield
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.