From: "yukuai (C)" <yukuai3@huawei.com>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
ysato@users.sourceforge.jp, dalias@libc.org,
aacraid@microsemi.com, jejb@linux.ibm.com,
martin.petersen@oracle.com, sathya.prakash@broadcom.com,
chaitra.basappa@broadcom.com,
suganath-prabu.subramani@broadcom.com
Cc: linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-scsi@vger.kernel.org, MPT-FusionLinux.pdl@broadcom.com,
zhengbin13@huawei.com, yi.zhang@huawei.com
Subject: Re: [PATCH] scsi: don't memset to zero after dma_alloc_coherent
Date: Thu, 26 Dec 2019 11:33:05 +0000 [thread overview]
Message-ID: <bbec6a4a-2c57-2254-2970-95acb098c7f3@huawei.com> (raw)
In-Reply-To: <68771eb5-03c4-422b-9956-930a0e3c9de8@cogentembedded.com>
On 2019/12/26 19:16, Sergei Shtylyov wrote:
> On 26.12.2019 14:13, yukuai (C) wrote:
>
>>>> dma_alloc_coherent already zeros out memory, so memset to zero is not
>>>> needed.
>>>>
>>>> Signed-off-by: yu kuai <yukuai3@huawei.com>
>>>> ---
>>>> arch/sh/mm/consistent.c | 2 --
>>>
>>> How this one is related to SCSI?
>>>
>> Thank you for your response!
>> I put them in the same patch because I thougt they are the same
>> situation. I'm sorry if it's not appropriate.
>
> I'd recommend to split such patch to (at least) different
> subsystems, e.g. arch/sh/ part, drivers/scsi/ part.
I'll do that, thank you again for your advise!
Yu Kuai
WARNING: multiple messages have this Message-ID (diff)
From: "yukuai (C)" <yukuai3@huawei.com>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
<ysato@users.sourceforge.jp>, <dalias@libc.org>,
<aacraid@microsemi.com>, <jejb@linux.ibm.com>,
<martin.petersen@oracle.com>, <sathya.prakash@broadcom.com>,
<chaitra.basappa@broadcom.com>,
<suganath-prabu.subramani@broadcom.com>
Cc: <linux-sh@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-scsi@vger.kernel.org>, <MPT-FusionLinux.pdl@broadcom.com>,
<zhengbin13@huawei.com>, <yi.zhang@huawei.com>
Subject: Re: [PATCH] scsi: don't memset to zero after dma_alloc_coherent
Date: Thu, 26 Dec 2019 19:33:05 +0800 [thread overview]
Message-ID: <bbec6a4a-2c57-2254-2970-95acb098c7f3@huawei.com> (raw)
In-Reply-To: <68771eb5-03c4-422b-9956-930a0e3c9de8@cogentembedded.com>
On 2019/12/26 19:16, Sergei Shtylyov wrote:
> On 26.12.2019 14:13, yukuai (C) wrote:
>
>>>> dma_alloc_coherent already zeros out memory, so memset to zero is not
>>>> needed.
>>>>
>>>> Signed-off-by: yu kuai <yukuai3@huawei.com>
>>>> ---
>>>> arch/sh/mm/consistent.c | 2 --
>>>
>>> How this one is related to SCSI?
>>>
>> Thank you for your response!
>> I put them in the same patch because I thougt they are the same
>> situation. I'm sorry if it's not appropriate.
>
> I'd recommend to split such patch to (at least) different
> subsystems, e.g. arch/sh/ part, drivers/scsi/ part.
I'll do that, thank you again for your advise!
Yu Kuai
next prev parent reply other threads:[~2019-12-26 11:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-25 13:23 [PATCH] scsi: don't memset to zero after dma_alloc_coherent yu kuai
2019-12-25 13:23 ` yu kuai
2019-12-26 11:03 ` Sergei Shtylyov
2019-12-26 11:03 ` Sergei Shtylyov
2019-12-26 11:13 ` yukuai (C)
2019-12-26 11:13 ` yukuai (C)
2019-12-26 11:16 ` Sergei Shtylyov
2019-12-26 11:16 ` Sergei Shtylyov
2019-12-26 11:33 ` yukuai (C) [this message]
2019-12-26 11:33 ` yukuai (C)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bbec6a4a-2c57-2254-2970-95acb098c7f3@huawei.com \
--to=yukuai3@huawei.com \
--cc=MPT-FusionLinux.pdl@broadcom.com \
--cc=aacraid@microsemi.com \
--cc=chaitra.basappa@broadcom.com \
--cc=dalias@libc.org \
--cc=jejb@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=sathya.prakash@broadcom.com \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=suganath-prabu.subramani@broadcom.com \
--cc=yi.zhang@huawei.com \
--cc=ysato@users.sourceforge.jp \
--cc=zhengbin13@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.