From: Robin Murphy <robin.murphy@arm.com>
To: Joerg Roedel <joro@8bytes.org>, Kevin Tang <kevin3.tang@gmail.com>
Cc: Maxime Ripard <maxime@cerno.tech>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Sean Paul <sean@poorly.run>, David Airlie <airlied@linux.ie>,
Daniel Vetter <daniel@ffwll.ch>, Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Orson Zhai <orsonzhai@gmail.com>,
Chunyan Zhang <zhang.lyra@gmail.com>,
"Linux-Kernel@Vger. Kernel. Org" <linux-kernel@vger.kernel.org>,
ML dri-devel <dri-devel@lists.freedesktop.org>,
devicetree@vger.kernel.org
Subject: Re: [PATCH v5 4/6] drm/sprd: add Unisoc's drm display controller driver
Date: Mon, 17 May 2021 17:35:23 +0100 [thread overview]
Message-ID: <bc0e3025-60bd-c6b4-117f-592dc1c1a2f0@arm.com> (raw)
In-Reply-To: <YKI26bZGAA+ZNLLj@8bytes.org>
On 2021-05-17 10:27, Joerg Roedel wrote:
> On Fri, Apr 30, 2021 at 08:20:10PM +0800, Kevin Tang wrote:
>> Cc Robin & Joerg
>
> This is just some GPU internal MMU being used here, it seems. It doesn't
> use the IOMMU core code, so no Ack needed from the IOMMU side.
Except the actual MMU being used is drivers/iommu/sprd_iommu.c - this is
just the display driver poking directly at the interrupt registers of
its associated IOMMU instance. I still think this is wrong, and that it
should be treated as a shared interrupt, with the IOMMU driver handling
its own registers and reporting to the client through the standard
report_iommu_fault() API, especially since there are apparently more
blocks using these IOMMU instances than just the display.
Robin.
WARNING: multiple messages have this Message-ID (diff)
From: Robin Murphy <robin.murphy@arm.com>
To: Joerg Roedel <joro@8bytes.org>, Kevin Tang <kevin3.tang@gmail.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, David Airlie <airlied@linux.ie>,
Chunyan Zhang <zhang.lyra@gmail.com>,
"Linux-Kernel@Vger. Kernel. Org" <linux-kernel@vger.kernel.org>,
ML dri-devel <dri-devel@lists.freedesktop.org>,
Rob Herring <robh+dt@kernel.org>,
Maxime Ripard <maxime@cerno.tech>,
Orson Zhai <orsonzhai@gmail.com>, Sean Paul <sean@poorly.run>
Subject: Re: [PATCH v5 4/6] drm/sprd: add Unisoc's drm display controller driver
Date: Mon, 17 May 2021 17:35:23 +0100 [thread overview]
Message-ID: <bc0e3025-60bd-c6b4-117f-592dc1c1a2f0@arm.com> (raw)
In-Reply-To: <YKI26bZGAA+ZNLLj@8bytes.org>
On 2021-05-17 10:27, Joerg Roedel wrote:
> On Fri, Apr 30, 2021 at 08:20:10PM +0800, Kevin Tang wrote:
>> Cc Robin & Joerg
>
> This is just some GPU internal MMU being used here, it seems. It doesn't
> use the IOMMU core code, so no Ack needed from the IOMMU side.
Except the actual MMU being used is drivers/iommu/sprd_iommu.c - this is
just the display driver poking directly at the interrupt registers of
its associated IOMMU instance. I still think this is wrong, and that it
should be treated as a shared interrupt, with the IOMMU driver handling
its own registers and reporting to the client through the standard
report_iommu_fault() API, especially since there are apparently more
blocks using these IOMMU instances than just the display.
Robin.
next prev parent reply other threads:[~2021-05-17 16:35 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-25 12:36 [PATCH v5 0/6] Add Unisoc's drm kms module Kevin Tang
2021-04-25 12:36 ` Kevin Tang
2021-04-25 12:36 ` [PATCH v5 1/6] dt-bindings: display: add Unisoc's drm master bindings Kevin Tang
2021-04-25 12:36 ` Kevin Tang
2021-04-30 9:12 ` Maxime Ripard
2021-04-30 9:12 ` Maxime Ripard
2021-04-25 12:36 ` [PATCH v5 2/6] drm/sprd: add Unisoc's drm kms master Kevin Tang
2021-04-25 12:36 ` Kevin Tang
2021-04-25 12:36 ` [PATCH v5 3/6] dt-bindings: display: add Unisoc's dpu bindings Kevin Tang
2021-04-25 12:36 ` Kevin Tang
2021-04-25 12:36 ` [PATCH v5 4/6] drm/sprd: add Unisoc's drm display controller driver Kevin Tang
2021-04-25 12:36 ` Kevin Tang
2021-04-30 9:22 ` Maxime Ripard
2021-04-30 9:22 ` Maxime Ripard
2021-04-30 12:20 ` Kevin Tang
2021-04-30 12:20 ` Kevin Tang
2021-05-17 9:27 ` Joerg Roedel
2021-05-17 9:27 ` Joerg Roedel
2021-05-17 16:35 ` Robin Murphy [this message]
2021-05-17 16:35 ` Robin Murphy
2021-05-26 7:59 ` Chunyan Zhang
2021-05-26 8:07 ` Chunyan Zhang
2021-05-26 8:07 ` Chunyan Zhang
2021-05-14 13:18 ` Kevin Tang
2021-05-14 13:18 ` Kevin Tang
2021-05-18 14:23 ` Maxime Ripard
2021-05-18 14:23 ` Maxime Ripard
2021-05-12 6:25 ` Chunyan Zhang
2021-05-12 6:25 ` Chunyan Zhang
2021-04-25 12:36 ` [PATCH v5 5/6] dt-bindings: display: add Unisoc's mipi dsi controller bindings Kevin Tang
2021-04-25 12:36 ` Kevin Tang
2021-04-25 12:36 ` [PATCH v5 6/6] drm/sprd: add Unisoc's drm mipi dsi&dphy driver Kevin Tang
2021-04-25 12:36 ` Kevin Tang
2021-04-25 16:27 ` kernel test robot
2021-04-30 9:35 ` Maxime Ripard
2021-05-12 13:53 ` Kevin Tang
2021-05-18 14:20 ` Maxime Ripard
2021-05-18 14:20 ` Maxime Ripard
2021-04-26 6:17 [PATCH v5 4/6] drm/sprd: add Unisoc's drm display controller driver kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bc0e3025-60bd-c6b4-117f-592dc1c1a2f0@arm.com \
--to=robin.murphy@arm.com \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=joro@8bytes.org \
--cc=kevin3.tang@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mark.rutland@arm.com \
--cc=maxime@cerno.tech \
--cc=orsonzhai@gmail.com \
--cc=robh+dt@kernel.org \
--cc=sean@poorly.run \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.