* [PATCH] vl: initialize displays _after_ exiting preconfiguration
@ 2020-12-17 9:14 Paolo Bonzini
2021-01-06 17:06 ` BALATON Zoltan
0 siblings, 1 reply; 4+ messages in thread
From: Paolo Bonzini @ 2020-12-17 9:14 UTC (permalink / raw)
To: qemu-devel; +Cc: Howard Spoelstra
Due to the renumbering of text consoles when graphical consoles are
created, init_displaystate must be called after all QemuConsoles are
created, i.e. after devices are created.
vl.c calls it from qemu_init_displays, while qmp_x_exit_preconfig is
where devices are created. If qemu_init_displays is called before it,
the VGA graphical console does not come up.
Reported-by: Howard Spoelstra <hsp.cat7@gmail.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
softmmu/vl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/softmmu/vl.c b/softmmu/vl.c
index 0ed5c5ba93..7ddf405d76 100644
--- a/softmmu/vl.c
+++ b/softmmu/vl.c
@@ -3529,10 +3529,10 @@ void qemu_init(int argc, char **argv, char **envp)
exit(0);
}
- qemu_init_displays();
if (!preconfig_requested) {
qmp_x_exit_preconfig(&error_fatal);
}
+ qemu_init_displays();
accel_setup_post(current_machine);
os_setup_post();
resume_mux_open();
--
2.29.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] vl: initialize displays _after_ exiting preconfiguration
2020-12-17 9:14 [PATCH] vl: initialize displays _after_ exiting preconfiguration Paolo Bonzini
@ 2021-01-06 17:06 ` BALATON Zoltan
2021-01-06 19:58 ` Paolo Bonzini
0 siblings, 1 reply; 4+ messages in thread
From: BALATON Zoltan @ 2021-01-06 17:06 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: Peter Maydell, Gerd Hoffmann, qemu-devel, Howard Spoelstra
On Thu, 17 Dec 2020, Paolo Bonzini wrote:
> Due to the renumbering of text consoles when graphical consoles are
> created, init_displaystate must be called after all QemuConsoles are
> created, i.e. after devices are created.
>
> vl.c calls it from qemu_init_displays, while qmp_x_exit_preconfig is
> where devices are created. If qemu_init_displays is called before it,
> the VGA graphical console does not come up.
Tested-by: BALATON Zoltan <balaton@eik.bme.hu>
This still seems to be missing from master, who should take care of this?
Regards,
BALATON Zoltan
> Reported-by: Howard Spoelstra <hsp.cat7@gmail.com>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> softmmu/vl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/softmmu/vl.c b/softmmu/vl.c
> index 0ed5c5ba93..7ddf405d76 100644
> --- a/softmmu/vl.c
> +++ b/softmmu/vl.c
> @@ -3529,10 +3529,10 @@ void qemu_init(int argc, char **argv, char **envp)
> exit(0);
> }
>
> - qemu_init_displays();
> if (!preconfig_requested) {
> qmp_x_exit_preconfig(&error_fatal);
> }
> + qemu_init_displays();
> accel_setup_post(current_machine);
> os_setup_post();
> resume_mux_open();
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] vl: initialize displays _after_ exiting preconfiguration
2021-01-06 17:06 ` BALATON Zoltan
@ 2021-01-06 19:58 ` Paolo Bonzini
2021-01-06 21:24 ` BALATON Zoltan
0 siblings, 1 reply; 4+ messages in thread
From: Paolo Bonzini @ 2021-01-06 19:58 UTC (permalink / raw)
To: BALATON Zoltan; +Cc: Peter Maydell, Gerd Hoffmann, qemu-devel, Howard Spoelstra
[-- Attachment #1: Type: text/plain, Size: 1403 bytes --]
Il mer 6 gen 2021, 18:06 BALATON Zoltan <balaton@eik.bme.hu> ha scritto:
> On Thu, 17 Dec 2020, Paolo Bonzini wrote:
> > Due to the renumbering of text consoles when graphical consoles are
> > created, init_displaystate must be called after all QemuConsoles are
> > created, i.e. after devices are created.
> >
> > vl.c calls it from qemu_init_displays, while qmp_x_exit_preconfig is
> > where devices are created. If qemu_init_displays is called before it,
> > the VGA graphical console does not come up.
>
> Tested-by: BALATON Zoltan <balaton@eik.bme.hu>
>
> This still seems to be missing from master, who should take care of this?
>
It's in now, I think.
Paolo
> Regards,
> BALATON Zoltan
>
> > Reported-by: Howard Spoelstra <hsp.cat7@gmail.com>
> > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> > ---
> > softmmu/vl.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/softmmu/vl.c b/softmmu/vl.c
> > index 0ed5c5ba93..7ddf405d76 100644
> > --- a/softmmu/vl.c
> > +++ b/softmmu/vl.c
> > @@ -3529,10 +3529,10 @@ void qemu_init(int argc, char **argv, char
> **envp)
> > exit(0);
> > }
> >
> > - qemu_init_displays();
> > if (!preconfig_requested) {
> > qmp_x_exit_preconfig(&error_fatal);
> > }
> > + qemu_init_displays();
> > accel_setup_post(current_machine);
> > os_setup_post();
> > resume_mux_open();
> >
>
>
[-- Attachment #2: Type: text/html, Size: 2454 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] vl: initialize displays _after_ exiting preconfiguration
2021-01-06 19:58 ` Paolo Bonzini
@ 2021-01-06 21:24 ` BALATON Zoltan
0 siblings, 0 replies; 4+ messages in thread
From: BALATON Zoltan @ 2021-01-06 21:24 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: Peter Maydell, Gerd Hoffmann, qemu-devel, Howard Spoelstra
On Wed, 6 Jan 2021, Paolo Bonzini wrote:
> Il mer 6 gen 2021, 18:06 BALATON Zoltan <balaton@eik.bme.hu> ha scritto:
>
>> On Thu, 17 Dec 2020, Paolo Bonzini wrote:
>>> Due to the renumbering of text consoles when graphical consoles are
>>> created, init_displaystate must be called after all QemuConsoles are
>>> created, i.e. after devices are created.
>>>
>>> vl.c calls it from qemu_init_displays, while qmp_x_exit_preconfig is
>>> where devices are created. If qemu_init_displays is called before it,
>>> the VGA graphical console does not come up.
>>
>> Tested-by: BALATON Zoltan <balaton@eik.bme.hu>
>>
>> This still seems to be missing from master, who should take care of this?
>>
>
> It's in now, I think.
Yes, got merges with the misc fixes series.
Thanks,
BALATON Zoltan
> Paolo
>
>
>> Regards,
>> BALATON Zoltan
>>
>>> Reported-by: Howard Spoelstra <hsp.cat7@gmail.com>
>>> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>>> ---
>>> softmmu/vl.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/softmmu/vl.c b/softmmu/vl.c
>>> index 0ed5c5ba93..7ddf405d76 100644
>>> --- a/softmmu/vl.c
>>> +++ b/softmmu/vl.c
>>> @@ -3529,10 +3529,10 @@ void qemu_init(int argc, char **argv, char
>> **envp)
>>> exit(0);
>>> }
>>>
>>> - qemu_init_displays();
>>> if (!preconfig_requested) {
>>> qmp_x_exit_preconfig(&error_fatal);
>>> }
>>> + qemu_init_displays();
>>> accel_setup_post(current_machine);
>>> os_setup_post();
>>> resume_mux_open();
>>>
>>
>>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-01-06 21:26 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-17 9:14 [PATCH] vl: initialize displays _after_ exiting preconfiguration Paolo Bonzini
2021-01-06 17:06 ` BALATON Zoltan
2021-01-06 19:58 ` Paolo Bonzini
2021-01-06 21:24 ` BALATON Zoltan
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.