* [PATCH] nbd: Consistently use request pointer in debug messages.
@ 2018-06-04 16:40 kvigor
2018-06-05 13:13 ` Josef Bacik
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: kvigor @ 2018-06-04 16:40 UTC (permalink / raw)
To: linux-block; +Cc: josef, axboe, Kevin Vigor
From: Kevin Vigor <kvigor@fb.com>
Existing dev_dbg messages sometimes identify request using request
pointer, sometimes using nbd_cmd pointer. This makes it hard to
follow request flow. Consistently use request pointer instead.
---
drivers/block/nbd.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c
index 3ed1ef8..b5afa11 100644
--- a/drivers/block/nbd.c
+++ b/drivers/block/nbd.c
@@ -275,7 +275,7 @@ static void nbd_complete_rq(struct request *req)
{
struct nbd_cmd *cmd = blk_mq_rq_to_pdu(req);
- dev_dbg(nbd_to_dev(cmd->nbd), "request %p: %s\n", cmd,
+ dev_dbg(nbd_to_dev(cmd->nbd), "request %p: %s\n", req,
cmd->status ? "failed" : "done");
blk_mq_end_request(req, cmd->status);
@@ -482,7 +482,7 @@ static int nbd_send_cmd(struct nbd_device *nbd, struct nbd_cmd *cmd, int index)
memcpy(request.handle, &tag, sizeof(tag));
dev_dbg(nbd_to_dev(nbd), "request %p: sending control (%s@%llu,%uB)\n",
- cmd, nbdcmd_to_ascii(type),
+ req, nbdcmd_to_ascii(type),
(unsigned long long)blk_rq_pos(req) << 9, blk_rq_bytes(req));
result = sock_xmit(nbd, index, 1, &from,
(type == NBD_CMD_WRITE) ? MSG_MORE : 0, &sent);
@@ -518,7 +518,7 @@ static int nbd_send_cmd(struct nbd_device *nbd, struct nbd_cmd *cmd, int index)
int flags = is_last ? 0 : MSG_MORE;
dev_dbg(nbd_to_dev(nbd), "request %p: sending %d bytes data\n",
- cmd, bvec.bv_len);
+ req, bvec.bv_len);
iov_iter_bvec(&from, ITER_BVEC | WRITE,
&bvec, 1, bvec.bv_len);
if (skip) {
@@ -610,7 +610,7 @@ static struct nbd_cmd *nbd_read_stat(struct nbd_device *nbd, int index)
return cmd;
}
- dev_dbg(nbd_to_dev(nbd), "request %p: got reply\n", cmd);
+ dev_dbg(nbd_to_dev(nbd), "request %p: got reply\n", req);
if (rq_data_dir(req) != WRITE) {
struct req_iterator iter;
struct bio_vec bvec;
@@ -637,7 +637,7 @@ static struct nbd_cmd *nbd_read_stat(struct nbd_device *nbd, int index)
return ERR_PTR(-EIO);
}
dev_dbg(nbd_to_dev(nbd), "request %p: got %d bytes data\n",
- cmd, bvec.bv_len);
+ req, bvec.bv_len);
}
} else {
/* See the comment in nbd_queue_rq. */
--
2.7.4
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] nbd: Consistently use request pointer in debug messages.
2018-06-04 16:40 [PATCH] nbd: Consistently use request pointer in debug messages kvigor
@ 2018-06-05 13:13 ` Josef Bacik
2018-06-05 14:23 ` Jens Axboe
2018-06-05 15:45 ` Jens Axboe
2 siblings, 0 replies; 7+ messages in thread
From: Josef Bacik @ 2018-06-05 13:13 UTC (permalink / raw)
To: kvigor; +Cc: linux-block, josef, axboe, Kevin Vigor
On Mon, Jun 04, 2018 at 10:40:12AM -0600, kvigor@gmail.com wrote:
> From: Kevin Vigor <kvigor@fb.com>
>
> Existing dev_dbg messages sometimes identify request using request
> pointer, sometimes using nbd_cmd pointer. This makes it hard to
> follow request flow. Consistently use request pointer instead.
Reviewed-by: Josef Bacik <jbacik@toxicpanda.com>
Thanks,
Josef
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] nbd: Consistently use request pointer in debug messages.
2018-06-04 16:40 [PATCH] nbd: Consistently use request pointer in debug messages kvigor
2018-06-05 13:13 ` Josef Bacik
@ 2018-06-05 14:23 ` Jens Axboe
2018-06-05 14:30 ` Josef Bacik
2018-06-05 15:45 ` Jens Axboe
2 siblings, 1 reply; 7+ messages in thread
From: Jens Axboe @ 2018-06-05 14:23 UTC (permalink / raw)
To: kvigor, linux-block; +Cc: josef, Kevin Vigor
On 6/4/18 10:40 AM, kvigor@gmail.com wrote:
> From: Kevin Vigor <kvigor@fb.com>
>
> Existing dev_dbg messages sometimes identify request using request
> pointer, sometimes using nbd_cmd pointer. This makes it hard to
> follow request flow. Consistently use request pointer instead.
You're missing the Signed-off-by.
--
Jens Axboe
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] nbd: Consistently use request pointer in debug messages.
2018-06-05 14:23 ` Jens Axboe
@ 2018-06-05 14:30 ` Josef Bacik
2018-06-05 14:32 ` Jens Axboe
0 siblings, 1 reply; 7+ messages in thread
From: Josef Bacik @ 2018-06-05 14:30 UTC (permalink / raw)
To: Jens Axboe; +Cc: kvigor, linux-block, josef, Kevin Vigor
On Tue, Jun 05, 2018 at 08:23:06AM -0600, Jens Axboe wrote:
> On 6/4/18 10:40 AM, kvigor@gmail.com wrote:
> > From: Kevin Vigor <kvigor@fb.com>
> >
> > Existing dev_dbg messages sometimes identify request using request
> > pointer, sometimes using nbd_cmd pointer. This makes it hard to
> > follow request flow. Consistently use request pointer instead.
>
> You're missing the Signed-off-by.
>
Blah sorry, still a little foggy,
Signed-off-by: Josef Bacik <josef@toxicpanda.com>
Thanks,
Josef
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] nbd: Consistently use request pointer in debug messages.
2018-06-05 14:30 ` Josef Bacik
@ 2018-06-05 14:32 ` Jens Axboe
2018-06-05 15:42 ` Kevin Vigor
0 siblings, 1 reply; 7+ messages in thread
From: Jens Axboe @ 2018-06-05 14:32 UTC (permalink / raw)
To: Josef Bacik; +Cc: kvigor, linux-block, Kevin Vigor
On 6/5/18 8:30 AM, Josef Bacik wrote:
> On Tue, Jun 05, 2018 at 08:23:06AM -0600, Jens Axboe wrote:
>> On 6/4/18 10:40 AM, kvigor@gmail.com wrote:
>>> From: Kevin Vigor <kvigor@fb.com>
>>>
>>> Existing dev_dbg messages sometimes identify request using request
>>> pointer, sometimes using nbd_cmd pointer. This makes it hard to
>>> follow request flow. Consistently use request pointer instead.
>>
>> You're missing the Signed-off-by.
>>
>
> Blah sorry, still a little foggy,
>
> Signed-off-by: Josef Bacik <josef@toxicpanda.com>
Not you, Kevin :-)
--
Jens Axboe
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] nbd: Consistently use request pointer in debug messages.
2018-06-05 14:32 ` Jens Axboe
@ 2018-06-05 15:42 ` Kevin Vigor
0 siblings, 0 replies; 7+ messages in thread
From: Kevin Vigor @ 2018-06-05 15:42 UTC (permalink / raw)
To: Jens Axboe; +Cc: Josef Bacik, linux-block, Kevin Vigor
[-- Attachment #1: Type: text/plain, Size: 761 bytes --]
Sorry, also foggy from Josef's exploits.
Signed-off-by: Kevin Vigor <kvigor@fb.com>
On Tue, Jun 5, 2018 at 8:32 AM Jens Axboe <axboe@kernel.dk> wrote:
> On 6/5/18 8:30 AM, Josef Bacik wrote:
> > On Tue, Jun 05, 2018 at 08:23:06AM -0600, Jens Axboe wrote:
> >> On 6/4/18 10:40 AM, kvigor@gmail.com wrote:
> >>> From: Kevin Vigor <kvigor@fb.com>
> >>>
> >>> Existing dev_dbg messages sometimes identify request using request
> >>> pointer, sometimes using nbd_cmd pointer. This makes it hard to
> >>> follow request flow. Consistently use request pointer instead.
> >>
> >> You're missing the Signed-off-by.
> >>
> >
> > Blah sorry, still a little foggy,
> >
> > Signed-off-by: Josef Bacik <josef@toxicpanda.com>
>
> Not you, Kevin :-)
>
> --
> Jens Axboe
>
>
[-- Attachment #2: Type: text/html, Size: 1399 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] nbd: Consistently use request pointer in debug messages.
2018-06-04 16:40 [PATCH] nbd: Consistently use request pointer in debug messages kvigor
2018-06-05 13:13 ` Josef Bacik
2018-06-05 14:23 ` Jens Axboe
@ 2018-06-05 15:45 ` Jens Axboe
2 siblings, 0 replies; 7+ messages in thread
From: Jens Axboe @ 2018-06-05 15:45 UTC (permalink / raw)
To: kvigor, linux-block; +Cc: josef, Kevin Vigor
On 6/4/18 10:40 AM, kvigor@gmail.com wrote:
> From: Kevin Vigor <kvigor@fb.com>
>
> Existing dev_dbg messages sometimes identify request using request
> pointer, sometimes using nbd_cmd pointer. This makes it hard to
> follow request flow. Consistently use request pointer instead.
Applied, with the SOB added.
--
Jens Axboe
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2018-06-05 15:45 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-06-04 16:40 [PATCH] nbd: Consistently use request pointer in debug messages kvigor
2018-06-05 13:13 ` Josef Bacik
2018-06-05 14:23 ` Jens Axboe
2018-06-05 14:30 ` Josef Bacik
2018-06-05 14:32 ` Jens Axboe
2018-06-05 15:42 ` Kevin Vigor
2018-06-05 15:45 ` Jens Axboe
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.