From: Robin Murphy <robin.murphy@arm.com>
To: Tom Murphy <tmurphy@arista.com>, Christoph Hellwig <hch@infradead.org>
Cc: iommu@lists.linux-foundation.org,
Heiko Stuebner <heiko@sntech.de>,
Will Deacon <will.deacon@arm.com>,
David Brown <david.brown@linaro.org>,
linux-samsung-soc@vger.kernel.org,
Dmitry Safonov <dima@arista.com>,
Krzysztof Kozlowski <krzk@kernel.org>,
linux-rockchip@lists.infradead.org, Kukjin Kim <kgene@kernel.org>,
Andy Gross <andy.gross@linaro.org>,
Marc Zyngier <marc.zyngier@arm.com>,
linux-arm-msm@vger.kernel.org,
linux-mediatek@lists.infradead.org,
Matthias Brugger <matthias.bgg@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Tom Murphy <murphyt7@tcd.ie>
Subject: Re: [PATCH 3/9] iommu/dma-iommu: Add iommu_dma_copy_reserved_iova, iommu_dma_apply_resv_region to the dma-iommu api
Date: Tue, 16 Apr 2019 14:37:39 +0100 [thread overview]
Message-ID: <bc3cc59a-ea12-c82a-87a0-779a3418125f@arm.com> (raw)
In-Reply-To: <CAPL0++7Z=EMpYOvUn8yvcRqRT5iwJMD8zLhmFr4uFbH7W3WqXQ@mail.gmail.com>
On 16/04/2019 14:22, Tom Murphy wrote:
> I hoped this could be an exception, it's easier to grok without the
> line break and isn't crazy long. Because you mentioned it I'll fix it.
Frankly this patch is hard to justify anyway - iommu-dma already has its
own reserved region handling, and there should be no need for external
callers to be poking into the innards provided the IOMMU driver reports
the correct reserved regions in the first place.
If the iommu-dma abstraction is not quite sufficient to actually convert
amd-iommu to use it properly, then we should improve the abstraction,
rather than just punching holes in it to merely poke renamed parts of
the existing amd-iommu logic into.
Robin.
> On Mon, Apr 15, 2019 at 7:31 AM Christoph Hellwig <hch@infradead.org> wrote:
>>
>> On Thu, Apr 11, 2019 at 07:47:32PM +0100, Tom Murphy via iommu wrote:
>>> +
>>> + WARN_ON_ONCE(iommu_dma_reserve_iova(domain, region->start, end) == NULL);
>>
>> Overly long line..
WARNING: multiple messages have this Message-ID (diff)
From: Robin Murphy <robin.murphy@arm.com>
To: Tom Murphy <tmurphy@arista.com>, Christoph Hellwig <hch@infradead.org>
Cc: linux-samsung-soc@vger.kernel.org,
Heiko Stuebner <heiko@sntech.de>,
Dmitry Safonov <dima@arista.com>,
Marc Zyngier <marc.zyngier@arm.com>,
linux-arm-msm@vger.kernel.org, Will Deacon <will.deacon@arm.com>,
linux-kernel@vger.kernel.org,
Krzysztof Kozlowski <krzk@kernel.org>,
David Brown <david.brown@linaro.org>,
iommu@lists.linux-foundation.org, Kukjin Kim <kgene@kernel.org>,
linux-mediatek@lists.infradead.org, Tom Murphy <murphyt7@tcd.ie>,
Andy Gross <andy.gross@linaro.org>,
linux-rockchip@lists.infradead.org,
Thomas Gleixner <tglx@linutronix.de>,
linux-arm-kernel@lists.infradead.org,
Matthias Brugger <matthias.bgg@gmail.com>
Subject: Re: [PATCH 3/9] iommu/dma-iommu: Add iommu_dma_copy_reserved_iova, iommu_dma_apply_resv_region to the dma-iommu api
Date: Tue, 16 Apr 2019 14:37:39 +0100 [thread overview]
Message-ID: <bc3cc59a-ea12-c82a-87a0-779a3418125f@arm.com> (raw)
Message-ID: <20190416133739.8GowdzEXvLQLIhAOEB0y3p28kgxcN8cvvkLIkT0QRPo@z> (raw)
In-Reply-To: <CAPL0++7Z=EMpYOvUn8yvcRqRT5iwJMD8zLhmFr4uFbH7W3WqXQ@mail.gmail.com>
On 16/04/2019 14:22, Tom Murphy wrote:
> I hoped this could be an exception, it's easier to grok without the
> line break and isn't crazy long. Because you mentioned it I'll fix it.
Frankly this patch is hard to justify anyway - iommu-dma already has its
own reserved region handling, and there should be no need for external
callers to be poking into the innards provided the IOMMU driver reports
the correct reserved regions in the first place.
If the iommu-dma abstraction is not quite sufficient to actually convert
amd-iommu to use it properly, then we should improve the abstraction,
rather than just punching holes in it to merely poke renamed parts of
the existing amd-iommu logic into.
Robin.
> On Mon, Apr 15, 2019 at 7:31 AM Christoph Hellwig <hch@infradead.org> wrote:
>>
>> On Thu, Apr 11, 2019 at 07:47:32PM +0100, Tom Murphy via iommu wrote:
>>> +
>>> + WARN_ON_ONCE(iommu_dma_reserve_iova(domain, region->start, end) == NULL);
>>
>> Overly long line..
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
WARNING: multiple messages have this Message-ID (diff)
From: Robin Murphy <robin.murphy@arm.com>
To: Tom Murphy <tmurphy@arista.com>, Christoph Hellwig <hch@infradead.org>
Cc: linux-samsung-soc@vger.kernel.org,
Heiko Stuebner <heiko@sntech.de>,
Dmitry Safonov <dima@arista.com>,
Marc Zyngier <marc.zyngier@arm.com>,
linux-arm-msm@vger.kernel.org, Will Deacon <will.deacon@arm.com>,
linux-kernel@vger.kernel.org,
Krzysztof Kozlowski <krzk@kernel.org>,
David Brown <david.brown@linaro.org>,
iommu@lists.linux-foundation.org, Kukjin Kim <kgene@kernel.org>,
linux-mediatek@lists.infradead.org, Tom Murphy <murphyt7@tcd.ie>,
Andy Gross <andy.gross@linaro.org>,
linux-rockchip@lists.infradead.org,
Thomas Gleixner <tglx@linutronix.de>,
linux-arm-kernel@lists.infradead.org,
Matthias Brugger <matthias.bgg@gmail.com>
Subject: Re: [PATCH 3/9] iommu/dma-iommu: Add iommu_dma_copy_reserved_iova, iommu_dma_apply_resv_region to the dma-iommu api
Date: Tue, 16 Apr 2019 14:37:39 +0100 [thread overview]
Message-ID: <bc3cc59a-ea12-c82a-87a0-779a3418125f@arm.com> (raw)
In-Reply-To: <CAPL0++7Z=EMpYOvUn8yvcRqRT5iwJMD8zLhmFr4uFbH7W3WqXQ@mail.gmail.com>
On 16/04/2019 14:22, Tom Murphy wrote:
> I hoped this could be an exception, it's easier to grok without the
> line break and isn't crazy long. Because you mentioned it I'll fix it.
Frankly this patch is hard to justify anyway - iommu-dma already has its
own reserved region handling, and there should be no need for external
callers to be poking into the innards provided the IOMMU driver reports
the correct reserved regions in the first place.
If the iommu-dma abstraction is not quite sufficient to actually convert
amd-iommu to use it properly, then we should improve the abstraction,
rather than just punching holes in it to merely poke renamed parts of
the existing amd-iommu logic into.
Robin.
> On Mon, Apr 15, 2019 at 7:31 AM Christoph Hellwig <hch@infradead.org> wrote:
>>
>> On Thu, Apr 11, 2019 at 07:47:32PM +0100, Tom Murphy via iommu wrote:
>>> +
>>> + WARN_ON_ONCE(iommu_dma_reserve_iova(domain, region->start, end) == NULL);
>>
>> Overly long line..
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-04-16 13:37 UTC|newest]
Thread overview: 89+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-11 18:47 [PATCH 0/9] iommu/amd: Convert the AMD iommu driver to the dma-iommu api Tom Murphy
2019-04-11 18:47 ` Tom Murphy
2019-04-11 18:47 ` Tom Murphy via iommu
2019-04-11 18:47 ` Tom Murphy
2019-04-11 18:47 ` [PATCH 1/9] iommu/dma-iommu: Add iommu_map_atomic Tom Murphy
2019-04-11 18:47 ` Tom Murphy
2019-04-11 18:47 ` Tom Murphy via iommu
2019-04-11 18:47 ` Tom Murphy
[not found] ` <20190411184741.27540-2-tmurphy-nzgTgzXrdUbQT0dZR+AlfA@public.gmane.org>
2019-04-15 6:30 ` Christoph Hellwig
2019-04-15 6:30 ` Christoph Hellwig
2019-04-15 6:30 ` Christoph Hellwig
2019-04-15 6:30 ` Christoph Hellwig
2019-04-11 18:47 ` [PATCH 2/9] iommu/dma-iommu: Add function to flush any cached not present IOTLB entries Tom Murphy
2019-04-11 18:47 ` Tom Murphy
2019-04-11 18:47 ` Tom Murphy via iommu
2019-04-11 18:47 ` Tom Murphy
2019-04-16 14:00 ` Robin Murphy
2019-04-16 14:00 ` Robin Murphy
2019-04-16 14:00 ` Robin Murphy
[not found] ` <82ce70dc-b370-3bb0-bce8-2d32db4d6a0d-5wv7dgnIgG8@public.gmane.org>
2019-04-16 16:40 ` Tom Murphy via iommu
2019-04-16 16:40 ` Tom Murphy
2019-04-16 16:40 ` Tom Murphy via iommu
2019-04-16 16:40 ` Tom Murphy
2019-04-11 18:47 ` [PATCH 3/9] iommu/dma-iommu: Add iommu_dma_copy_reserved_iova, iommu_dma_apply_resv_region to the dma-iommu api Tom Murphy
2019-04-11 18:47 ` Tom Murphy
2019-04-11 18:47 ` Tom Murphy via iommu
2019-04-11 18:47 ` Tom Murphy
[not found] ` <20190411184741.27540-4-tmurphy-nzgTgzXrdUbQT0dZR+AlfA@public.gmane.org>
2019-04-15 6:31 ` Christoph Hellwig
2019-04-15 6:31 ` Christoph Hellwig
2019-04-15 6:31 ` Christoph Hellwig
2019-04-15 6:31 ` Christoph Hellwig
2019-04-16 13:22 ` Tom Murphy
2019-04-16 13:22 ` Tom Murphy
2019-04-16 13:22 ` Tom Murphy via iommu
2019-04-16 13:37 ` Robin Murphy [this message]
2019-04-16 13:37 ` Robin Murphy
2019-04-16 13:37 ` Robin Murphy
2019-04-11 18:47 ` [PATCH 4/9] iommu/dma-iommu: Add iommu_dma_map_page_coherent Tom Murphy
2019-04-11 18:47 ` Tom Murphy
2019-04-11 18:47 ` Tom Murphy via iommu
2019-04-11 18:47 ` Tom Murphy
2019-04-15 6:33 ` Christoph Hellwig
2019-04-15 6:33 ` Christoph Hellwig
2019-04-15 6:33 ` Christoph Hellwig
2019-04-11 18:47 ` [PATCH 5/9] iommu/amd: Implement .flush_np_cache Tom Murphy
2019-04-11 18:47 ` Tom Murphy
2019-04-11 18:47 ` Tom Murphy via iommu
2019-04-11 18:47 ` Tom Murphy
[not found] ` <20190411184741.27540-6-tmurphy-nzgTgzXrdUbQT0dZR+AlfA@public.gmane.org>
2019-04-15 6:33 ` Christoph Hellwig
2019-04-15 6:33 ` Christoph Hellwig
2019-04-15 6:33 ` Christoph Hellwig
2019-04-15 6:33 ` Christoph Hellwig
2019-04-15 18:18 ` Tom Murphy
2019-04-15 18:18 ` Tom Murphy
2019-04-15 18:18 ` Tom Murphy via iommu
2019-04-11 18:47 ` [PATCH 6/9] iommu/amd: Implement map_atomic Tom Murphy
2019-04-11 18:47 ` Tom Murphy
2019-04-11 18:47 ` Tom Murphy via iommu
2019-04-11 18:47 ` Tom Murphy
2019-04-16 14:13 ` Robin Murphy
2019-04-16 14:13 ` Robin Murphy
2019-04-16 14:13 ` Robin Murphy
2019-04-11 18:47 ` [PATCH 7/9] iommu/amd: Use the dma-iommu api Tom Murphy
2019-04-11 18:47 ` Tom Murphy
2019-04-11 18:47 ` Tom Murphy via iommu
2019-04-11 18:47 ` Tom Murphy
2019-04-11 18:47 ` [PATCH 8/9] iommu/amd: Clean up unused functions Tom Murphy
2019-04-11 18:47 ` Tom Murphy
2019-04-11 18:47 ` Tom Murphy via iommu
2019-04-11 18:47 ` Tom Murphy
[not found] ` <20190411184741.27540-9-tmurphy-nzgTgzXrdUbQT0dZR+AlfA@public.gmane.org>
2019-04-15 6:22 ` Christoph Hellwig
2019-04-15 6:22 ` Christoph Hellwig
2019-04-15 6:22 ` Christoph Hellwig
2019-04-15 6:22 ` Christoph Hellwig
2019-04-11 18:47 ` [PATCH 9/9] iommu/amd: Add allocated domain to global list earlier Tom Murphy
2019-04-11 18:47 ` Tom Murphy
2019-04-11 18:47 ` Tom Murphy via iommu
2019-04-11 18:47 ` Tom Murphy
[not found] ` <20190411184741.27540-10-tmurphy-nzgTgzXrdUbQT0dZR+AlfA@public.gmane.org>
2019-04-15 6:23 ` Christoph Hellwig
2019-04-15 6:23 ` Christoph Hellwig
2019-04-15 6:23 ` Christoph Hellwig
2019-04-15 6:23 ` Christoph Hellwig
2019-04-15 18:06 ` Tom Murphy
2019-04-15 18:06 ` Tom Murphy
2019-04-15 18:06 ` Tom Murphy via iommu
[not found] ` <20190411184741.27540-1-tmurphy-nzgTgzXrdUbQT0dZR+AlfA@public.gmane.org>
2019-04-15 6:18 ` [PATCH 0/9] iommu/amd: Convert the AMD iommu driver to the dma-iommu api Christoph Hellwig
2019-04-15 6:18 ` Christoph Hellwig
2019-04-15 6:18 ` Christoph Hellwig
2019-04-15 6:18 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bc3cc59a-ea12-c82a-87a0-779a3418125f@arm.com \
--to=robin.murphy@arm.com \
--cc=andy.gross@linaro.org \
--cc=david.brown@linaro.org \
--cc=dima@arista.com \
--cc=hch@infradead.org \
--cc=heiko@sntech.de \
--cc=iommu@lists.linux-foundation.org \
--cc=kgene@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=murphyt7@tcd.ie \
--cc=tglx@linutronix.de \
--cc=tmurphy@arista.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.