* [PATCH] gpio: Add support for DM GPIO for Kirkwood
@ 2020-11-27 21:56 Harm Berntsen
2020-11-28 10:08 ` Stefan Roese
2020-11-29 10:08 ` [PATCH v2] " Harm Berntsen
0 siblings, 2 replies; 6+ messages in thread
From: Harm Berntsen @ 2020-11-27 21:56 UTC (permalink / raw)
To: u-boot
The Armada driver also works on Nedap's ax8008 Kirkwood board with a
Marvell 88F6180 CPU. The original commit of that driver,
704d9a645e1790e568abf43c5eff2de0d7b135ed also mentions that this driver
would be suitable for Kirkwood.
This driver does not completely replace the Kirkwood specific driver as
there are still dependencies on that driver(i.e. soft_i2c.c. in our
case).
Signed-off-by: Harm Berntsen <harm.berntsen@nedap.com>
CC: Stefan Roese <sr@denx.de>
---
drivers/gpio/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
index 202fcc6f47..1f41bd3d55 100644
--- a/drivers/gpio/Kconfig
+++ b/drivers/gpio/Kconfig
@@ -374,7 +374,7 @@ config SIFIVE_GPIO
config MVEBU_GPIO
bool "Marvell MVEBU GPIO driver"
- depends on DM_GPIO && ARCH_MVEBU
+ depends on DM_GPIO && (ARCH_MVEBU || ARCH_KIRKWOOD)
default y
help
Say yes here to support Marvell MVEBU (Armada XP/38x) GPIOs.
--
2.29.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] gpio: Add support for DM GPIO for Kirkwood
2020-11-27 21:56 [PATCH] gpio: Add support for DM GPIO for Kirkwood Harm Berntsen
@ 2020-11-28 10:08 ` Stefan Roese
2020-11-29 10:01 ` Harm Berntsen
2020-11-29 10:08 ` [PATCH v2] " Harm Berntsen
1 sibling, 1 reply; 6+ messages in thread
From: Stefan Roese @ 2020-11-28 10:08 UTC (permalink / raw)
To: u-boot
Hi Harm,
On 27.11.20 22:56, Harm Berntsen wrote:
> The Armada driver also works on Nedap's ax8008 Kirkwood board with a
> Marvell 88F6180 CPU. The original commit of that driver,
> 704d9a645e1790e568abf43c5eff2de0d7b135ed also mentions that this driver
> would be suitable for Kirkwood.
Well, this was really a long time ago. ;)
> This driver does not completely replace the Kirkwood specific driver as
> there are still dependencies on that driver(i.e. soft_i2c.c. in our
> case).
So what work needs to be doney to completely replace the old legacy
kw_gpio driver and remove it completely? Could you perhaps tackle it
as well?
Other than that:
Reviewed-by: Stefan Roese <sr@denx.de>
Thanks,
Stefan
> Signed-off-by: Harm Berntsen <harm.berntsen@nedap.com>
> CC: Stefan Roese <sr@denx.de>
> ---
>
> drivers/gpio/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
> index 202fcc6f47..1f41bd3d55 100644
> --- a/drivers/gpio/Kconfig
> +++ b/drivers/gpio/Kconfig
> @@ -374,7 +374,7 @@ config SIFIVE_GPIO
>
> config MVEBU_GPIO
> bool "Marvell MVEBU GPIO driver"
> - depends on DM_GPIO && ARCH_MVEBU
> + depends on DM_GPIO && (ARCH_MVEBU || ARCH_KIRKWOOD)
> default y
> help
> Say yes here to support Marvell MVEBU (Armada XP/38x) GPIOs.
>
Viele Gr??e,
Stefan
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr at denx.de
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] gpio: Add support for DM GPIO for Kirkwood
2020-11-28 10:08 ` Stefan Roese
@ 2020-11-29 10:01 ` Harm Berntsen
2020-11-30 9:00 ` Stefan Roese
0 siblings, 1 reply; 6+ messages in thread
From: Harm Berntsen @ 2020-11-29 10:01 UTC (permalink / raw)
To: u-boot
Hi Stefan,
Thanks for your review.
I've looked into the usage of the kw_gpio driver. The soft_i2c part I
mentioned in the commit appeared to be specific to my board
configuration. I've replaced the usage of that driver with the DM based
i2c-gpio driver there.
All the usage of the kw_gpio functions is in board-specific code. I
think the kw_gpio driver can be deprecated and board maintainers could
update their code.
Kind regards,
Harm
-----Original Message-----
From: Stefan Roese <sr@denx.de>
To: Harm Berntsen <harm.berntsen@nedap.com>, u-boot at lists.denx.de
<u-boot@lists.denx.de>
Subject: Re: [PATCH] gpio: Add support for DM GPIO for Kirkwood
Date: Sat, 28 Nov 2020 11:08:43 +0100
Hi Harm,
On 27.11.20 22:56, Harm Berntsen wrote:
> The Armada driver also works on Nedap's ax8008 Kirkwood board with a
> Marvell 88F6180 CPU. The original commit of that driver,
> 704d9a645e1790e568abf43c5eff2de0d7b135ed also mentions that this
> driver
> would be suitable for Kirkwood.
Well, this was really a long time ago. ;)
> This driver does not completely replace the Kirkwood specific driver
> as
> there are still dependencies on that driver(i.e. soft_i2c.c. in our
> case).
So what work needs to be doney to completely replace the old legacy
kw_gpio driver and remove it completely? Could you perhaps tackle it
as well?
Other than that:
Reviewed-by: Stefan Roese <sr@denx.de>
Thanks,
Stefan
> Signed-off-by: Harm Berntsen <harm.berntsen@nedap.com>
> CC: Stefan Roese <sr@denx.de>
> ---
>
> ? drivers/gpio/Kconfig | 2 +-
> ? 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
> index 202fcc6f47..1f41bd3d55 100644
> --- a/drivers/gpio/Kconfig
> +++ b/drivers/gpio/Kconfig
> @@ -374,7 +374,7 @@ config SIFIVE_GPIO
> ?
> ? config MVEBU_GPIO
> ????????bool "Marvell MVEBU GPIO driver"
> -???????depends on DM_GPIO && ARCH_MVEBU
> +???????depends on DM_GPIO && (ARCH_MVEBU || ARCH_KIRKWOOD)
> ????????default y
> ????????help
> ????????? Say yes here to support Marvell MVEBU (Armada XP/38x)
> GPIOs.
>
Viele Gr??e,
Stefan
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2] gpio: Add support for DM GPIO for Kirkwood
2020-11-27 21:56 [PATCH] gpio: Add support for DM GPIO for Kirkwood Harm Berntsen
2020-11-28 10:08 ` Stefan Roese
@ 2020-11-29 10:08 ` Harm Berntsen
2020-11-30 9:01 ` Stefan Roese
1 sibling, 1 reply; 6+ messages in thread
From: Harm Berntsen @ 2020-11-29 10:08 UTC (permalink / raw)
To: u-boot
The Armada driver also works on Nedap's custom Kirkwood board with a
Marvell 88F6180 CPU. The original commit of that driver,
commit 704d9a645e17 ("gpio: Add DM GPIO driver for Marvell MVEBU"),
also mentions that this driver would be suitable for Kirkwood. This
does not completely replace the Kirkwood specific driver as there
are still boards depending on that driver.
Signed-off-by: Harm Berntsen <harm.berntsen@nedap.com>
CC: Stefan Roese <sr@denx.de>,
---
Canges for v2:
- Made commit message more clear
drivers/gpio/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
index 202fcc6f47..1f41bd3d55 100644
--- a/drivers/gpio/Kconfig
+++ b/drivers/gpio/Kconfig
@@ -374,7 +374,7 @@ config SIFIVE_GPIO
config MVEBU_GPIO
bool "Marvell MVEBU GPIO driver"
- depends on DM_GPIO && ARCH_MVEBU
+ depends on DM_GPIO && (ARCH_MVEBU || ARCH_KIRKWOOD)
default y
help
Say yes here to support Marvell MVEBU (Armada XP/38x) GPIOs.
--
2.29.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] gpio: Add support for DM GPIO for Kirkwood
2020-11-29 10:01 ` Harm Berntsen
@ 2020-11-30 9:00 ` Stefan Roese
0 siblings, 0 replies; 6+ messages in thread
From: Stefan Roese @ 2020-11-30 9:00 UTC (permalink / raw)
To: u-boot
Hi Harm,
On 29.11.20 11:01, Harm Berntsen wrote:
> Hi Stefan,
>
> Thanks for your review.
>
> I've looked into the usage of the kw_gpio driver. The soft_i2c part I
> mentioned in the commit appeared to be specific to my board
> configuration. I've replaced the usage of that driver with the DM based
> i2c-gpio driver there.
Good.
> All the usage of the kw_gpio functions is in board-specific code. I
> think the kw_gpio driver can be deprecated and board maintainers could
> update their code.
Yes, that would be great. We probably need some way to deprecate this
driver, so that current users will be notified top switch to the common
MVEBU DM GPIO driver when compiling for these boards.
Thanks,
Stefan
> Kind regards,
> Harm
>
> -----Original Message-----
> From: Stefan Roese <sr@denx.de>
> To: Harm Berntsen <harm.berntsen@nedap.com>, u-boot at lists.denx.de
> <u-boot@lists.denx.de>
> Subject: Re: [PATCH] gpio: Add support for DM GPIO for Kirkwood
> Date: Sat, 28 Nov 2020 11:08:43 +0100
>
> Hi Harm,
>
> On 27.11.20 22:56, Harm Berntsen wrote:
>> The Armada driver also works on Nedap's ax8008 Kirkwood board with a
>> Marvell 88F6180 CPU. The original commit of that driver,
>> 704d9a645e1790e568abf43c5eff2de0d7b135ed also mentions that this
>> driver
>> would be suitable for Kirkwood.
>
> Well, this was really a long time ago. ;)
>
>> This driver does not completely replace the Kirkwood specific driver
>> as
>> there are still dependencies on that driver(i.e. soft_i2c.c. in our
>> case).
>
> So what work needs to be doney to completely replace the old legacy
> kw_gpio driver and remove it completely? Could you perhaps tackle it
> as well?
>
> Other than that:
>
> Reviewed-by: Stefan Roese <sr@denx.de>
>
> Thanks,
> Stefan
>
>> Signed-off-by: Harm Berntsen <harm.berntsen@nedap.com>
>> CC: Stefan Roese <sr@denx.de>
>> ---
>>
>> ? drivers/gpio/Kconfig | 2 +-
>> ? 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
>> index 202fcc6f47..1f41bd3d55 100644
>> --- a/drivers/gpio/Kconfig
>> +++ b/drivers/gpio/Kconfig
>> @@ -374,7 +374,7 @@ config SIFIVE_GPIO
>>
>> ? config MVEBU_GPIO
>> ????????bool "Marvell MVEBU GPIO driver"
>> -???????depends on DM_GPIO && ARCH_MVEBU
>> +???????depends on DM_GPIO && (ARCH_MVEBU || ARCH_KIRKWOOD)
>> ????????default y
>> ????????help
>> ????????? Say yes here to support Marvell MVEBU (Armada XP/38x)
>> GPIOs.
>>
>
>
> Viele Gr??e,
> Stefan
>
>
Viele Gr??e,
Stefan
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr at denx.de
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2] gpio: Add support for DM GPIO for Kirkwood
2020-11-29 10:08 ` [PATCH v2] " Harm Berntsen
@ 2020-11-30 9:01 ` Stefan Roese
0 siblings, 0 replies; 6+ messages in thread
From: Stefan Roese @ 2020-11-30 9:01 UTC (permalink / raw)
To: u-boot
On 29.11.20 11:08, Harm Berntsen wrote:
> The Armada driver also works on Nedap's custom Kirkwood board with a
> Marvell 88F6180 CPU. The original commit of that driver,
> commit 704d9a645e17 ("gpio: Add DM GPIO driver for Marvell MVEBU"),
> also mentions that this driver would be suitable for Kirkwood. This
> does not completely replace the Kirkwood specific driver as there
> are still boards depending on that driver.
>
> Signed-off-by: Harm Berntsen <harm.berntsen@nedap.com>
> CC: Stefan Roese <sr@denx.de>,
Reviewed-by: Stefan Roese <sr@denx.de>
Thanks,
Stefan
> ---
> Canges for v2:
> - Made commit message more clear
>
> drivers/gpio/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
> index 202fcc6f47..1f41bd3d55 100644
> --- a/drivers/gpio/Kconfig
> +++ b/drivers/gpio/Kconfig
> @@ -374,7 +374,7 @@ config SIFIVE_GPIO
>
> config MVEBU_GPIO
> bool "Marvell MVEBU GPIO driver"
> - depends on DM_GPIO && ARCH_MVEBU
> + depends on DM_GPIO && (ARCH_MVEBU || ARCH_KIRKWOOD)
> default y
> help
> Say yes here to support Marvell MVEBU (Armada XP/38x) GPIOs.
>
Viele Gr??e,
Stefan
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr at denx.de
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-11-30 9:01 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-27 21:56 [PATCH] gpio: Add support for DM GPIO for Kirkwood Harm Berntsen
2020-11-28 10:08 ` Stefan Roese
2020-11-29 10:01 ` Harm Berntsen
2020-11-30 9:00 ` Stefan Roese
2020-11-29 10:08 ` [PATCH v2] " Harm Berntsen
2020-11-30 9:01 ` Stefan Roese
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.