[PATCH] drm/amdgpu: no job timeout setting on compute queues

[PATCH] drm/amdgpu: no job timeout setting on compute queues

[Evan Quan]

Under some heavy computing test(dgemm) environment, it may takes
the asic over 50+ seconds to finish the dispatched single job
which will trigger the timeout. It's quite annoying although it
does not seem to bring any real problems.
As a quick workround, we choose to not enfoce the timeout
setting on compute queues.

Change-Id: I210011a90898617367e897a90e9f8fb2639281a3
Signed-off-by: Evan Quan <evan.quan@amd.com>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c
index 008e198..455a81e 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c
@@ -435,7 +435,9 @@ int amdgpu_fence_driver_init_ring(struct amdgpu_ring *ring,
 	if (ring->funcs->type != AMDGPU_RING_TYPE_KIQ) {
 		r = drm_sched_init(&ring->sched, &amdgpu_sched_ops,
 				   num_hw_submission, amdgpu_job_hang_limit,
-				   msecs_to_jiffies(amdgpu_lockup_timeout), ring->name);
+				   (ring->funcs->type == AMDGPU_RING_TYPE_COMPUTE) ?
+				   MAX_SCHEDULE_TIMEOUT : msecs_to_jiffies(amdgpu_lockup_timeout),
+				   ring->name);
 		if (r) {
 			DRM_ERROR("Failed to create scheduler on ring %s.\n",
 				  ring->name);
-- 
2.7.4

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Re: [PATCH] drm/amdgpu: no job timeout setting on compute queues

[Deucher, Alexander]

[-- Attachment #1.1: Type: text/plain, Size: 2059 bytes --]

Since GPU reset is not enabled yet anyway, a timeout will just print a message, can we just change amdgpu_lockup_timeout to MAX_SCHEDULE_TIMEOUT until we enable GPU reset?


Alex

________________________________
From: Evan Quan <evan.quan-5C7GfCeVMHo@public.gmane.org>
Sent: Friday, March 16, 2018 12:52:32 AM
To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Cc: Deucher, Alexander; Quan, Evan
Subject: [PATCH] drm/amdgpu: no job timeout setting on compute queues

Under some heavy computing test(dgemm) environment, it may takes
the asic over 50+ seconds to finish the dispatched single job
which will trigger the timeout. It's quite annoying although it
does not seem to bring any real problems.
As a quick workround, we choose to not enfoce the timeout
setting on compute queues.

Change-Id: I210011a90898617367e897a90e9f8fb2639281a3
Signed-off-by: Evan Quan <evan.quan-5C7GfCeVMHo@public.gmane.org>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c
index 008e198..455a81e 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c
@@ -435,7 +435,9 @@ int amdgpu_fence_driver_init_ring(struct amdgpu_ring *ring,
         if (ring->funcs->type != AMDGPU_RING_TYPE_KIQ) {
                 r = drm_sched_init(&ring->sched, &amdgpu_sched_ops,
                                    num_hw_submission, amdgpu_job_hang_limit,
-                                  msecs_to_jiffies(amdgpu_lockup_timeout), ring->name);
+                                  (ring->funcs->type == AMDGPU_RING_TYPE_COMPUTE) ?
+                                  MAX_SCHEDULE_TIMEOUT : msecs_to_jiffies(amdgpu_lockup_timeout),
+                                  ring->name);
                 if (r) {
                         DRM_ERROR("Failed to create scheduler on ring %s.\n",
                                   ring->name);
--
2.7.4


[-- Attachment #1.2: Type: text/html, Size: 4893 bytes --]

[-- Attachment #2: Type: text/plain, Size: 154 bytes --]

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Re: [PATCH] drm/amdgpu: no job timeout setting on compute queues

[Michel Dänzer]

On 2018-03-16 05:14 PM, Deucher, Alexander wrote:
> Since GPU reset is not enabled yet anyway, a timeout will just print a
> message, can we just change amdgpu_lockup_timeout to
> MAX_SCHEDULE_TIMEOUT until we enable GPU reset?

Wouldn't that be rather surprising for somebody who sets
amdgpu.gpu_recovery=1 ?


-- 
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Re: [PATCH] drm/amdgpu: no job timeout setting on compute queues

[Deucher, Alexander]

[-- Attachment #1.1: Type: text/plain, Size: 1060 bytes --]

How about something like this:

/* Disable timeout when GPU reset is disabled to avoid confusing timeout messages in the kernel log */

If (amdgpu_gpu_recovery == 0 || amdgpu_gpu_recovery == -1)

    amdgpu_lockup_timeout = MAX_SCHEDULE_TIMEOUT;


Alex

________________________________
From: Michel Dänzer <michel-otUistvHUpPR7s880joybQ@public.gmane.org>
Sent: Friday, March 16, 2018 12:25:03 PM
To: Deucher, Alexander; Quan, Evan
Cc: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Subject: Re: [PATCH] drm/amdgpu: no job timeout setting on compute queues

On 2018-03-16 05:14 PM, Deucher, Alexander wrote:
> Since GPU reset is not enabled yet anyway, a timeout will just print a
> message, can we just change amdgpu_lockup_timeout to
> MAX_SCHEDULE_TIMEOUT until we enable GPU reset?

Wouldn't that be rather surprising for somebody who sets
amdgpu.gpu_recovery=1 ?


--
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer

[-- Attachment #1.2: Type: text/html, Size: 3351 bytes --]

[-- Attachment #2: Type: text/plain, Size: 154 bytes --]

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

RE: [PATCH] drm/amdgpu: no job timeout setting on compute queues

[Quan, Evan]

[-- Attachment #1.1: Type: text/plain, Size: 1586 bytes --]

That's fine for me. Will update the patch accordingly.

Regards,
Evan
From: Deucher, Alexander
Sent: Saturday, March 17, 2018 1:17 AM
To: Michel Dänzer <michel-otUistvHUpPR7s880joybQ@public.gmane.org>; Quan, Evan <Evan.Quan-5C7GfCeVMHo@public.gmane.org>
Cc: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Subject: Re: [PATCH] drm/amdgpu: no job timeout setting on compute queues


How about something like this:

/* Disable timeout when GPU reset is disabled to avoid confusing timeout messages in the kernel log */

If (amdgpu_gpu_recovery == 0 || amdgpu_gpu_recovery == -1)

    amdgpu_lockup_timeout = MAX_SCHEDULE_TIMEOUT;



Alex

________________________________
From: Michel Dänzer <michel-otUistvHUpPR7s880joybQ@public.gmane.org<mailto:michel-otUistvHUpPR7s880joybQ@public.gmane.org>>
Sent: Friday, March 16, 2018 12:25:03 PM
To: Deucher, Alexander; Quan, Evan
Cc: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org<mailto:amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>
Subject: Re: [PATCH] drm/amdgpu: no job timeout setting on compute queues

On 2018-03-16 05:14 PM, Deucher, Alexander wrote:
> Since GPU reset is not enabled yet anyway, a timeout will just print a
> message, can we just change amdgpu_lockup_timeout to
> MAX_SCHEDULE_TIMEOUT until we enable GPU reset?

Wouldn't that be rather surprising for somebody who sets
amdgpu.gpu_recovery=1 ?


--
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer

[-- Attachment #1.2: Type: text/html, Size: 5355 bytes --]

[-- Attachment #2: Type: text/plain, Size: 154 bytes --]

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

RE: [PATCH] drm/amdgpu: no job timeout setting on compute queues

[Liu, Monk]

[-- Attachment #1.1: Type: text/plain, Size: 1855 bytes --]

Please don’t do it for SR-IOV

/Monk

From: amd-gfx [mailto:amd-gfx-bounces@lists.freedesktop.org] On Behalf Of Quan, Evan
Sent: 2018年3月19日 9:47
To: Deucher, Alexander <Alexander.Deucher@amd.com>; Michel Dänzer <michel@daenzer.net>
Cc: amd-gfx@lists.freedesktop.org
Subject: RE: [PATCH] drm/amdgpu: no job timeout setting on compute queues

That’s fine for me. Will update the patch accordingly.

Regards,
Evan
From: Deucher, Alexander
Sent: Saturday, March 17, 2018 1:17 AM
To: Michel Dänzer <michel@daenzer.net<mailto:michel@daenzer.net>>; Quan, Evan <Evan.Quan@amd.com<mailto:Evan.Quan@amd.com>>
Cc: amd-gfx@lists.freedesktop.org<mailto:amd-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] drm/amdgpu: no job timeout setting on compute queues


How about something like this:

/* Disable timeout when GPU reset is disabled to avoid confusing timeout messages in the kernel log */

If (amdgpu_gpu_recovery == 0 || amdgpu_gpu_recovery == -1)

    amdgpu_lockup_timeout = MAX_SCHEDULE_TIMEOUT;




Alex

________________________________
From: Michel Dänzer <michel@daenzer.net<mailto:michel@daenzer.net>>
Sent: Friday, March 16, 2018 12:25:03 PM
To: Deucher, Alexander; Quan, Evan
Cc: amd-gfx@lists.freedesktop.org<mailto:amd-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] drm/amdgpu: no job timeout setting on compute queues

On 2018-03-16 05:14 PM, Deucher, Alexander wrote:
> Since GPU reset is not enabled yet anyway, a timeout will just print a
> message, can we just change amdgpu_lockup_timeout to
> MAX_SCHEDULE_TIMEOUT until we enable GPU reset?

Wouldn't that be rather surprising for somebody who sets
amdgpu.gpu_recovery=1 ?


--
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer

[-- Attachment #1.2: Type: text/html, Size: 7341 bytes --]

[-- Attachment #2: Type: text/plain, Size: 154 bytes --]

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

RE: [PATCH] drm/amdgpu: no job timeout setting on compute queues

[Liu, Monk]

[-- Attachment #1.1: Type: text/plain, Size: 2248 bytes --]

Besides, if some compute shader takes time more them 50 seconds, you can just set lockuptime out to 50s
Why change the logic in kmd side ?

I don’t think it’s a good idea to disable the time out message for compute ring, we have virtualization end-user
Still want those message printed out

Can you do this way ?
In amdgpu_job_timeout, you can use DRM_WARN to replace DRM_ERROR for the job belongs to CPC engine ?

/Monk

From: amd-gfx [mailto:amd-gfx-bounces@lists.freedesktop.org] On Behalf Of Quan, Evan
Sent: 2018年3月19日 9:47
To: Deucher, Alexander <Alexander.Deucher@amd.com>; Michel Dänzer <michel@daenzer.net>
Cc: amd-gfx@lists.freedesktop.org
Subject: RE: [PATCH] drm/amdgpu: no job timeout setting on compute queues

That’s fine for me. Will update the patch accordingly.

Regards,
Evan
From: Deucher, Alexander
Sent: Saturday, March 17, 2018 1:17 AM
To: Michel Dänzer <michel@daenzer.net<mailto:michel@daenzer.net>>; Quan, Evan <Evan.Quan@amd.com<mailto:Evan.Quan@amd.com>>
Cc: amd-gfx@lists.freedesktop.org<mailto:amd-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] drm/amdgpu: no job timeout setting on compute queues


How about something like this:

/* Disable timeout when GPU reset is disabled to avoid confusing timeout messages in the kernel log */

If (amdgpu_gpu_recovery == 0 || amdgpu_gpu_recovery == -1)

    amdgpu_lockup_timeout = MAX_SCHEDULE_TIMEOUT;




Alex

________________________________
From: Michel Dänzer <michel@daenzer.net<mailto:michel@daenzer.net>>
Sent: Friday, March 16, 2018 12:25:03 PM
To: Deucher, Alexander; Quan, Evan
Cc: amd-gfx@lists.freedesktop.org<mailto:amd-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] drm/amdgpu: no job timeout setting on compute queues

On 2018-03-16 05:14 PM, Deucher, Alexander wrote:
> Since GPU reset is not enabled yet anyway, a timeout will just print a
> message, can we just change amdgpu_lockup_timeout to
> MAX_SCHEDULE_TIMEOUT until we enable GPU reset?

Wouldn't that be rather surprising for somebody who sets
amdgpu.gpu_recovery=1 ?


--
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer

[-- Attachment #1.2: Type: text/html, Size: 8500 bytes --]

[-- Attachment #2: Type: text/plain, Size: 154 bytes --]

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Re: [PATCH] drm/amdgpu: no job timeout setting on compute queues

[Deucher, Alexander]

[-- Attachment #1.1: Type: text/plain, Size: 2610 bytes --]

That's fine with me too.  Or make them DRM_INFO.


Alex

________________________________
From: Liu, Monk
Sent: Monday, March 26, 2018 8:55:51 AM
To: Quan, Evan; Deucher, Alexander; Michel Dänzer
Cc: amd-gfx@lists.freedesktop.org
Subject: RE: [PATCH] drm/amdgpu: no job timeout setting on compute queues


Besides, if some compute shader takes time more them 50 seconds, you can just set lockuptime out to 50s

Why change the logic in kmd side ?



I don’t think it’s a good idea to disable the time out message for compute ring, we have virtualization end-user

Still want those message printed out



Can you do this way ?

In amdgpu_job_timeout, you can use DRM_WARN to replace DRM_ERROR for the job belongs to CPC engine ?



/Monk



From: amd-gfx [mailto:amd-gfx-bounces@lists.freedesktop.org] On Behalf Of Quan, Evan
Sent: 2018年3月19日 9:47
To: Deucher, Alexander <Alexander.Deucher@amd.com>; Michel Dänzer <michel@daenzer.net>
Cc: amd-gfx@lists.freedesktop.org
Subject: RE: [PATCH] drm/amdgpu: no job timeout setting on compute queues



That’s fine for me. Will update the patch accordingly.



Regards,

Evan

From: Deucher, Alexander
Sent: Saturday, March 17, 2018 1:17 AM
To: Michel Dänzer <michel@daenzer.net<mailto:michel@daenzer.net>>; Quan, Evan <Evan.Quan@amd.com<mailto:Evan.Quan@amd.com>>
Cc: amd-gfx@lists.freedesktop.org<mailto:amd-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] drm/amdgpu: no job timeout setting on compute queues



How about something like this:

/* Disable timeout when GPU reset is disabled to avoid confusing timeout messages in the kernel log */

If (amdgpu_gpu_recovery == 0 || amdgpu_gpu_recovery == -1)

    amdgpu_lockup_timeout = MAX_SCHEDULE_TIMEOUT;




Alex

________________________________

From: Michel Dänzer <michel@daenzer.net<mailto:michel@daenzer.net>>
Sent: Friday, March 16, 2018 12:25:03 PM
To: Deucher, Alexander; Quan, Evan
Cc: amd-gfx@lists.freedesktop.org<mailto:amd-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] drm/amdgpu: no job timeout setting on compute queues



On 2018-03-16 05:14 PM, Deucher, Alexander wrote:
> Since GPU reset is not enabled yet anyway, a timeout will just print a
> message, can we just change amdgpu_lockup_timeout to
> MAX_SCHEDULE_TIMEOUT until we enable GPU reset?

Wouldn't that be rather surprising for somebody who sets
amdgpu.gpu_recovery=1 ?


--
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer

[-- Attachment #1.2: Type: text/html, Size: 8314 bytes --]

[-- Attachment #2: Type: text/plain, Size: 154 bytes --]

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

RE: [PATCH] drm/amdgpu: no job timeout setting on compute queues

[Quan, Evan]

[-- Attachment #1.1: Type: text/plain, Size: 3637 bytes --]

Hi Monk,

That’s a fix reached after a long discussion(I believe you were in that mail thread).
50s is for the dgemm test. We are not sure whether it’s enough for other compute use case.
If virtualization still needs these messages, I believe we can list that as an exception

-                                  (ring->funcs->type == AMDGPU_RING_TYPE_COMPUTE) ?
+                                  /* for non-sriov case, no timeout enforce on compute ring */
+                                  ((ring->funcs->type == AMDGPU_RING_TYPE_COMPUTE) && !amdgpu_sriov_vf(ring->adev)) ?

Regards,
Evan
From: Deucher, Alexander
Sent: Monday, March 26, 2018 11:20 PM
To: Liu, Monk <Monk.Liu@amd.com>; Quan, Evan <Evan.Quan@amd.com>; Michel Dänzer <michel@daenzer.net>
Cc: amd-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/amdgpu: no job timeout setting on compute queues


That's fine with me too.  Or make them DRM_INFO.



Alex

________________________________
From: Liu, Monk
Sent: Monday, March 26, 2018 8:55:51 AM
To: Quan, Evan; Deucher, Alexander; Michel Dänzer
Cc: amd-gfx@lists.freedesktop.org<mailto:amd-gfx@lists.freedesktop.org>
Subject: RE: [PATCH] drm/amdgpu: no job timeout setting on compute queues


Besides, if some compute shader takes time more them 50 seconds, you can just set lockuptime out to 50s

Why change the logic in kmd side ?



I don’t think it’s a good idea to disable the time out message for compute ring, we have virtualization end-user

Still want those message printed out



Can you do this way ?

In amdgpu_job_timeout, you can use DRM_WARN to replace DRM_ERROR for the job belongs to CPC engine ?



/Monk



From: amd-gfx [mailto:amd-gfx-bounces@lists.freedesktop.org] On Behalf Of Quan, Evan
Sent: 2018年3月19日 9:47
To: Deucher, Alexander <Alexander.Deucher@amd.com<mailto:Alexander.Deucher@amd.com>>; Michel Dänzer <michel@daenzer.net<mailto:michel@daenzer.net>>
Cc: amd-gfx@lists.freedesktop.org<mailto:amd-gfx@lists.freedesktop.org>
Subject: RE: [PATCH] drm/amdgpu: no job timeout setting on compute queues



That’s fine for me. Will update the patch accordingly.



Regards,

Evan

From: Deucher, Alexander
Sent: Saturday, March 17, 2018 1:17 AM
To: Michel Dänzer <michel@daenzer.net<mailto:michel@daenzer.net>>; Quan, Evan <Evan.Quan@amd.com<mailto:Evan.Quan@amd.com>>
Cc: amd-gfx@lists.freedesktop.org<mailto:amd-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] drm/amdgpu: no job timeout setting on compute queues



How about something like this:

/* Disable timeout when GPU reset is disabled to avoid confusing timeout messages in the kernel log */

If (amdgpu_gpu_recovery == 0 || amdgpu_gpu_recovery == -1)

    amdgpu_lockup_timeout = MAX_SCHEDULE_TIMEOUT;



Alex

________________________________

From: Michel Dänzer <michel@daenzer.net<mailto:michel@daenzer.net>>
Sent: Friday, March 16, 2018 12:25:03 PM
To: Deucher, Alexander; Quan, Evan
Cc: amd-gfx@lists.freedesktop.org<mailto:amd-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] drm/amdgpu: no job timeout setting on compute queues



On 2018-03-16 05:14 PM, Deucher, Alexander wrote:
> Since GPU reset is not enabled yet anyway, a timeout will just print a
> message, can we just change amdgpu_lockup_timeout to
> MAX_SCHEDULE_TIMEOUT until we enable GPU reset?

Wouldn't that be rather surprising for somebody who sets
amdgpu.gpu_recovery=1 ?


--
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer

[-- Attachment #1.2: Type: text/html, Size: 12195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 154 bytes --]

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

RE: [PATCH] drm/amdgpu: no job timeout setting on compute queues

[Liu, Monk]

[-- Attachment #1.1: Type: text/plain, Size: 4103 bytes --]

Ok,  fine by me

/Monk
From: Quan, Evan
Sent: 2018年3月27日 9:34
To: Deucher, Alexander <Alexander.Deucher@amd.com>; Liu, Monk <Monk.Liu@amd.com>; Michel Dänzer <michel@daenzer.net>
Cc: amd-gfx@lists.freedesktop.org; Koenig, Christian <Christian.Koenig@amd.com>
Subject: RE: [PATCH] drm/amdgpu: no job timeout setting on compute queues

Hi Monk,

That’s a fix reached after a long discussion(I believe you were in that mail thread).
50s is for the dgemm test. We are not sure whether it’s enough for other compute use case.
If virtualization still needs these messages, I believe we can list that as an exception

-                                  (ring->funcs->type == AMDGPU_RING_TYPE_COMPUTE) ?
+                                  /* for non-sriov case, no timeout enforce on compute ring */
+                                  ((ring->funcs->type == AMDGPU_RING_TYPE_COMPUTE) && !amdgpu_sriov_vf(ring->adev)) ?

Regards,
Evan
From: Deucher, Alexander
Sent: Monday, March 26, 2018 11:20 PM
To: Liu, Monk <Monk.Liu@amd.com<mailto:Monk.Liu@amd.com>>; Quan, Evan <Evan.Quan@amd.com<mailto:Evan.Quan@amd.com>>; Michel Dänzer <michel@daenzer.net<mailto:michel@daenzer.net>>
Cc: amd-gfx@lists.freedesktop.org<mailto:amd-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] drm/amdgpu: no job timeout setting on compute queues


That's fine with me too.  Or make them DRM_INFO.



Alex

________________________________
From: Liu, Monk
Sent: Monday, March 26, 2018 8:55:51 AM
To: Quan, Evan; Deucher, Alexander; Michel Dänzer
Cc: amd-gfx@lists.freedesktop.org<mailto:amd-gfx@lists.freedesktop.org>
Subject: RE: [PATCH] drm/amdgpu: no job timeout setting on compute queues


Besides, if some compute shader takes time more them 50 seconds, you can just set lockuptime out to 50s

Why change the logic in kmd side ?



I don’t think it’s a good idea to disable the time out message for compute ring, we have virtualization end-user

Still want those message printed out



Can you do this way ?

In amdgpu_job_timeout, you can use DRM_WARN to replace DRM_ERROR for the job belongs to CPC engine ?



/Monk



From: amd-gfx [mailto:amd-gfx-bounces@lists.freedesktop.org] On Behalf Of Quan, Evan
Sent: 2018年3月19日 9:47
To: Deucher, Alexander <Alexander.Deucher@amd.com<mailto:Alexander.Deucher@amd.com>>; Michel Dänzer <michel@daenzer.net<mailto:michel@daenzer.net>>
Cc: amd-gfx@lists.freedesktop.org<mailto:amd-gfx@lists.freedesktop.org>
Subject: RE: [PATCH] drm/amdgpu: no job timeout setting on compute queues



That’s fine for me. Will update the patch accordingly.



Regards,

Evan

From: Deucher, Alexander
Sent: Saturday, March 17, 2018 1:17 AM
To: Michel Dänzer <michel@daenzer.net<mailto:michel@daenzer.net>>; Quan, Evan <Evan.Quan@amd.com<mailto:Evan.Quan@amd.com>>
Cc: amd-gfx@lists.freedesktop.org<mailto:amd-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] drm/amdgpu: no job timeout setting on compute queues



How about something like this:

/* Disable timeout when GPU reset is disabled to avoid confusing timeout messages in the kernel log */

If (amdgpu_gpu_recovery == 0 || amdgpu_gpu_recovery == -1)

    amdgpu_lockup_timeout = MAX_SCHEDULE_TIMEOUT;



Alex

________________________________

From: Michel Dänzer <michel@daenzer.net<mailto:michel@daenzer.net>>
Sent: Friday, March 16, 2018 12:25:03 PM
To: Deucher, Alexander; Quan, Evan
Cc: amd-gfx@lists.freedesktop.org<mailto:amd-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] drm/amdgpu: no job timeout setting on compute queues



On 2018-03-16 05:14 PM, Deucher, Alexander wrote:
> Since GPU reset is not enabled yet anyway, a timeout will just print a
> message, can we just change amdgpu_lockup_timeout to
> MAX_SCHEDULE_TIMEOUT until we enable GPU reset?

Wouldn't that be rather surprising for somebody who sets
amdgpu.gpu_recovery=1 ?


--
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer

[-- Attachment #1.2: Type: text/html, Size: 15048 bytes --]

[-- Attachment #2: Type: text/plain, Size: 154 bytes --]

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx