All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Zimmermann <tzimmermann@suse.de>
To: Javier Martinez Canillas <javierm@redhat.com>,
	linux-kernel@vger.kernel.org
Cc: David Airlie <airlied@linux.ie>, Sandy Huang <hjc@rock-chips.com>,
	dri-devel@lists.freedesktop.org,
	linux-rockchip@lists.infradead.org,
	Peter Robinson <pbrobinson@gmail.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2] drm/rockchip: remove existing generic drivers to take over the device
Date: Fri, 28 May 2021 15:59:15 +0200	[thread overview]
Message-ID: <bc8ba42b-2fbf-ba95-d7a4-92f789142bd3@suse.de> (raw)
In-Reply-To: <1f781f88-24ff-98b8-9c86-ae4db311843f@redhat.com>


[-- Attachment #1.1: Type: text/plain, Size: 1429 bytes --]



Am 27.05.21 um 09:38 schrieb Javier Martinez Canillas:
> Hello Thomas,
> 
> On 5/16/21 12:30 PM, Thomas Zimmermann wrote:
>>
>>
>> Am 16.05.21 um 09:48 schrieb Javier Martinez Canillas:
>>> There are drivers that register framebuffer devices very early in the boot
>>> process and make use of the existing framebuffer as setup by the firmware.
>>>
>>> If one of those drivers has registered a fbdev, then the fallback fbdev
>> of
>>> the DRM driver won't be bound to the framebuffer console. To avoid that,
>>> remove any existing generic driver and take over the graphics device.
>>>
>>> By doing that, the fb mapped to the console is switched correctly from the
>>> early fbdev to the one registered by the rockchip DRM driver:
>>>
>>>       [   40.752420] fb0: switching to rockchip-drm-fb from EFI VGA
>>>
>>> Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
>>
>> Acked-by: Thomas Zimmermann <tzimmermann@suse.de>
>>
> 
> Thanks for the ack.
>   
>> Ping me if no one else merges the patch.
>>
> 
> I would really appreciate if you merge this patch.

It's merged now. Thanks for the patch.

Best regards
Thomas

>   
>> Best regards
>> Thomas
> 
> Best regards,
> 

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Thomas Zimmermann <tzimmermann@suse.de>
To: Javier Martinez Canillas <javierm@redhat.com>,
	linux-kernel@vger.kernel.org
Cc: David Airlie <airlied@linux.ie>, Sandy Huang <hjc@rock-chips.com>,
	dri-devel@lists.freedesktop.org,
	linux-rockchip@lists.infradead.org,
	Peter Robinson <pbrobinson@gmail.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2] drm/rockchip: remove existing generic drivers to take over the device
Date: Fri, 28 May 2021 15:59:15 +0200	[thread overview]
Message-ID: <bc8ba42b-2fbf-ba95-d7a4-92f789142bd3@suse.de> (raw)
In-Reply-To: <1f781f88-24ff-98b8-9c86-ae4db311843f@redhat.com>


[-- Attachment #1.1.1: Type: text/plain, Size: 1429 bytes --]



Am 27.05.21 um 09:38 schrieb Javier Martinez Canillas:
> Hello Thomas,
> 
> On 5/16/21 12:30 PM, Thomas Zimmermann wrote:
>>
>>
>> Am 16.05.21 um 09:48 schrieb Javier Martinez Canillas:
>>> There are drivers that register framebuffer devices very early in the boot
>>> process and make use of the existing framebuffer as setup by the firmware.
>>>
>>> If one of those drivers has registered a fbdev, then the fallback fbdev
>> of
>>> the DRM driver won't be bound to the framebuffer console. To avoid that,
>>> remove any existing generic driver and take over the graphics device.
>>>
>>> By doing that, the fb mapped to the console is switched correctly from the
>>> early fbdev to the one registered by the rockchip DRM driver:
>>>
>>>       [   40.752420] fb0: switching to rockchip-drm-fb from EFI VGA
>>>
>>> Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
>>
>> Acked-by: Thomas Zimmermann <tzimmermann@suse.de>
>>
> 
> Thanks for the ack.
>   
>> Ping me if no one else merges the patch.
>>
> 
> I would really appreciate if you merge this patch.

It's merged now. Thanks for the patch.

Best regards
Thomas

>   
>> Best regards
>> Thomas
> 
> Best regards,
> 

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer


[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]

[-- Attachment #2: Type: text/plain, Size: 170 bytes --]

_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

WARNING: multiple messages have this Message-ID (diff)
From: Thomas Zimmermann <tzimmermann@suse.de>
To: Javier Martinez Canillas <javierm@redhat.com>,
	linux-kernel@vger.kernel.org
Cc: David Airlie <airlied@linux.ie>, Sandy Huang <hjc@rock-chips.com>,
	dri-devel@lists.freedesktop.org,
	linux-rockchip@lists.infradead.org,
	Peter Robinson <pbrobinson@gmail.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2] drm/rockchip: remove existing generic drivers to take over the device
Date: Fri, 28 May 2021 15:59:15 +0200	[thread overview]
Message-ID: <bc8ba42b-2fbf-ba95-d7a4-92f789142bd3@suse.de> (raw)
In-Reply-To: <1f781f88-24ff-98b8-9c86-ae4db311843f@redhat.com>


[-- Attachment #1.1.1: Type: text/plain, Size: 1429 bytes --]



Am 27.05.21 um 09:38 schrieb Javier Martinez Canillas:
> Hello Thomas,
> 
> On 5/16/21 12:30 PM, Thomas Zimmermann wrote:
>>
>>
>> Am 16.05.21 um 09:48 schrieb Javier Martinez Canillas:
>>> There are drivers that register framebuffer devices very early in the boot
>>> process and make use of the existing framebuffer as setup by the firmware.
>>>
>>> If one of those drivers has registered a fbdev, then the fallback fbdev
>> of
>>> the DRM driver won't be bound to the framebuffer console. To avoid that,
>>> remove any existing generic driver and take over the graphics device.
>>>
>>> By doing that, the fb mapped to the console is switched correctly from the
>>> early fbdev to the one registered by the rockchip DRM driver:
>>>
>>>       [   40.752420] fb0: switching to rockchip-drm-fb from EFI VGA
>>>
>>> Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
>>
>> Acked-by: Thomas Zimmermann <tzimmermann@suse.de>
>>
> 
> Thanks for the ack.
>   
>> Ping me if no one else merges the patch.
>>
> 
> I would really appreciate if you merge this patch.

It's merged now. Thanks for the patch.

Best regards
Thomas

>   
>> Best regards
>> Thomas
> 
> Best regards,
> 

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer


[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-05-28 13:59 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-16  7:48 [PATCH v2] drm/rockchip: remove existing generic drivers to take over the device Javier Martinez Canillas
2021-05-16  7:48 ` Javier Martinez Canillas
2021-05-16  7:48 ` Javier Martinez Canillas
2021-05-16  7:48 ` Javier Martinez Canillas
2021-05-16 10:30 ` Thomas Zimmermann
2021-05-16 10:30   ` Thomas Zimmermann
2021-05-16 10:30   ` Thomas Zimmermann
2021-05-16 10:30   ` Thomas Zimmermann
2021-05-16 15:25   ` Javier Martinez Canillas
2021-05-16 15:25     ` Javier Martinez Canillas
2021-05-16 15:25     ` Javier Martinez Canillas
2021-05-16 15:25     ` Javier Martinez Canillas
2021-05-27  7:38   ` Javier Martinez Canillas
2021-05-27  7:38     ` Javier Martinez Canillas
2021-05-27  7:38     ` Javier Martinez Canillas
2021-05-27  7:38     ` Javier Martinez Canillas
2021-05-28 13:59     ` Thomas Zimmermann [this message]
2021-05-28 13:59       ` Thomas Zimmermann
2021-05-28 13:59       ` Thomas Zimmermann
2021-05-16 12:31 ` Peter Robinson
2021-05-16 12:31   ` Peter Robinson
2021-05-16 12:31   ` Peter Robinson
2021-05-16 12:31   ` Peter Robinson
2021-05-27  9:15 ` Heiko Stübner
2021-05-27  9:15   ` Heiko Stübner
2021-05-27  9:15   ` Heiko Stübner
2021-05-27  9:15   ` Heiko Stübner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bc8ba42b-2fbf-ba95-d7a4-92f789142bd3@suse.de \
    --to=tzimmermann@suse.de \
    --cc=airlied@linux.ie \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=hjc@rock-chips.com \
    --cc=javierm@redhat.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=pbrobinson@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.