All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] cpu: 83xx: Add missing dependency on CPU_MPC83XX
@ 2022-04-22 13:32 Michal Simek
  2022-04-22 16:51 ` Tom Rini
  0 siblings, 1 reply; 2+ messages in thread
From: Michal Simek @ 2022-04-22 13:32 UTC (permalink / raw)
  To: u-boot, git, Simon Glass, mario.six

It looks quite weird that for non PPC platforms cpu driver for MPC83xx can
be selected. That's why define proper dependency.

Signed-off-by: Michal Simek <michal.simek@xilinx.com>
---

 drivers/cpu/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/cpu/Kconfig b/drivers/cpu/Kconfig
index 3d5729f6dca8..789728167ceb 100644
--- a/drivers/cpu/Kconfig
+++ b/drivers/cpu/Kconfig
@@ -9,7 +9,7 @@ config CPU
 
 config CPU_MPC83XX
 	bool "Enable MPC83xx CPU driver"
-	depends on CPU
+	depends on CPU && MPC83xx
 	select CLK_MPC83XX
 	help
 	  Support CPU cores for SoCs of the MPC83xx series.
-- 
2.36.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] cpu: 83xx: Add missing dependency on CPU_MPC83XX
  2022-04-22 13:32 [PATCH] cpu: 83xx: Add missing dependency on CPU_MPC83XX Michal Simek
@ 2022-04-22 16:51 ` Tom Rini
  0 siblings, 0 replies; 2+ messages in thread
From: Tom Rini @ 2022-04-22 16:51 UTC (permalink / raw)
  To: Michal Simek; +Cc: u-boot, git, Simon Glass, mario.six

[-- Attachment #1: Type: text/plain, Size: 501 bytes --]

On Fri, Apr 22, 2022 at 03:32:21PM +0200, Michal Simek wrote:

> It looks quite weird that for non PPC platforms cpu driver for MPC83xx can
> be selected. That's why define proper dependency.
> 
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>

Long term, we need the "or compile testing only" option like Linux has,
for doing static analysis checks via sandbox.  But given what we have /
do today, this makes the most sense.

Reviewed-by: Tom Rini <trini@konsulko.com>

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-04-22 16:52 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-22 13:32 [PATCH] cpu: 83xx: Add missing dependency on CPU_MPC83XX Michal Simek
2022-04-22 16:51 ` Tom Rini

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.